Review Request 63742: Add service dependencies

2017-11-10 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63742/
---

Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and Swapan 
Shridhar.


Bugs: AMBARI-22345
https://issues.apache.org/jira/browse/AMBARI-22345


Repository: ambari


Description
---

Second part of patch. Did some code cleanup. Also reimplemented API and BE to 
use sevice dependency id.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
 afdfcc4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java
 97fe502 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java
 d8d89da 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterServiceDAO.java
 0eeb19b 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java
 976bb67 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDependencyEntity.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
27d37e3 
  ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
c4c2d84 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
bfb04be 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 755a80f 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e1e7c9e 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b438e69 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql aab7f95 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 8832818 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 135707b 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 7d93aad 
  ambari-server/src/main/resources/META-INF/persistence.xml 009ecd5 


Diff: https://reviews.apache.org/r/63742/diff/1/


Testing
---


Thanks,

Vitalyi Brodetskyi

Re: Review Request 63725: Fix tar_archive.py: 1. remove verbosity flags, 2. archive_dir() and archive_directory_dereference() should store relative paths

2017-11-10 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63725/#review190750
---


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 10, 2017, 10:26 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63725/
> ---
> 
> (Updated Nov. 10, 2017, 10:26 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Andrew Onischuk, 
> and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22413
> https://issues.apache.org/jira/browse/AMBARI-22413
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Removed verbosity flag and fixed the two methods to store relative paths.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py
>  e6d8924 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 8c48347 
>   ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py 3114fa8 
> 
> 
> Diff: https://reviews.apache.org/r/63725/diff/1/
> 
> 
> Testing
> ---
> 
> - Manually tested archiving / restoration at Falcon server start / stop.
> - Manually tested HDP upgrades with Falcon server and BigInsight 4.2.5 -> HDP 
> upgrade (didn't not test the archival process only that upgrade went smoothly)
> - Updates python unit tests. All python unit tests pass in ambari-server
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 63707: Simplify Ambari configuration tables from AMBARI-21307

2017-11-10 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63707/#review190746
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 10, 2017, 11:24 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63707/
> ---
> 
> (Updated Nov. 10, 2017, 11:24 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Nate Cole, Robert Nettleton, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22347
> https://issues.apache.org/jira/browse/AMBARI-22347
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Simplify Ambari configuration tables from AMBARI-21307.
> 
> configuration_base and ambari_configuration tables were introduced in 
> AMBARI-21307; however, these tables are more complex than needed. Future 
> architecture changes will eventually negate the need to have a shard 
> configuration structure as proposed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java
>  5e8094e9c7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java
>  38ae7669db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/AmbariConfiguration.java
>  b5cc9212da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationService.java
>  13f8835655 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java
>  4f4cc7070d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> 0f9ff52147 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariLdapConfigChangedEvent.java
>  48799d793b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfiguration.java
>  8b26cd3e29 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java
>  c88d420e9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/LdapConnectionTemplateFactory.java
>  8467af08b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AmbariConfigurationDAO.java
>  83293efb82 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AmbariConfigurationEntity.java
>  c9f4695469 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AmbariConfigurationEntityPK.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ConfigurationBaseEntity.java
>  9ad30d7d1a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
>  8812ef5bfc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  d3e924e66c 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7d634941d9 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql af17353ff3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 89c7971303 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 3d2bd3a107 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 55a6c61017 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e5e8af59c3 
>   ambari-server/src/main/resources/META-INF/persistence.xml 67eef705af 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProviderTest.java
>  c2a14218e7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AmbariConfigurationDAOTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  bd8f5cbd57 
> 
> 
> Diff: https://reviews.apache.org/r/63707/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: 
> 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 26:56 min
> [INFO] Finished at: 2017-11-09T17:32:37-05:00
> [INFO] Final Memory: 98M/1957M
> [INFO] 
> 
> ```
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 63695: Create a Pre-Upgrade Check Warning About LZO

2017-11-10 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63695/
---

(Updated Nov. 10, 2017, 7:47 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

fixed review comments


Bugs: AMBARI-22387
https://issues.apache.org/jira/browse/AMBARI-22387


Repository: ambari


Description
---

Ambari has removed its native support of distributing and installing LZO when 
the LZO codecs are enabled in {{core-site}}. For existing clusters where LZO is 
enabled, this means that performing an upgrade will now require manual user 
intervention to get the LZO packages installed.

A pre-upgrade check should be created which checks to see if LZO is enabled in 
the cluster and then produces a {{WARNING}} to the user letting them know that 
before upgrading, they'd need to distribute the appropriate LZO packages.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 f5e4ff9061 
  ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 3d0d906856 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
3e044ec02e 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 c698d5e244 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
08725f04c4 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 48be5d1971 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
cbe809a410 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 b4e3745099 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
98223904c8 
  ambari-server/src/test/java/org/apache/ambari/server/checks/LZOCheckTest.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/63695/diff/3/

Changes: https://reviews.apache.org/r/63695/diff/2-3/


Testing (updated)
---

mvn clean test
live cluster check


Thanks,

Dmitro Lisnichenko

Re: Review Request 63735: Ambari checks fail with FIPS mode is activated on the OS

2017-11-10 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63735/#review190739
---


Ship it!




Ship It!

- Balázs Bence Sári


On Nov. 10, 2017, 4:43 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63735/
> ---
> 
> (Updated Nov. 10, 2017, 4:43 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Andrew Onischuk, Balázs Bence Sári, 
> Eugene Chekanskiy, Jonathan Hurley, Robert Nettleton, Swapan Shridhar, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22417
> https://issues.apache.org/jira/browse/AMBARI-22417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari checks fail with FIPS mode is activated on the OS (Rhel7). FIPS mode 
> disables weak ciphers (such as MD5). 
> Ambari code is doing 
> 
> ```
> ccache_file_name = _md5("
> {0}|{1}".format(principal, keytab)).hexdigest(). MD5 is disabled on the OS 
> (RHEL7) so ambari throws errors.
> ```
> 
> - All service checks fail, Ranger KMS start fails via ambari. 
> - However all the services are actually running and fine. 
> 
> - Also Ranger KMS succesfully started from command Line
> 
> Here is the stack trace from Ambari
> 
> ```
> service_check
> params.kinit_path_local, False, None, params.smoke_user)
> File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/curl_krb_request.py",
>  line 109, in curl_krb_request
> ccache_file_name = _md5("{0}
> |
> {1}
> ".format(principal, keytab)).hexdigest()
> ValueError: error:060800A3:digital envelope 
> routines:EVP_DigestInit_ex:disabled for fips
> ```
> 
> Fix: 
> MD5 is disabled on the OS, Code needs to be updated to use SHA?
> 
> This is required when FIPS mode is enabled on the RHEL OS
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
>  95e8625d67 
> 
> 
> Diff: https://reviews.apache.org/r/63735/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 63735: Ambari checks fail with FIPS mode is activated on the OS

2017-11-10 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63735/#review190733
---




ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
Line 35 (original), 37 (patched)


Using `sha224` rather than `sha156` to keep the generated string smaller 
since it will be part of a path. For example:

SHA224
```

web_alert_ambari-qa_cc_e9e01054f2ce1b0a41f59c30a282cd6e8a0aacc207f6be80b3b5fc57
```

SHA256
```

web_alert_ambari-qa_cc_90a8d884d4b9c869a647be5d9690386b2c1e7352e876fba54b96438a648b1d7d
```


- Robert Levas


On Nov. 10, 2017, 11:43 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63735/
> ---
> 
> (Updated Nov. 10, 2017, 11:43 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Andrew Onischuk, Balázs Bence Sári, 
> Eugene Chekanskiy, Jonathan Hurley, Robert Nettleton, Swapan Shridhar, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22417
> https://issues.apache.org/jira/browse/AMBARI-22417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari checks fail with FIPS mode is activated on the OS (Rhel7). FIPS mode 
> disables weak ciphers (such as MD5). 
> Ambari code is doing 
> 
> ```
> ccache_file_name = _md5("
> {0}|{1}".format(principal, keytab)).hexdigest(). MD5 is disabled on the OS 
> (RHEL7) so ambari throws errors.
> ```
> 
> - All service checks fail, Ranger KMS start fails via ambari. 
> - However all the services are actually running and fine. 
> 
> - Also Ranger KMS succesfully started from command Line
> 
> Here is the stack trace from Ambari
> 
> ```
> service_check
> params.kinit_path_local, False, None, params.smoke_user)
> File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/curl_krb_request.py",
>  line 109, in curl_krb_request
> ccache_file_name = _md5("{0}
> |
> {1}
> ".format(principal, keytab)).hexdigest()
> ValueError: error:060800A3:digital envelope 
> routines:EVP_DigestInit_ex:disabled for fips
> ```
> 
> Fix: 
> MD5 is disabled on the OS, Code needs to be updated to use SHA?
> 
> This is required when FIPS mode is enabled on the RHEL OS
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
>  95e8625d67 
> 
> 
> Diff: https://reviews.apache.org/r/63735/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 63735: Ambari checks fail with FIPS mode is activated on the OS

2017-11-10 Thread Robert Levas 


> On Nov. 10, 2017, 11:57 a.m., Robert Levas wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
> > Line 35 (original), 37 (patched)
> > 
> >
> > Using `sha224` rather than `sha156` to keep the generated string 
> > smaller since it will be part of a path. For example:
> > 
> > SHA224
> > ```
> > 
> > web_alert_ambari-qa_cc_e9e01054f2ce1b0a41f59c30a282cd6e8a0aacc207f6be80b3b5fc57
> > ```
> > 
> > SHA256
> > ```
> > 
> > web_alert_ambari-qa_cc_90a8d884d4b9c869a647be5d9690386b2c1e7352e876fba54b96438a648b1d7d
> > ```

Correction: `sha156` --> `sha256`


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63735/#review190733
---


On Nov. 10, 2017, 11:43 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63735/
> ---
> 
> (Updated Nov. 10, 2017, 11:43 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Andrew Onischuk, Balázs Bence Sári, 
> Eugene Chekanskiy, Jonathan Hurley, Robert Nettleton, Swapan Shridhar, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22417
> https://issues.apache.org/jira/browse/AMBARI-22417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari checks fail with FIPS mode is activated on the OS (Rhel7). FIPS mode 
> disables weak ciphers (such as MD5). 
> Ambari code is doing 
> 
> ```
> ccache_file_name = _md5("
> {0}|{1}".format(principal, keytab)).hexdigest(). MD5 is disabled on the OS 
> (RHEL7) so ambari throws errors.
> ```
> 
> - All service checks fail, Ranger KMS start fails via ambari. 
> - However all the services are actually running and fine. 
> 
> - Also Ranger KMS succesfully started from command Line
> 
> Here is the stack trace from Ambari
> 
> ```
> service_check
> params.kinit_path_local, False, None, params.smoke_user)
> File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/curl_krb_request.py",
>  line 109, in curl_krb_request
> ccache_file_name = _md5("{0}
> |
> {1}
> ".format(principal, keytab)).hexdigest()
> ValueError: error:060800A3:digital envelope 
> routines:EVP_DigestInit_ex:disabled for fips
> ```
> 
> Fix: 
> MD5 is disabled on the OS, Code needs to be updated to use SHA?
> 
> This is required when FIPS mode is enabled on the RHEL OS
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
>  95e8625d67 
> 
> 
> Diff: https://reviews.apache.org/r/63735/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 63735: Ambari checks fail with FIPS mode is activated on the OS

2017-11-10 Thread Attila Magyar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63735/#review190734
---


Ship it!




Ship It!

- Attila Magyar


On Nov. 10, 2017, 4:43 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63735/
> ---
> 
> (Updated Nov. 10, 2017, 4:43 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Andrew Onischuk, Balázs Bence Sári, 
> Eugene Chekanskiy, Jonathan Hurley, Robert Nettleton, Swapan Shridhar, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22417
> https://issues.apache.org/jira/browse/AMBARI-22417
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari checks fail with FIPS mode is activated on the OS (Rhel7). FIPS mode 
> disables weak ciphers (such as MD5). 
> Ambari code is doing 
> 
> ```
> ccache_file_name = _md5("
> {0}|{1}".format(principal, keytab)).hexdigest(). MD5 is disabled on the OS 
> (RHEL7) so ambari throws errors.
> ```
> 
> - All service checks fail, Ranger KMS start fails via ambari. 
> - However all the services are actually running and fine. 
> 
> - Also Ranger KMS succesfully started from command Line
> 
> Here is the stack trace from Ambari
> 
> ```
> service_check
> params.kinit_path_local, False, None, params.smoke_user)
> File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/curl_krb_request.py",
>  line 109, in curl_krb_request
> ccache_file_name = _md5("{0}
> |
> {1}
> ".format(principal, keytab)).hexdigest()
> ValueError: error:060800A3:digital envelope 
> routines:EVP_DigestInit_ex:disabled for fips
> ```
> 
> Fix: 
> MD5 is disabled on the OS, Code needs to be updated to use SHA?
> 
> This is required when FIPS mode is enabled on the RHEL OS
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
>  95e8625d67 
> 
> 
> Diff: https://reviews.apache.org/r/63735/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 63735: Ambari checks fail with FIPS mode is activated on the OS

2017-11-10 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63735/
---

Review request for Ambari, Attila Magyar, Andrew Onischuk, Balázs Bence Sári, 
Eugene Chekanskiy, Jonathan Hurley, Robert Nettleton, Swapan Shridhar, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-22417
https://issues.apache.org/jira/browse/AMBARI-22417


Repository: ambari


Description
---

Ambari checks fail with FIPS mode is activated on the OS (Rhel7). FIPS mode 
disables weak ciphers (such as MD5). 
Ambari code is doing 

```
ccache_file_name = _md5("
{0}|{1}".format(principal, keytab)).hexdigest(). MD5 is disabled on the OS 
(RHEL7) so ambari throws errors.
```

- All service checks fail, Ranger KMS start fails via ambari. 
- However all the services are actually running and fine. 

- Also Ranger KMS succesfully started from command Line

Here is the stack trace from Ambari

```
service_check
params.kinit_path_local, False, None, params.smoke_user)
File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/curl_krb_request.py",
 line 109, in curl_krb_request
ccache_file_name = _md5("{0}
|
{1}
".format(principal, keytab)).hexdigest()
ValueError: error:060800A3:digital envelope routines:EVP_DigestInit_ex:disabled 
for fips
```

Fix: 
MD5 is disabled on the OS, Code needs to be updated to use SHA?

This is required when FIPS mode is enabled on the RHEL OS


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
 95e8625d67 


Diff: https://reviews.apache.org/r/63735/diff/1/


Testing
---

Manually tested


Thanks,

Robert Levas

Re: Review Request 63734: Log Search UI: fixes for filtering form

2017-11-10 Thread Aleksandr Kovalenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63734/#review190730
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Ноя. 10, 2017, 4:19 п.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63734/
> ---
> 
> (Updated Ноя. 10, 2017, 4:19 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-22416
> https://issues.apache.org/jira/browse/AMBARI-22416
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Checkboxes in multiselect, labels of dropdown filter buttons etc. should 
> pick up currently selected value even if it's set from outside the form
> 2. All the tabs should have their own isolated filtering options, so that 
> filters application on one tab doesn't affect other tab
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 56562df 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/filtering.ts dde144b 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-state.ts 
> 2c5c083 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node-item.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node.ts 
> a14e51a 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts 
> d912b35 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/tab.ts bb8028a 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.ts 
> 4de47ea 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.html
>  798a609 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts
>  f11ca09 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts
>  0bf4422 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.html
>  5de78ad 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts
>  5455e67 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts
>  3e40455 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.ts
>  2c8ecd7 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts
>  c294e8e 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.ts
>  9e5a6f1 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html
>  fa739a4 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts
>  0bb0204 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts
>  9601a0e 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.spec.ts
>  4e9bdc9 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.spec.ts
>  0a9418f 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts
>  21949f1 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html
>  10f4af1 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.spec.ts
>  8ee4ca3 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts
>  017bc82 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts
>  261e213 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.ts
>  5932e1b 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/pagination-controls/pagination-controls.component.ts
>  81676a9 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.html
>  679a7e5 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.spec.ts
>  ff8675d 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.ts
>  cc5589f 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts
>  5520310 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.html
>  973db61 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.spec.t

Review Request 63734: Log Search UI: fixes for filtering form

2017-11-10 Thread Andrii Babiichuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63734/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-22416
https://issues.apache.org/jira/browse/AMBARI-22416


Repository: ambari


Description
---

1. Checkboxes in multiselect, labels of dropdown filter buttons etc. should 
pick up currently selected value even if it's set from outside the form
2. All the tabs should have their own isolated filtering options, so that 
filters application on one tab doesn't affect other tab


Diffs
-

  ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 56562df 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/filtering.ts dde144b 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-state.ts 
2c5c083 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node-item.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node.ts a14e51a 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts d912b35 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/tab.ts bb8028a 
  ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.ts 
4de47ea 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.html
 798a609 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts
 f11ca09 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts
 0bf4422 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.html
 5de78ad 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts
 5455e67 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts
 3e40455 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.ts
 2c8ecd7 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts
 c294e8e 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.ts
 9e5a6f1 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html
 fa739a4 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts
 0bb0204 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts
 9601a0e 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.spec.ts
 4e9bdc9 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.spec.ts
 0a9418f 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts
 21949f1 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html
 10f4af1 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.spec.ts
 8ee4ca3 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts
 017bc82 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts
 261e213 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.ts
 5932e1b 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/pagination-controls/pagination-controls.component.ts
 81676a9 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.html
 679a7e5 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.spec.ts
 ff8675d 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.ts
 cc5589f 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts
 5520310 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.html
 973db61 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.spec.ts
 7612cc3 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.ts
 af4933a 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/timezone-picker/timezone-picker.component.spec.ts
 53afc47 
  
ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.spec.ts
 e6a02c0 
  
ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.ts
 c483cd8 
  
ambari-logsearch/ambari-logsearch-web/src/app/services/component-generator.service.spec.ts
 5dc38b4 
  
ambari-logsearch/ambari-logsearch-web/src/app/services/filteri

Re: Review Request 63725: Fix tar_archive.py: 1. remove verbosity flags, 2. archive_dir() and archive_directory_dereference() should store relative paths

2017-11-10 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63725/#review190727
---


Ship it!




Ship It!

- Attila Doroszlai


On Nov. 10, 2017, 4:26 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63725/
> ---
> 
> (Updated Nov. 10, 2017, 4:26 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Andrew Onischuk, 
> and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22413
> https://issues.apache.org/jira/browse/AMBARI-22413
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Removed verbosity flag and fixed the two methods to store relative paths.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py
>  e6d8924 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 8c48347 
>   ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py 3114fa8 
> 
> 
> Diff: https://reviews.apache.org/r/63725/diff/1/
> 
> 
> Testing
> ---
> 
> - Manually tested archiving / restoration at Falcon server start / stop.
> - Manually tested HDP upgrades with Falcon server and BigInsight 4.2.5 -> HDP 
> upgrade (didn't not test the archival process only that upgrade went smoothly)
> - Updates python unit tests. All python unit tests pass in ambari-server
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 63725: Fix tar_archive.py: 1. remove verbosity flags, 2. archive_dir() and archive_directory_dereference() should store relative paths

2017-11-10 Thread Attila Magyar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63725/#review190726
---


Ship it!




Ship It!

- Attila Magyar


On Nov. 10, 2017, 3:26 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63725/
> ---
> 
> (Updated Nov. 10, 2017, 3:26 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Andrew Onischuk, 
> and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22413
> https://issues.apache.org/jira/browse/AMBARI-22413
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Removed verbosity flag and fixed the two methods to store relative paths.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py
>  e6d8924 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 8c48347 
>   ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py 3114fa8 
> 
> 
> Diff: https://reviews.apache.org/r/63725/diff/1/
> 
> 
> Testing
> ---
> 
> - Manually tested archiving / restoration at Falcon server start / stop.
> - Manually tested HDP upgrades with Falcon server and BigInsight 4.2.5 -> HDP 
> upgrade (didn't not test the archival process only that upgrade went smoothly)
> - Updates python unit tests. All python unit tests pass in ambari-server
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 63722: Remove IPA integration from experimental status

2017-11-10 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63722/
---

(Updated Nov. 10, 2017, 10:43 a.m.)


Review request for Ambari, Aleksandr Kovalenko, Attila Magyar, Andrii Tkach, 
Balázs Bence Sári, Denys Buzhor, Eugene Chekanskiy, and Oleg Nechiporenko.


Bugs: AMBARI-22412
https://issues.apache.org/jira/browse/AMBARI-22412


Repository: ambari


Description
---

Remove IPA integration from experimental status so that users can select 
FreeIPA when enabling Kerberos via the Enable Kerberos Wizard without having to 
explicitly enable it via the Experimental page.


Diffs
-

  ambari-web/app/config.js 0963f7094a 
  ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 2e41e3d774 
  ambari-web/app/messages.js bee581aefa 
  ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
ca80341780 


Diff: https://reviews.apache.org/r/63722/diff/1/


Testing (updated)
---

Manually tested

# Local test results: 
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 04:38 min
[INFO] Finished at: 2017-11-10T06:04:05-05:00
[INFO] Final Memory: 30M/1361M
[INFO] 
```

# Jenkins test results:

```
{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment
  
http://issues.apache.org/jira/secure/attachment/12897064/AMBARI-22412_trunk_01.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-web.
```


Thanks,

Robert Levas

Re: Review Request 63729: Blueprint deploys failing with missing smoke user keytab file

2017-11-10 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63729/#review190725
---


Ship it!




Ship It!

- Robert Levas


On Nov. 10, 2017, 10:21 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63729/
> ---
> 
> (Updated Nov. 10, 2017, 10:21 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-22415
> https://issues.apache.org/jira/browse/AMBARI-22415
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> cache files respected by blueprint install
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  aa65e61c67 
> 
> 
> Diff: https://reviews.apache.org/r/63729/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 63729: Blueprint deploys failing with missing smoke user keytab file

2017-11-10 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63729/#review190722
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 10, 2017, 5:21 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63729/
> ---
> 
> (Updated Nov. 10, 2017, 5:21 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-22415
> https://issues.apache.org/jira/browse/AMBARI-22415
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> cache files respected by blueprint install
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  aa65e61c67 
> 
> 
> Diff: https://reviews.apache.org/r/63729/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Review Request 63725: Fix tar_archive.py: 1. remove verbosity flags, 2. archive_dir() and archive_directory_dereference() should store relative paths

2017-11-10 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63725/
---

Review request for Ambari, Attila Doroszlai, Attila Magyar, Andrew Onischuk, 
and Jonathan Hurley.


Bugs: AMBARI-22413
https://issues.apache.org/jira/browse/AMBARI-22413


Repository: ambari


Description
---

Removed verbosity flag and fixed the two methods to store relative paths.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py
 e6d8924 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 8c48347 
  ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py 3114fa8 


Diff: https://reviews.apache.org/r/63725/diff/1/


Testing
---

- Manually tested archiving / restoration at Falcon server start / stop.
- Manually tested HDP upgrades with Falcon server and BigInsight 4.2.5 -> HDP 
upgrade (didn't not test the archival process only that upgrade went smoothly)
- Updates python unit tests. All python unit tests pass in ambari-server


Thanks,

Balázs Bence Sári

Review Request 63729: Blueprint deploys failing with missing smoke user keytab file

2017-11-10 Thread Eugene Chekanskiy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63729/
---

Review request for Ambari, Dmitro Lisnichenko and Robert Levas.


Bugs: AMBARI-22415
https://issues.apache.org/jira/browse/AMBARI-22415


Repository: ambari


Description
---

cache files respected by blueprint install


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
 aa65e61c67 


Diff: https://reviews.apache.org/r/63729/diff/1/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Re: Review Request 63722: Remove IPA integration from experimental status

2017-11-10 Thread Eugene Chekanskiy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63722/#review190720
---


Ship it!




Ship It!

- Eugene Chekanskiy


On Nov. 10, 2017, 11:22 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63722/
> ---
> 
> (Updated Nov. 10, 2017, 11:22 a.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, Attila Magyar, Andrii Tkach, 
> Balázs Bence Sári, Denys Buzhor, Eugene Chekanskiy, and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-22412
> https://issues.apache.org/jira/browse/AMBARI-22412
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove IPA integration from experimental status so that users can select 
> FreeIPA when enabling Kerberos via the Enable Kerberos Wizard without having 
> to explicitly enable it via the Experimental page.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/config.js 0963f7094a 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 
> 2e41e3d774 
>   ambari-web/app/messages.js bee581aefa 
>   ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
> ca80341780 
> 
> 
> Diff: https://reviews.apache.org/r/63722/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 04:38 min
> [INFO] Finished at: 2017-11-10T06:04:05-05:00
> [INFO] Final Memory: 30M/1361M
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 63722: Remove IPA integration from experimental status

2017-11-10 Thread Andrii Tkach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63722/#review190719
---


Ship it!




Ship It!

- Andrii Tkach


On Nov. 10, 2017, 11:22 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63722/
> ---
> 
> (Updated Nov. 10, 2017, 11:22 a.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, Attila Magyar, Andrii Tkach, 
> Balázs Bence Sári, Denys Buzhor, Eugene Chekanskiy, and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-22412
> https://issues.apache.org/jira/browse/AMBARI-22412
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove IPA integration from experimental status so that users can select 
> FreeIPA when enabling Kerberos via the Enable Kerberos Wizard without having 
> to explicitly enable it via the Experimental page.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/config.js 0963f7094a 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 
> 2e41e3d774 
>   ambari-web/app/messages.js bee581aefa 
>   ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
> ca80341780 
> 
> 
> Diff: https://reviews.apache.org/r/63722/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 04:38 min
> [INFO] Finished at: 2017-11-10T06:04:05-05:00
> [INFO] Final Memory: 30M/1361M
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 63713: Restart all required services failed when running cluster with several patch upgrades applied

2017-11-10 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63713/#review190701
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 10, 2017, 3:43 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63713/
> ---
> 
> (Updated Nov. 10, 2017, 3:43 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22411
> https://issues.apache.org/jira/browse/AMBARI-22411
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Small refactor to pass StackID instead of RepositoryVersionEntity, negating 
> the check that made this call fail.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d8712f2c75 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  5ea4bbdf3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  1ec790f7cc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  23c6d32dff 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  c80620f6a3 
> 
> 
> Diff: https://reviews.apache.org/r/63713/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.
> Unit tests pending.  Mostly verify that existing tests continue to work 
> without error.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 63464: Beeline connection hangs for longer time when connection to HS2 with metastore DB down

2017-11-10 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63464/
---

(Updated Nov. 10, 2017, 11:27 a.m.)


Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-22346
https://issues.apache.org/jira/browse/AMBARI-22346


Repository: ambari


Description
---

PROBLEM:  
beeline connection to HS2 hangs when hive metastore Database is down.  
Issue seen on HDP 2.5.3 and 2.6 version clusters, same test on HDP 2.4.2
beeline doesn't hangs.

BUSINESS IMPACT:  
Ambari spawning multiple beeline processes thats hanging causes unnecessary
memory usage, resulting in master service failures.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py
 3560bf82f5 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_thrift_port.py
 3f80fd941d 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/alerts/alert_spark2_thrift_port.py
 9e1afea374 


Diff: https://reviews.apache.org/r/63464/diff/2/

Changes: https://reviews.apache.org/r/63464/diff/1-2/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 63722: Remove IPA integration from experimental status

2017-11-10 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63722/
---

Review request for Ambari, Aleksandr Kovalenko, Attila Magyar, Andrii Tkach, 
Balázs Bence Sári, Denys Buzhor, Eugene Chekanskiy, and Oleg Nechiporenko.


Bugs: AMBARI-22412
https://issues.apache.org/jira/browse/AMBARI-22412


Repository: ambari


Description
---

Remove IPA integration from experimental status so that users can select 
FreeIPA when enabling Kerberos via the Enable Kerberos Wizard without having to 
explicitly enable it via the Experimental page.


Diffs
-

  ambari-web/app/config.js 0963f7094a 
  ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 2e41e3d774 
  ambari-web/app/messages.js bee581aefa 
  ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
ca80341780 


Diff: https://reviews.apache.org/r/63722/diff/1/


Testing
---

Manually tested

# Local test results: 
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 04:38 min
[INFO] Finished at: 2017-11-10T06:04:05-05:00
[INFO] Final Memory: 30M/1361M
[INFO] 
```


Thanks,

Robert Levas

Re: Review Request 63464: Beeline connection hangs for longer time when connection to HS2 with metastore DB down

2017-11-10 Thread Andrew Onischuk 


> On Nov. 9, 2017, 3:27 p.m., Attila Doroszlai wrote:
> > Doesn't the same problem affect Spark/Spark2 Thrift Server alert, which 
> > also uses Beeline?

Wow nice find Attila. Didn't know that we used beeline for Spark and Spark2


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63464/#review190596
---


On Nov. 1, 2017, 12:43 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63464/
> ---
> 
> (Updated Nov. 1, 2017, 12:43 p.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22346
> https://issues.apache.org/jira/browse/AMBARI-22346
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM:  
> beeline connection to HS2 hangs when hive metastore Database is down.  
> Issue seen on HDP 2.5.3 and 2.6 version clusters, same test on HDP 2.4.2
> beeline doesn't hangs.
> 
> BUSINESS IMPACT:  
> Ambari spawning multiple beeline processes thats hanging causes unnecessary
> memory usage, resulting in master service failures.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py
>  3560bf82f5 
> 
> 
> Diff: https://reviews.apache.org/r/63464/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>