Re: Review Request 63440: Metrics for OneFS mpack

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63440/#review191246
---


Ship it!




Ship It!

- Nate Cole


On Nov. 6, 2017, 4:48 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63440/
> ---
> 
> (Updated Nov. 6, 2017, 4:48 a.m.)
> 
> 
> Review request for Ambari, Nate Cole, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22339
> https://issues.apache.org/jira/browse/AMBARI-22339
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> OneFS puts its own hostname into the metrics data that is sent to AMS. That 
> hostname is not registered to Ambari therefore AMS host metrics don't show up.
> I added an option to override the default hostname in the metrics.json file.
> 
> 
> For example when a metrics.json has this:
> 
> "properties" : {
>   "overridden_host" : "${hdfs-site/dfs.namenode.http-address}"
> },
> 
> Ambari will use this hostname (instead of the component hostname) to assemble 
> the URL that is used to get the metrics data from AMS.
> 
> for example: 
> http://c6403.ambari.apache.org:6188/ws/v1/timeline/metrics?metricNames=cpu_wio=<>
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OverriddenMetricsHostProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
>  8c2198b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricHostProvider.java
>  28e5381 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSComponentPropertyProvider.java
>  487afde 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> edeb4b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/MetricDefinition.java
>  635ae35 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/OverriddenMetricsHostProviderTest.java
>  PRE-CREATION 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/metrics.json
>  335bfba 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/widgets.json
>  dbde93b 
> 
> 
> Diff: https://reviews.apache.org/r/63440/diff/2/
> 
> 
> Testing
> ---
> 
> - checked ams host and non host metrics through the ui
> 
> 
> existing tests: passed
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 63876: ambari-server upgrade to 2.6.1 should surface the GPL agreement

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63876/#review191221
---


Fix it, then Ship it!




Just minor typos.


ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java
Lines 41 (patched)


LZO_ENABLED_JSON_KEY



ambari-server/src/main/python/ambari_server/serverUpgrade.py
Lines 77 (patched)


By saying no, ...


- Nate Cole


On Nov. 16, 2017, 8:27 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63876/
> ---
> 
> (Updated Nov. 16, 2017, 8:27 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-22454
> https://issues.apache.org/jira/browse/AMBARI-22454
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * ambari-server upgrade should determine whether lzo is enabled. 
> * If yes: Surface the same agreement as the setup step
> * If no: Provide link to the documentation to disable lzo configuration 
> and cleanup local repositories.
> 
> Since this involves reading from the database we should think of sending back
> data on the pipe as stdout from the upgrade jvm and the python process.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  dac871ea28 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
>  a2dea40f58 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog.java
>  21273fd49a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java
>  PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 
> 262e9447e5 
>   ambari-server/src/main/python/ambari_server/serverSetup.py 8a14066a66 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 421adfc4a1 
> 
> 
> Diff: https://reviews.apache.org/r/63876/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 63876: ambari-server upgrade to 2.6.1 should surface the GPL agreement

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63876/#review191210
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java
Lines 32 (patched)


This import ordering might not conform to those enforced by ambari-utility, 
make sure to address it in your IDE.



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java
Lines 90 (patched)


To make this future proof we should have a cluter map returned but for now 
lets add a TODO for it.


- Sid Wagle


On Nov. 16, 2017, 1:27 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63876/
> ---
> 
> (Updated Nov. 16, 2017, 1:27 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-22454
> https://issues.apache.org/jira/browse/AMBARI-22454
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * ambari-server upgrade should determine whether lzo is enabled. 
> * If yes: Surface the same agreement as the setup step
> * If no: Provide link to the documentation to disable lzo configuration 
> and cleanup local repositories.
> 
> Since this involves reading from the database we should think of sending back
> data on the pipe as stdout from the upgrade jvm and the python process.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  dac871ea28 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
>  a2dea40f58 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog.java
>  21273fd49a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java
>  PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 
> 262e9447e5 
>   ambari-server/src/main/python/ambari_server/serverSetup.py 8a14066a66 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 421adfc4a1 
> 
> 
> Diff: https://reviews.apache.org/r/63876/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 63880: VDF defined HDP-GPL repo should be tagged appropriately

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63880/#review191207
---


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 16, 2017, 10:45 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63880/
> ---
> 
> (Updated Nov. 16, 2017, 10:45 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan 
> Hurley.
> 
> 
> Bugs: AMBARI-22461
> https://issues.apache.org/jira/browse/AMBARI-22461
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This adds tags to a repository for use by Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  a6315f8350 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  5ec46f044f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  3c10e43343 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  3ca81d7648 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  034f3bce6e 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
> 81b4da949f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  bd53c11bd7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoTag.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  79ace89380 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  a77caab32d 
>   ambari-server/src/main/resources/version_definition.xsd eaed31d582 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
>  c46cce708e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
>  6f33c7e8c1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java
>  70ff801eb3 
>   ambari-server/src/test/resources/version_definition_with_tags.xml 
> PRE-CREATION 
>   contrib/version-builder/version_builder.py 5bf54303ed 
> 
> 
> Diff: https://reviews.apache.org/r/63880/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Unit tests:
> 
> [INFO] Results:
> [INFO]
> [WARNING] Tests run: 4925, Failures: 0, Errors: 0, Skipped: 34
> [INFO]
> [INFO]
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 63838: ambari-server setup should surface GPL software agreement

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63838/#review191189
---



I have committed a follow up patch to fix review comment. As i accidentally 
committed old version of the patch (from here)

- Andrew Onischuk


On Nov. 16, 2017, 6:26 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63838/
> ---
> 
> (Updated Nov. 16, 2017, 6:26 a.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22453
> https://issues.apache.org/jira/browse/AMBARI-22453
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Ask the user if they are okay with installing GPL license software
>   * Surface the license agreement subtext, for now use placeholder
>   * Save the result in ambari.properties
>   * The user selection should be available through API for the client and 
> also stack scripts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  91df506478 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  0bd6af6611 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d8712f2c75 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  0b048ad089 
>   ambari-server/src/main/python/ambari-server.py 60c60052cc 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 
> c7ac13476f 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c1643f2621 
> 
> 
> Diff: https://reviews.apache.org/r/63838/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 63880: VDF defined HDP-GPL repo should be tagged appropriately

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63880/
---

Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan 
Hurley.


Bugs: AMBARI-22461
https://issues.apache.org/jira/browse/AMBARI-22461


Repository: ambari


Description
---

This adds tags to a repository for use by Ambari


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 a6315f8350 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
 5ec46f044f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
 3c10e43343 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
 3ca81d7648 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
 034f3bce6e 
  ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
81b4da949f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 
bd53c11bd7 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoTag.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
 79ace89380 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
 a77caab32d 
  ambari-server/src/main/resources/version_definition.xsd eaed31d582 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
 c46cce708e 
  
ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
 6f33c7e8c1 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java
 70ff801eb3 
  ambari-server/src/test/resources/version_definition_with_tags.xml 
PRE-CREATION 
  contrib/version-builder/version_builder.py 5bf54303ed 


Diff: https://reviews.apache.org/r/63880/diff/1/


Testing
---

Manual.  Unit tests pending.


Thanks,

Nate Cole

Re: Review Request 63840: Improved service/component dependency support

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63840/#review191180
---


Ship it!




Ship It!

- Andrii Tkach


On Nov. 16, 2017, 12:56 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63840/
> ---
> 
> (Updated Nov. 16, 2017, 12:56 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, and Nate Cole.
> 
> 
> Bugs: AMBARI-22449
> https://issues.apache.org/jira/browse/AMBARI-22449
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Selecting a service that requires HDFS triggers the addServicePopup and HDFS 
> is automatically selected, even if an other HDFS compatible service like 
> OneFS is already selected. The UI should recognize OneFS as an alternative 
> option of HDFS.
> 
> If the user selects a service that needs HDFS and other HDFS compatible 
> services are presented in the stack, then the UI should show that there are 
> multiple options to resolve the problem and instruct the user to choose one 
> compatible service.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step4_controller.js d82bf34 
>   ambari-web/app/messages.js 3c4f038 
>   ambari-web/app/models/stack_service.js 241f6ab 
>   ambari-web/test/controllers/wizard/step4_test.js 0fad0c1 
> 
> 
> Diff: https://reviews.apache.org/r/63840/diff/2/
> 
> 
> Testing
> ---
> 
> 1. Tried to add HBASE without selecting HDFS or ONEFS
> 2. UI showed popup saying I need to select either HDFS or ONEFS
> 3. Selected ONEFS
> 4. Pressed next, no popup
> 
> 1. Tried to add HBAES when ONEFS was already selected
> 2. Pressed next, no popup
> 
> 1. checked existing cases when ONEFS mpack was not installed
> 
> existing tests: passed
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Review Request 63877: AMBARI-22459 IOP/HDP migration NN HA restart post Ambari upgrade fails

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63877/
---

Review request for Ambari, Jonathan Hurley and Tim Thorpe.


Bugs: AMBARI-22459
https://issues.apache.org/jira/browse/AMBARI-22459


Repository: ambari


Description
---

File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/stack_select.py",
 line 109, in get_package_name
package = get_packages(PACKAGE_SCOPE_STACK_SELECT, service_name, component_name)
File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/stack_select.py",
 line 234, in get_packages
raise Fail("The package
{0}
is not supported by this version of the stack-select tool.".format(package))
resource_management.core.exceptions.Fail: The package hadoop-hdfs-zkfc is not 
supported by this version of the stack-select tool.


Diffs
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_packages.json
 f890d66 


Diff: https://reviews.apache.org/r/63877/diff/1/


Testing
---

Have an IOP 4.2.5 NN HA cluster, modify the file after yum upgrade of ambari 
rpms to Ambari 2.6, then run ambari-server upgrade, then try to restart HDFS, 
verify HDFS can restart. Proceed with EU, verify EU is successful.


Thanks,

Di Li

Re: Review Request 63877: AMBARI-22459 IOP/HDP migration NN HA restart post Ambari upgrade fails

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63877/#review191176
---


Ship it!




Ship It!

- Tim Thorpe


On Nov. 16, 2017, 1:36 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63877/
> ---
> 
> (Updated Nov. 16, 2017, 1:36 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tim Thorpe.
> 
> 
> Bugs: AMBARI-22459
> https://issues.apache.org/jira/browse/AMBARI-22459
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/stack_select.py",
>  line 109, in get_package_name
> package = get_packages(PACKAGE_SCOPE_STACK_SELECT, service_name, 
> component_name)
> File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/stack_select.py",
>  line 234, in get_packages
> raise Fail("The package
> {0}
> is not supported by this version of the stack-select tool.".format(package))
> resource_management.core.exceptions.Fail: The package hadoop-hdfs-zkfc is not 
> supported by this version of the stack-select tool.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_packages.json
>  f890d66 
> 
> 
> Diff: https://reviews.apache.org/r/63877/diff/1/
> 
> 
> Testing
> ---
> 
> Have an IOP 4.2.5 NN HA cluster, modify the file after yum upgrade of ambari 
> rpms to Ambari 2.6, then run ambari-server upgrade, then try to restart HDFS, 
> verify HDFS can restart. Proceed with EU, verify EU is successful.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 63876: ambari-server upgrade to 2.6.1 should surface the GPL agreement

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63876/
---

Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-22454
https://issues.apache.org/jira/browse/AMBARI-22454


Repository: ambari


Description
---

* ambari-server upgrade should determine whether lzo is enabled. 
* If yes: Surface the same agreement as the setup step
* If no: Provide link to the documentation to disable lzo configuration and 
cleanup local repositories.

Since this involves reading from the database we should think of sending back
data on the pipe as stdout from the upgrade jvm and the python process.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 dac871ea28 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
 a2dea40f58 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog.java
 21273fd49a 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java
 PRE-CREATION 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py 262e9447e5 
  ambari-server/src/main/python/ambari_server/serverSetup.py 8a14066a66 
  ambari-server/src/main/python/ambari_server/serverUpgrade.py 421adfc4a1 


Diff: https://reviews.apache.org/r/63876/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 63840: Improved service/component dependency support

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63840/
---

(Updated Nov. 16, 2017, 12:56 p.m.)


Review request for Ambari, Alexandr Antonenko, Andrii Tkach, and Nate Cole.


Changes
---

addressed review comments


Bugs: AMBARI-22449
https://issues.apache.org/jira/browse/AMBARI-22449


Repository: ambari


Description
---

Selecting a service that requires HDFS triggers the addServicePopup and HDFS is 
automatically selected, even if an other HDFS compatible service like OneFS is 
already selected. The UI should recognize OneFS as an alternative option of 
HDFS.

If the user selects a service that needs HDFS and other HDFS compatible 
services are presented in the stack, then the UI should show that there are 
multiple options to resolve the problem and instruct the user to choose one 
compatible service.


Diffs (updated)
-

  ambari-web/app/controllers/wizard/step4_controller.js d82bf34 
  ambari-web/app/messages.js 3c4f038 
  ambari-web/app/models/stack_service.js 241f6ab 
  ambari-web/test/controllers/wizard/step4_test.js 0fad0c1 


Diff: https://reviews.apache.org/r/63840/diff/2/

Changes: https://reviews.apache.org/r/63840/diff/1-2/


Testing
---

1. Tried to add HBASE without selecting HDFS or ONEFS
2. UI showed popup saying I need to select either HDFS or ONEFS
3. Selected ONEFS
4. Pressed next, no popup

1. Tried to add HBAES when ONEFS was already selected
2. Pressed next, no popup

1. checked existing cases when ONEFS mpack was not installed

existing tests: passed


Thanks,

Attila Magyar

Re: Review Request 63840: Improved service/component dependency support

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63840/#review191168
---




ambari-web/app/messages.js
Lines 882 (patched)


Please choose more specific name than "body2"



ambari-web/app/models/stack_service.js
Lines 26 (patched)


get works with multiple keys: get('service.serviceName')



ambari-web/app/models/stack_service.js
Lines 44 (patched)


Why this is computed if it always return constant? Also string should be in 
translations.



ambari-web/app/models/stack_service.js
Lines 61 (patched)


should be computed property



ambari-web/app/models/stack_service.js
Lines 70 (patched)


should be computed property



ambari-web/app/models/stack_service.js
Lines 126 (patched)


From performance perspectives, this better be done in a single loop



ambari-web/app/models/stack_service.js
Lines 147 (patched)


You can use someProperty instead.


- Andrii Tkach


On Nov. 15, 2017, 4:46 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63840/
> ---
> 
> (Updated Nov. 15, 2017, 4:46 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, and Nate Cole.
> 
> 
> Bugs: AMBARI-22449
> https://issues.apache.org/jira/browse/AMBARI-22449
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Selecting a service that requires HDFS triggers the addServicePopup and HDFS 
> is automatically selected, even if an other HDFS compatible service like 
> OneFS is already selected. The UI should recognize OneFS as an alternative 
> option of HDFS.
> 
> If the user selects a service that needs HDFS and other HDFS compatible 
> services are presented in the stack, then the UI should show that there are 
> multiple options to resolve the problem and instruct the user to choose one 
> compatible service.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step4_controller.js d82bf34 
>   ambari-web/app/messages.js 3c4f038 
>   ambari-web/app/models/stack_service.js 241f6ab 
>   ambari-web/test/controllers/wizard/step4_test.js 0fad0c1 
> 
> 
> Diff: https://reviews.apache.org/r/63840/diff/1/
> 
> 
> Testing
> ---
> 
> 1. Tried to add HBASE without selecting HDFS or ONEFS
> 2. UI showed popup saying I need to select either HDFS or ONEFS
> 3. Selected ONEFS
> 4. Pressed next, no popup
> 
> 1. Tried to add HBAES when ONEFS was already selected
> 2. Pressed next, no popup
> 
> 1. checked existing cases when ONEFS mpack was not installed
> 
> existing tests: passed
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 63872: NFSGateway start failed

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63872/#review191166
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Лис. 16, 2017, 10:21 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63872/
> ---
> 
> (Updated Лис. 16, 2017, 10:21 до полудня)
> 
> 
> Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22460
> https://issues.apache.org/jira/browse/AMBARI-22460
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Initializing privileged NFS client socket...
> java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.apache.commons.daemon.support.DaemonLoader.start(DaemonLoader.java:243)
> Caused by: java.net.ConnectException: Call From 
> ctr-e134-1499953498516-310520-01-02.hwx.site/172.27.26.203 to 
> ctr-e134-1499953498516-310520-01-07.hwx.site:8020 failed on connection 
> exception: java.net.ConnectException: Connection refused; For more details 
> see:  http://wiki.apache.org/hadoop/ConnectionRefused
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.apache.hadoop.net.NetUtils.wrapWithMessage(NetUtils.java:801)
> at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:732)
> at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1558)
> at org.apache.hadoop.ipc.Client.call(Client.java:1498)
> at org.apache.hadoop.ipc.Client.call(Client.java:1398)
> at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:233)
> at com.sun.proxy.$Proxy13.getFileInfo(Unknown Source)
> at 
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getFileInfo(ClientNamenodeProtocolTranslatorPB.java:823)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:291)
> at 
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:203)
> at 
> org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:185)
> at com.sun.proxy.$Proxy14.getFileInfo(Unknown Source)
> at org.apache.hadoop.hdfs.DFSClient.getFileInfo(DFSClient.java:2165)
> at 
> org.apache.hadoop.hdfs.DistributedFileSystem$26.doCall(DistributedFileSystem.java:1442)
> at 
> org.apache.hadoop.hdfs.DistributedFileSystem$26.doCall(DistributedFileSystem.java:1438)
> at 
> org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
> at 
> org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1454)
> at org.apache.hadoop.fs.FileSystem.resolvePath(FileSystem.java:770)
> at 
> org.apache.hadoop.hdfs.nfs.mount.RpcProgramMountd.addExports(RpcProgramMountd.java:107)
> at 
> org.apache.hadoop.hdfs.nfs.mount.RpcProgramMountd.(RpcProgramMountd.java:94)
> at org.apache.hadoop.hdfs.nfs.mount.Mountd.(Mountd.java:37)
> at org.apache.hadoop.hdfs.nfs.nfs3.Nfs3.(Nfs3.java:47)
> at org.apache.hadoop.hdfs.nfs.nfs3.Nfs3.startService(Nfs3.java:67)
> at 
> org.apache.hadoop.hdfs.nfs.nfs3.PrivilegedNfsGatewayStarter.start(PrivilegedNfsGatewayStarter.java:71)
> ... 5 more
> Caused by: java.net.ConnectException: Connection refused
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
> at 
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
> 
> 
> NFSGateway tries to connect to Namenode during start up. But in this case 
> NFSGateway starts before Namenode. We have no dependency in 
> role_command_order.json to regulate this. (Ps. deploy is 

Review Request 63872: NFSGateway start failed

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63872/
---

Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.


Bugs: AMBARI-22460
https://issues.apache.org/jira/browse/AMBARI-22460


Repository: ambari


Description
---

Initializing privileged NFS client socket...
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.apache.commons.daemon.support.DaemonLoader.start(DaemonLoader.java:243)
Caused by: java.net.ConnectException: Call From 
ctr-e134-1499953498516-310520-01-02.hwx.site/172.27.26.203 to 
ctr-e134-1499953498516-310520-01-07.hwx.site:8020 failed on connection 
exception: java.net.ConnectException: Connection refused; For more details see: 
 http://wiki.apache.org/hadoop/ConnectionRefused
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at org.apache.hadoop.net.NetUtils.wrapWithMessage(NetUtils.java:801)
at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:732)
at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1558)
at org.apache.hadoop.ipc.Client.call(Client.java:1498)
at org.apache.hadoop.ipc.Client.call(Client.java:1398)
at 
org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:233)
at com.sun.proxy.$Proxy13.getFileInfo(Unknown Source)
at 
org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getFileInfo(ClientNamenodeProtocolTranslatorPB.java:823)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:291)
at 
org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:203)
at 
org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:185)
at com.sun.proxy.$Proxy14.getFileInfo(Unknown Source)
at org.apache.hadoop.hdfs.DFSClient.getFileInfo(DFSClient.java:2165)
at 
org.apache.hadoop.hdfs.DistributedFileSystem$26.doCall(DistributedFileSystem.java:1442)
at 
org.apache.hadoop.hdfs.DistributedFileSystem$26.doCall(DistributedFileSystem.java:1438)
at 
org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
at 
org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1454)
at org.apache.hadoop.fs.FileSystem.resolvePath(FileSystem.java:770)
at 
org.apache.hadoop.hdfs.nfs.mount.RpcProgramMountd.addExports(RpcProgramMountd.java:107)
at 
org.apache.hadoop.hdfs.nfs.mount.RpcProgramMountd.(RpcProgramMountd.java:94)
at org.apache.hadoop.hdfs.nfs.mount.Mountd.(Mountd.java:37)
at org.apache.hadoop.hdfs.nfs.nfs3.Nfs3.(Nfs3.java:47)
at org.apache.hadoop.hdfs.nfs.nfs3.Nfs3.startService(Nfs3.java:67)
at 
org.apache.hadoop.hdfs.nfs.nfs3.PrivilegedNfsGatewayStarter.start(PrivilegedNfsGatewayStarter.java:71)
... 5 more
Caused by: java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)


NFSGateway tries to connect to Namenode during start up. But in this case 
NFSGateway starts before Namenode. We have no dependency in 
role_command_order.json to regulate this. (Ps. deploy is non-blueprint) 

As to how this worked before.
Most likely the ordering for was good because of how ordering algorithm worked. 
However maybe QE tests were adding NFS Gateway component only after Initial 
Deploy is done. Or maybe nfsgateway had some retry connect to NN code which is 
broken now.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json 
78a31f1797 


Diff: https://reviews.apache.org/r/63872/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 63838: ambari-server setup should surface GPL software agreement

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63838/#review191162
---



Thanks for your reviews guys.

- Andrew Onischuk


On Nov. 16, 2017, 6:26 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63838/
> ---
> 
> (Updated Nov. 16, 2017, 6:26 a.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22453
> https://issues.apache.org/jira/browse/AMBARI-22453
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Ask the user if they are okay with installing GPL license software
>   * Surface the license agreement subtext, for now use placeholder
>   * Save the result in ambari.properties
>   * The user selection should be available through API for the client and 
> also stack scripts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  91df506478 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  0bd6af6611 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d8712f2c75 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  0b048ad089 
>   ambari-server/src/main/python/ambari-server.py 60c60052cc 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 
> c7ac13476f 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c1643f2621 
> 
> 
> Diff: https://reviews.apache.org/r/63838/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>