Re: Review Request 63937: AMBARI-22472. Ambari Upgrade 2.5 -> 2.6 : Update NodeManager's HSI identity 'llap_zk_hive' and 'llap_task_hive' to use '/HIVE/HIVE_SERVER/hive_server_hive' reference instead

2017-11-20 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63937/
---

(Updated Nov. 21, 2017, 7:28 a.m.)


Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and Robert 
Levas.


Bugs: AMBARI-22472
https://issues.apache.org/jira/browse/AMBARI-22472


Repository: ambari


Description
---

**Background:**
YARN NodeManager currently has:

- 2 identities in 2.5 stack, namely : **'/HIVE/HIVE_SERVER/hive_server_hive'**  
and **'llap_zk_hive'**.
-- **/HIVE/HIVE_SERVER/hive_server_hive** is a reference from HIVE_SERVER, 
whereas
-- **llap_zk_hive** creates same principal as above in a separate keytab file.

- and 3 identities in 2.6 stack:
*'/HIVE/HIVE_SERVER/hive_server_hive'*  and *'llap_zk_hive'*.
-- **/HIVE/HIVE_SERVER/hive_server_hive** is a reference from HIVE_SERVER, 
whereas
-- **llap_zk_hive** and **llap_task_hive** creates same principal as above in a 
separate keytab file.

**Issue:** Recreating same identities in different files creates issues while 
AMbari upgrade from 2.5 to 2.6, as the *llap_zk_hive* are not refreshed/updated 
after the upgrade. Thus, HSI fails to come up.

**Fix:** 

**For HDP 2.5:** Make **llap_zk_hive** point as a reference pointing to 
/HIVE/HIVE_SERVER/hive_server_hive, so that we have one identity getting 
created only at one place and one keytab file.

**For HDP 2.6:** Make **llap_zk_hive** and **llap_task_hive** point as a 
reference pointing to /HIVE/HIVE_SERVER/hive_server_hive, so that we have one 
identity getting created only at one place and one keytab file.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
 96ce807 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
af6bda6 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/kerberos.json 
e0417bf 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
 be04cd5 
  
ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_ranger_kms.json
 e17e121 


Diff: https://reviews.apache.org/r/63937/diff/2/


Testing (updated)
---

**TESTING:**

||   Ambari 2.5, HDP 2.5 before upgrade:
||


{code:title=From /etc/hive2/cong/conf.server/hive-site.xml}
  
  hive.llap.daemon.keytab.file
  /etc/security/keytabs/hive.service.keytab



  hive.llap.daemon.service.principal
  hive/_h...@example.com



  hive.llap.zk.sm.keytab.file
  /etc/security/keytabs/hive.llap.zk.sm.keytab



  hive.llap.zk.sm.principal
  hive/_h...@example.com

{code} 


||Upgrade to Ambari-2.6
||


**Logs: Ambari Server Upgrade**

[root@swap-qqq-1 ~]# ambari-server upgrade
Using python  /usr/bin/python
Upgrading ambari-server
INFO: Upgrade Ambari Server
INFO: Updating Ambari Server properties in ambari.properties ...
INFO: Updating Ambari Server properties in ambari-env.sh ...
WARNING: Original file ambari-env.sh kept
INFO: Fixing database objects owner
Ambari Server configured for Embedded Postgres. Confirm you have made a backup 
of the Ambari Server database [y/n] (y)? y
INFO: Upgrading database schema
INFO: Return code from schema upgrade command, retcode = 0
INFO: Schema upgrade completed
Adjusting ambari-server permissions and ownership...
Ambari Server 'upgrade' completed successfully.
[root@swap-qqq-1 ~]#
[root@swap-qqq-1 ~]#
[root@swap-qqq-1 ~]#
[root@swap-qqq-1 ~]#
[root@swap-qqq-1 ~]# ambari-server --version
2.6.0.0-267
[root@swap-qqq-1 ~]#


**Logs : Updating Kerberos descriptors**

21 Nov 2017 01:01:20,438  INFO [main] UpgradeCatalog260:675 - Updating YARN's 
HSI Kerberos Descriptor 
21 Nov 2017 01:01:20,438  INFO [main] UpgradeCatalog260:687 -   Retrieved 
HIVE->HIVE_SERVER kerberos descriptor. Name = hive_server_hive
21 Nov 2017 01:01:20,438  INFO [main] UpgradeCatalog260:707 -   Retrieved 
YARN->NODEMANAGER kerberos descriptor to be updated. Name = llap_zk_hive
21 Nov 2017 01:01:20,439  INFO [main] UpgradeCatalog260:712 - Updated 
'llap_zk_hive' identity descriptor reference = 
'/HIVE/HIVE_SERVER/hive_server_hive'
21 Nov 2017 01:01:20,439  INFO [main] UpgradeCatalog260:715 - Updated 
'llap_zk_hive' principal descriptor value = 'null'
21 Nov 2017 01:01:20,439  INFO [main] UpgradeCatalog260:720 - Updated 
'llap_zk_hive' keytab descriptor file = 'null'
21 Nov 2017 01:01:20,439  INFO [main] UpgradeCatalog260:723 - Updated 
'llap_zk_hive' keytab descriptor owner name = 'null'
21 Nov 2017 01:01:20,439  INFO [main] UpgradeCatalog260:725 - Updated 
'llap_zk_hive' keytab descriptor owner access = 'null'
21 Nov 2017 01:01:20,439  INFO [main] UpgradeCatalog260:727 - Updated 
'llap_zk_hive' keytab descriptor group name = 'null'
21 Nov 2017 01:01:20,439

Re: Review Request 63937: AMBARI-22472. Ambari Upgrade 2.5 -> 2.6 : Update NodeManager's HSI identity 'llap_zk_hive' and 'llap_task_hive' to use '/HIVE/HIVE_SERVER/hive_server_hive' reference instead

2017-11-20 Thread Swapan Shridhar 


> On Nov. 18, 2017, 12:11 p.m., Robert Levas wrote:
> > Shouldn't there be at least one updated kerberos.json file?

Missed on adding them.
- Added files HDP/2.5/services/YARN/kerberos.json and 
HDP/2.6/services/YARN/kerberos.json for "llap_zk_hive" and "llap_task_hive" 
changes.


> On Nov. 18, 2017, 12:11 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> > Lines 711 (patched)
> > 
> >
> > I suspect that this should be set to `null` rather than an empty 
> > string.  But if it works, I am ok with it.

This worked for me, but nonetheless null makes more sense. Updated the code 
with using null.


> On Nov. 18, 2017, 12:11 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> > Lines 716 (patched)
> > 
> >
> > I suspect that this should be set to `null` rather than an empty 
> > string.  But if it works, I am ok with it.

This worked for me, but nonetheless null makes more sense. Updated the code 
with using null.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63937/#review191443
---


On Nov. 21, 2017, 7:25 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63937/
> ---
> 
> (Updated Nov. 21, 2017, 7:25 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and 
> Robert Levas.
> 
> 
> Bugs: AMBARI-22472
> https://issues.apache.org/jira/browse/AMBARI-22472
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Background:**
> YARN NodeManager currently has:
> 
> - 2 identities in 2.5 stack, namely : 
> **'/HIVE/HIVE_SERVER/hive_server_hive'**  and **'llap_zk_hive'**.
> -- **/HIVE/HIVE_SERVER/hive_server_hive** is a reference from HIVE_SERVER, 
> whereas
> -- **llap_zk_hive** creates same principal as above in a separate keytab file.
> 
> - and 3 identities in 2.6 stack:
> *'/HIVE/HIVE_SERVER/hive_server_hive'*  and *'llap_zk_hive'*.
> -- **/HIVE/HIVE_SERVER/hive_server_hive** is a reference from HIVE_SERVER, 
> whereas
> -- **llap_zk_hive** and **llap_task_hive** creates same principal as above in 
> a separate keytab file.
> 
> **Issue:** Recreating same identities in different files creates issues while 
> AMbari upgrade from 2.5 to 2.6, as the *llap_zk_hive* are not 
> refreshed/updated after the upgrade. Thus, HSI fails to come up.
> 
> **Fix:** 
> 
> **For HDP 2.5:** Make **llap_zk_hive** point as a reference pointing to 
> /HIVE/HIVE_SERVER/hive_server_hive, so that we have one identity getting 
> created only at one place and one keytab file.
> 
> **For HDP 2.6:** Make **llap_zk_hive** and **llap_task_hive** point as a 
> reference pointing to /HIVE/HIVE_SERVER/hive_server_hive, so that we have one 
> identity getting created only at one place and one keytab file.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  96ce807 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> af6bda6 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/kerberos.json 
> e0417bf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
>  be04cd5 
>   
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_ranger_kms.json
>  e17e121 
> 
> 
> Diff: https://reviews.apache.org/r/63937/diff/2/
> 
> 
> Testing
> ---
> 
> **TESTING:**
> 
> ||   Ambari 2.5, HDP 2.5 before upgrade:
> ||
> 
> 
> {code:title=From /etc/hive2/cong/conf.server/hive-site.xml}
>   
>   hive.llap.daemon.keytab.file
>   /etc/security/keytabs/hive.service.keytab
> 
> 
> 
>   hive.llap.daemon.service.principal
>   hive/_h...@example.com
> 
> 
> 
>   hive.llap.zk.sm.keytab.file
>   /etc/security/keytabs/hive.llap.zk.sm.keytab
> 
> 
> 
>   hive.llap.zk.sm.principal
>   hive/_h...@example.com
> 
> {code} 
> 
> 
> ||Upgrade to Ambari-2.6
> ||
> 
> 
> **Logs: Ambari Server Upgrade**
> 
> [root@swap-qqq-1 ~]# ambari-server upgrade
> Using python  /usr/bin/python
> Upgrading ambari-server
> INFO: Upgrade Ambari Server
> INFO: Updating Ambari Server properties in ambari.properties ...
> INFO: Updating Ambari Server properties in ambari-env.sh ...
> WARNING: Original file ambari-env.sh kept
> INFO: Fixing database objects owner
> Ambari Server

Re: Review Request 63962: Conditionally Rebuild MapReduce and Tez Tarballs with LZO if Enabled

2017-11-20 Thread Dmytro Grinenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63962/#review191550
---


Fix it, then Ship it!





ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
Lines 96 (patched)


better to use function from the sudo module here



ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
Lines 100 (patched)


we need to use sudo module, as agent may work not from root, thus we can 
get here "permission denied" or not found



ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
Lines 162 (patched)


better to use function from sudo module



ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
Lines 181 (patched)


here native python call is fine, as we operating with our temporary created 
directory and have full ownership on it


- Dmytro Grinenko


On Nov. 20, 2017, 7:27 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63962/
> ---
> 
> (Updated Nov. 20, 2017, 7:27 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Nate Cole.
> 
> 
> Bugs: AMBARI-22486
> https://issues.apache.org/jira/browse/AMBARI-22486
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If LZO is enabled and has been opted-in, then the Tez and MapReduce tarballs 
> should have LZO added to them.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  b05c97cdfe 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py
>  dfa650110d 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml
>  3438c45527 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/TEZ/configuration/tez-site.xml
>  4ffb7a49a4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration-mapred/mapred-site.xml
>  084e91254c 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> 45380728e3 
> 
> 
> Diff: https://reviews.apache.org/r/63962/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 63965: New endpoint service_config_version for creating new config versions via service endpoint instead of cluster update

2017-11-20 Thread Madhuvanthi Radhakrishnan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63965/
---

Review request for Ambari, Jayush Luniya, Swapan Shridhar, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-22487
https://issues.apache.org/jira/browse/AMBARI-22487


Repository: ambari


Description
---

Create new service config version
POST
api/v2/clusters//servicegroups//services//configurations/service_config_versions


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ConfigurationService.java
 79128a2374 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceConfigVersionService.java
 c6e320121f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 b5bc813e9c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 875d9b6f9f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionRequest.java
 29a7a421cd 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java
 cbc08ebdf4 


Diff: https://reviews.apache.org/r/63965/diff/1/


Testing
---

mvn clean install -DskipTests=true -Dmaven.test.skip=true -X
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main  SUCCESS [ 20.681 s]
[INFO] Apache Ambari Project POM .. SUCCESS [  0.047 s]
[INFO] Ambari Web . SUCCESS [ 59.888 s]
[INFO] Ambari Views ... SUCCESS [  1.454 s]
[INFO] Ambari Admin View .. SUCCESS [  9.794 s]
[INFO] ambari-utility . SUCCESS [  4.461 s]
[INFO] ambari-metrics . SUCCESS [  1.585 s]
[INFO] Ambari Metrics Common .. SUCCESS [  5.107 s]
[INFO] Ambari Metrics Hadoop Sink . SUCCESS [  3.697 s]
[INFO] Ambari Metrics Flume Sink .. SUCCESS [  3.057 s]
[INFO] Ambari Metrics Kafka Sink .. SUCCESS [  3.088 s]
[INFO] Ambari Metrics Storm Sink .. SUCCESS [  2.462 s]
[INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [  2.196 s]
[INFO] Ambari Metrics Collector ... SUCCESS [ 20.644 s]
[INFO] Ambari Metrics Monitor . SUCCESS [  2.597 s]
[INFO] Ambari Metrics Grafana . SUCCESS [  5.799 s]
[INFO] Ambari Metrics Host Aggregator . SUCCESS [  5.548 s]
[INFO] Ambari Metrics Assembly  SUCCESS [01:48 min]
[INFO] Ambari Service Advisor . SUCCESS [  0.614 s]
[INFO] Ambari Server .. SUCCESS [03:49 min]
[INFO] Ambari Functional Tests  SUCCESS [  0.494 s]
[INFO] Ambari Agent ... SUCCESS [ 50.352 s]
[INFO] Ambari Client .. SUCCESS [  0.100 s]
[INFO] Ambari Python Client ... SUCCESS [  0.896 s]
[INFO] Ambari Groovy Client ... SUCCESS [  1.600 s]
[INFO] Ambari Shell ... SUCCESS [  0.101 s]
[INFO] Ambari Python Shell  SUCCESS [  0.699 s]
[INFO] Ambari Groovy Shell  SUCCESS [  0.756 s]
[INFO] ambari-logsearch ... SUCCESS [  3.196 s]
[INFO] Ambari Logsearch Appender .. SUCCESS [  0.303 s]
[INFO] Ambari Logsearch Config Api  SUCCESS [  0.242 s]
[INFO] Ambari Logsearch Config Zookeeper .. SUCCESS [  0.352 s]
[INFO] Ambari Logsearch Log Feeder  SUCCESS [  4.504 s]
[INFO] Ambari Logsearch Web ... SUCCESS [01:10 min]
[INFO] Ambari Logsearch Server  SUCCESS [  8.842 s]
[INFO] Ambari Logsearch Assembly .. SUCCESS [  0.206 s]
[INFO] Ambari Logsearch Integration Test .. SUCCESS [  0.299 s]
[INFO] ambari-infra ... SUCCESS [  0.198 s]
[INFO] Ambari Infra Solr Client ... SUCCESS [  2.149 s]
[INFO] Ambari Infra Solr Plugin ... SUCCESS [  0.445 s]
[INFO] Ambari Infra Manager ... SUCCESS [  8.802 s]
[INFO] Ambari Infra Solr Assembly . SUCCESS [  0.214 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 10:47 min
[INFO]

Re: Review Request 63955: Validate blueprint does not allow lzo enable without setup with license agreement.

2017-11-20 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63955/#review191538
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 20, 2017, 5:06 p.m., Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63955/
> ---
> 
> (Updated Nov. 20, 2017, 5:06 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, 
> Robert Nettleton, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22480
> https://issues.apache.org/jira/browse/AMBARI-22480
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Blueprint validation should fail if LZO is enabled and GPL license is not 
> accepted on server setup.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  1c127c080cd33314e47bcfff63e0c1e6d58937bc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
> c9dc7281a092ff9f22551c9f8fc64ebca15fda36 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
>  1d917e0940b1ba5988a740005017c9d228e46f96 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidator.java
>  206d161fc694f67ae982ef668c5057b4bacec59b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  1aaa5ce66d1a5385018e4f29c92441e157c2be02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/GPLLicenseNotAcceptedException.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
>  fdbc0807788377f689e19200be9d6cdc2c992690 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  ea6bee314192f0665d4df652cf0c401e0218026f 
> 
> 
> Diff: https://reviews.apache.org/r/63955/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 63961: Ambari upgrade failed

2017-11-20 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63961/#review191536
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
Line 510 (original), 510 (patched)


I'm also considering changing this to

if (allVersionsList.isEmpty()) {
  return null;
} else if (currentVersionList.isEmpty()) {
  throw new AmbariException("Unable to find any CURRENT repositories.");
} else if (currentVersionList.size() != 1) {
  throw new AmbariException("The following repositories were found to be 
CURRENT: ".concat(StringUtils.join(currentVersionList, ",")));
}


- Dmitro Lisnichenko


On Nov. 20, 2017, 9:52 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63961/
> ---
> 
> (Updated Nov. 20, 2017, 9:52 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22469
> https://issues.apache.org/jira/browse/AMBARI-22469
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari upgrade would fail for all Ambari view servers.
> Steps to reproduce:
> 1. Install Ambari 2.5.2 and setup it as view server. (it you don't set up it 
> up as view server also it fails)
> 2. now install 2.6.0
> 3. run ambari-server upgrade
> it fails out with below exception.
> 
> {noformat}
> ERROR: Error executing schema upgrade, please check the server logs.
> ERROR: Error output from schema upgrade command:
> ERROR: Exception in thread "main" org.apache.ambari.server.AmbariException: 
> Unable to find any CURRENT repositories.
>   at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:203)
>   at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
> Caused by: org.apache.ambari.server.AmbariException: Unable to find any 
> CURRENT repositories.
>   at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.getCurrentVersionID(UpgradeCatalog260.java:510)
>   at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:194)
>   at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
>   at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
>   ... 1 more
> 
> 
> ERROR: Ambari server upgrade failed. Please look at 
> /var/log/ambari-server/ambari-server.log, for more details.
> ERROR: Exiting with exit code 11.
> REASON: Schema upgrade failed.
> {noformat}
> 
> For some reason we are checking cluster_version table entries and throwing up 
> above exception.
> 
> 
> {noformat}
> In UpgradeCatalog260.java
> public int getCurrentVersionID() throws AmbariException, SQLException {
> List currentVersionList = 
> dbAccessor.getIntColumnValues(CLUSTER_VERSION_TABLE, REPO_VERSION_ID_COLUMN,
> new String[]{STATE_COLUMN}, new String[]{CURRENT}, false);
> if (currentVersionList.isEmpty()) {
>   throw new AmbariException("Unable to find any CURRENT repositories.");
> } else if (currentVersionList.size() != 1) {
>   throw new AmbariException("The following repositories were found to be 
> CURRENT: ".concat(StringUtils.join(currentVersionList, ",")));
> }
> return currentVersionList.get(0);
>   }
> {noformat}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  96ce807d5f 
> 
> 
> Diff: https://reviews.apache.org/r/63961/diff/1/
> 
> 
> Testing
> ---
> 
> pending check on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 63961: Ambari upgrade failed

2017-11-20 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63961/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-22469
https://issues.apache.org/jira/browse/AMBARI-22469


Repository: ambari


Description
---

Ambari upgrade would fail for all Ambari view servers.
Steps to reproduce:
1. Install Ambari 2.5.2 and setup it as view server. (it you don't set up it up 
as view server also it fails)
2. now install 2.6.0
3. run ambari-server upgrade
it fails out with below exception.

{noformat}
ERROR: Error executing schema upgrade, please check the server logs.
ERROR: Error output from schema upgrade command:
ERROR: Exception in thread "main" org.apache.ambari.server.AmbariException: 
Unable to find any CURRENT repositories.
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:203)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
Caused by: org.apache.ambari.server.AmbariException: Unable to find any CURRENT 
repositories.
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.getCurrentVersionID(UpgradeCatalog260.java:510)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:194)
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
... 1 more


ERROR: Ambari server upgrade failed. Please look at 
/var/log/ambari-server/ambari-server.log, for more details.
ERROR: Exiting with exit code 11.
REASON: Schema upgrade failed.
{noformat}

For some reason we are checking cluster_version table entries and throwing up 
above exception.


{noformat}
In UpgradeCatalog260.java
public int getCurrentVersionID() throws AmbariException, SQLException {
List currentVersionList = 
dbAccessor.getIntColumnValues(CLUSTER_VERSION_TABLE, REPO_VERSION_ID_COLUMN,
new String[]{STATE_COLUMN}, new String[]{CURRENT}, false);
if (currentVersionList.isEmpty()) {
  throw new AmbariException("Unable to find any CURRENT repositories.");
} else if (currentVersionList.size() != 1) {
  throw new AmbariException("The following repositories were found to be 
CURRENT: ".concat(StringUtils.join(currentVersionList, ",")));
}
return currentVersionList.get(0);
  }
{noformat}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
 96ce807d5f 


Diff: https://reviews.apache.org/r/63961/diff/1/


Testing
---

pending check on live cluster


Thanks,

Dmitro Lisnichenko

Review Request 63962: Conditionally Rebuild MapReduce and Tez Tarballs with LZO if Enabled

2017-11-20 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63962/
---

Review request for Ambari, Dmytro Grinenko and Nate Cole.


Bugs: AMBARI-22486
https://issues.apache.org/jira/browse/AMBARI-22486


Repository: ambari


Description
---

If LZO is enabled and has been opted-in, then the Tez and MapReduce tarballs 
should have LZO added to them.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
 b05c97cdfe 
  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py
 dfa650110d 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml
 3438c45527 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/TEZ/configuration/tez-site.xml
 4ffb7a49a4 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration-mapred/mapred-site.xml
 084e91254c 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
45380728e3 


Diff: https://reviews.apache.org/r/63962/diff/1/


Testing
---

Manual testing.


Thanks,

Jonathan Hurley

Re: Review Request 63957: Stack advisor should disallow lzo enable without accepting license agreement.

2017-11-20 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63957/#review191533
---


Ship it!




Ship It!

- Sid Wagle


On Nov. 20, 2017, 5:06 p.m., Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63957/
> ---
> 
> (Updated Nov. 20, 2017, 5:06 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-22484
> https://issues.apache.org/jira/browse/AMBARI-22484
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If the user adds com.hadoop.compression.lzo.LzoCodec to core-site property 
> io.compression.codec.lzo.class and the ambari.properties does not have the 
> allow GPL software install flag, throw validation error
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
>  64180e5039bdb74d3aaf25e140565c82a95a26c1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  5440462b86cdcfafb1e9ab239dacfddee0b31b93 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  b2a68d66d777f107fdc4f5576a691e8d25ec2c92 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java
>  dd32c6badb18c1a8c02b7093813cd92ccd2fc74c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> c36a41f49b224a904368c7474f0f769348e65ae6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java
>  cdbf2d782f86b2a30f54619c4e2a9165a020275c 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 9e0070458987ee490f3918fead5ef11d201c8612 
> 
> 
> Diff: https://reviews.apache.org/r/63957/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 63957: Stack advisor should disallow lzo enable without accepting license agreement.

2017-11-20 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63957/#review191532
---


Ship it!





ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py
Lines 531 (patched)


nit: "Please refer to the documentation..."


- Nate Cole


On Nov. 20, 2017, 12:06 p.m., Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63957/
> ---
> 
> (Updated Nov. 20, 2017, 12:06 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-22484
> https://issues.apache.org/jira/browse/AMBARI-22484
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If the user adds com.hadoop.compression.lzo.LzoCodec to core-site property 
> io.compression.codec.lzo.class and the ambari.properties does not have the 
> allow GPL software install flag, throw validation error
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
>  64180e5039bdb74d3aaf25e140565c82a95a26c1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  5440462b86cdcfafb1e9ab239dacfddee0b31b93 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  b2a68d66d777f107fdc4f5576a691e8d25ec2c92 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java
>  dd32c6badb18c1a8c02b7093813cd92ccd2fc74c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> c36a41f49b224a904368c7474f0f769348e65ae6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java
>  cdbf2d782f86b2a30f54619c4e2a9165a020275c 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 9e0070458987ee490f3918fead5ef11d201c8612 
> 
> 
> Diff: https://reviews.apache.org/r/63957/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 63955: Validate blueprint does not allow lzo enable without setup with license agreement.

2017-11-20 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63955/#review191531
---


Ship it!




Ship It!

- Nate Cole


On Nov. 20, 2017, 12:06 p.m., Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63955/
> ---
> 
> (Updated Nov. 20, 2017, 12:06 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, 
> Robert Nettleton, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22480
> https://issues.apache.org/jira/browse/AMBARI-22480
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Blueprint validation should fail if LZO is enabled and GPL license is not 
> accepted on server setup.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  1c127c080cd33314e47bcfff63e0c1e6d58937bc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
> c9dc7281a092ff9f22551c9f8fc64ebca15fda36 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
>  1d917e0940b1ba5988a740005017c9d228e46f96 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidator.java
>  206d161fc694f67ae982ef668c5057b4bacec59b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  1aaa5ce66d1a5385018e4f29c92441e157c2be02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/GPLLicenseNotAcceptedException.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
>  fdbc0807788377f689e19200be9d6cdc2c992690 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  ea6bee314192f0665d4df652cf0c401e0218026f 
> 
> 
> Diff: https://reviews.apache.org/r/63955/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 63955: Validate blueprint does not allow lzo enable without setup with license agreement.

2017-11-20 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63955/#review191529
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
Line 351 (original), 352 (patched)


Add missing throws to documentation



ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidator.java
Line 38 (original), 38 (patched)


add missing throws to documentation


- Jonathan Hurley


On Nov. 20, 2017, 12:06 p.m., Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63955/
> ---
> 
> (Updated Nov. 20, 2017, 12:06 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, 
> Robert Nettleton, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22480
> https://issues.apache.org/jira/browse/AMBARI-22480
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Blueprint validation should fail if LZO is enabled and GPL license is not 
> accepted on server setup.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  1c127c080cd33314e47bcfff63e0c1e6d58937bc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
> c9dc7281a092ff9f22551c9f8fc64ebca15fda36 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
>  1d917e0940b1ba5988a740005017c9d228e46f96 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidator.java
>  206d161fc694f67ae982ef668c5057b4bacec59b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  1aaa5ce66d1a5385018e4f29c92441e157c2be02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/GPLLicenseNotAcceptedException.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
>  fdbc0807788377f689e19200be9d6cdc2c992690 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  ea6bee314192f0665d4df652cf0c401e0218026f 
> 
> 
> Diff: https://reviews.apache.org/r/63955/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 63957: Stack advisor should disallow lzo enable without accepting license agreement.

2017-11-20 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63957/#review191526
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
Lines 121-123 (patched)


Documentation.



ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
Lines 197-201 (patched)


Documentation.



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py
Lines 519 (patched)


Documentation.


- Jonathan Hurley


On Nov. 20, 2017, 12:06 p.m., Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63957/
> ---
> 
> (Updated Nov. 20, 2017, 12:06 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-22484
> https://issues.apache.org/jira/browse/AMBARI-22484
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If the user adds com.hadoop.compression.lzo.LzoCodec to core-site property 
> io.compression.codec.lzo.class and the ambari.properties does not have the 
> allow GPL software install flag, throw validation error
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
>  64180e5039bdb74d3aaf25e140565c82a95a26c1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  5440462b86cdcfafb1e9ab239dacfddee0b31b93 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  b2a68d66d777f107fdc4f5576a691e8d25ec2c92 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java
>  dd32c6badb18c1a8c02b7093813cd92ccd2fc74c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> c36a41f49b224a904368c7474f0f769348e65ae6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java
>  cdbf2d782f86b2a30f54619c4e2a9165a020275c 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 9e0070458987ee490f3918fead5ef11d201c8612 
> 
> 
> Diff: https://reviews.apache.org/r/63957/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 63935: AMBARI-22470 : Refine Metric Definition Service and AD Query service.

2017-11-20 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63935/
---

(Updated Nov. 20, 2017, 5:20 p.m.)


Review request for Ambari, Jayush Luniya and Sid Wagle.


Bugs: AMBARI-22470
https://issues.apache.org/jira/browse/AMBARI-22470


Repository: ambari


Description
---

Metric definition service - integration with LevelDB.
Metric definition service - integration with Metrics Collector
AD Query Service - Ability to retrieve anomaly data from Phoenix.
Fix pom.xml issues.
Startup metric definition and query services during server start.
Remove phoenix connection code from ambari-metrics-common collector and AD 
service modules.


Diffs (updated)
-

  ambari-metrics/ambari-metrics-anomaly-detection-service/pom.xml 142f02f 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/config.yml
 9402f6e 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/hbase-site.xml
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/ADServiceScalaModule.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionApp.scala
 8b3a829 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala
 93f6b28 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppModule.scala
 a896563 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/HBaseConfiguration.scala
 a51a959 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/AdAnomalyStoreAccessor.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/AdMetadataStoreAccessorImpl.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/ConnectionProvider.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/DefaultPhoenixDataSource.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/LevelDbStoreAccessor.scala
 baad57d 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/MetadataDatasource.scala
 aa6694a 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/PhoenixAnomalyStoreAccessor.scala
 36aea21 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/PhoenixConnectionProvider.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/PhoenixQueryConstants.scala
 5379c91 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/leveldb/LevelDBDatasource.scala
 a34a60a 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metadata/ADMetadataProvider.scala
 95b1b63 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metadata/InputMetricDefinitionParser.scala
 cc66c90 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metadata/MetricDefinition.scala
 036867b 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metadata/MetricDefinitionService.scala
 635dc60 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metadata/MetricDefinitionServiceImpl.scala
 c34d2dd 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metadata/MetricKey.scala
 afad617 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metadata/MetricMetadataProvider.scala
 5f9c0a0 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/model/MetricAnomalyInstance.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/model/SingleMetricAnomalyInstance.scala
 981a893 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/resource/AnomalyResource.scala
 98ce0c4

Review Request 63957: Stack advisor should disallow lzo enable without accepting license agreement.

2017-11-20 Thread Myroslav Papirkovskyy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63957/
---

Review request for Ambari, Andrew Onischuk and Sid Wagle.


Bugs: AMBARI-22484
https://issues.apache.org/jira/browse/AMBARI-22484


Repository: ambari


Description
---

If the user adds com.hadoop.compression.lzo.LzoCodec to core-site property 
io.compression.codec.lzo.class and the ambari.properties does not have the 
allow GPL software install flag, throw validation error


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
 64180e5039bdb74d3aaf25e140565c82a95a26c1 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
 5440462b86cdcfafb1e9ab239dacfddee0b31b93 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 b2a68d66d777f107fdc4f5576a691e8d25ec2c92 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java
 dd32c6badb18c1a8c02b7093813cd92ccd2fc74c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
c36a41f49b224a904368c7474f0f769348e65ae6 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java
 cdbf2d782f86b2a30f54619c4e2a9165a020275c 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
9e0070458987ee490f3918fead5ef11d201c8612 


Diff: https://reviews.apache.org/r/63957/diff/1/


Testing
---

mvn clean test


Thanks,

Myroslav Papirkovskyy

Review Request 63956: Use case and service based mpack selection

2017-11-20 Thread Jason Golieb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63956/
---

Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, 
Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako.


Bugs: AMBARI-22482
https://issues.apache.org/jira/browse/AMBARI-22482


Repository: ambari


Description
---

Enable selection of mpacks to install via use cases or by direct service 
selection. This includes switching between "basic" and "advanced" selection 
modes. Basic mode allows selection of use cases only. Advanced mode allows 
selection of mpacks and/or services directly.


Diffs
-

  ambari-web/app/controllers/installer.js 14ae790df97 
  ambari-web/app/controllers/wizard/downloadProducts_controller.js b3537320292 
  ambari-web/app/controllers/wizard/selectMpacks_controller.js a7c62ff0c6a 
  ambari-web/app/messages.js c9bae250241 
  ambari-web/app/routes/installer.js 9a49c365344 
  ambari-web/app/templates/wizard/selectMpacks.hbs 19855d3071e 
  ambari-web/app/templates/wizard/selectMpacks/mpack.hbs 9a65baf5b1a 
  ambari-web/app/templates/wizard/selectMpacks/selectedMpackVersion.hbs 
05e75ffb150 
  ambari-web/app/templates/wizard/selectMpacks/service.hbs PRE-CREATION 
  ambari-web/app/templates/wizard/selectMpacks/usecase.hbs PRE-CREATION 
  ambari-web/app/utils/ajax/ajax.js f86fd3ddbbf 
  ambari-web/app/views/wizard/selectMpacks_view.js deab12b5354 
  ambari-web/test/controllers/wizard/selectMpacks_test.js 7102d91f026 


Diff: https://reviews.apache.org/r/63956/diff/1/


Testing
---

20287 passing (30s)
  124 pending


Thanks,

Jason Golieb

Review Request 63955: Validate blueprint does not allow lzo enable without setup with license agreement.

2017-11-20 Thread Myroslav Papirkovskyy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63955/
---

Review request for Ambari, Andrew Onischuk, Robert Nettleton, and Sid Wagle.


Bugs: AMBARI-22480
https://issues.apache.org/jira/browse/AMBARI-22480


Repository: ambari


Description
---

Blueprint validation should fail if LZO is enabled and GPL license is not 
accepted on server setup.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
 1c127c080cd33314e47bcfff63e0c1e6d58937bc 
  ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
c9dc7281a092ff9f22551c9f8fc64ebca15fda36 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
 1d917e0940b1ba5988a740005017c9d228e46f96 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidator.java
 206d161fc694f67ae982ef668c5057b4bacec59b 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
 1aaa5ce66d1a5385018e4f29c92441e157c2be02 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/GPLLicenseNotAcceptedException.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
 fdbc0807788377f689e19200be9d6cdc2c992690 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
 ea6bee314192f0665d4df652cf0c401e0218026f 


Diff: https://reviews.apache.org/r/63955/diff/1/


Testing
---

mvn clean test


Thanks,

Myroslav Papirkovskyy

Re: Review Request 63945: AMBARI-22393: UI changes for prompting user during registration failure for new OS family

2017-11-20 Thread Sonia Garudi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63945/
---

(Updated Nov. 20, 2017, 2:25 p.m.)


Review request for Ambari and Nate Cole.


Changes
---

Fix for 1 test case failure in doBootstrapSuccessCallback


Bugs: AMBARI-22393
https://issues.apache.org/jira/browse/AMBARI-22393


Repository: ambari


Description
---

The bootstrap process fails with code 44 incase the ambari repository URL is 
not set for a particular os type in the ambari.properties file. Checks for the 
returned status code from bootstrap.py and accordingly displays a prompt on UI 
for ambari reposiory URL for the failing os types.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatus.java
 3d1b31c 
  
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java
 b72ca20 
  ambari-web/app/controllers/wizard/step3_controller.js 29393e3 
  ambari-web/app/messages.js 390f803 
  ambari-web/app/styles/wizard.less cb9eb92 
  ambari-web/app/templates/wizard/step3.hbs e00012c 
  ambari-web/test/controllers/wizard/step3_test.js b8bc794 


Diff: https://reviews.apache.org/r/63945/diff/2/

Changes: https://reviews.apache.org/r/63945/diff/1-2/


Testing
---

Tests were successful in ambari-web and ambari-server.


Thanks,

Sonia Garudi

Re: Review Request 63947: Log Search UI: implement access logs table

2017-11-20 Thread Andrii Tkach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63947/#review191497
---


Ship it!




Ship It!

- Andrii Tkach


On Nov. 20, 2017, 11:34 a.m., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63947/
> ---
> 
> (Updated Nov. 20, 2017, 11:34 a.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-22477
> https://issues.apache.org/jira/browse/AMBARI-22477
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add layout for audit logs table
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 805f8e2 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table-component.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table-component.ts
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log.ts 
> fbe0e46 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.html
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.less
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts
>  3314252 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html
>  2c3a3b9 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts
>  f8acd50 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html
>  7de0b96 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less
>  c5c4c5a 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.spec.ts
>  21c4f02 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts
>  3a56fca 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.html
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.less
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.ts
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/mock-data.ts 147efef 
>   ambari-logsearch/ambari-logsearch-web/src/app/services/auth.service.spec.ts 
> fd5a83e 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts
>  f45887b 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/mock-api-data.service.ts
>  8b157df 
> 
> 
> Diff: https://reviews.apache.org/r/63947/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 211 of 211 SUCCESS (4.882 secs / 4.796 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Review Request 63947: Log Search UI: implement access logs table

2017-11-20 Thread Andrii Babiichuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63947/
---

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-22477
https://issues.apache.org/jira/browse/AMBARI-22477


Repository: ambari


Description
---

Add layout for audit logs table


Diffs
-

  ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 805f8e2 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table-component.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table-component.ts
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log.ts 
fbe0e46 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.html
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.less
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts
 3314252 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html
 2c3a3b9 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts
 f8acd50 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html
 7de0b96 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less
 c5c4c5a 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.spec.ts
 21c4f02 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts
 3a56fca 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.html
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.less
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.ts
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/mock-data.ts 147efef 
  ambari-logsearch/ambari-logsearch-web/src/app/services/auth.service.spec.ts 
fd5a83e 
  
ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts
 f45887b 
  
ambari-logsearch/ambari-logsearch-web/src/app/services/mock-api-data.service.ts 
8b157df 


Diff: https://reviews.apache.org/r/63947/diff/1/


Testing
---

Executed 211 of 211 SUCCESS (4.882 secs / 4.796 secs)


Thanks,

Andrii Babiichuk

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-20 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63916/#review191492
---



Thanks for reviews

- Andrew Onischuk


On Nov. 20, 2017, 10:35 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63916/
> ---
> 
> (Updated Nov. 20, 2017, 10:35 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Myroslav 
> Papirkovskyy, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22467
> https://issues.apache.org/jira/browse/AMBARI-22467
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changes Summary:
> - Do not install lzo if GPL license if not accepted, instead give out 
> logger.warning and skip
> - Remove installation of lzo from metainfo.xml. Since we need to install lzo 
> on restart if lzo is enabled/license accepted, we still need to do this in 
> Python code. No need to duplicate.
> Clients will also use that code during install.
> - Move function get_lzo_packages to lzo_utils.py
> - Add code for Yarn, MR2, Hive to install lzo, edit existing code to install 
> lzo for HDFS,Oozie to use lzo_utils.py 
> 
> Notes:
> - Impl is Patch Upgrade friendly as uses the same code to detect 
> {stack_version} as all the other packages. That code (not implemented here) 
> gets version depending component specific repo info not stack specific.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/__init__.py
>  f144b2da32266782437d6dad3f6c76de7e8106cd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
>  cfbb7d81e82a08acf187999b95b02bca8b8fb54a 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  31e78b9e60b40513e8d107d45ed2fbf4620ce9db 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 2df1b9f6476c52deab49e24028d10817c83af8ef 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
>  6f702d3616f0991862cd7e020e7e18f3b389883b 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/install_params.py
>  fe488c3004f934e00030e1b9d8952fd42d71f8e3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  5ca012b7966c044c4e5971bb400517f82aaa95c6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  abbe59ed9f9ff4922da78a31661308804b517893 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  7d2260318420e869f4011d54117e8233a6cd9928 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  cd1f7ad36fbda06d86effb7c1d04edbc20a1a876 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  f6e8391a54a03db3e4209edf5d2089eb86c14fd3 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 
> 07a9ef8e943dc47428c07c60c872580c141c5dbc 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml 
> 63e85e363f295627bba4e3b30328bb7f521cb9b3 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 
> 86ca03a4a3101e646f265b5dca6e32bb179c9856 
> 
> 
> Diff: https://reviews.apache.org/r/63916/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-20 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63916/
---

(Updated Nov. 20, 2017, 10:35 a.m.)


Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Myroslav 
Papirkovskyy, Nate Cole, and Sid Wagle.


Bugs: AMBARI-22467
https://issues.apache.org/jira/browse/AMBARI-22467


Repository: ambari


Description
---

Changes Summary:
- Do not install lzo if GPL license if not accepted, instead give out 
logger.warning and skip
- Remove installation of lzo from metainfo.xml. Since we need to install lzo on 
restart if lzo is enabled/license accepted, we still need to do this in Python 
code. No need to duplicate.
Clients will also use that code during install.
- Move function get_lzo_packages to lzo_utils.py
- Add code for Yarn, MR2, Hive to install lzo, edit existing code to install 
lzo for HDFS,Oozie to use lzo_utils.py 

Notes:
- Impl is Patch Upgrade friendly as uses the same code to detect 
{stack_version} as all the other packages. That code (not implemented here) 
gets version depending component specific repo info not stack specific.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/__init__.py
 f144b2da32266782437d6dad3f6c76de7e8106cd 
  
ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
 cfbb7d81e82a08acf187999b95b02bca8b8fb54a 
  
ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
 31e78b9e60b40513e8d107d45ed2fbf4620ce9db 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
2df1b9f6476c52deab49e24028d10817c83af8ef 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
 6f702d3616f0991862cd7e020e7e18f3b389883b 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/install_params.py
 fe488c3004f934e00030e1b9d8952fd42d71f8e3 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 5ca012b7966c044c4e5971bb400517f82aaa95c6 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 abbe59ed9f9ff4922da78a31661308804b517893 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 7d2260318420e869f4011d54117e8233a6cd9928 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 cd1f7ad36fbda06d86effb7c1d04edbc20a1a876 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 f6e8391a54a03db3e4209edf5d2089eb86c14fd3 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 
07a9ef8e943dc47428c07c60c872580c141c5dbc 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml 
63e85e363f295627bba4e3b30328bb7f521cb9b3 
  ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 
86ca03a4a3101e646f265b5dca6e32bb179c9856 


Diff: https://reviews.apache.org/r/63916/diff/2/

Changes: https://reviews.apache.org/r/63916/diff/1-2/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-20 Thread Andrew Onischuk 


> On Nov. 17, 2017, 4:25 p.m., Nate Cole wrote:
> > Please also verify if BigInsight stacks are affected by this change.  If 
> > that is the case, then a separate JIRA should be opened to address that.
> 
> Jonathan Hurley wrote:
> Great catch! Looks like it does:
> 
> https://github.com/apache/ambari/blob/branch-2.5/ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/scripts/hdfs.py#L118-L119
> 
> So BI 4.0 and 4.2 will need it ... 4.2.5 extends common-services, so it 
> doesn't need it.
> 
> Also - don't forget to merge into 3.0 stack in trunk as well ... anything 
> Python changes in branch-2.6 need extra-work done when going into trunk.
> 
> Andrew Onischuk wrote:
> Sure @Jonathan.
> Do you guys think a separate jira should be fixVersion 3.0 or 2.6?

Created it for 3.0


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63916/#review191346
---


On Nov. 17, 2017, 2:40 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63916/
> ---
> 
> (Updated Nov. 17, 2017, 2:40 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Myroslav 
> Papirkovskyy, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22467
> https://issues.apache.org/jira/browse/AMBARI-22467
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changes Summary:
> - Do not install lzo if GPL license if not accepted, instead give out 
> logger.warning and skip
> - Remove installation of lzo from metainfo.xml. Since we need to install lzo 
> on restart if lzo is enabled/license accepted, we still need to do this in 
> Python code. No need to duplicate.
> Clients will also use that code during install.
> - Move function get_lzo_packages to lzo_utils.py
> - Add code for Yarn, MR2, Hive to install lzo, edit existing code to install 
> lzo for HDFS,Oozie to use lzo_utils.py 
> 
> Notes:
> - Impl is Patch Upgrade friendly as uses the same code to detect 
> {stack_version} as all the other packages. That code (not implemented here) 
> gets version depending component specific repo info not stack specific.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/__init__.py
>  f144b2da32 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
>  cfbb7d81e8 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  31e78b9e60 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 2df1b9f647 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
>  6f702d3616 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/install_params.py
>  fe488c3004 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  5ca012b796 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  abbe59ed9f 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  7d22603184 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  cd1f7ad36f 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  f6e8391a54 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 
> 07a9ef8e94 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml 
> 63e85e363f 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 
> 86ca03a4a3 
> 
> 
> Diff: https://reviews.apache.org/r/63916/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 63945: AMBARI-22393: UI changes for prompting user during registration failure for new OS family

2017-11-20 Thread Sonia Garudi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63945/
---

(Updated Nov. 20, 2017, 9:48 a.m.)


Review request for Ambari and Nate Cole.


Bugs: AMBARI-22393
https://issues.apache.org/jira/browse/AMBARI-22393


Repository: ambari


Description
---

The bootstrap process fails with code 44 incase the ambari repository URL is 
not set for a particular os type in the ambari.properties file. Checks for the 
returned status code from bootstrap.py and accordingly displays a prompt on UI 
for ambari reposiory URL for the failing os types.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatus.java
 3d1b31c 
  
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java
 b72ca20 
  ambari-web/app/controllers/wizard/step3_controller.js 29393e3 
  ambari-web/app/messages.js 390f803 
  ambari-web/app/styles/wizard.less cb9eb92 
  ambari-web/app/templates/wizard/step3.hbs e00012c 
  ambari-web/test/controllers/wizard/step3_test.js b8bc794 


Diff: https://reviews.apache.org/r/63945/diff/1/


Testing
---

Tests were successful in ambari-web and ambari-server.


Thanks,

Sonia Garudi

Review Request 63945: AMBARI-22393: UI changes for prompting user during registration failure for new OS family

2017-11-20 Thread Sonia Garudi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63945/
---

Review request for Ambari and Nate Cole.


Bugs: AMBARI-22393
https://issues.apache.org/jira/browse/AMBARI-22393


Repository: ambari


Description
---

The bootstrap process fails with code 44 incase the ambari repository URL is 
not set for a particular os type in the ambari.properties file. Checks for the 
returned status code from bootstrap.py and accordingly displays a prompt on UI 
for ambari reposiory URL for the failing os types.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatus.java
 3d1b31c 
  
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java
 b72ca20 
  ambari-web/app/controllers/wizard/step3_controller.js 29393e3 
  ambari-web/app/messages.js 390f803 
  ambari-web/app/styles/wizard.less cb9eb92 
  ambari-web/app/templates/wizard/step3.hbs e00012c 
  ambari-web/test/controllers/wizard/step3_test.js b8bc794 


Diff: https://reviews.apache.org/r/63945/diff/1/


Testing
---

Tests were successful in ambari-web and ambari-server.


Thanks,

Sonia Garudi