Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-02 Thread Yussuf Shaikh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64887/
---

(Updated Jan. 3, 2018, 7:03 a.m.)


Review request for Ambari and Nate Cole.


Bugs: AMBARI-22403
https://issues.apache.org/jira/browse/AMBARI-22403


Repository: ambari


Description
---

Java side changes required to read JAVA HOME value for each host depending on 
the OS type eg: java.home.redhat7.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 182cd58 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 c0a7a7b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 c4df0b1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 198b617 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 dcafdea 
  ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
b6287e6 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 e47fcd2 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 6bece66 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 e795d28 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 a1f28f1 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
 c5994c5 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
 51035ba 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java
 670c187 
  
ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java 
b90295d 


Diff: https://reviews.apache.org/r/64887/diff/2/

Changes: https://reviews.apache.org/r/64887/diff/1-2/


Testing
---

tests ran on ambari-server project.


Thanks,

Yussuf Shaikh

Re: Review Request 64775: AMBARI-22394: Store and retrieve the ambari repo urls for os family during bootstrap

2018-01-02 Thread Sneha Kanekar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64775/
---

(Updated Jan. 3, 2018, 3:47 a.m.)


Review request for Ambari and Nate Cole.


Bugs: AMBARI-22394
https://issues.apache.org/jira/browse/AMBARI-22394


Repository: ambari


Description
---

Ambari configuration will have list of repo urls for each os type. During 
bootstrap, the stored repo url will be used to correct the base url from ambari 
repo file on agent host.


Diffs
-

  ambari-server/src/main/python/bootstrap.py f1c53ce 
  ambari-server/src/main/python/os_check_type.py da37560 
  ambari-server/src/main/python/setupAgent.py efc3d7c 
  ambari-server/src/test/python/TestBootstrap.py bea47f4 
  ambari-server/src/test/python/TestSetupAgent.py 0b33e9f 


Diff: https://reviews.apache.org/r/64775/diff/2/


Testing
---

Tests were successful in ambari-server.


Thanks,

Sneha Kanekar

Re: Review Request 64894: zeppelin.livy.url is not getting updated after moving livy to a new host

2018-01-02 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64894/
---

(Updated Jan. 3, 2018, 1:11 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22716
https://issues.apache.org/jira/browse/AMBARI-22716


Repository: ambari


Description
---

zeppelin.livy.url is not getting updated after moving livy to a new host

Steps to reproduce :
1) Create a cluster with both Spark and Spark2 component
2) Delete livy component from current host.
3) Add the livy component on a new host
4) Restart zeppelin server. 
5) Now check the zeppelin interpreter settings. zeppelin.livy.url is still 
referring to older livy host. 
Its not reflecting the new livy server address.

Note 1 : If I restart zeppelin server after step1 (ie after deleting the livy 
host) before performing rest of the steps, then changes are getting reflected 
properly. System test was mistakenly doing this step so didn't fail during 
nightly run

Note 2 : Issue is happening only when both Spark and Spark2 are installed. If 
cluster contains only Spark2, this feature works as expected.
Issue is coming if I add Spark(version 1) to it.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 efa3ffe3ba 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
f5027b2aee 


Diff: https://reviews.apache.org/r/64894/diff/2/


Testing
---

Manually tested on CentOS 6


File Attachments (updated)


0AMBARI-22716_branch-2.6_v1.patch
  
https://reviews.apache.org/media/uploaded/files/2018/01/02/2c206e6b-759d-4f94-899d-8d595e29832c__0AMBARI-22716_branch-2.6_v1.patch
0AMBARI-22716_branch-2.6_v2.patch
  
https://reviews.apache.org/media/uploaded/files/2018/01/02/4bf2c460-c5cd-443a-a0ce-80357ec5bd93__0AMBARI-22716_branch-2.6_v2.patch


Thanks,

Prabhjyot Singh

Re: Review Request 64894: zeppelin.livy.url is not getting updated after moving livy to a new host

2018-01-02 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64894/
---

(Updated Jan. 3, 2018, 1:10 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22716
https://issues.apache.org/jira/browse/AMBARI-22716


Repository: ambari


Description
---

zeppelin.livy.url is not getting updated after moving livy to a new host

Steps to reproduce :
1) Create a cluster with both Spark and Spark2 component
2) Delete livy component from current host.
3) Add the livy component on a new host
4) Restart zeppelin server. 
5) Now check the zeppelin interpreter settings. zeppelin.livy.url is still 
referring to older livy host. 
Its not reflecting the new livy server address.

Note 1 : If I restart zeppelin server after step1 (ie after deleting the livy 
host) before performing rest of the steps, then changes are getting reflected 
properly. System test was mistakenly doing this step so didn't fail during 
nightly run

Note 2 : Issue is happening only when both Spark and Spark2 are installed. If 
cluster contains only Spark2, this feature works as expected.
Issue is coming if I add Spark(version 1) to it.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 efa3ffe3ba 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
f5027b2aee 


Diff: https://reviews.apache.org/r/64894/diff/2/

Changes: https://reviews.apache.org/r/64894/diff/1-2/


Testing
---

Manually tested on CentOS 6


File Attachments


0AMBARI-22716_branch-2.6_v1.patch
  
https://reviews.apache.org/media/uploaded/files/2018/01/02/2c206e6b-759d-4f94-899d-8d595e29832c__0AMBARI-22716_branch-2.6_v1.patch


Thanks,

Prabhjyot Singh

Re: Review Request 64894: zeppelin.livy.url is not getting updated after moving livy to a new host

2018-01-02 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64894/#review194645
---


Ship it!





ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
Lines 397 (patched)


Maybe just comment on why this is needed ...


- Jonathan Hurley


On Jan. 2, 2018, 2:18 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64894/
> ---
> 
> (Updated Jan. 2, 2018, 2:18 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22716
> https://issues.apache.org/jira/browse/AMBARI-22716
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> zeppelin.livy.url is not getting updated after moving livy to a new host
> 
> Steps to reproduce :
> 1) Create a cluster with both Spark and Spark2 component
> 2) Delete livy component from current host.
> 3) Add the livy component on a new host
> 4) Restart zeppelin server. 
> 5) Now check the zeppelin interpreter settings. zeppelin.livy.url is still 
> referring to older livy host. 
> Its not reflecting the new livy server address.
> 
> Note 1 : If I restart zeppelin server after step1 (ie after deleting the livy 
> host) before performing rest of the steps, then changes are getting reflected 
> properly. System test was mistakenly doing this step so didn't fail during 
> nightly run
> 
> Note 2 : Issue is happening only when both Spark and Spark2 are installed. If 
> cluster contains only Spark2, this feature works as expected.
> Issue is coming if I add Spark(version 1) to it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  efa3ffe3ba 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> f5027b2aee 
> 
> 
> Diff: https://reviews.apache.org/r/64894/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS 6
> 
> 
> File Attachments
> 
> 
> 0AMBARI-22716_branch-2.6_v1.patch
>   
> https://reviews.apache.org/media/uploaded/files/2018/01/02/2c206e6b-759d-4f94-899d-8d595e29832c__0AMBARI-22716_branch-2.6_v1.patch
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 64894: zeppelin.livy.url is not getting updated after moving livy to a new host

2018-01-02 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64894/
---

(Updated Jan. 3, 2018, 12:48 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22716
https://issues.apache.org/jira/browse/AMBARI-22716


Repository: ambari


Description
---

zeppelin.livy.url is not getting updated after moving livy to a new host

Steps to reproduce :
1) Create a cluster with both Spark and Spark2 component
2) Delete livy component from current host.
3) Add the livy component on a new host
4) Restart zeppelin server. 
5) Now check the zeppelin interpreter settings. zeppelin.livy.url is still 
referring to older livy host. 
Its not reflecting the new livy server address.

Note 1 : If I restart zeppelin server after step1 (ie after deleting the livy 
host) before performing rest of the steps, then changes are getting reflected 
properly. System test was mistakenly doing this step so didn't fail during 
nightly run

Note 2 : Issue is happening only when both Spark and Spark2 are installed. If 
cluster contains only Spark2, this feature works as expected.
Issue is coming if I add Spark(version 1) to it.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 efa3ffe3ba 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
f5027b2aee 


Diff: https://reviews.apache.org/r/64894/diff/1/


Testing
---

Manually tested on CentOS 6


File Attachments (updated)


0AMBARI-22716_branch-2.6_v1.patch
  
https://reviews.apache.org/media/uploaded/files/2018/01/02/2c206e6b-759d-4f94-899d-8d595e29832c__0AMBARI-22716_branch-2.6_v1.patch


Thanks,

Prabhjyot Singh

Review Request 64894: zeppelin.livy.url is not getting updated after moving livy to a new host

2018-01-02 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64894/
---

Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22716
https://issues.apache.org/jira/browse/AMBARI-22716


Repository: ambari


Description
---

zeppelin.livy.url is not getting updated after moving livy to a new host

Steps to reproduce :
1) Create a cluster with both Spark and Spark2 component
2) Delete livy component from current host.
3) Add the livy component on a new host
4) Restart zeppelin server. 
5) Now check the zeppelin interpreter settings. zeppelin.livy.url is still 
referring to older livy host. 
Its not reflecting the new livy server address.

Note 1 : If I restart zeppelin server after step1 (ie after deleting the livy 
host) before performing rest of the steps, then changes are getting reflected 
properly. System test was mistakenly doing this step so didn't fail during 
nightly run

Note 2 : Issue is happening only when both Spark and Spark2 are installed. If 
cluster contains only Spark2, this feature works as expected.
Issue is coming if I add Spark(version 1) to it.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 efa3ffe3ba 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
f5027b2aee 


Diff: https://reviews.apache.org/r/64894/diff/1/


Testing
---

Manually tested on CentOS 6


Thanks,

Prabhjyot Singh

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-02 Thread Yussuf Shaikh 


> On Jan. 2, 2018, 4:51 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 3058-3065 (original), 3057-3060 (patched)
> > 
> >
> > The old logic here is still sound, it would help for when people add 
> > properties without having to restart Ambari to get them (not changed 
> > properties, but new ones which is fine).

Agreed. I will keep both functions here.


> On Jan. 2, 2018, 4:51 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java
> > Line 633 (original)
> > 
> >
> > It's much more convenient to keep JAVA_HOME in one place.  We want to 
> > centralize (as much as we can) the places where we have to remember to set 
> > JAVA_HOME.  Can you pass in the os type or OS (the object0 here instead?

Here we do not know the os type of each host. This method is  called initially 
during stage creation. Hence had introduced a method in Configuration class 
which is called in hosts loop later for different flows.


- Yussuf


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64887/#review194635
---


On Jan. 2, 2018, 2:54 p.m., Yussuf Shaikh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64887/
> ---
> 
> (Updated Jan. 2, 2018, 2:54 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22403
> https://issues.apache.org/jira/browse/AMBARI-22403
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Java side changes required to read JAVA HOME value for each host depending on 
> the OS type eg: java.home.redhat7.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  182cd58 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  c0a7a7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  c4df0b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  198b617 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  dcafdea 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
> b6287e6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  e47fcd2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  6bece66 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  e795d28 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  a1f28f1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  c5994c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  51035ba 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java
>  670c187 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java
>  b90295d 
> 
> 
> Diff: https://reviews.apache.org/r/64887/diff/1/
> 
> 
> Testing
> ---
> 
> tests ran on ambari-server project.
> 
> 
> Thanks,
> 
> Yussuf Shaikh
> 
>

Re: Review Request 64775: AMBARI-22394: Store and retrieve the ambari repo urls for os family during bootstrap

2018-01-02 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64775/#review194638
---



This has been pushed.  Please close this review and associated JIRA.

- Nate Cole


On Dec. 23, 2017, 2:16 a.m., Sneha Kanekar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64775/
> ---
> 
> (Updated Dec. 23, 2017, 2:16 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22394
> https://issues.apache.org/jira/browse/AMBARI-22394
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari configuration will have list of repo urls for each os type. During 
> bootstrap, the stored repo url will be used to correct the base url from 
> ambari repo file on agent host.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/bootstrap.py f1c53ce 
>   ambari-server/src/main/python/os_check_type.py da37560 
>   ambari-server/src/main/python/setupAgent.py efc3d7c 
>   ambari-server/src/test/python/TestBootstrap.py bea47f4 
>   ambari-server/src/test/python/TestSetupAgent.py 0b33e9f 
> 
> 
> Diff: https://reviews.apache.org/r/64775/diff/2/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-server.
> 
> 
> Thanks,
> 
> Sneha Kanekar
> 
>

Re: Review Request 64775: AMBARI-22394: Store and retrieve the ambari repo urls for os family during bootstrap

2018-01-02 Thread Nate Cole 


> On Dec. 22, 2017, 10:12 a.m., Nate Cole wrote:
> > ambari-server/src/main/python/bootstrap.py
> > Lines 762-763 (patched)
> > 
> >
> > Use "".format() syntax here.
> > 
> > Should we give more information here?  How will we tell the user what 
> > to do?  How do they get the os_type into ambari.properties?

Please mark these as Fixed when they are updated in a diff.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64775/#review194436
---


On Dec. 23, 2017, 2:16 a.m., Sneha Kanekar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64775/
> ---
> 
> (Updated Dec. 23, 2017, 2:16 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22394
> https://issues.apache.org/jira/browse/AMBARI-22394
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari configuration will have list of repo urls for each os type. During 
> bootstrap, the stored repo url will be used to correct the base url from 
> ambari repo file on agent host.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/bootstrap.py f1c53ce 
>   ambari-server/src/main/python/os_check_type.py da37560 
>   ambari-server/src/main/python/setupAgent.py efc3d7c 
>   ambari-server/src/test/python/TestBootstrap.py bea47f4 
>   ambari-server/src/test/python/TestSetupAgent.py 0b33e9f 
> 
> 
> Diff: https://reviews.apache.org/r/64775/diff/2/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-server.
> 
> 
> Thanks,
> 
> Sneha Kanekar
> 
>

Re: Review Request 64775: AMBARI-22394: Store and retrieve the ambari repo urls for os family during bootstrap

2018-01-02 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64775/#review194636
---


Ship it!




Ship It!

- Nate Cole


On Dec. 23, 2017, 2:16 a.m., Sneha Kanekar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64775/
> ---
> 
> (Updated Dec. 23, 2017, 2:16 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22394
> https://issues.apache.org/jira/browse/AMBARI-22394
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari configuration will have list of repo urls for each os type. During 
> bootstrap, the stored repo url will be used to correct the base url from 
> ambari repo file on agent host.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/bootstrap.py f1c53ce 
>   ambari-server/src/main/python/os_check_type.py da37560 
>   ambari-server/src/main/python/setupAgent.py efc3d7c 
>   ambari-server/src/test/python/TestBootstrap.py bea47f4 
>   ambari-server/src/test/python/TestSetupAgent.py 0b33e9f 
> 
> 
> Diff: https://reviews.apache.org/r/64775/diff/2/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-server.
> 
> 
> Thanks,
> 
> Sneha Kanekar
> 
>

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-02 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64887/#review194635
---




ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 3058-3065 (original), 3057-3060 (patched)


The old logic here is still sound, it would help for when people add 
properties without having to restart Ambari to get them (not changed 
properties, but new ones which is fine).



ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java
Line 633 (original)


It's much more convenient to keep JAVA_HOME in one place.  We want to 
centralize (as much as we can) the places where we have to remember to set 
JAVA_HOME.  Can you pass in the os type or OS (the object0 here instead?


- Nate Cole


On Jan. 2, 2018, 9:54 a.m., Yussuf Shaikh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64887/
> ---
> 
> (Updated Jan. 2, 2018, 9:54 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22403
> https://issues.apache.org/jira/browse/AMBARI-22403
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Java side changes required to read JAVA HOME value for each host depending on 
> the OS type eg: java.home.redhat7.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  182cd58 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  c0a7a7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  c4df0b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  198b617 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  dcafdea 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
> b6287e6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  e47fcd2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  6bece66 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  e795d28 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  a1f28f1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  c5994c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  51035ba 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java
>  670c187 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java
>  b90295d 
> 
> 
> Diff: https://reviews.apache.org/r/64887/diff/1/
> 
> 
> Testing
> ---
> 
> tests ran on ambari-server project.
> 
> 
> Thanks,
> 
> Yussuf Shaikh
> 
>

Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

2018-01-02 Thread Nate Cole 


> On Dec. 22, 2017, 9:51 a.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 863-880 (patched)
> > 
> >
> > I'm no UI expert, but this entire new block seems to be doing repo 
> > stuff that already is on the UI.  Can you explain the gist here?
> 
> Sonia Garudi wrote:
> We need each host's os type which is not available on the UI. This 
> function makes an API call which gets information of all the bootstrapped 
> hosts .

I see.  We should probably have that returned as part of host registration and 
read it from there instead of making another call.  Is that possible in this 
patch?


> On Dec. 22, 2017, 9:51 a.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 968-972 (patched)
> > 
> >
> > Should not rely on the name for the id.  The API should be giving you 
> > the id.
> 
> Sonia Garudi wrote:
> Made the required change in next diff.

Ok, please resolve review issues as they are fixed in diffs with "Fixed"


> On Dec. 22, 2017, 9:51 a.m., Nate Cole wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js
> > Lines 1192 (patched)
> > 
> >
> > ftp?  I think it's fine to be only http or https.
> 
> Sonia Garudi wrote:
> Made the required change in next diff.

Ok, please resolve review issues as they are fixed in diffs with "Fixed"


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64769/#review194434
---


On Dec. 26, 2017, 7:05 a.m., Sonia Garudi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64769/
> ---
> 
> (Updated Dec. 26, 2017, 7:05 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22406
> https://issues.apache.org/jira/browse/AMBARI-22406
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Includes UI changes in ambari-web to check if the repo is selected or 
> provides prompt to the user to enter the HDP and HDP-utils repo URL's. 
> Includes necessary validation checks for the repo urls, allows user to select 
> the public and local repository and also provides functionality to skip 
> validation checks.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step3_controller.js 29393e3 
>   ambari-web/app/styles/wizard.less 7d425d9 
>   ambari-web/app/templates/wizard/step3.hbs e00012c 
>   ambari-web/app/utils/ajax/ajax.js 3f85dfdc 
>   ambari-web/app/views/wizard/step3_view.js 3249b24 
>   ambari-web/test/controllers/wizard/step3_test.js b8bc794 
> 
> 
> Diff: https://reviews.apache.org/r/64769/diff/3/
> 
> 
> Testing
> ---
> 
> Tests were successful in ambari-web
> 
> 
> Thanks,
> 
> Sonia Garudi
> 
>

Re: Review Request 64853: UpgradeUserKerberosDescriptor is not executed during stack upgrade due to missing target stack data

2018-01-02 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64853/#review194627
---


Ship it!




Ship It!

- Robert Nettleton


On Dec. 27, 2017, 3:58 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64853/
> ---
> 
> (Updated Dec. 27, 2017, 3:58 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sandor Molnar.
> 
> 
> Bugs: AMBARI-22693
> https://issues.apache.org/jira/browse/AMBARI-22693
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UpgradeUserKerberosDescriptor is not executed during stack upgrade due to 
> missing target stack data.
> 
> *Steps to reproduce*
> # Deploy cluster with Ambari version 2.6.0 and HDP version 2.4
> ** Storm should be installed to guarantee an error
> # Do Express upgrade to HDP version 2.6
> # Regenerate Keytabs.
> 
> Upon restarting Storm the following error is encountered
> ```
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at java.lang.Class.forName0(Native Method)
>   at java.lang.Class.forName(Class.java:348)
>   at clojure.lang.RT.classForName(RT.java:2154)
>   at clojure.lang.RT.classForName(RT.java:2163)
>   at clojure.lang.RT.loadClassForName(RT.java:2182)
>   at clojure.lang.RT.load(RT.java:436)
>   at clojure.lang.RT.load(RT.java:412)
>   at clojure.core$load$fn__5448.invoke(core.clj:5866)
>   at clojure.core$load.doInvoke(core.clj:5865)
>   at clojure.lang.RestFn.invoke(RestFn.java:408)
>   at clojure.core$load_one.invoke(core.clj:5671)
>   at clojure.core$load_lib$fn__5397.invoke(core.clj:5711)
>   at clojure.core$load_lib.doInvoke(core.clj:5710)
>   at clojure.lang.RestFn.applyTo(RestFn.java:142)
>   at clojure.core$apply.invoke(core.clj:632)
>   at clojure.core$load_libs.doInvoke(core.clj:5749)
>   at clojure.lang.RestFn.applyTo(RestFn.java:137)
>   at clojure.core$apply.invoke(core.clj:632)
>   at clojure.core$require.doInvoke(core.clj:5832)
>   at clojure.lang.RestFn.invoke(RestFn.java:408)
>   at 
> org.apache.storm.daemon.nimbus$loading__5340__auto982.invoke(nimbus.clj:16)
>   at org.apache.storm.daemon.nimbus__init.load(Unknown Source)
>   at org.apache.storm.daemon.nimbus__init.(Unknown Source)
>   at java.lang.Class.forName0(Native Method)
>   at java.lang.Class.forName(Class.java:348)
>   at clojure.lang.RT.classForName(RT.java:2154)
>   at clojure.lang.RT.classForName(RT.java:2163)
>   at clojure.lang.RT.loadClassForName(RT.java:2182)
>   at clojure.lang.RT.load(RT.java:436)
>   at clojure.lang.RT.load(RT.java:412)
>   at clojure.core$load$fn__5448.invoke(core.clj:5866)
>   at clojure.core$load.doInvoke(core.clj:5865)
>   at clojure.lang.RestFn.invoke(RestFn.java:408)
>   at clojure.lang.Var.invoke(Var.java:379)
>   at org.apache.storm.daemon.nimbus.(Unknown Source)
> Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException: 
> backtype.storm.security.auth.KerberosPrincipalToLocal
>   at 
> org.apache.storm.security.auth.AuthUtils.GetPrincipalToLocalPlugin(AuthUtils.java:125)
>   at 
> org.apache.storm.security.auth.authorizer.ImpersonationAuthorizer.prepare(ImpersonationAuthorizer.java:54)
>   at 
> org.apache.storm.daemon.common$mk_authorization_handler.invoke(common.clj:417)
>   at org.apache.storm.ui.core__init.load(Unknown Source)
>   at org.apache.storm.ui.core__init.(Unknown Source)
>   ... 35 more
> Caused by: java.lang.ClassNotFoundException: 
> backtype.storm.security.auth.KerberosPrincipalToLocal
>   at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>   at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>   at java.lang.Class.forName0(Native Method)
>   at java.lang.Class.forName(Class.java:264)
>   at 
> org.apache.storm.security.auth.AuthUtils.GetPrincipalToLocalPlugin(AuthUtils.java:121)
>   ... 39 more
> ```
> 
> #Cause
> In the following code snip, {{targetStackID}} is {null}}:
> *`org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java:103`*:
> ```
> StackId targetStackId = 
> getStackIdFromCommandParams(KeyNames.TARGET_STACK);
> ```
> This causes the logic in `UpgradeUserKerberosDescriptor` to be skipped.  
> 
> #Solution
> Change the code snip from above to 
> *`org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java:103`*
> ```
> StackId

Re: Review Request 64863: Implement resolving dependencies for each service

2018-01-02 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64863/
---

(Updated Січ. 2, 2018, 2:57 після полудня)


Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.


Bugs: AMBARI-22707
https://issues.apache.org/jira/browse/AMBARI-22707


Repository: ambari


Description
---

Resolve dependencies for services.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java
 73a2c93 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java
 e19e6e3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
 38e1233 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
d12e8cd 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
 dcc8433 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
7f1daa7 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 a811c5e 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProviderTest.java
 bed3689 


Diff: https://reviews.apache.org/r/64863/diff/2/

Changes: https://reviews.apache.org/r/64863/diff/1-2/


Testing
---

UT will be added soon


Thanks,

Vitalyi Brodetskyi

Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-02 Thread Yussuf Shaikh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64887/
---

Review request for Ambari and Nate Cole.


Bugs: AMBARI-22403
https://issues.apache.org/jira/browse/AMBARI-22403


Repository: ambari


Description
---

Java side changes required to read JAVA HOME value for each host depending on 
the OS type eg: java.home.redhat7.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 182cd58 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 c0a7a7b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 c4df0b1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 198b617 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 dcafdea 
  ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 
b6287e6 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 e47fcd2 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 6bece66 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 e795d28 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 a1f28f1 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
 c5994c5 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
 51035ba 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java
 670c187 
  
ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java 
b90295d 


Diff: https://reviews.apache.org/r/64887/diff/1/


Testing
---

tests ran on ambari-server project.


Thanks,

Yussuf Shaikh

Re: Review Request 64886: Log Search UI: implement Summary tab for Access Logs page

2018-01-02 Thread Aleksandr Kovalenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64886/#review194626
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Янв. 2, 2018, 1:08 п.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64886/
> ---
> 
> (Updated Янв. 2, 2018, 1:08 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-22714
> https://issues.apache.org/jira/browse/AMBARI-22714
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Implement Summary tab with two diagrams: Top 6 users and Top 10 resources.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/package.json b9ee179 
>   ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts b76de20 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/graph.component.less
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/graph.component.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table-component.spec.ts
>  05f80a7 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table-component.ts
>  0b8866a 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table/logs-table-component.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table/logs-table-component.ts
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/graph.ts PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.ts 
> 15fefde 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/tab.ts 05ea59d 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/object.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.ts
>  3b38a03 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-top-resources-query-params.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.ts
>  0700a98 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/service-injector.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.html
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.ts
>  0e578ab 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.html
>  b73fa45 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.ts
>  cbc0dd7 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts
>  fc42e3c 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts
>  a8037d0 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts
>  6a9aca5 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.ts
>  2dcecd1 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts
>  8293ba0 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.ts
>  d677d81 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts
>  480706a 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend-item/graph-legend-item.component.html
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend-item/graph-legend-item.component.less
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend-item/graph-legend-item.component.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend-item/graph-legend-item.component.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend/graph-legend.component.html
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend/graph-legend.component.spec.ts
>  PRE-CREATION 
>   
>

Review Request 64886: Log Search UI: implement Summary tab for Access Logs page

2018-01-02 Thread Andrii Babiichuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64886/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-22714
https://issues.apache.org/jira/browse/AMBARI-22714


Repository: ambari


Description
---

Implement Summary tab with two diagrams: Top 6 users and Top 10 resources.


Diffs
-

  ambari-logsearch/ambari-logsearch-web/package.json b9ee179 
  ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts b76de20 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/graph.component.less
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/components/graph/graph.component.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table-component.spec.ts
 05f80a7 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table-component.ts
 0b8866a 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table/logs-table-component.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/components/logs-table/logs-table-component.ts
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/graph.ts PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.ts 
15fefde 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/models/tab.ts 05ea59d 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/object.ts PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.ts
 3b38a03 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-top-resources-query-params.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.ts
 0700a98 
  ambari-logsearch/ambari-logsearch-web/src/app/classes/service-injector.ts 
PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.html
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-entries/audit-logs-entries.component.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.ts
 0e578ab 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.html
 b73fa45 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.ts
 cbc0dd7 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts
 fc42e3c 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts
 a8037d0 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts
 6a9aca5 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.ts
 2dcecd1 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts
 8293ba0 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.ts
 d677d81 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts
 480706a 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend-item/graph-legend-item.component.html
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend-item/graph-legend-item.component.less
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend-item/graph-legend-item.component.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend-item/graph-legend-item.component.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend/graph-legend.component.html
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend/graph-legend.component.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/graph-legend/graph-legend.component.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/graph-tooltip/graph-tooltip.component.html
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/graph-tooltip/graph-tooltip.component.less
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/graph-tooltip/graph-tooltip.component.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/graph-tooltip/graph-tooltip.component.ts
 PRE-CREATION

Re: Review Request 64852: Ambari Infra Manager: deleting documents

2018-01-02 Thread Attila Magyar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64852/#review194624
---


Ship it!




Ship It!

- Attila Magyar


On Dec. 28, 2017, 2:09 p.m., Krisztian Kasa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64852/
> ---
> 
> (Updated Dec. 28, 2017, 2:09 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Oliver Szabo, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22653 and AMBARI-22702
> https://issues.apache.org/jira/browse/AMBARI-22653
> https://issues.apache.org/jira/browse/AMBARI-22702
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * defining new job for deleting documents from solr: collection and filter 
> field can be defined in properties
> * archiving job supports deleting the succesfully uploaded documents
> * date time format in output filename can be defined in property file
> * s3 secret and access keys can be defined in a csv file and this file can be 
> referenced from infra-manager.properties or in environmental variables
> * generic property processing for jobs
> * Helper class for processing parametrized solr query text
> * new IT case: Running archiving job with a bigger start value than end value 
> exports and deletes 0 documents
> * new IT case: After Deleting job deletes documents from solr no document 
> found in the specified interval
> * existing IT cases for archiving also check that solr has no more documents 
> left in the specified interval after archiving job finished
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/OffsetDateTimeConverter.java
>  9db562cec3 
>   
> ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/steps/AbstractInfraSteps.java
>  703e1cfa67 
>   
> ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/steps/ExportJobsSteps.java
>  4a09d7d7ee 
>   
> ambari-infra/ambari-infra-manager-it/src/test/resources/stories/infra_api_tests.story
>  cd1f49d052 
>   ambari-infra/ambari-infra-manager/docker/infra-manager-docker-compose.sh 
> ab026598b1 
>   ambari-infra/ambari-infra-manager/pom.xml 67bf7d133b 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/JobProperties.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/PropertyMap.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/SolrDAOBase.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/AbstractFileAction.java
>  7a30393224 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/CompositeFileAction.java
>  8421802cd7 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/Document.java
>  1f3957a034 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportConfiguration.java
>  189591102b 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportJobListener.java
>  3b6c402458 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportProperties.java
>  37f6d1b669 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportPropertyMap.java
>  9af4afc630 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentWiper.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/FileAction.java
>  d3f2a65e07 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/FileNameSuffixFormatter.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/ItemWriterListener.java
>  742777109e 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriter.java
>  baad61bdcb 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/LocalItemWriterListener.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Properties.java
>  0979f10bfc 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Uploader.java
>  deeb9c7ea0 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDAO.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDocumentIterator.java
>  2e7341d365

Re: Review Request 64884: AMBARI-22711 -- Ambari Versions Page is having JS error When using redhat satellite server for repos

2018-01-02 Thread Aleksandr Kovalenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64884/#review194622
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Янв. 2, 2018, 10:26 д.п., Akhil S Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64884/
> ---
> 
> (Updated Янв. 2, 2018, 10:26 д.п.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Alexandr Antonenko.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/AMBARI-22711
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-22711
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari Versions page not updating when using Redhat satellite server for repos
> Due to exception in JS Code
> 
> as a Fix : 
> in stack_mapper.js code
> for the line : stack.use_redhat_satellite = 
> Em.get(item,'operating_systems.0.OperatingSystems.ambari_managed_repositories')
>  === false;
> 
> we need to remove the direct check of property and use the Em.get Instead 
> (Ember-metal 
> APIhttps://github.com/emberjs/ember.js/blob/0d68d0a3b3072995e3db603a24fe5ac56cf26d6d/packages/ember-metal/lib/property_get.js)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/mappers/stack_mapper.js 323a033 
> 
> 
> Diff: https://reviews.apache.org/r/64884/diff/1/
> 
> 
> Testing
> ---
> 
> * unit tests runs fine
> * fix works fine
> *
> 
> 
> Thanks,
> 
> Akhil S Naik
> 
>

Review Request 64884: AMBARI-22711 -- Ambari Versions Page is having JS error When using redhat satellite server for repos

2018-01-02 Thread Akhil S Naik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64884/
---

Review request for Ambari, Aleksandr Kovalenko and Alexandr Antonenko.


Bugs: https://issues.apache.org/jira/browse/AMBARI-22711

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-22711


Repository: ambari


Description
---

Ambari Versions page not updating when using Redhat satellite server for repos
Due to exception in JS Code

as a Fix : 
in stack_mapper.js code
for the line : stack.use_redhat_satellite = 
Em.get(item,'operating_systems.0.OperatingSystems.ambari_managed_repositories') 
=== false;

we need to remove the direct check of property and use the Em.get Instead 
(Ember-metal 
APIhttps://github.com/emberjs/ember.js/blob/0d68d0a3b3072995e3db603a24fe5ac56cf26d6d/packages/ember-metal/lib/property_get.js)


Diffs
-

  ambari-web/app/mappers/stack_mapper.js 323a033 


Diff: https://reviews.apache.org/r/64884/diff/1/


Testing
---

* unit tests runs fine
* fix works fine
*


Thanks,

Akhil S Naik