Re: Review Request 57248: Visual explain is not routing to visual explain tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57248/#review167699 --- Ship it! Ship It! - Abhishek Kumar On March 2, 2017, 6:08 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57248/ > --- > > (Updated March 2, 2017, 6:08 p.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20274 > https://issues.apache.org/jira/browse/AMBARI-20274 > > > Repository: ambari > > > Description > --- > > changed the logic to re-direct to visual explain route if 'visual explain' > button is clicked. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > cf51ff7 > > > Diff: https://reviews.apache.org/r/57248/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 57100: Select operators should not appear before fetch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57100/#review167658 --- Ship it! Ship It! - Abhishek Kumar On Feb. 27, 2017, 7:29 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57100/ > --- > > (Updated Feb. 27, 2017, 7:29 p.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20215 > https://issues.apache.org/jira/browse/AMBARI-20215 > > > Repository: ambari > > > Description > --- > > modified logic to show select node. > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js > a252498 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > 196a514 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js > 01d6000 > > > Diff: https://reviews.apache.org/r/57100/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 57100: Select operators should not appear before fetch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57100/#review167032 --- Ship it! Ship It! - Abhishek Kumar On Feb. 27, 2017, 7:29 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57100/ > --- > > (Updated Feb. 27, 2017, 7:29 p.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20215 > https://issues.apache.org/jira/browse/AMBARI-20215 > > > Repository: ambari > > > Description > --- > > modified logic to show select node. > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js > a252498 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > 196a514 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js > 01d6000 > > Diff: https://reviews.apache.org/r/57100/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56965: Hive 2: "insert udf" opens empty drop down
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56965/#review166472 --- Ship it! Ship It! - Abhishek Kumar On Feb. 23, 2017, 3:40 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56965/ > --- > > (Updated Feb. 23, 2017, 3:40 a.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20127 > https://issues.apache.org/jira/browse/AMBARI-20127 > > > Repository: ambari > > > Description > --- > > - Added condition of disabling the "Insert UDF" button when there is no UDF. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 64f38ab > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 4fd3ce201 > > Diff: https://reviews.apache.org/r/56965/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56925: Hive2: Visual Explain - Eliminate "limit -1"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56925/#review166364 --- Ship it! Ship It! - Abhishek Kumar On Feb. 22, 2017, 2:12 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56925/ > --- > > (Updated Feb. 22, 2017, 2:12 p.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20114 > https://issues.apache.org/jira/browse/AMBARI-20114 > > > Repository: ambari > > > Description > --- > > Modifies the condition. > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer-force.js > 2dfdc86 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > a332802 > > Diff: https://reviews.apache.org/r/56925/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56922: Hive2: Query in query editor is getting modified while navigating across different tabs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56922/#review166331 --- Ship it! Ship It! - Abhishek Kumar On Feb. 22, 2017, 7:24 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56922/ > --- > > (Updated Feb. 22, 2017, 7:24 a.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20111 > https://issues.apache.org/jira/browse/AMBARI-20111 > > > Repository: ambari > > > Description > --- > > Saving the right value in the model. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/configs/result-tabs.js > f48dcd8 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 9196d8b > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > c2a0c8c > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > c3d907d > > Diff: https://reviews.apache.org/r/56922/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56884: Hive 2: Visual Explain - Remove children in the JSON dump
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56884/#review166171 --- Ship it! Ship It! - Abhishek Kumar On Feb. 21, 2017, 1:09 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56884/ > --- > > (Updated Feb. 21, 2017, 1:09 p.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20097 > https://issues.apache.org/jira/browse/AMBARI-20097 > > > Repository: ambari > > > Description > --- > > - Fix layout glitches > - remove uuid > - positioning fix > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js > 2800c09 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > d3768c1 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss fd1f0eb > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs > 905e73c > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > d62c781 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > 3dedd8f > > Diff: https://reviews.apache.org/r/56884/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56884: Hive2: Visual Explain -Layout glitches of overlapping edges
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56884/#review166160 --- Ship it! Ship It! - Abhishek Kumar On Feb. 21, 2017, 1:05 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56884/ > --- > > (Updated Feb. 21, 2017, 1:05 p.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20097 > https://issues.apache.org/jira/browse/AMBARI-20097 > > > Repository: ambari > > > Description > --- > > - Fix layout glitches > - remove uuid > - positioning fix > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js > 2800c09 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > d3768c1 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss fd1f0eb > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs > 905e73c > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > d62c781 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > 3dedd8f > > Diff: https://reviews.apache.org/r/56884/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56756: Hive View 2.0: Visual Explain-The operators are being shown out of order
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56756/ --- (Updated Feb. 20, 2017, 10:04 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. Changes --- fixed overlaps and merge Bugs: AMBARI-20048 https://issues.apache.org/jira/browse/AMBARI-20048 Repository: ambari Description --- The operators are being shown out of order. It’s hard to think about what to do with the plan output when the operators are out of order, so this needs to be fixed first. Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 6805bb8 contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer.js 2b59340 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/enhancer.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/fallback.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/index.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer-force.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/bower.json 9fa7076 contrib/views/hive20/src/main/resources/ui/ember-cli-build.js d53cdac Diff: https://reviews.apache.org/r/56756/diff/ Testing --- Manually Tested Thanks, Abhishek Kumar
Re: Review Request 56756: Hive View 2.0: Visual Explain-The operators are being shown out of order
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56756/ --- (Updated Feb. 17, 2017, 7:37 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. Changes --- fixed issue Bugs: AMBARI-20048 https://issues.apache.org/jira/browse/AMBARI-20048 Repository: ambari Description --- The operators are being shown out of order. It’s hard to think about what to do with the plan output when the operators are out of order, so this needs to be fixed first. Diffs (updated) - .gitignore a40e61a contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 6805bb8 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5b2b5c2 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer.js 2b59340 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/enhancer.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/fallback.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/index.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer-force.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/bower.json 9fa7076 contrib/views/hive20/src/main/resources/ui/ember-cli-build.js d53cdac Diff: https://reviews.apache.org/r/56756/diff/ Testing --- Manually Tested Thanks, Abhishek Kumar
Review Request 56756: Hive View 2.0: Visual Explain-The operators are being shown out of order
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56756/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-20048 https://issues.apache.org/jira/browse/AMBARI-20048 Repository: ambari Description --- The operators are being shown out of order. It’s hard to think about what to do with the plan output when the operators are out of order, so this needs to be fixed first. Diffs - .gitignore a40e61a contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js 6805bb8 contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer.js 2b59340 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/enhancer.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/fallback.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/index.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js PRE-CREATION Diff: https://reviews.apache.org/r/56756/diff/ Testing --- Manually Tested Thanks, Abhishek Kumar
Re: Review Request 56572: Hive2. Visual Explain -Show additional info when you click on a box, i.e. can drill down to get more info on operators.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56572/#review165242 --- Ship it! - Abhishek Kumar On Feb. 11, 2017, 10:26 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56572/ > --- > > (Updated Feb. 11, 2017, 10:26 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19975 > https://issues.apache.org/jira/browse/AMBARI-19975 > > > Repository: ambari > > > Description > --- > > created visual explain detail component > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain-detail.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js > 6551974 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > dcf27b4 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1dc86d7 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain-detail.hbs > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs > 4238d43 > > Diff: https://reviews.apache.org/r/56572/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56483: HiveView2.0: DB panel shows up on Query result full screen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56483/#review165241 --- Ship it! - Abhishek Kumar On Feb. 11, 2017, 10:43 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56483/ > --- > > (Updated Feb. 11, 2017, 10:43 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19931 > https://issues.apache.org/jira/browse/AMBARI-19931 > > > Repository: ambari > > > Description > --- > > Minor JS issue > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > dcf27b4 > contrib/views/hive20/src/main/resources/ui/app/services/query.js b484c74 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1dc86d7 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 2d6c5aa > > Diff: https://reviews.apache.org/r/56483/diff/ > > > Testing > --- > > manuualy tested > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56542: Hive View 2.0 - deleting a saved query is buggy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56542/#review165240 --- Ship it! - Abhishek Kumar On Feb. 10, 2017, 12:27 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56542/ > --- > > (Updated Feb. 10, 2017, 12:27 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19958 > https://issues.apache.org/jira/browse/AMBARI-19958 > > > Repository: ambari > > > Description > --- > > Setting the controller value to reflect the changes. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js > 5ee757b > contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js > 27d43d5 > contrib/views/hive20/src/main/resources/ui/app/controllers/saved-query.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > dcf27b4 > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > 7b9cb09 > contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js > 29ef4b5 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 2d6c5aa > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > 36dc982 > > Diff: https://reviews.apache.org/r/56542/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 55836: Hive View 2.0: Editor should be stretchable by dragging
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55836/ --- (Updated Feb. 10, 2017, 6:27 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-19667 https://issues.apache.org/jira/browse/AMBARI-19667 Repository: ambari Description --- Added jQuery-ui to add "draggable" functionality Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 27d43d5 contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 0dae396 contrib/views/hive20/src/main/resources/ui/bower.json f4d9aa0 contrib/views/hive20/src/main/resources/ui/ember-cli-build.js 10e0402 Diff: https://reviews.apache.org/r/55836/diff/ Testing --- manually tested. Thanks, Abhishek Kumar
Review Request 55839: Hive View 2.0: Code hints for query editor are not working
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55839/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-19673 https://issues.apache.org/jira/browse/AMBARI-19673 Repository: ambari Description --- User should be able to see code hints and syntax colorization while typing hive queries. Diffs - contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 27d43d5 contrib/views/hive20/src/main/resources/ui/ember-cli-build.js e41c8e8 Diff: https://reviews.apache.org/r/55839/diff/ Testing --- Manually tested Thanks, Abhishek Kumar
Re: Review Request 55837: Hive View 2.0: Incorrect behaviour on select of database
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55837/ --- (Updated Jan. 23, 2017, 11:37 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-19671 https://issues.apache.org/jira/browse/AMBARI-19671 Repository: ambari Description --- On selecting a database from right panel, display does not change. Ideally followings should happen: 1. Move "checked" icon to selected database 2. Hide tables related to unselected database and show tables for the selected one. Diffs - contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 950e4f3 Diff: https://reviews.apache.org/r/55837/diff/ Testing (updated) --- Manually tested Thanks, Abhishek Kumar
Review Request 55837: Hive View 2.0: Incorrect behaviour on select of database
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55837/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-19671 https://issues.apache.org/jira/browse/AMBARI-19671 Repository: ambari Description --- On selecting a database from right panel, display does not change. Ideally followings should happen: 1. Move "checked" icon to selected database 2. Hide tables related to unselected database and show tables for the selected one. Diffs - contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 950e4f3 Diff: https://reviews.apache.org/r/55837/diff/ Testing --- Thanks, Abhishek Kumar
Review Request 55836: Hive View 2.0: Editor should be stretchable by dragging
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55836/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-19667 https://issues.apache.org/jira/browse/AMBARI-19667 Repository: ambari Description --- Added jQuery-ui to add "draggable" functionality Diffs - contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 27d43d5 contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 5ae65d1 contrib/views/hive20/src/main/resources/ui/bower.json 4eadee7 contrib/views/hive20/src/main/resources/ui/package.json ed7a299 Diff: https://reviews.apache.org/r/55836/diff/ Testing --- manually tested. Thanks, Abhishek Kumar
