Review Request 49539: AMBARI-17541: LogSearch should also show audit logs from Apache Ranger Solr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49539/ --- Review request for Ambari, Dharmesh Makwana, Miklos Gergely, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. Bugs: AMBARI-17541 https://issues.apache.org/jira/browse/AMBARI-17541 Repository: ambari Description --- Creating solr colection alias with audit_logs and ranger_audits Diffs - ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java f1789c1 ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java 3a1a1ca Diff: https://reviews.apache.org/r/49539/diff/ Testing --- Tested in 3 node ambari cluster Thanks, Don Bosco Durai
Review Request 49505: AMBARI-17521: If Solr is configured to use implicit routing, then replicationFactor is ignored
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49505/ --- Review request for Ambari, Dharmesh Makwana, Miklos Gergely, Oliver Szabo, and Sumit Mohanty. Bugs: AMBARI-17521 https://issues.apache.org/jira/browse/AMBARI-17521 Repository: ambari Description --- Now passing replicationFactor to create method for implicit routing use case also Diffs - ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties 982a72d ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh b84bfc2 ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java c13105a Diff: https://reviews.apache.org/r/49505/diff/ Testing --- Tested with 6 nodes SolrCloud cluster Thanks, Don Bosco Durai
Re: Review Request 49233: Remove superfluous Logfeeder codes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49233/#review139504 --- Ship it! Ship It! - Don Bosco Durai On June 25, 2016, 11:49 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49233/ > --- > > (Updated June 25, 2016, 11:49 p.m.) > > > Review request for Ambari, Don Bosco Durai, Hayat Behlim, Dharmesh Makwana, > Oliver Szabo, Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-17347 > https://issues.apache.org/jira/browse/AMBARI-17347 > > > Repository: ambari > > > Description > --- > > Remove > - unnecessary imports > - unused functions > - unused variables > - empty comments > - meaningless comments > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/AliasUtil.java > 3836c76 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/ConfigBlock.java > 521319e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/InputMgr.java > 4359c78 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java > d00ed67 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java > 6f29fde > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java > 7a68b4d > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricCount.java > c715881 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricsMgr.java > be7594a > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/OutputMgr.java > f84457e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java > aa1edea > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java > 9b2a717 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java > c4da3cb > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/JSONFilterCode.java > 5c4d30e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java > 18e2184 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java > 7107a69 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java > 6196068 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java > d68ab96 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java > 9c46c4e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/LogsearchReaderFactory.java > a231807 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java > 5b9fe8f > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederConstants.java > f177e49 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/ApplyLogFilter.java > f223207 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/DefaultDataFilter.java > a064663 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/Mapper.java > 5b89d4b > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java > 107e7e4 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldName.java > 99c33ed > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldValue.java > 9810ceb > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/Output.java > 99a2909 >
Review Request 49235: AMBARI-17390: Need to create field "text" in history collection
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49235/ --- Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Miklos Gergely, Oliver Szabo, and Sumit Mohanty. Bugs: AMBARI-17390 https://issues.apache.org/jira/browse/AMBARI-17390 Repository: ambari Description --- Added additional field called "text. Diffs - ambari-logsearch/ambari-logsearch-portal/src/main/configsets/history/conf/managed-schema fed5cd9 Diff: https://reviews.apache.org/r/49235/diff/ Testing --- Tested creating 3 node hadoop cluster Thanks, Don Bosco Durai
Re: Review Request 48793: Log Level filter not applied before Log Search Starts at first
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48793/#review138515 --- Ship it! Ship It! - Don Bosco Durai On June 19, 2016, 10:39 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48793/ > --- > > (Updated June 19, 2016, 10:39 p.m.) > > > Review request for Ambari, Don Bosco Durai, Dharmesh Makwana, Oliver Szabo, > Robert Nettleton, and Sumit Mohanty. > > > Bugs: Ambari-17277 > https://issues.apache.org/jira/browse/Ambari-17277 > > > Repository: ambari > > > Description > --- > > After Log Search is started it sends the filters to the Solr which describes > what log levels should be persisted. In the meantime Logfeeders start to push > their data, which is not filtered. The result is misleading, the user may > find it add that some specific level logs are loaded, others are not. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > b14c273 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java > 29feef7 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties > 076c09c > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java > afbccca > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 > 6a52708 > > Diff: https://reviews.apache.org/r/48793/diff/ > > > Testing > --- > > logfeeder: > Tests run: 35, Failures: 0, Errors: 0, Skipped: 0 > > ambari-server > Total run:1062 > Total errors:0 > Total failures:0 > > > Thanks, > > Miklos Gergely > >
Re: Review Request 48793: Log Level filter not applied before Log Search Starts at first
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48793/#review138424 --- ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java (line 146) <https://reviews.apache.org/r/48793/#comment203599> I don't not sure whether this is the right place to put this check? Output is generally only for writing. We should probably move the code to FetchConfigFromSolr and call it from InputMgr.init(). And also, move LogfeederScheduler.INSTANCE.start(); from LogFeeder.java before inputMgr.init() is called. More important, it should be only called if Solr Zookeeper/URL and config collection is provided. In offline, mode, these might not be set. ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java (line 149) <https://reviews.apache.org/r/48793/#comment203593> Should we wait for config? Config is optional. And in some case, configs might not be used at all ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java (line 227) <https://reviews.apache.org/r/48793/#comment203589> Should this be WARN? And we have been using LogFeederUtil.logErrorMessageByInterval to control the number of log messages ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java (line 240) <https://reviews.apache.org/r/48793/#comment203588> We should use a constant value (or configurable), so it can be used other places also. We could use RETRY_INTERVAL which is in the Worker thread by moving to the class level ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java (line 254) <https://reviews.apache.org/r/48793/#comment203592> Good to print the name of the field also. ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java (line 267) <https://reviews.apache.org/r/48793/#comment203598> Should we print using LogFeederUtil.logErrorMessageByInterval and also remove hard coded 10 seconds? ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java (line 271) <https://reviews.apache.org/r/48793/#comment203596> Can we put more context here? Example the query we are running and collection name? ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java (line 273) <https://reviews.apache.org/r/48793/#comment203597> Should we put more info? And also print error using LogFeederUtil.logErrorMessageByInterval ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java (line 276) <https://reviews.apache.org/r/48793/#comment203591> Should use LogFeederUtil.logErrorMessageByInterval if possible ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java (line 280) <https://reviews.apache.org/r/48793/#comment203590> Same here, we could use a constant value ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 (line 21) <https://reviews.apache.org/r/48793/#comment203595> Should we take this out? - Don Bosco Durai On June 18, 2016, 9:10 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48793/ > ------- > > (Updated June 18, 2016, 9:10 a.m.) > > > Review request for Ambari, Don Bosco Durai, Dharmesh Makwana, Oliver Szabo, > Robert Nettleton, and Sumit Mohanty. > > > Bugs: Ambari-17277 > https://issues.apache.org/jira/browse/Ambari-17277 > > > Repository: ambari > > > Description > --- > > After Log Search is started it sends the filters to the Solr which describes > what log levels should be persisted. In the meantime Logfeeders start to push > their data, which is not filtered. The result is misleading, the user may > find it add that some specific level logs are loaded, others are not. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > b14c273 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties > 076c09c > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSol
Review Request 48903: AMBARI-17307: LogFeeder output to Solr doesn't handle empty buffer queue properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48903/ --- Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Miklos Gergely, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. Bugs: AMBARI-17307 https://issues.apache.org/jira/browse/AMBARI-17307 Repository: ambari Description --- Reseting the retry timer if the buffer is empty. Diffs - ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java b14c273 Diff: https://reviews.apache.org/r/48903/diff/ Testing --- Thanks, Don Bosco Durai
Re: Review Request 48866: Service check for logsearch server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48866/#review138344 --- Ship it! Ship It! - Don Bosco Durai On June 17, 2016, 6:50 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48866/ > --- > > (Updated June 17, 2016, 6:50 p.m.) > > > Review request for Ambari, Don Bosco Durai, Robert Nettleton, Sumit Mohanty, > and Sebastian Toader. > > > Bugs: branch-2.4 and trunk > https://issues.apache.org/jira/browse/branch-2.4 > https://issues.apache.org/jira/browse/trunk > > > Repository: ambari > > > Description > --- > > Adding simple service check for logsearch server. > Solr service check wont be needed, because later we can add a helth_check > endpoint to logsearch server, there the portal can communicate with the solr > instances. > Also unti kerberization of the logsearch-portal is not supported, we do not > need to do any kinit before the status check (solr kerberos support will be > added in 2.4.0, but if logsearch portal is configured well, then it can > communicate with kerberized solr instances anyway) > > > Diffs > - > > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml > 48451a0 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > 8a1449d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/48866/diff/ > > > Testing > --- > > testing done. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 48741: LogSearch Solr kerberos support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48741/#review138077 --- Ship it! Ship It! - Don Bosco Durai On June 16, 2016, 5:53 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48741/ > --- > > (Updated June 16, 2016, 5:53 p.m.) > > > Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Levas, > Robert Nettleton, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-16736 > https://issues.apache.org/jira/browse/AMBARI-16736 > > > Repository: ambari > > > Description > --- > > Basuc logsearch solr kerberos support. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py > e0a30ed > ambari-logsearch/ambari-logsearch-logfeeder/pom.xml bbe0bc9 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > b14c273 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties > 076c09c > ambari-logsearch/ambari-logsearch-portal/pom.xml e83c75b > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java > cd4ef93 > > ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties > 37c8317 > ambari-logsearch/ambari-logsearch-solr-client/pom.xml b634928 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java > a2da737 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java > 2805b0b > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java > 0813221 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json > 85762e0 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml > d27067c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > 3682e5d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml > 2420be0 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json > 6dd4aa7 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py > ce7f71c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py > 2b5fdf7 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py > d0ac389 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py > b55f3d6 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > 8a1449d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py > 5d1ca85 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > 368db03 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py > eac60db > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/status_params.py > 1efe605 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 > 6a52708 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 > 9ada5bf > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch_solr_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/zoo.cfg.j2 > 1f3808b > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-log4j.xml.j2 > 15345cf > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-solr-env.sh.j2 > 9f76d18 > ambari-web/app/data/HDP2/site_properties.js 09b2572 > > Diff: https://reviews.apache.org/r/48741/diff/ > > > Testing > --- > > ambari server python unit test output: > > Total run:1061 > Total errors:0 > Total failures:0 > > > Thanks, > > Oliver Szabo > >
Re: Review Request 48727: Log Search default log levels can not be altered
> On June 15, 2016, 7:38 p.m., Don Bosco Durai wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java, > > line 133 > > <https://reviews.apache.org/r/48727/diff/1/?file=1419712#file1419712line133> > > > > Not sure I understood this use case. The defaults from the properties > > is only used for bootstraping values in the Solr. Once it is in the Solr, > > users might change the default values via LogSearch UI. If we overwrite the > > values in Solr on each startup, then any user changes will be lost. > > > > I assume, this requirement is coming due to support for new services > > that could be added later. If so, we might have to change the logic for > > bootstraping the initial values. > > > > If this is the case, we might have to discuss more. > > Miklos Gergely wrote: > logsearch.logfeeder.include.default.level can be modified on ambari after > Log Search was installed. In this case the user would expect to see the > effect of this modification. As I see there are 3 ways to solve this: > > 1. Allow the users to modify the config only by altering > logsearch.logfeeder.include.default.level > 2. Allow the users to modify the config only on the LogSearch UI, and > remove logsearch.logfeeder.include.default.level from the property list, and > the bootstrap should be done with some constant > 3. If there is a way to make logsearch.logfeeder.include.default.level > unmodifiable after the installation is done, then this would fix the issue too I would prefer option #3, because I feel in some environment they want all logs. Is it possible to do it? - Don Bosco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48727/#review137811 --- On June 15, 2016, 12:46 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48727/ > --- > > (Updated June 15, 2016, 12:46 p.m.) > > > Review request for Ambari, Don Bosco Durai, Dharmesh Makwana, Oliver Szabo, > Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-17254 > https://issues.apache.org/jira/browse/AMBARI-17254 > > > Repository: ambari > > > Description > --- > > The default log levels (log levels to include) can not be altered, forever > the ones set during the installation (more precisely: the one which is the > value of the property during the first run of the portal) would be in effect. > > Currently the portal checks if there is a configuration, and does nothing if > there is. After this change it will remove any existing configuration upon > starting, and replace it with a newly generated configuration. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java > 147e148 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java > edf1dcc > > Diff: https://reviews.apache.org/r/48727/diff/ > > > Testing > --- > > Tested on local cluster. > > > Thanks, > > Miklos Gergely > >
Re: Review Request 48741: LogSearch Solr kerberos support
> On June 15, 2016, 7:11 p.m., Don Bosco Durai wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py, > > line 82 > > <https://reviews.apache.org/r/48741/diff/1/?file=1420250#file1420250line82> > > > > We should set explicit permission to this path. Only > > logsearch-solr-user, logsearch-user, ranger-user and atlas-user should have > > write permission. Essentially, in addition to logsearch-solr-user, only > > other who need to upload config into zookeeper should have write permission. > > > > I have also seen cases, where if we don't protect zookeeper path, then > > if knit'ed user accesses zookeeper, then it will fail. > > Oliver Szabo wrote: > can it be done in different patch? just because im not sure zkcli of solr > is able to set ACLs. if not maybe the users should setup this manually with > zookeeper cli anyway. > > Don Bosco Durai wrote: > Yes, we could do it later. We also need to see how hbase is doing it. > > Oliver Szabo wrote: > If zkcli cannot do that we can still use the logsearch-solr-client to set > ACLs programmatically You are correct. logsearch-solr-client has the zookeeper client. We just have to run it with the appropriate user permisison to change the permission of the zookeeper path - Don Bosco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48741/#review137798 --- On June 15, 2016, 5:37 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48741/ > ----------- > > (Updated June 15, 2016, 5:37 p.m.) > > > Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Levas, > Robert Nettleton, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-16736 > https://issues.apache.org/jira/browse/AMBARI-16736 > > > Repository: ambari > > > Description > --- > > Basuc logsearch solr kerberos support. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py > e0a30ed > ambari-logsearch/ambari-logsearch-logfeeder/pom.xml bbe0bc9 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > b14c273 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties > 076c09c > ambari-logsearch/ambari-logsearch-portal/pom.xml e83c75b > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java > cd4ef93 > > ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties > 37c8317 > ambari-logsearch/ambari-logsearch-solr-client/pom.xml b634928 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java > a2da737 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java > 2805b0b > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java > 0813221 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json > 85762e0 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml > d27067c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > 3682e5d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml > 2420be0 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json > 6dd4aa7 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py > ce7f71c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py > 2b5fdf7 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py > d0ac389 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py > b55f3d6 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > 8a1449d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/pa
Re: Review Request 48741: LogSearch Solr kerberos support
> On June 15, 2016, 7:11 p.m., Don Bosco Durai wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py, > > line 82 > > <https://reviews.apache.org/r/48741/diff/1/?file=1420250#file1420250line82> > > > > We should set explicit permission to this path. Only > > logsearch-solr-user, logsearch-user, ranger-user and atlas-user should have > > write permission. Essentially, in addition to logsearch-solr-user, only > > other who need to upload config into zookeeper should have write permission. > > > > I have also seen cases, where if we don't protect zookeeper path, then > > if knit'ed user accesses zookeeper, then it will fail. > > Oliver Szabo wrote: > can it be done in different patch? just because im not sure zkcli of solr > is able to set ACLs. if not maybe the users should setup this manually with > zookeeper cli anyway. Yes, we could do it later. We also need to see how hbase is doing it. - Don Bosco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48741/#review137798 --- On June 15, 2016, 5:37 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48741/ > ----------- > > (Updated June 15, 2016, 5:37 p.m.) > > > Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Levas, > Robert Nettleton, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-16736 > https://issues.apache.org/jira/browse/AMBARI-16736 > > > Repository: ambari > > > Description > --- > > Basuc logsearch solr kerberos support. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py > e0a30ed > ambari-logsearch/ambari-logsearch-logfeeder/pom.xml bbe0bc9 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > b14c273 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties > 076c09c > ambari-logsearch/ambari-logsearch-portal/pom.xml e83c75b > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java > cd4ef93 > > ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties > 37c8317 > ambari-logsearch/ambari-logsearch-solr-client/pom.xml b634928 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java > a2da737 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java > 2805b0b > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java > 0813221 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json > 85762e0 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml > d27067c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > 3682e5d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml > 2420be0 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json > 6dd4aa7 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py > ce7f71c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py > 2b5fdf7 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py > d0ac389 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py > b55f3d6 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > 8a1449d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py > 5d1ca85 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > 368db03 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py > eac60db > > ambari-server/src/main/resources/common-
Re: Review Request 48485: AMBARI-17044 Optimize LogSearch Solr for cache setting and default values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48485/ --- (Updated June 13, 2016, 10:24 a.m.) Review request for Ambari, Oliver Szabo and Sumit Mohanty. Changes --- Updated solrconfig.xml.j2 in the Ambari stack location Bugs: AMBARI-17044 https://issues.apache.org/jira/browse/AMBARI-17044 Repository: ambari Description --- Changed default settings to not to wait for cache to be fully build before addressing request Diffs (updated) - ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/solrconfig.xml.j2 c0d8b2f ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/audit_logs-solrconfig.xml.j2 c870edc ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/service_logs-solrconfig.xml.j2 a06a900 Diff: https://reviews.apache.org/r/48485/diff/ Testing --- Create 3 node Hadoop cluster and tested the change Thanks, Don Bosco Durai
Re: Review Request 48622: AMBARI-17136: If Solr is down or not ready, then LogFeeder to should retry
> On June 13, 2016, 9:56 a.m., Miklos Gergely wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java, > > line 354 > > <https://reviews.apache.org/r/48622/diff/1/?file=1416645#file1416645line354> > > > > addRouterField should be called outside of the loop. The purpose of > > this function is to distribute the uploaded documents evenly among the > > shards, so it is not important to ensure that the ROUTER_FIELD is > > calculated based on the actual sending time, there is no need to re-set it > > in every iteration. The addRouterField function may not throw an exception > > so it is not a problem if it is not in any try-catch block. > > > > Using setField instead of addField is a good decision, it describes > > better what the program's intention is. In a multi-node SolrCloud cluster, each shard might be in different nodes. I have seen in some cases, if particular shard has any long running issue, then it is better to move on to next shard so that we don't block forever. - Don Bosco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48622/#review137260 ------- On June 13, 2016, 9:28 a.m., Don Bosco Durai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48622/ > --- > > (Updated June 13, 2016, 9:28 a.m.) > > > Review request for Ambari, Dharmesh Makwana, Miklos Gergely, Oliver Szabo, > and Sumit Mohanty. > > > Bugs: AMBARI-17136 > https://issues.apache.org/jira/browse/AMBARI-17136 > > > Repository: ambari > > > Description > --- > > Uploaded new patch based on feedback from previous review board requests > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > 6fb0b0e > > Diff: https://reviews.apache.org/r/48622/diff/ > > > Testing > --- > > Tested on 3 node hadoop cluster > > > Thanks, > > Don Bosco Durai > >
Re: Review Request 48486: AMBARI-17136: If Solr is down or not ready, then LogFeeder to should retry
> On June 10, 2016, 6:08 p.m., Miklos Gergely wrote: > > Good feedback. Let me do this before we commit. - Don Bosco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48486/#review137048 --- On June 10, 2016, 7:39 p.m., Don Bosco Durai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48486/ > --- > > (Updated June 10, 2016, 7:39 p.m.) > > > Review request for Ambari, Oliver Szabo and Sumit Mohanty. > > > Bugs: AMBARI-17136 > https://issues.apache.org/jira/browse/AMBARI-17136 > > > Repository: ambari > > > Description > --- > > In addition to IOException, now also considering SolrException also has > transient errors. In addition, now not relying on Ping to check whether Solr > is up. The reason being, Solr might be up, but the collection/shard might not > be available. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > 6fb0b0e > > Diff: https://reviews.apache.org/r/48486/diff/ > > > Testing > --- > > Created 3 node hadoop cluster and tested this patch > > > Thanks, > > Don Bosco Durai > >
Re: Review Request 48486: AMBARI-17136: If Solr is down or not ready, then LogFeeder to should retry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48486/ --- (Updated June 10, 2016, 7:39 p.m.) Review request for Ambari, Oliver Szabo and Sumit Mohanty. Bugs: AMBARI-17136 https://issues.apache.org/jira/browse/AMBARI-17136 Repository: ambari Description --- In addition to IOException, now also considering SolrException also has transient errors. In addition, now not relying on Ping to check whether Solr is up. The reason being, Solr might be up, but the collection/shard might not be available. Diffs - ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java 6fb0b0e Diff: https://reviews.apache.org/r/48486/diff/ Testing --- Created 3 node hadoop cluster and tested this patch Thanks, Don Bosco Durai
Re: Review Request 48486: AMBARI-17136: If Solr is down or not ready, then LogFeeder to should retry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48486/ --- (Updated June 10, 2016, 5:53 p.m.) Review request for Ambari, Oliver Szabo and Sumit Mohanty. Changes --- Aded more comments Bugs: AMBARI-17136 https://issues.apache.org/jira/browse/AMBARI-17136 Repository: ambari Description --- In addition to IOException, now also considering SolrException also has transient errors. In addition, now not relying on Ping to check whether Solr is up. The reason being, Solr might be up, but the collection/shard might not be available. Diffs (updated) - ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java 6fb0b0e Diff: https://reviews.apache.org/r/48486/diff/ Testing --- Created 3 node hadoop cluster and tested this patch Thanks, Don Bosco Durai
Re: Review Request 48485: AMBARI-17044 Optimize LogSearch Solr for cache setting and default values
> On June 9, 2016, 6:14 p.m., Oliver Szabo wrote: > > I think, we don't need this to be configurable. Also, do I need to modify any other file other than the .j2? I thought, we were reusing the same files - Don Bosco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48485/#review136866 --- On June 9, 2016, 10:15 a.m., Don Bosco Durai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48485/ > --- > > (Updated June 9, 2016, 10:15 a.m.) > > > Review request for Ambari, Oliver Szabo and Sumit Mohanty. > > > Bugs: AMBARI-17044 > https://issues.apache.org/jira/browse/AMBARI-17044 > > > Repository: ambari > > > Description > --- > > Changed default settings to not to wait for cache to be fully build before > addressing request > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/solrconfig.xml > 7af91df > > ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/solrconfig.xml.j2 > c0d8b2f > > ambari-logsearch/ambari-logsearch-portal/src/main/configsets/hadoop_logs/conf/solrconfig.xml > 59f778f > > ambari-logsearch/ambari-logsearch-portal/src/main/configsets/hadoop_logs/conf/solrconfig.xml.j2 > 0152880 > > ambari-logsearch/ambari-logsearch-portal/src/main/configsets/history/conf/solrconfig.xml > 8244a08 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java > 147e148 > > Diff: https://reviews.apache.org/r/48485/diff/ > > > Testing > --- > > Create 3 node Hadoop cluster and tested the change > > > Thanks, > > Don Bosco Durai > >
Re: Review Request 47344: Log count text on Log level select boxes in Service Logs Tab not getting updated while checking and unchecking
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47344/#review134701 --- Ship it! Ship It! - Don Bosco Durai On May 13, 2016, 12:01 p.m., Dharmesh Makwana wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47344/ > --- > > (Updated May 13, 2016, 12:01 p.m.) > > > Review request for Ambari, Don Bosco Durai, Jaimin Jetly, Oliver Szabo, and > Sumit Mohanty. > > > Bugs: AMBARI-16657 > https://issues.apache.org/jira/browse/AMBARI-16657 > > > Repository: ambari > > > Description > --- > > Patch contains fix for log level count not getting updated while checking and > unchecking > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/LogLevelBoxView.js > 2d5096a > > Diff: https://reviews.apache.org/r/47344/diff/ > > > Testing > --- > > Tested in local Ambari environment. > > > Thanks, > > Dharmesh Makwana > >
Re: Review Request 47605: AMBARI-16446 Ranger audit properties should be configured to use Ambari installed Solr (LogSearch)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47605/#review134681 --- Ship it! Ship It! - Don Bosco Durai On May 24, 2016, 11:58 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47605/ > --- > > (Updated May 24, 2016, 11:58 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco > Durai, Gautam Borad, Jaimin Jetly, Jayush Luniya, Oliver Szabo, and > Velmurugan Periasamy. > > > Bugs: AMBARI-16446 > https://issues.apache.org/jira/browse/AMBARI-16446 > > > Repository: ambari > > > Description > --- > > From stack 2.5 onwards Ranger Service is dependent on Logsearch for Solr > instance. > Enable Audit to Solr and populate Ranger Audit properties with that Solr > instance. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 2e18443 > > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py > aba3025 > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py > 9e9cadc > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > d4418e0 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py > c015367 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > fabe2fb > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml > ef05604 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml > 43975af > ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml > 59451b2 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 3ec5d05 > ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json > f7e15aa > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/ranger-kms-audit.xml > bfa0fd2 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 11aac72 > ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json > b6d7d5b > > Diff: https://reviews.apache.org/r/47605/diff/ > > > Testing > --- > > Tested Ranger installation with Logsearch on centos 6. > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 47452: Do not use implicit routing by default in solr-client
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47452/#review134480 --- Ship it! Ship It! - Don Bosco Durai On May 17, 2016, 1:29 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47452/ > --- > > (Updated May 17, 2016, 1:29 p.m.) > > > Review request for Ambari, Don Bosco Durai, Oliver Szabo, Robert Nettleton, > and Sumit Mohanty. > > > Bugs: AMBARI-16701 > https://issues.apache.org/jira/browse/AMBARI-16701 > > > Repository: ambari > > > Description > --- > > By default ambari should not use implicit routing for creating collections > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py > d661288 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java > 21e7fee > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java > c888269 > > Diff: https://reviews.apache.org/r/47452/diff/ > > > Testing > --- > > ambari logsearch solr-client tests: > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Oliver Szabo > >
Re: Review Request 47452: Do not use implicit routing by default in solr-client
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47452/#review134474 --- Fix it, then Ship it! Ship it after reviewing feedback. Thanks ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java (line 53) <https://reviews.apache.org/r/47452/#comment199310> During Create collection, shards is a valid value. Only after the collection is created, you can't add shards to SolrCloud using compositeId - Don Bosco Durai On May 17, 2016, 1:29 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47452/ > --- > > (Updated May 17, 2016, 1:29 p.m.) > > > Review request for Ambari, Don Bosco Durai, Oliver Szabo, Robert Nettleton, > and Sumit Mohanty. > > > Bugs: AMBARI-16701 > https://issues.apache.org/jira/browse/AMBARI-16701 > > > Repository: ambari > > > Description > --- > > By default ambari should not use implicit routing for creating collections > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py > d661288 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java > 21e7fee > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java > c888269 > > Diff: https://reviews.apache.org/r/47452/diff/ > > > Testing > --- > > ambari logsearch solr-client tests: > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Oliver Szabo > >
Re: Review Request 47446: Logsearch color codes works only for upper case log levels.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47446/#review134027 --- Ship it! Ship It! - Don Bosco Durai On May 17, 2016, 8:35 a.m., Dharmesh Makwana wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47446/ > --- > > (Updated May 17, 2016, 8:35 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco > Durai, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and > Sebastian Toader. > > > Bugs: AMBARI-16698 > https://issues.apache.org/jira/browse/AMBARI-16698 > > > Repository: ambari > > > Description > --- > > Patch contains: > Fix for log level color code doesn't show up, if log levels are not in upper > case. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/ViewUtils.js > ba21b65 > > ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/ComparisonView.js > 8ad0c4b > > ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js > 2d19d78 > > Diff: https://reviews.apache.org/r/47446/diff/ > > > Testing > --- > > Setup logsearch on 3 node cluster and tested the above features. > > > Thanks, > > Dharmesh Makwana > >
Re: Review Request 46999: AMBARI-16261: LogFeeder logs are not showing up in LogSearch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46999/ --- (Updated May 10, 2016, 7:34 a.m.) Review request for Ambari, Oliver Szabo and Sumit Mohanty. Changes --- Seems the input.config.j2 was not properly uploaded. Retrying it. Bugs: AMBARI-16261 https://issues.apache.org/jira/browse/AMBARI-16261 Repository: ambari Description --- Found out 3 issues: 1. Path to LogFeeder was incorrect 2. Input config was incorrect. We were using grok, but LogSearch logs are in JSON format 3. log4j.xml for logsearch portal was not using JSON appender Diffs (updated) - ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-logsearch.json.j2 06aaba6 Diff: https://reviews.apache.org/r/46999/diff/ Testing --- Tested by updating the log4j in Ambari and also updating config files. Thanks, Don Bosco Durai
Re: Review Request 46931: Updated grok lib version(0.1.1 to 0.1.4) to get latest fixes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46931/#review131545 --- Ship it! Ship It! - Don Bosco Durai On May 3, 2016, 11:42 a.m., Hayat Behlim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46931/ > --- > > (Updated May 3, 2016, 11:42 a.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-16211 > https://issues.apache.org/jira/browse/AMBARI-16211 > > > Repository: ambari > > > Description > --- > > Patch contains : > Some log messages were not getting parsed due to grok lib issue with v.0.1.1, > need to update grok to latest version. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 12255fe > > Diff: https://reviews.apache.org/r/46931/diff/ > > > Testing > --- > > > Thanks, > > Hayat Behlim > >
Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/#review129750 --- Looks good to me. Thanks - Don Bosco Durai On April 20, 2016, 4:36 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46152/ > --- > > (Updated April 20, 2016, 4:36 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert > Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-15865 > https://issues.apache.org/jira/browse/AMBARI-15865 > > > Repository: ambari > > > Description > --- > > Create a small ambari solr client (and rpm/deb), for logsearch solr. > The goal is the create a client which can be used for another services to > access zookeeper/solr and create their own collections in logsearch solr. > (e.g. for ATLAS or RANGER) > > > Diffs > - > > ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm > PRE-CREATION > ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION > ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractRetryCommand.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperRetryCommand.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/DownloadConfigZkCommand.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/UploadConfigZkCommand.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCloudCli.sh > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java > PRE-CREATION > ambari-logsearch/pom.xml 475de9f > > Diff: https://reviews.apache.org/r/46152/diff/ > > > Testing > --- > > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - > in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest > > > Thanks, > > Oliver Szabo > >
Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/#review129415 --- ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java (line 49) <https://reviews.apache.org/r/46152/#comment192837> might be good to put the path at the end, e.g. host1:port,host2:port,host3:port,.../ambari_solr ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java (line 95) <https://reviews.apache.org/r/46152/#comment192838> short form for retryOption and intervalOption seems to be the same ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java (line 52) <https://reviews.apache.org/r/46152/#comment192839> Show we move the sleep in the else condition? ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java (line 103) <https://reviews.apache.org/r/46152/#comment192842> Not sure why we are testing result with "collection1". - Don Bosco Durai On April 18, 2016, 4:47 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46152/ > --- > > (Updated April 18, 2016, 4:47 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert > Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-15865 > https://issues.apache.org/jira/browse/AMBARI-15865 > > > Repository: ambari > > > Description > --- > > Create a small ambari solr client (and rpm/deb), for logsearch solr. > The goal is the create a client which can be used for another services to > access zookeeper/solr and create their own collections in logsearch solr. > (e.g. for ATLAS or RANGER) > > > Diffs > - > > ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm > PRE-CREATION > ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION > ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java > PRE-CREATION > ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java > PRE-CREATION > ambari-logsearch/pom.xml 475de9f > > Diff: https://reviews.apache.org/r/46152/diff/ > > > Testing > --- > > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - > in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest > > > Thanks, > > Oliver Szabo > >
Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/#review128699 --- ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.groovy (line 73) <https://reviews.apache.org/r/46152/#comment192166> In LogSearch we use implicit routing, which needs to be sent as additional param while creating collections ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.groovy (line 78) <https://reviews.apache.org/r/46152/#comment192167> We might have take a higher number or configurable param. If the node contains other shards, then this will fail. - Don Bosco Durai On April 13, 2016, 4:32 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46152/ > --- > > (Updated April 13, 2016, 4:32 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert > Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-15865 > https://issues.apache.org/jira/browse/AMBARI-15865 > > > Repository: ambari > > > Description > --- > > Create a small ambari solr client (and rpm/deb), for logsearch solr. > The goal is the create a client which can be used for another services to > access zookeeper/solr and create their own collections in logsearch solr. > (e.g. for ATLAS or RANGER) > > > Diffs > - > > ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm > PRE-CREATION > ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION > ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.groovy > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.groovy > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/DoNotDeleteMe.java > PRE-CREATION > ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/test/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.groovy > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/NeitherMe.java > PRE-CREATION > ambari-logsearch/pom.xml 3d4edcd > > Diff: https://reviews.apache.org/r/46152/diff/ > > > Testing > --- > > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - > in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest > > > Thanks, > > Oliver Szabo > >
