Review Request 47379: PXF operations considers the agent status

2016-05-13 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47379/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
Lav Jain, and Matt.


Bugs: AMBARI-16670
https://issues.apache.org/jira/browse/AMBARI-16670


Repository: ambari


Description
---

PXF operations considers the agent status


Diffs
-

  ambari-web/app/controllers/main/service/item.js 9250bfc 
  ambari-web/app/models/host_component.js 569879f 
  ambari-web/test/controllers/main/service/item_test.js 383aa2f 

Diff: https://reviews.apache.org/r/47379/diff/


Testing
---

Yes.

User should be able to do the following ops on PXF:
Start PXF slaves if one or more slaves are down
Stop PXF slaves if one or more slaves are up
Start disabled if all agents are up
Stop disabled if all agents are down
Service Check disabled if one or more slaves are down
Service Check enabled if all agents are up


Thanks,

Goutam Tadi



Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only

2016-05-12 Thread Goutam Tadi


> On May 12, 2016, 4:51 a.m., Matt wrote:
> > Would you like to add tests for this new widget?

Added


- Goutam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47252/#review132815
---


On May 12, 2016, 9:26 p.m., Goutam Tadi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47252/
> ---
> 
> (Updated May 12, 2016, 9:26 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
> Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16461
> https://issues.apache.org/jira/browse/AMBARI-16461
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF Agents Live Widget on Dashboard needs custom widget to display only 
> single threshold i.e., Green/Red only
> 
> 
> Diffs
> -
> 
>   ambari-web/app/assets/test/tests.js eb2edf1 
>   ambari-web/app/messages.js 910bed7 
>   ambari-web/app/mixins.js cf8cef6 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 97b6330 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> PRE-CREATION 
>   ambari-web/app/styles/modal_popups.less 5e89dbc 
>   
> ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs
>  PRE-CREATION 
>   ambari-web/app/views.js 127a996 
>   ambari-web/app/views/main/dashboard/widgets.js 38181c0 
>   ambari-web/app/views/main/dashboard/widgets/pxf_live.js 75f5886 
>   ambari-web/app/views/main/dashboard/widgets/text_widget_single_threshold.js 
> PRE-CREATION 
>   ambari-web/test/aliases/computed/gtProperties.js f3f1def 
>   
> ambari-web/test/views/main/dashboard/widgets/text_widget_single_threshold_test.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47252/diff/
> 
> 
> Testing
> ---
> 
> Yes, All tests passed. Test was already in place.
> 
> 
> Thanks,
> 
> Goutam Tadi
> 
>



Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only

2016-05-12 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47252/
---

(Updated May 12, 2016, 9:26 p.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
Lav Jain, and Matt.


Bugs: AMBARI-16461
https://issues.apache.org/jira/browse/AMBARI-16461


Repository: ambari


Description
---

PXF Agents Live Widget on Dashboard needs custom widget to display only single 
threshold i.e., Green/Red only


Diffs (updated)
-

  ambari-web/app/assets/test/tests.js eb2edf1 
  ambari-web/app/messages.js 910bed7 
  ambari-web/app/mixins.js cf8cef6 
  ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 97b6330 
  ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
PRE-CREATION 
  ambari-web/app/styles/modal_popups.less 5e89dbc 
  
ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs 
PRE-CREATION 
  ambari-web/app/views.js 127a996 
  ambari-web/app/views/main/dashboard/widgets.js 38181c0 
  ambari-web/app/views/main/dashboard/widgets/pxf_live.js 75f5886 
  ambari-web/app/views/main/dashboard/widgets/text_widget_single_threshold.js 
PRE-CREATION 
  ambari-web/test/aliases/computed/gtProperties.js f3f1def 
  
ambari-web/test/views/main/dashboard/widgets/text_widget_single_threshold_test.js
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47252/diff/


Testing
---

Yes, All tests passed. Test was already in place.


Thanks,

Goutam Tadi



Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only

2016-05-12 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47252/
---

(Updated May 12, 2016, 9:19 p.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
Lav Jain, and Matt.


Changes
---

Applied feedback


Bugs: AMBARI-16461
https://issues.apache.org/jira/browse/AMBARI-16461


Repository: ambari


Description
---

PXF Agents Live Widget on Dashboard needs custom widget to display only single 
threshold i.e., Green/Red only


Diffs (updated)
-

  ambari-web/app/assets/test/tests.js eb2edf1 
  ambari-web/app/messages.js 910bed7 
  ambari-web/app/mixins.js cf8cef6 
  ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 97b6330 
  ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
PRE-CREATION 
  ambari-web/app/styles/modal_popups.less 5e89dbc 
  
ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs 
PRE-CREATION 
  ambari-web/app/views.js 127a996 
  ambari-web/app/views/main/dashboard/widgets.js 38181c0 
  ambari-web/app/views/main/dashboard/widgets/pxf_live.js 75f5886 
  ambari-web/app/views/main/dashboard/widgets/text_widget_single_threshold.js 
PRE-CREATION 
  ambari-web/test/aliases/computed/gtProperties.js f3f1def 
  
ambari-web/test/views/main/dashboard/widgets/text_widget_single_threshold_test.js
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47252/diff/


Testing
---

Yes, All tests passed. Test was already in place.


Thanks,

Goutam Tadi



Re: Review Request 47160: PXF should be collocated with NAMENODE even if NAMENODE is moved to another host

2016-05-10 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47160/#review132476
---


Ship it!




Ship It!

- Goutam Tadi


On May 10, 2016, 7:26 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47160/
> ---
> 
> (Updated May 10, 2016, 7:26 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16419
> https://issues.apache.org/jira/browse/AMBARI-16419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After move NAMENODE wizard is executed,
> - PXF should be installed on the target host.
> - If the source host does not have a DATANODE, PXF should be removed from the 
> source host.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step6_controller.js 
> f718d46 
>   ambari-web/app/messages.js e388526 
>   ambari-web/test/controllers/main/service/reassign/step6_controller_test.js 
> 89e2325 
> 
> Diff: https://reviews.apache.org/r/47160/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> 
>   27727 tests complete (25 seconds)
>   154 tests pending
>   
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:14 min
> [INFO] Finished at: 2016-05-10T00:20:54-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 46752: Ambari Web Service installation does not comply with Final Attribute. (isFinal is skipped)

2016-05-04 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46752/
---

(Updated May 4, 2016, 4:30 p.m.)


Review request for Ambari, Andriy Babiichuk, Alexander Denissov, bhuvnesh 
chaudhary, jun aoki, Lav Jain, Matt, and Yusaku Sako.


Bugs: AMBARI-16147
https://issues.apache.org/jira/browse/AMBARI-16147


Repository: ambari


Description
---

When installing HDFS/HIVE/any service the properties that are marked final 
before installation are marked as de-finalized post installation. This occurs 
at the last step of installation i.e deploy stage.


Diffs (updated)
-

  ambari-web/app/controllers/wizard.js 64ee3dd 

Diff: https://reviews.apache.org/r/46752/diff/


Testing
---

Yes, Tested manually.

27704 tests complete (25 seconds)
INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 57.007s
[INFO] Finished at: Wed Apr 27 22:00:48 UTC 2016
[INFO] Final Memory: 9M/43M
[INFO] 


Thanks,

Goutam Tadi



Re: Review Request 46742: Use additional flags for HAWQ Check

2016-04-29 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46742/#review131161
---


Ship it!




Ship It!

- Goutam Tadi


On April 29, 2016, 6:48 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46742/
> ---
> 
> (Updated April 29, 2016, 6:48 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16106
> https://issues.apache.org/jira/browse/AMBARI-16106
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Make changes to HAWQ Check implementation based on HAWQ-668
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  15ceaa2 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
>  76a5885 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 03323df 
> 
> Diff: https://reviews.apache.org/r/46742/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> Added 15 unit tests.
> 
> Ran unit tests:
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-04-29 11:48:07,197 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-04-29 11:48:07,201 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-04-29 11:48:07,205 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-04-29 11:48:07,213 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
> Kerberized ... 2016-04-29 11:48:07,221 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case12 (test_haw

Review Request 46791: Capitalize HAWQ and PXF on service check

2016-04-28 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46791/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
Lav Jain, and Matt.


Bugs: AMBARI-16168
https://issues.apache.org/jira/browse/AMBARI-16168


Repository: ambari


Description
---

Capitalize HAWQ and PXF on service check


Diffs
-

  ambari-web/app/utils/helper.js 3cffc09 

Diff: https://reviews.apache.org/r/46791/diff/


Testing
---

Yes, Tested manually. Tests passed.


Thanks,

Goutam Tadi



Re: Review Request 46752: Ambari Web Service installation does not comply with Final Attribute. (isFinal is skipped)

2016-04-27 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46752/
---

(Updated April 27, 2016, 11:16 p.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
Lav Jain, and Matt.


Bugs: AMBARI-16147
https://issues.apache.org/jira/browse/AMBARI-16147


Repository: ambari


Description
---

When installing HDFS/HIVE/any service the properties that are marked final 
before installation are marked as de-finalized post installation. This occurs 
at the last step of installation i.e deploy stage.


Diffs (updated)
-

  ambari-web/app/controllers/wizard.js 52fb241 

Diff: https://reviews.apache.org/r/46752/diff/


Testing
---

Yes, Tested manually.

27704 tests complete (25 seconds)
INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 57.007s
[INFO] Finished at: Wed Apr 27 22:00:48 UTC 2016
[INFO] Final Memory: 9M/43M
[INFO] 


Thanks,

Goutam Tadi



Re: Review Request 46752: Ambari Web Service installation does not comply with Final Attribute. (isFinal is skipped)

2016-04-27 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46752/
---

(Updated April 27, 2016, 10:02 p.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
Lav Jain, and Matt.


Bugs: AMBARI-16147
https://issues.apache.org/jira/browse/AMBARI-16147


Repository: ambari


Description
---

When installing HDFS/HIVE/any service the properties that are marked final 
before installation are marked as de-finalized post installation. This occurs 
at the last step of installation i.e deploy stage.


Diffs
-

  ambari-web/app/controllers/wizard.js 52fb241 

Diff: https://reviews.apache.org/r/46752/diff/


Testing
---

Yes, Tested manually.

27704 tests complete (25 seconds)
INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 57.007s
[INFO] Finished at: Wed Apr 27 22:00:48 UTC 2016
[INFO] Final Memory: 9M/43M
[INFO] 


Thanks,

Goutam Tadi



Review Request 46752: Ambari Web Service installation does not comply with Final Attribute. (isFinal is skipped)

2016-04-27 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46752/
---

Review request for Ambari.


Bugs: AMBARI-16147
https://issues.apache.org/jira/browse/AMBARI-16147


Repository: ambari


Description
---

When installing HDFS/HIVE/any service the properties that are marked final 
before installation are marked as de-finalized post installation. This occurs 
at the last step of installation i.e deploy stage.


Diffs
-

  ambari-web/app/controllers/wizard.js 52fb241 

Diff: https://reviews.apache.org/r/46752/diff/


Testing
---

Yes, Tested manually.

27704 tests complete (25 seconds)
INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 57.007s
[INFO] Finished at: Wed Apr 27 22:00:48 UTC 2016
[INFO] Final Memory: 9M/43M
[INFO] 


Thanks,

Goutam Tadi



Re: Review Request 46585: Show number of PXFs Live widget on main dashboard

2016-04-25 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46585/#review130451
---


Ship it!




Ship It!

- Goutam Tadi


On April 22, 2016, 11:51 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46585/
> ---
> 
> (Updated April 22, 2016, 11:51 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16074
> https://issues.apache.org/jira/browse/AMBARI-16074
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Show number of PXFs Live widget on main dashboard
> 
> 
> Diffs
> -
> 
>   ambari-web/app/assets/test/tests.js 33e7f1c 
>   ambari-web/app/mappers/components_state_mapper.js 755c0f5 
>   ambari-web/app/messages.js 907d9ae 
>   ambari-web/app/views.js 6bb2774 
>   ambari-web/app/views/main/dashboard/widgets.js 067607f 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js bec98c6 
>   ambari-web/app/views/main/dashboard/widgets/pxf_live.js PRE-CREATION 
>   ambari-web/test/views/main/dashboard/widgets/pxf_live_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46585/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> Added Unit test.
> 
> Unit test Results:
> 
>   27538 tests complete (22 seconds)
>   154 tests pending
>   
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:11 min
> [INFO] Finished at: 2016-04-22T16:50:37-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 46350: PXF Check fails on Kerberized cluster without a YARN component

2016-04-19 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46350/#review129629
---


Ship it!




Ship It!

- Goutam Tadi


On April 19, 2016, 9:18 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46350/
> ---
> 
> (Updated April 19, 2016, 9:18 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-15954
> https://issues.apache.org/jira/browse/AMBARI-15954
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If the PXF component is not co-located with a YARN component, PXF service 
> check would fail. This is because it requires yarn-site on that host.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py
>  ae0c80c 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
>  fe3c17e 
> 
> Diff: https://reviews.apache.org/r/46350/diff/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Lav Jain
> 
>



Re: Review Request 46359: HAWQ Immediate Stop cluster fails with key error

2016-04-19 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46359/#review129577
---


Ship it!




Ship It!

- Goutam Tadi


On April 19, 2016, 1:20 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46359/
> ---
> 
> (Updated April 19, 2016, 1:20 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-15960
> https://issues.apache.org/jira/browse/AMBARI-15960
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Error log from running the wizard:
> 
> 
> stderr: 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py",
>  line 98, in 
> HawqMaster().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 219, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py",
>  line 69, in immediate_stop_hawq_service
> common.stop_component(hawq_constants.CLUSTER, hawq_constants.IMMEDIATE)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/common.py",
>  line 309, in stop_component
> port_property_name = 
> hawq_constants.COMPONENT_ATTRIBUTES_MAP[component_name]['port_property']
> KeyError: 'cluster'
>  stdout:
> None
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
>  4ce0c94 
> 
> Diff: https://reviews.apache.org/r/46359/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested. Unit Tests passed.
> 
> 
> Thanks,
> 
> Matt
> 
>



Re: Review Request 46170: HAWQ Segment Registration Status Alert shows false alert

2016-04-14 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46170/#review129033
---


Ship it!




Ship It!

- Goutam Tadi


On April 14, 2016, 11:52 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46170/
> ---
> 
> (Updated April 14, 2016, 11:52 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-15794
> https://issues.apache.org/jira/browse/AMBARI-15794
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> 
> Install HAWQ with HAWQSEGMENT on the same host as HAWQMASTER
> Segment registration would show an alert saying that localhost is not 
> registered.
> 
> localhost is returned by gp_segment_configuration for that HAWQSEGMENT, but 
> in the slaves file, there is no entry 'localhost'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py
>  4d09763 
> 
> Diff: https://reviews.apache.org/r/46170/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Lav Jain
> 
>



Re: Review Request 46176: Update group for postgres proxy user to * from hadoop

2016-04-13 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46176/#review128778
---


Ship it!




Ship It!

- Goutam Tadi


On April 13, 2016, 10:41 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46176/
> ---
> 
> (Updated April 13, 2016, 10:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Jayush Luniya, Lav Jain, Matt, Sumit Mohanty, and Srimanth 
> Gunturi.
> 
> 
> Bugs: AMBARI-15770
> https://issues.apache.org/jira/browse/AMBARI-15770
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update group for postgres proxy user to * from hadoop
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/kerberos.json 
> 088a244 
> 
> Diff: https://reviews.apache.org/r/46176/diff/
> 
> 
> Testing
> ---
> 
> Manual.
> 
> --
> Ran 260 tests in 7.220s
> OK
> --
> Total run:959
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>



Re: Review Request 46170: HAWQ Segment Registration Status Alert shows false alert

2016-04-13 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46170/#review128763
---


Ship it!




Ship It!

- Goutam Tadi


On April 13, 2016, 9:55 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46170/
> ---
> 
> (Updated April 13, 2016, 9:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-15794
> https://issues.apache.org/jira/browse/AMBARI-15794
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> 
> Install HAWQ with HAWQSEGMENT on the same host as HAWQMASTER
> Segment registration would show an alert saying that localhost is not 
> registered.
> 
> localhost is returned by gp_segment_configuration for that HAWQSEGMENT, but 
> in the slaves file, there is no entry 'localhost'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py
>  4d09763 
> 
> Diff: https://reviews.apache.org/r/46170/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Lav Jain
> 
>



Review Request 45899: After enabling NN HA with HAWQ installed, duplicate properties are seen on HAWQ config tab

2016-04-07 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45899/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Lav Jain, 
and Matt.


Bugs: AMBARI-15771
https://issues.apache.org/jira/browse/AMBARI-15771


Repository: ambari


Description
---

After enabling NN HA with HAWQ installed, duplicate properties are seen on HAWQ 
config tab


Diffs
-

  
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js
 d004ba1 

Diff: https://reviews.apache.org/r/45899/diff/


Testing
---

Yes.
 10491 tests complete (11 seconds)
  121 tests pending
  [INFO] 

[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 41.245 s
[INFO] Finished at: 2016-04-07T14:59:25-07:00
[INFO] Final Memory: 15M/422M
[INFO] --


Thanks,

Goutam Tadi



Re: Review Request 45826: Descriptions for HAWQ sysctl params mention incorrect default values

2016-04-06 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45826/#review127388
---


Ship it!




Ship It!

- Goutam Tadi


On April 6, 2016, 6:04 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45826/
> ---
> 
> (Updated April 6, 2016, 6:04 p.m.)
> 
> 
> Review request for Ambari, bhuvnesh chaudhary, Goutam Tadi, Lav Jain, and 
> Matt.
> 
> 
> Bugs: AMBARI-15738
> https://issues.apache.org/jira/browse/AMBARI-15738
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Descriptions for HAWQ sysctl params mention incorrect default values
> 
> kernel.shmmax and net.ipv4.ip_local_port_range have incorrect default values 
> in their descriptions
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  365fa86 
> 
> Diff: https://reviews.apache.org/r/45826/diff/
> 
> 
> Testing
> ---
> 
> Manual, tests ran OK
> 
> --
> Ran 246 tests in 7.005s
> 
> OK
> --
> Total run:921
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>



Re: Review Request 45719: Alert to notify if a HAWQ Segment is unregistered with HAWQ Master

2016-04-05 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45719/
---

(Updated April 5, 2016, 4:01 p.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Lav Jain, 
and Matt.


Bugs: AMBARI-15704
https://issues.apache.org/jira/browse/AMBARI-15704


Repository: ambari


Description
---

Include an alert informing the number of segments marked down in 
gp_segment_configuration table


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 
8da5beb 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py
 PRE-CREATION 
  
ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_segment_registration_status.py
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45719/diff/


Testing
---

Test cases added.

test_missing_configs 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_slave_file 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_successful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_empty_db_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status_plural 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok


Thanks,

Goutam Tadi



Re: Review Request 44915: https://issues.apache.org/jira/browse/HAWQ-497

2016-03-19 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44915/#review123883
---




ambari-web/app/messages.js (line 2586)
<https://reviews.apache.org/r/44915/#comment186169>

This fix is for another story.


- Goutam Tadi


On March 16, 2016, 4:58 p.m., Goutam Tadi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44915/
> ---
> 
> (Updated March 16, 2016, 4:58 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
> and Lav Jain.
> 
> 
> Bugs: AMBARI-15435
> https://issues.apache.org/jira/browse/AMBARI-15435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update configs for setting virtual segments in HAWQ HashDistributed Tables 
> and random distributed tables
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  d3aa0ed 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
> aa35311 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 791d5b8 
>   ambari-web/app/messages.js 5addc9b 
> 
> Diff: https://reviews.apache.org/r/44915/diff/
> 
> 
> Testing
> ---
> 
> Yes. Manually.
> 
> 
> Thanks,
> 
> Goutam Tadi
> 
>



Re: Review Request 44915: https://issues.apache.org/jira/browse/HAWQ-497

2016-03-19 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44915/
---

(Updated March 17, 2016, 12:47 a.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
and Lav Jain.


Changes
---

tests updated


Bugs: AMBARI-15435
https://issues.apache.org/jira/browse/AMBARI-15435


Repository: ambari


Description
---

Update configs for setting virtual segments in HAWQ HashDistributed Tables and 
random distributed tables


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 d187017 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
aa35311 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
8e1aff2 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 1af32d1 

Diff: https://reviews.apache.org/r/44915/diff/


Testing (updated)
---

Yes. tested with test case


Thanks,

Goutam Tadi



Re: Review Request 44915: https://issues.apache.org/jira/browse/HAWQ-497

2016-03-19 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44915/
---

(Updated March 17, 2016, 2:28 p.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
and Lav Jain.


Bugs: AMBARI-15435
https://issues.apache.org/jira/browse/AMBARI-15435


Repository: ambari


Description
---

Update configs for setting virtual segments in HAWQ HashDistributed Tables and 
random distributed tables


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 d187017 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
aa35311 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
8e1aff2 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 7a2a37d 

Diff: https://reviews.apache.org/r/44915/diff/


Testing
---

Yes. tested with test case


Thanks,

Goutam Tadi



Review Request 44915: https://issues.apache.org/jira/browse/HAWQ-497

2016-03-19 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44915/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
and Lav Jain.


Bugs: AMBARI-15435
https://issues.apache.org/jira/browse/AMBARI-15435


Repository: ambari


Description
---

Update configs for setting virtual segments in HAWQ HashDistributed Tables and 
random distributed tables


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 d3aa0ed 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
aa35311 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
791d5b8 
  ambari-web/app/messages.js 5addc9b 

Diff: https://reviews.apache.org/r/44915/diff/


Testing
---

Yes. Manually.


Thanks,

Goutam Tadi



Re: Review Request 44687: Update RCO : PXF should start after HDFS

2016-03-15 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44687/#review123693
---


Ship it!




Ship It!

- Goutam Tadi


On March 11, 2016, 9:50 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44687/
> ---
> 
> (Updated March 11, 2016, 9:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, 
> Matt, Oleksandr Diachenko, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-15381
> https://issues.apache.org/jira/browse/AMBARI-15381
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update RCO to ensure that PXF is started after HDFS. 
> PXF connects to namenode during startup and retries couple of times until 
> namenode has come up.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 
> b28f2a9 
> 
> Diff: https://reviews.apache.org/r/44687/diff/
> 
> 
> Testing
> ---
> 
> yes. manually.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>



Re: Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-14 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44769/#review123469
---


Ship it!




Ship It!

- Goutam Tadi


On March 14, 2016, 3:59 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44769/
> ---
> 
> (Updated March 14, 2016, 3:59 p.m.)
> 
> 
> Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alexandr 
> Antonenko, Andrii Tkach, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Matt, 
> Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-15396
> https://issues.apache.org/jira/browse/AMBARI-15396
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of AMBARI-15189, dfs.allow.truncate was set to true if HAWQ service 
> is being installed. However, the recommendation is getting cleared in 
> ambari-web because HDFS is already installed.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/mixins/common/configs/enhanced_configs.js 1ee4526 
> 
> Diff: https://reviews.apache.org/r/44769/diff/
> 
> 
> Testing
> ---
> 
> Tested manually with and without HAWQ.
> 
> 
> Thanks,
> 
> Lav Jain
> 
>



Review Request 44574: Rename Service Action 'HAWQ Check' to 'HAWQ Config Check'

2016-03-09 Thread Goutam Tadi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44574/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Lav Jain, 
and Matt.


Bugs: AMBARI-15357
https://issues.apache.org/jira/browse/AMBARI-15357


Repository: ambari


Description
---

Rename Service Action 'HAWQ Check' to 'HAWQ Config Check'


Diffs
-

  ambari-web/app/messages.js 8e69dd0 

Diff: https://reviews.apache.org/r/44574/diff/


Testing
---

Yeah done.


Thanks,

Goutam Tadi