Re: Review Request 64985: AMBARI-22244. Use service type instead of service name - addendum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64985/#review194906 --- Ship it! Are we using serviceType because for 3.0, we will have configurations per serviceType and not per serviceInstance? - Madhuvanthi Radhakrishnan On Jan. 5, 2018, 7:10 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64985/ > --- > > (Updated Jan. 5, 2018, 7:10 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi > Radhakrishnan, and Robert Nettleton. > > > Bugs: AMBARI-22244 > https://issues.apache.org/jira/browse/AMBARI-22244 > > > Repository: ambari > > > Description > --- > > cherry-picked from `branch-feature-AMBARI-14714-blueprintv2` branch: > > Replaced `serviceName` with `serviceType` in more places > (`getDefaultProperties`, `getServiceProperties` and `getReadOnlyProperties` > calls). > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java > 2582c71eb95255f0f8081e90473183243f12cdd0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 38e1233308a7f423789a1961e3dd8664919f29ae > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > 6bb248e19bef39ba2edb3671d38ef815d8efb593 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 4008c21f8ef092e2a1ebd0d7c18ad95bc8206e37 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java > 36918ccfef596e14a0d3e8e663fb097d065e27a4 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > a6c650705ad6b90834906bd3ce08149e2528f28e > > > Diff: https://reviews.apache.org/r/64985/diff/1/ > > > Testing > --- > > Used in blueprint cluster creation (on > `branch-feature-AMBARI-14714-blueprintv2` branch). > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 64478: Blueprint V2 API: object model, resource provider, cluster creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64478/#review194709 --- Ship it! Ship It! - Madhuvanthi Radhakrishnan On Dec. 9, 2017, 12:19 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64478/ > --- > > (Updated Dec. 9, 2017, 12:19 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi > Radhakrishnan, Robert Nettleton, and Swapan Shridhar. > > > Bugs: AMBARI-22253, AMBARI-22297 and AMBARI-22325 > https://issues.apache.org/jira/browse/AMBARI-22253 > https://issues.apache.org/jira/browse/AMBARI-22297 > https://issues.apache.org/jira/browse/AMBARI-22325 > > > Repository: ambari > > > Description > --- > > Implementation of Blueprint V2 API POST that allows cluster creation. > Co-authored by Balázs Bence Sári and Attila Doroszlai. > > Includes minor fixes for: > > * AMBARI-22196 -- yum repo file contains parsing errors due to initial > whitespace > * AMBARI-22249 -- AmbariContext.serviceGroupDependencyResourceProvider > initialization > * AMBARI-22164 -- wrong assignment due to leftover parameter name > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/ObjectNotFoundException.java > 75c9f3b5d50102f3beeeaa8041178cc08e22e241 > > ambari-server/src/main/java/org/apache/ambari/server/ParentObjectNotFoundException.java > 15bd7cb6bbe5026bf0a5ae9d3fc0bec575137643 > > ambari-server/src/main/java/org/apache/ambari/server/StackAccessException.java > b8bfff3991a4e49514801dbb480958941cff01ac > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > fd43edfa88339cd94686ddc13822b36ab7c74d6f > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java > 2582c71eb95255f0f8081e90473183243f12cdd0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 59e6622f708e7d8d27c9e28ce2ce58f014a4a5dc > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c88b23c8af374dd9bd695b70560079871f3366fd > > ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationRequest.java > d26cf16b59897573173ea258133a1c1b4e6f31f1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > f2ff181da0327a82adb67e1405ab9ae238b5c4d4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java > cc84ce24b5e769257ac0e8744a93e3e236bb04e3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java > 6d0f3fbd4288d31c3e077445e20c3b2bac696930 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java > ea082c66e128a30368d6be195f3ee270a08e8518 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2.java > 0b0329c31bb5800eb32ba4b437bd57a41a618dbe > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2Factory.java > 784b3683ba9d3909bb9e6d900e4175b6a00aec9a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > 5104354fce7701fe023723c19d56d25e7adf5219 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseClusterRequest.java > a38f478ed05ec88816e6363b31aa102a4a9d353f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintV2ResourceProvider.java > 6d2c4f06f5c75fbdf9e81c2d711440862f375bb9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > cc0cea377233931bf65943f792f6a7e11b074f06 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java > 565369b08b6eeb1a598575e448ce0c6334b6234b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java > f773fc8aac61f74988dd63a7a8b2cc30053023d2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationResourceProvider.java > 5a6dff4144bc059ff2614fb1ee4704c0c7a64809 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java > 1284c265c150aa03c00b43b364c
Re: Review Request 64614: AMBARI-22164. Fix wrong assignment due to leftover parameter name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64614/#review193844 --- Ship it! Ship It! - Madhuvanthi Radhakrishnan On Dec. 14, 2017, 1:25 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64614/ > --- > > (Updated Dec. 14, 2017, 1:25 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi > Radhakrishnan, and Swapan Shridhar. > > > Bugs: AMBARI-22164 > https://issues.apache.org/jira/browse/AMBARI-22164 > > > Repository: ambari > > > Description > --- > > `serviceDisplayName` was changed to `serviceName` in both sides of the > assignment, but the parameter name was left as was, resulting in the member > variable `serviceName` always being set to `null`. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java > ea082c66e128a30368d6be195f3ee270a08e8518 > > > Diff: https://reviews.apache.org/r/64614/diff/1/ > > > Testing > --- > > Tested in blueprint deployment. > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64594/#review193825 --- Fix it, then Ship it! ambari-common/src/main/python/resource_management/libraries/functions/cluster_settings.py Lines 45 (patched) <https://reviews.apache.org/r/64594/#comment272459> Hi, Eventually it might never happen that cluster_settings is None, but if it does then this would be a Logger.error and return None instead of Logger.info because it will throw an error at Line 54 if we continue with the function. Looks like we have this in Line 78 so need to have the same behaviour here. Thanks ambari-common/src/main/python/resource_management/libraries/functions/cluster_settings.py Lines 53 (patched) <https://reviews.apache.org/r/64594/#comment272460> What is the format that the calling function is expected to pass "setting_names" as? Do we need to do set(setting_names) if it is already being passed as a set? ambari-common/src/main/python/resource_management/libraries/functions/stack_settings.py Lines 50 (patched) <https://reviews.apache.org/r/64594/#comment272461> return None ambari-common/src/main/python/resource_management/libraries/functions/stack_settings.py Lines 58 (patched) <https://reviews.apache.org/r/64594/#comment272462> Remove set() - Madhuvanthi Radhakrishnan On Dec. 14, 2017, 9:02 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64594/ > --- > > (Updated Dec. 14, 2017, 9:02 a.m.) > > > Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. > > > Bugs: AMBARI-22649 > https://issues.apache.org/jira/browse/AMBARI-22649 > > > Repository: ambari > > > Description > --- > > Background : AMBARI-22198 added "stack settings", and AMBARI-22196 introduced > "cluster settings" in Ambari. > > **==** > **Library for querying _clusterSettings_ and _stackSettings_ for its contents > in command*.json.** > **==** > > One should be able to query for a given **clusterSettings** or > **stackSettings**: > - by passing in the setting name(one or more) in order to get it back as > key-value map, or > - just get the value back for a passed-in setting. > > > **Functions for clusterSettings:** > **--** > - **get_cluster_setting_entries(setting_names)** : > -- Retrieves the passed-in cluster setting entr(y/ies) and their values > as a map. >If 'setting_names' is passed-in as None : all the settings names and > their corresponding values will be returned as map. >If 'setting_names' is passed-in as empty set : None will be returned. > > - **get_cluster_setting_value(setting_name)** : > -- Retrieves the passed-in cluster setting entry's value. > > - **is_security_enabled()** : > -- Retrieves the cluster's security status. > > > **Functions for stackSettings:** > **** > > Stack settings as of now has 5 settings : stack_name, stack_root, > stack_features, stack_tools, stack_packages. stack_name, stack_root have > string as values, whereas stack_features, stack_tools, stack_packages have > values as JSON. Further there already exists python functions in files : > **stack_features.py**, **stack_tools.py** and **stack_select.py**. > >- **get_stack_setting_entries(setting_names)** : > -- Retrieves the passed-in stack setting entr(y/ies) and their values > as a map. > If 'setting_names' is passed-in as None, all the settings names > and their corresponding values will be returned as map. > If 'setting_names' is passed-in as empty set : None will be > returned. > >- **get_stack_setting_value(setting_name)**: > -- Retrieves the passed-in stack setting entry's value. > > - **get_stack_name()**: > -- Retrieves the stack name. > > - **get_stack_root()**: >-- Retrieves the stack root. > > > > **Modifications in _stack_features.py, stack_tools.py and stack_select.py_ > files:** > **-** > > - Given that these already exist and as of now they read t
Re: Review Request 64478: Blueprint V2 API: object model, resource provider, cluster creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64478/#review193429 --- ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java Line 1029 (original), 1023 (patched) <https://reviews.apache.org/r/64478/#comment271972> Hi Attila, Since we havent completely gotten rid of /cluster/configuration yet, the serviceId in the request can be null. The change you have made is what we will do eventually but right now this might break the existing feature branch deployments. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseClusterRequest.java Line 137 (original), 110 (patched) <https://reviews.apache.org/r/64478/#comment271973> Missing throws clause ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java Line 66 (original), 66 (patched) <https://reviews.apache.org/r/64478/#comment271983> If each service instance can have its own config properties then shouldnt it be serviceName (unique)? Correct me if i am wrong. ambari-server/src/main/java/org/apache/ambari/server/topology/HostGroupInfo.java Line 194 (original), 200 (patched) <https://reviews.apache.org/r/64478/#comment271995> Missing throws clause ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql Line 42 (original) <https://reviews.apache.org/r/64478/#comment272006> Where are we setting this value? I saw we removed it from the StackManager code. So, in UI deployment it might fail. - Madhuvanthi Radhakrishnan On Dec. 9, 2017, 12:19 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64478/ > --- > > (Updated Dec. 9, 2017, 12:19 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi > Radhakrishnan, Robert Nettleton, and Swapan Shridhar. > > > Bugs: AMBARI-22253, AMBARI-22297 and AMBARI-22325 > https://issues.apache.org/jira/browse/AMBARI-22253 > https://issues.apache.org/jira/browse/AMBARI-22297 > https://issues.apache.org/jira/browse/AMBARI-22325 > > > Repository: ambari > > > Description > --- > > Implementation of Blueprint V2 API POST that allows cluster creation. > Co-authored by Balázs Bence Sári and Attila Doroszlai. > > Includes minor fixes for: > > * AMBARI-22196 -- yum repo file contains parsing errors due to initial > whitespace > * AMBARI-22249 -- AmbariContext.serviceGroupDependencyResourceProvider > initialization > * AMBARI-22164 -- wrong assignment due to leftover parameter name > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/ObjectNotFoundException.java > 75c9f3b5d50102f3beeeaa8041178cc08e22e241 > > ambari-server/src/main/java/org/apache/ambari/server/ParentObjectNotFoundException.java > 15bd7cb6bbe5026bf0a5ae9d3fc0bec575137643 > > ambari-server/src/main/java/org/apache/ambari/server/StackAccessException.java > b8bfff3991a4e49514801dbb480958941cff01ac > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > fd43edfa88339cd94686ddc13822b36ab7c74d6f > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java > 2582c71eb95255f0f8081e90473183243f12cdd0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 59e6622f708e7d8d27c9e28ce2ce58f014a4a5dc > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c88b23c8af374dd9bd695b70560079871f3366fd > > ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationRequest.java > d26cf16b59897573173ea258133a1c1b4e6f31f1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > f2ff181da0327a82adb67e1405ab9ae238b5c4d4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java > cc84ce24b5e769257ac0e8744a93e3e236bb04e3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java > 6d0f3fbd4288d31c3e077445e20c3b2bac696930 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java > ea082c66e128a30368d6be195f3ee270a08e8518 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2.java > 0b0329c31bb5800eb32ba4b437bd57a41a618dbe > > ambari-server/src/m
Re: Review Request 64397: AMBARI-22602. Add 'clusterSettings' and 'stackSettings' parameters in Execution Command.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64397/#review193284
---
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
Line 57 (original)
<https://reviews.apache.org/r/64397/#comment271835>
Are we using this map anywhere?
- Madhuvanthi Radhakrishnan
On Dec. 7, 2017, 8:11 a.m., Swapan Shridhar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64397/
> ---
>
> (Updated Dec. 7, 2017, 8:11 a.m.)
>
>
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
>
>
> Bugs: AMBARI-22602
> https://issues.apache.org/jira/browse/AMBARI-22602
>
>
> Repository: ambari
>
>
> Description
> ---
>
> AMBARI-22198 added "stack settings", and AMBARI-22196 introduced "cluster
> settings" in Ambari.
>
> This review adds 2 new parameters to Execution Command : **(1).**
> clusterSettings and **(2).** stackSettings, and adds their respective set of
> key-values pairs.
>
> - This enables these parameters to be passed in to the ambari-agent's
> **command*.json**.
>
>
> Test cases are tracked in : AMBARI-22603
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
> 5ee4bf6
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
> e7dea06
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> 59e6622
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
> 9043297
>
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
> 8bd24f2
>
>
> Diff: https://reviews.apache.org/r/64397/diff/1/
>
>
> Testing
> ---
>
> Tested on Live cluster doing following :
> (1). Start Service
> (2). Restart Service
> (3). Stop Service
> (4). Refreshing client configs
> (5). Adding Client.
>
>
> **Snippet from command*.json as part of testing:**
> {
> ...
> ...
> "clusterSettings": {
> "security_enabled": "false",
> "hide_yarn_memory_widget": "false",
> "enable_external_ranger": "false",
> "override_uid": "true",
> "kerberos_domain": "EXAMPLE.COM",
> "one_dir_per_partition": "false",
> "repo_ubuntu_template": "{{package_type}} {{base_url}}
> {{components}}",
> "ignore_groupsusers_create": "false",
> "alerts_repeat_tolerance": "1",
> "namenode_rolling_restart_timeout": "4200",
> "fetch_nonlocal_groups": "true",
> "manage_dirs_on_root": "true",
> "recovery_lifetime_max_count": "1024",
> "agent_mounts_ignore_list": "",
> "ignore_bad_mounts": "false",
> "recovery_window_in_minutes": "60",
> "sysprep_skip_copy_tarballs_hdfs": "false",
> "recovery_type": "AUTO_START",
> "user_group": "hadoop",
> "namenode_rolling_restart_safemode_exit_timeout": "3600",
> "recovery_retry_interval": "5",
> "sysprep_skip_copy_oozie_share_lib_to_hdfs": "false",
> "sysprep_skip_setup_jce": "false",
> "manage_hive_fsroot": "true",
> "service_check_type": "full",
> "recovery_enabled": "true",
> "recovery_max_count": "6",
> "sysprep_skip_create_users_and_groups": "false",
> "smokeuser_keytab": "/etc/security/keytabs/smokeuser.headless.keytab",
> "managed_hdfs_resource_property_names": "false",
> "smokeuser": "ambari-qa",
> "sysprep_skip_copy_fast_jar_hdfs": "false"
> },
> ...
> ...
> ...
>
Re: Review Request 64024: AMBARI-22498. Remove trailing lines (if any) from llapstatus command before converting the o/p to JSON.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64024/#review191751
---
Ship it!
Ship It!
- Madhuvanthi Radhakrishnan
On Nov. 22, 2017, 8:31 a.m., Swapan Shridhar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64024/
> ---
>
> (Updated Nov. 22, 2017, 8:31 a.m.)
>
>
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
>
>
> Bugs: AMBARI-22498
> https://issues.apache.org/jira/browse/AMBARI-22498
>
>
> Repository: ambari
>
>
> Description
> ---
>
> **BACKGROUND:**
>
> - Existing code was removing extra lines from the beginning which may come
> because of MOTD.
> - Similar issue can happen if there are extra lines as the end, which if
> passed in for converting to JSON will fail.
>
>
> Example: of extra lines at beginning and end sandwiching the JSOn structure
> which needs to be parsed
>
> ===
> Hortonworks #
> This is MOTD message, added for testing in qe infra
> {
> "amInfo" : {
> "appName" : "llap",
> "appType" : "org-apache-slider",
> "appId" : "application_1455662455106_10882",
> "containerId" : "container_e14_1455662455106_10882_01_01",
> "hostname" : "HOST_REPLACED",
> "amWebUrl" : "http://HOST_REPLACED:1025/";
> },
> "state" : "RUNNING_ALL",
> "originalConfigurationPath" :
> "hdfs://HOST_REPLACED:8020/user/USER_REPLACED/.slider/cluster/llap/snapshot",
> "generatedConfigurationPath" :
> "hdfs://HOST_REPLACED:8020/user/USER_REPLACED/.slider/cluster/llap/generated",
> "desiredInstances" : 3,
> "liveInstances" : 3,
> "appStartTime" : 1459625802169,
> "llapInstances" : [ {
> "hostname" : "HOST_REPLACED",
> "containerId" : "container_e14_1455662455106_10882_01_03",
> "statusUrl" : "http://HOST_REPLACED:15002/status";,
> "webUrl" : "http://HOST_REPLACED:15002";,
> "rpcPort" : 15001,
> "mgmtPort" : 15004,
> "shufflePort" : 15551
> }, {
> "hostname" : "HOST_REPLACED",
> "containerId" : "container_e14_1455662455106_10882_01_02",
> "statusUrl" : "http://HOST_REPLACED:15002/status";,
> "webUrl" : "http://HOST_REPLACED:15002";,
> "rpcPort" : 15001,
> "mgmtPort" : 15004,
> "shufflePort" : 15551
> }, {
> "hostname" : "HOST_REPLACED",
> "containerId" : "container_e14_1455662455106_10882_01_04",
> "statusUrl" : "http://HOST_REPLACED:15002/status";,
> "webUrl" : "http://HOST_REPLACED:15002";,
> "rpcPort" : 15001,
> "mgmtPort" : 15004,
> "shufflePort" : 15551
> } ]
> }
>
> # THIS IS A DUMMY TRAILING MESSAGE 1
> # THIS IS A DUMMY TRAILING MESSAGE 2
>
> ===
>
>
> **Fix:**
> Added code to remove the trailing lines as well.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
> 57cbcd0
>
> ambari-server/src/test/python/stacks/2.5/HIVE/running_withMOTDmsg_andTrailingMsg.txt
> PRE-CREATION
> ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py
> cf79ec7
>
>
> Diff: https://reviews.apache.org/r/64024/diff/1/
>
>
> Testing
> ---
>
> - UT added having begginning and end extra lines. Passes.
> - Tested on live cluster with no begginning and trailing message.
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 63965: New endpoint service_config_version for creating new config versions via service endpoint instead of cluster update
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63965/ --- (Updated Nov. 22, 2017, 5:47 p.m.) Review request for Ambari, Jayush Luniya, Swapan Shridhar, and Vitalyi Brodetskyi. Changes --- Review comments incorporated Bugs: AMBARI-22487 https://issues.apache.org/jira/browse/AMBARI-22487 Repository: ambari Description --- Create new service config version POST api/v2/clusters//servicegroups//services//configurations/service_config_versions Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/ConfigurationService.java 79128a2374 ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceConfigVersionService.java c6e320121f ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java b5bc813e9c ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 875d9b6f9f ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionRequest.java 29a7a421cd ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java cbc08ebdf4 Diff: https://reviews.apache.org/r/63965/diff/2/ Changes: https://reviews.apache.org/r/63965/diff/1-2/ Testing --- mvn clean install -DskipTests=true -Dmaven.test.skip=true -X [INFO] Reactor Summary: [INFO] [INFO] Ambari Main SUCCESS [ 20.681 s] [INFO] Apache Ambari Project POM .. SUCCESS [ 0.047 s] [INFO] Ambari Web . SUCCESS [ 59.888 s] [INFO] Ambari Views ... SUCCESS [ 1.454 s] [INFO] Ambari Admin View .. SUCCESS [ 9.794 s] [INFO] ambari-utility . SUCCESS [ 4.461 s] [INFO] ambari-metrics . SUCCESS [ 1.585 s] [INFO] Ambari Metrics Common .. SUCCESS [ 5.107 s] [INFO] Ambari Metrics Hadoop Sink . SUCCESS [ 3.697 s] [INFO] Ambari Metrics Flume Sink .. SUCCESS [ 3.057 s] [INFO] Ambari Metrics Kafka Sink .. SUCCESS [ 3.088 s] [INFO] Ambari Metrics Storm Sink .. SUCCESS [ 2.462 s] [INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [ 2.196 s] [INFO] Ambari Metrics Collector ... SUCCESS [ 20.644 s] [INFO] Ambari Metrics Monitor . SUCCESS [ 2.597 s] [INFO] Ambari Metrics Grafana . SUCCESS [ 5.799 s] [INFO] Ambari Metrics Host Aggregator . SUCCESS [ 5.548 s] [INFO] Ambari Metrics Assembly SUCCESS [01:48 min] [INFO] Ambari Service Advisor . SUCCESS [ 0.614 s] [INFO] Ambari Server .. SUCCESS [03:49 min] [INFO] Ambari Functional Tests SUCCESS [ 0.494 s] [INFO] Ambari Agent ... SUCCESS [ 50.352 s] [INFO] Ambari Client .. SUCCESS [ 0.100 s] [INFO] Ambari Python Client ... SUCCESS [ 0.896 s] [INFO] Ambari Groovy Client ... SUCCESS [ 1.600 s] [INFO] Ambari Shell ... SUCCESS [ 0.101 s] [INFO] Ambari Python Shell SUCCESS [ 0.699 s] [INFO] Ambari Groovy Shell SUCCESS [ 0.756 s] [INFO] ambari-logsearch ... SUCCESS [ 3.196 s] [INFO] Ambari Logsearch Appender .. SUCCESS [ 0.303 s] [INFO] Ambari Logsearch Config Api SUCCESS [ 0.242 s] [INFO] Ambari Logsearch Config Zookeeper .. SUCCESS [ 0.352 s] [INFO] Ambari Logsearch Log Feeder SUCCESS [ 4.504 s] [INFO] Ambari Logsearch Web ... SUCCESS [01:10 min] [INFO] Ambari Logsearch Server SUCCESS [ 8.842 s] [INFO] Ambari Logsearch Assembly .. SUCCESS [ 0.206 s] [INFO] Ambari Logsearch Integration Test .. SUCCESS [ 0.299 s] [INFO] ambari-infra ... SUCCESS [ 0.198 s] [INFO] Ambari Infra Solr Client ... SUCCESS [ 2.149 s] [INFO] Ambari Infra Solr Plugin ... SUCCESS [ 0.445 s] [INFO] Ambari Infra Manager ... SUCCESS [ 8.802 s] [INFO] Ambari Infra Solr Assembly . SUCCESS [ 0.214 s] [INFO]
Re: Review Request 63937: AMBARI-22472. Ambari Upgrade 2.5 -> 2.6 : Update NodeManager's HSI identity 'llap_zk_hive' and 'llap_task_hive' to use '/HIVE/HIVE_SERVER/hive_server_hive' reference instead
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63937/#review191745
---
Ship it!
Ship It!
- Madhuvanthi Radhakrishnan
On Nov. 22, 2017, 12:13 a.m., Swapan Shridhar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63937/
> ---
>
> (Updated Nov. 22, 2017, 12:13 a.m.)
>
>
> Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and
> Robert Levas.
>
>
> Bugs: AMBARI-22472
> https://issues.apache.org/jira/browse/AMBARI-22472
>
>
> Repository: ambari
>
>
> Description
> ---
>
> **Background:**
> YARN NodeManager currently has:
>
> - 2 identities in 2.5 stack, namely :
> **'/HIVE/HIVE_SERVER/hive_server_hive'** and **'llap_zk_hive'**.
> -- **/HIVE/HIVE_SERVER/hive_server_hive** is a reference from HIVE_SERVER,
> whereas
> -- **llap_zk_hive** creates same principal as above in a separate keytab file.
>
> - and 3 identities in 2.6 stack:
> *'/HIVE/HIVE_SERVER/hive_server_hive'* and *'llap_zk_hive'*.
> -- **/HIVE/HIVE_SERVER/hive_server_hive** is a reference from HIVE_SERVER,
> whereas
> -- **llap_zk_hive** and **llap_task_hive** creates same principal as above in
> a separate keytab file.
>
> **Issue:** Recreating same identities in different files creates issues while
> AMbari upgrade from 2.5 to 2.6, as the *llap_zk_hive* are not
> refreshed/updated after the upgrade. Thus, HSI fails to come up.
>
> **Fix:**
>
> **For HDP 2.5:** Make **llap_zk_hive** point as a reference pointing to
> /HIVE/HIVE_SERVER/hive_server_hive, so that we have one identity getting
> created only at one place and one keytab file.
>
> **For HDP 2.6:** Make **llap_zk_hive** and **llap_task_hive** point as a
> reference pointing to /HIVE/HIVE_SERVER/hive_server_hive, so that we have one
> identity getting created only at one place and one keytab file.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> 96ce807
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json
> af6bda6
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/kerberos.json
> e0417bf
>
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
> be04cd5
>
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_ranger_kms.json
> e17e121
>
>
> Diff: https://reviews.apache.org/r/63937/diff/3/
>
>
> Testing
> ---
>
> **TESTING:**
>
> || Ambari 2.5, HDP 2.5 before upgrade:
> ||
>
>
> {code:title=From /etc/hive2/cong/conf.server/hive-site.xml}
>
> hive.llap.daemon.keytab.file
> /etc/security/keytabs/hive.service.keytab
>
>
>
> hive.llap.daemon.service.principal
> hive/_h...@example.com
>
>
>
> hive.llap.zk.sm.keytab.file
> /etc/security/keytabs/hive.llap.zk.sm.keytab
>
>
>
> hive.llap.zk.sm.principal
> hive/_h...@example.com
>
> {code}
>
>
> ||Upgrade to Ambari-2.6
> ||
>
>
> **Logs: Ambari Server Upgrade**
>
> [root@swap-qqq-1 ~]# ambari-server upgrade
> Using python /usr/bin/python
> Upgrading ambari-server
> INFO: Upgrade Ambari Server
> INFO: Updating Ambari Server properties in ambari.properties ...
> INFO: Updating Ambari Server properties in ambari-env.sh ...
> WARNING: Original file ambari-env.sh kept
> INFO: Fixing database objects owner
> Ambari Server configured for Embedded Postgres. Confirm you have made a
> backup of the Ambari Server database [y/n] (y)? y
> INFO: Upgrading database schema
> INFO: Return code from schema upgrade command, retcode = 0
> INFO: Schema upgrade completed
> Adjusting ambari-server permissions and ownership...
> Ambari Server 'upgrade' completed successfully.
> [root@swap-qqq-1 ~]#
> [root@swap-qqq-1 ~]#
> [root@swap-qqq-1 ~]#
> [root@swap-qqq-1 ~]#
> [root@swap-qqq-1 ~]# ambari-server --version
> 2.6.0.0-267
> [root@swap-qqq-1 ~]#
>
>
> **Logs : Updating Kerberos descriptors**
>
> 21 Nov 2017 01:01:20,438 INFO [main] UpgradeCatalog260:675 - Updating YARN's
> HSI Kerberos Descriptor
> 21 Nov 20
Re: Review Request 64005: Fix build for test classes in feature branch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64005/#review191669 --- Ship it! Ship It! - Madhuvanthi Radhakrishnan On Nov. 21, 2017, 10:45 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64005/ > --- > > (Updated Nov. 21, 2017, 10:45 p.m.) > > > Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. > > > Bugs: AMBARI-22493 > https://issues.apache.org/jira/browse/AMBARI-22493 > > > Repository: ambari > > > Description > --- > > Fixed build process with test classes. Test classes were fixed with > workarounds. > > > Diffs > - > > ambari-server/pom.xml e15e23e > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java > fb84df5 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionSchedulerThreading.java > 96269f8 > > ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java > b3c4e26 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java > 20ff949 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java > 374774a > > ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java > b47a25d > > ambari-server/src/test/java/org/apache/ambari/server/api/services/ComponentServiceTest.java > e4285d0 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/ConfigurationServiceTest.java > 679e645 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/ServiceServiceTest.java > a5bb5e7 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java > bc82999 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentsInstallationCheckTest.java > 0e57966 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java > 4d00644 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/RecoveryConfigHelperTest.java > 7b8bd8b > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > 883e891 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > a5f83af > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 44b46f4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java > 3d8d161 > > ambari-server/src/test/java/org/apache/ambari/server/controller/ClusterResponseTest.java > c9e91e3 > > ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java > ef186f1 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java > 7165e48 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 22b0e6b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java > 833be5d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java > 4a80893 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java > 110e359 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java > 78f79ea > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequestTest.java > e1f5583 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java > 7e32c15 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java > fd28081 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java > e19ad29 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java > 5ed582f > > ambari-server/src/test/java/org/apac
Review Request 63965: New endpoint service_config_version for creating new config versions via service endpoint instead of cluster update
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63965/ --- Review request for Ambari, Jayush Luniya, Swapan Shridhar, and Vitalyi Brodetskyi. Bugs: AMBARI-22487 https://issues.apache.org/jira/browse/AMBARI-22487 Repository: ambari Description --- Create new service config version POST api/v2/clusters//servicegroups//services//configurations/service_config_versions Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/ConfigurationService.java 79128a2374 ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceConfigVersionService.java c6e320121f ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java b5bc813e9c ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 875d9b6f9f ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionRequest.java 29a7a421cd ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java cbc08ebdf4 Diff: https://reviews.apache.org/r/63965/diff/1/ Testing --- mvn clean install -DskipTests=true -Dmaven.test.skip=true -X [INFO] Reactor Summary: [INFO] [INFO] Ambari Main SUCCESS [ 20.681 s] [INFO] Apache Ambari Project POM .. SUCCESS [ 0.047 s] [INFO] Ambari Web . SUCCESS [ 59.888 s] [INFO] Ambari Views ... SUCCESS [ 1.454 s] [INFO] Ambari Admin View .. SUCCESS [ 9.794 s] [INFO] ambari-utility . SUCCESS [ 4.461 s] [INFO] ambari-metrics . SUCCESS [ 1.585 s] [INFO] Ambari Metrics Common .. SUCCESS [ 5.107 s] [INFO] Ambari Metrics Hadoop Sink . SUCCESS [ 3.697 s] [INFO] Ambari Metrics Flume Sink .. SUCCESS [ 3.057 s] [INFO] Ambari Metrics Kafka Sink .. SUCCESS [ 3.088 s] [INFO] Ambari Metrics Storm Sink .. SUCCESS [ 2.462 s] [INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [ 2.196 s] [INFO] Ambari Metrics Collector ... SUCCESS [ 20.644 s] [INFO] Ambari Metrics Monitor . SUCCESS [ 2.597 s] [INFO] Ambari Metrics Grafana . SUCCESS [ 5.799 s] [INFO] Ambari Metrics Host Aggregator . SUCCESS [ 5.548 s] [INFO] Ambari Metrics Assembly SUCCESS [01:48 min] [INFO] Ambari Service Advisor . SUCCESS [ 0.614 s] [INFO] Ambari Server .. SUCCESS [03:49 min] [INFO] Ambari Functional Tests SUCCESS [ 0.494 s] [INFO] Ambari Agent ... SUCCESS [ 50.352 s] [INFO] Ambari Client .. SUCCESS [ 0.100 s] [INFO] Ambari Python Client ... SUCCESS [ 0.896 s] [INFO] Ambari Groovy Client ... SUCCESS [ 1.600 s] [INFO] Ambari Shell ... SUCCESS [ 0.101 s] [INFO] Ambari Python Shell SUCCESS [ 0.699 s] [INFO] Ambari Groovy Shell SUCCESS [ 0.756 s] [INFO] ambari-logsearch ... SUCCESS [ 3.196 s] [INFO] Ambari Logsearch Appender .. SUCCESS [ 0.303 s] [INFO] Ambari Logsearch Config Api SUCCESS [ 0.242 s] [INFO] Ambari Logsearch Config Zookeeper .. SUCCESS [ 0.352 s] [INFO] Ambari Logsearch Log Feeder SUCCESS [ 4.504 s] [INFO] Ambari Logsearch Web ... SUCCESS [01:10 min] [INFO] Ambari Logsearch Server SUCCESS [ 8.842 s] [INFO] Ambari Logsearch Assembly .. SUCCESS [ 0.206 s] [INFO] Ambari Logsearch Integration Test .. SUCCESS [ 0.299 s] [INFO] ambari-infra ... SUCCESS [ 0.198 s] [INFO] Ambari Infra Solr Client ... SUCCESS [ 2.149 s] [INFO] Ambari Infra Solr Plugin ... SUCCESS [ 0.445 s] [INFO] Ambari Infra Manager ... SUCCESS [ 8.802 s] [INFO] Ambari Infra Solr Assembly . SUCCESS [ 0.214 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 10:47 min [INFO] Finished
Review Request 63923: Unable to enable hdfs, hive plugin in ranger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63923/ --- Review request for Ambari, Jayush Luniya, Swapan Shridhar, and Vitalyi Brodetskyi. Bugs: AMBARI-22468 https://issues.apache.org/jira/browse/AMBARI-22468 Repository: ambari Description --- Exception in stack recommendation call due to null pointer for streamline-env configuration Diffs - ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py a16fdb737a Diff: https://reviews.apache.org/r/63923/diff/1/ Testing --- Enabled Hive and HDFS plugin successfully. Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 63819: Ambari Infra, AMS, LogSearch are missing from list of services to be installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63819/#review191017 --- Ship it! Ship It! - Madhuvanthi Radhakrishnan On Nov. 14, 2017, 11:43 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63819/ > --- > > (Updated Nov. 14, 2017, 11:43 p.m.) > > > Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. > > > Bugs: AMBARI-22447 > https://issues.apache.org/jira/browse/AMBARI-22447 > > > Repository: ambari > > > Description > --- > > Ambari Infra service is missing from list of services to be installed, This > is one of the necessary services for Atlas and Ranger, other-wise need to > setup Solr manually. > > > Diffs > - > > > ambari-server/src/main/resources/stacks/HDP/3.0/services/AMBARI_INFRA/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/3.0/services/AMBARI_METRICS/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/3.0/services/LOGSEARCH/metainfo.xml > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63819/diff/1/ > > > Testing > --- > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/#review190398
---
Ship it!
Ship It!
- Madhuvanthi Radhakrishnan
On Nov. 7, 2017, 11:59 p.m., Swapan Shridhar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63573/
> ---
>
> (Updated Nov. 7, 2017, 11:59 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
>
>
> Bugs: AMBARI-22366
> https://issues.apache.org/jira/browse/AMBARI-22366
>
>
> Repository: ambari
>
>
> Description
> ---
>
> AMBARI-22366. POST, GET and UPDATE API for cluster settings.
> (/clusters/{clusterName}/settings).
>
> **Background:** AMBARI-22196 did the following :
> (1). Refactoring work of moving all cluster related configs/settings in
> cluster-env to "cluster-settings" files.
> (2). Implementing READ only API to access *cluster-settings* file
> *setting(s)* : *http://:/api/v1/cluster_settings/ *
>
> - This was done to separate cluster related configs from stack related
> configs.
>
> **This JIRA implements the following :**
>
> - POST, GET, UPDATE and DELETE APIs for cluster settings with endpoint :
> *http://:/api/v1/clusters/[[clusterName]]/settings*, where
>-- the cluster settings would be initially read from the above mentioned
> read-only API : *http://:/api/v1/cluster_settings/*.
>
> - Further, added cluster *settings* as a sub-resource of *cluster* resource.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/ClusterSettingNotFoundException.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
> e5680dd
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
> 6096fa5
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
> 92f50f4
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
> 358b1bf
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> 370f735
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingRequest.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingResponse.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
> 3db55d4
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
> 20f4864
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
> 147650c
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
> 9050e3d
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
> c219d23
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
> 2e935af
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
> bd6d7bb
>
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingEvent.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterSettingDAO.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
> abbf709
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntity.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntityPK.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
> 3b74e69
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java
> 5ba61b7
>
>
Re: Review Request 63457: Add service dependencies
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63457/#review190223
---
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
Lines 180 (patched)
<https://reviews.apache.org/r/63457/#comment267519>
Hi Vitaly,
Can you please fix the syntax error for this one in all the SQL files?
- Madhuvanthi Radhakrishnan
On Nov. 1, 2017, 12:20 a.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63457/
> ---
>
> (Updated Nov. 1, 2017, 12:20 a.m.)
>
>
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
>
>
> Bugs: AMBARI-22345
> https://issues.apache.org/jira/browse/AMBARI-22345
>
>
> Repository: ambari
>
>
> Description
> ---
>
> API:
> {code}
> POST
> http://SERVER:8080/api/v2/clusters/{cluster-id}/servicegroups/{sgId}/services
>
> Request
>
> {
> "ServiceInfo" : {
> "service_name" : "{service-name}",
> "service_display_name" : "{service-display-name}",
> "service_version" : "{service-version}",
> "stack_id" : "{stack-id}",
> "hosting_platform" : "Ambari|Yarn"
> }
> "dependencies" : [
> {
> "ServiceInfo" : {
> "service_id" : "{dependent-service-id}",
> "cluster_id" : "{dependent-cluster-id}",
> "service_group_id" : "{dependent-service-group-id}",
>}
> }
> ]
> }
> {code}
>
> DB:
> Add table {{servicedependencies}}
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
> 737b9b4
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceDependencyResourceDefinition.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceResourceDefinition.java
> 8255674
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceKey.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
> cb0ad20
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
> 3117186
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
> f75a7d5
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyResponse.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
> b8c1674
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
> cfab185
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
> 6a76fff
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java
> 9fca099
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java
> 8fd878e
> ambari-server/src/main/java/org/apache/ambari/server/state/Service.java
> b9ab79f
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java
> b48d825
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
> 167e4ca
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> 1e4d81f
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
> 0434728
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c
>
>
> Diff: https://reviews.apache.org/r/63457/diff/1/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/#review190208
---
ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java
Lines 138 (patched)
<https://reviews.apache.org/r/63573/#comment267493>
Hi,
Do we need to create events for Cluster Setting creation?
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql
Lines 179 (patched)
<https://reviews.apache.org/r/63573/#comment267499>
Hi,
I guess we can have just id to be the primary key. Another uniquness will
be cluster_id + setting_name in case of multi-cluster scenario.
Thanks.
- Madhuvanthi Radhakrishnan
On Nov. 6, 2017, 6:54 a.m., Swapan Shridhar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63573/
> ---
>
> (Updated Nov. 6, 2017, 6:54 a.m.)
>
>
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
>
>
> Bugs: AMBARI-22366
> https://issues.apache.org/jira/browse/AMBARI-22366
>
>
> Repository: ambari
>
>
> Description
> ---
>
> AMBARI-22366. POST, GET and UPDATE API for cluster settings.
> (/clusters/{clusterName}/settings).
>
> **Background:** AMBARI-22196 did the following :
> (1). Refactoring work of moving all cluster related configs/settings in
> cluster-env to "cluster-settings" files.
> (2). Implementing READ only API to access *cluster-settings* file
> *setting(s)* : *http://:/api/v1/cluster_settings/ *
>
> - This was done to separate cluster related configs from stack related
> configs.
>
> **This JIRA implements the following :**
>
> - POST, GET, UPDATE and DELETE APIs for cluster settings with endpoint :
> *http://:/api/v1/clusters/[[clusterName]]/settings*, where
>-- the cluster settings would be initially read from the above mentioned
> read-only API : *http://:/api/v1/cluster_settings/*.
>
> - Further, added cluster *settings* as a sub-resource of *cluster* resource.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/ClusterSettingNotFoundException.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
> e5680dd
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
> 6096fa5
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
> 92f50f4
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
> 358b1bf
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> 370f735
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingRequest.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingResponse.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
> 3db55d4
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
> 20f4864
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
> 147650c
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
> 9050e3d
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
> c219d23
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
> 2e935af
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
> bd6d7bb
>
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java
> c88c514
>
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingEvent.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingIns
Re: Review Request 63034: AMBARI-22244. Update service component API call to work for second service instance
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63034/#review188379 --- Ship it! Ship It! - Madhuvanthi Radhakrishnan On Oct. 17, 2017, 6:34 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63034/ > --- > > (Updated Oct. 17, 2017, 6:34 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi > Radhakrishnan, Sandor Magyari, and Swapan Shridhar. > > > Bugs: AMBARI-22244 > https://issues.apache.org/jira/browse/AMBARI-22244 > > > Repository: ambari > > > Description > --- > > Replaced `serviceName` with `serviceType` in `getService` and `getComponent` > calls where found to be necessary. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java > ff13d0bc5334922e138ed622f9120a94c6c05883 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > bb298d5a5ceda4619de958c7a529101c6e4f2e3f > > ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java > 45cc97348e89cdf5bd73a5d4d6139f808bc23180 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 2bb450bd0ac6a0da064d892e74bbdd05e2475dd6 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java > 60230f6b9fe476deed40ed0f4083ec24bea742f5 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java > 69492574f8756006c9bd7aab495efb269265cfb7 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java > 5ecce88a84bb8897788fe881f0059fcb553c776f > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java > 0f6eb90803ca6b7a5fb9791294a269aaf4e45fb9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > ff35e8042846767adf858a112d0e9da729b81b84 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 58f1cbd464e3b4176cbc5535b92904cd27d8fb3b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > ca80961ab3634960e8f12cc56b876109afae33ec > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > ba5a4e78aebb49dbcc24d220c35abfd46fe3dbc0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > f7559c6d3422f4902e28b4f205564bc0ac0aaefa > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java > ba5fccc1dc1d6ace00ba0f9f36820b055a66ce3b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 252d7726e392307e1a8a0688b8de4e95e4982e8e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java > 8c2198bc185da616200bf2701acd4cb8a31f7022 > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java > 0cd55c31a90a17bcd3a8b17783156dc92b2a6a57 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java > cae330b3466982923deb388ac5323c67fffea02d > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java > e3f4e1a005c358ef5a7801691b56c9b91c9aaa11 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java > 603e650894ab27d12cbe2b9c49daf299e5818d5f > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java > 765e6fcaaa75086d2bc37e058b6e69e1268be8c2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java > 704b4b96fbe5b54a7c36c22280f27142c0a8cfe9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java > 5e23f0b592519746c111dd89afbda37a79c425b7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java > 6c5eab4090a18dce7
Re: Review Request 63034: AMBARI-22244. Update service component API call to work for second service instance
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63034/#review188326 --- ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java Line 78 (original), 78 (patched) <https://reviews.apache.org/r/63034/#comment265317> Do we not need to change here? - Madhuvanthi Radhakrishnan On Oct. 17, 2017, 1:46 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63034/ > --- > > (Updated Oct. 17, 2017, 1:46 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi > Radhakrishnan, Sandor Magyari, and Swapan Shridhar. > > > Bugs: AMBARI-22244 > https://issues.apache.org/jira/browse/AMBARI-22244 > > > Repository: ambari > > > Description > --- > > Replaced `serviceName` with `serviceType` in `getService` and `getComponent` > calls where found to be necessary. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > bb298d5a5ceda4619de958c7a529101c6e4f2e3f > > ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java > 45cc97348e89cdf5bd73a5d4d6139f808bc23180 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 2bb450bd0ac6a0da064d892e74bbdd05e2475dd6 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java > 60230f6b9fe476deed40ed0f4083ec24bea742f5 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java > 69492574f8756006c9bd7aab495efb269265cfb7 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java > 5ecce88a84bb8897788fe881f0059fcb553c776f > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java > 0f6eb90803ca6b7a5fb9791294a269aaf4e45fb9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > e12477eede7176a19b456294602f91d44a35ad61 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 28b5c28e848720191ddcdf142d52c862755eaab0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > ca80961ab3634960e8f12cc56b876109afae33ec > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > ba5a4e78aebb49dbcc24d220c35abfd46fe3dbc0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > f7559c6d3422f4902e28b4f205564bc0ac0aaefa > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java > ba5fccc1dc1d6ace00ba0f9f36820b055a66ce3b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 252d7726e392307e1a8a0688b8de4e95e4982e8e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java > 8c2198bc185da616200bf2701acd4cb8a31f7022 > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java > 0cd55c31a90a17bcd3a8b17783156dc92b2a6a57 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java > cae330b3466982923deb388ac5323c67fffea02d > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java > e3f4e1a005c358ef5a7801691b56c9b91c9aaa11 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java > 603e650894ab27d12cbe2b9c49daf299e5818d5f > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java > 765e6fcaaa75086d2bc37e058b6e69e1268be8c2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java > 704b4b96fbe5b54a7c36c22280f27142c0a8cfe9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java > 5e23f0b592519746c111dd89afbda37a79c425b7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieSer
Re: Review Request 62856: Remove cluster-stackid dependency related to Configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62856/ --- (Updated Oct. 12, 2017, 11:47 p.m.) Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan Shridhar. Changes --- Review comments Bugs: AMBARI-22181 https://issues.apache.org/jira/browse/AMBARI-22181 Repository: ambari Description --- Remove cluster-stackid dependency related to Configs Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java 6726d30e80 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d0dd7e0d9c ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 98b1edf6a4 ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java 29f8e2acbd ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java bb7fcbed3d ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java cf556609a4 ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8f9d8e1b0b ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 3bde889b4b Diff: https://reviews.apache.org/r/62856/diff/3/ Changes: https://reviews.apache.org/r/62856/diff/2-3/ Testing --- [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 11:01 min [INFO] Finished at: 2017-10-09T21:40:34-07:00 [INFO] Final Memory: 359M/1174M [INFO] Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 62856: Remove cluster-stackid dependency related to Configs
> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
> > Line 664 (original), 664 (patched)
> > <https://reviews.apache.org/r/62856/diff/1/?file=1850078#file1850078line664>
> >
> > We have to look at references to this function and see how the
> > servicesMap is populated.
> >
> > For example in configHelper.createUserGroupMap() we will end up
> > creating user to group mapping only for a single mpack instead of multiple
> > mpacks.
>
> Madhuvanthi Radhakrishnan wrote:
> Hi Jayush,
> The reason I went ahead with the change was that all the references to
> this and its overloaded counterpart populates servicesMap based on a stackId
> that is obtained from either a service or a serviceComponent. So it seemed
> that it is not coming from the cluster's stackid.
> For eg:
> AmbariManagementControllerImpl
> StackId stackId = scHost.getServiceComponent().getDesiredStackId();
> StackInfo stackInfo = ambariMetaInfo.getStack(stackId.getStackName(),
> stackId.getStackVersion());
> Map servicesMap =
> ambariMetaInfo.getServices(stackInfo.getName(), stackInfo.getVersion());
> Map> userGroupsMap = configHelper.createUserGroupsMap(
> cluster, clusterDesiredConfigs, servicesMap, stackProperties);
>
> public Map> createUserGroupsMap(
> Cluster cluster, Map desiredConfigs,
> Map servicesMap, Set
> stackProperties) throws AmbariException {
I have made a fix in createHostAction to the way the servicesMap is being
populated.
Currently, it is using service stackId to get the serviceInfo list from the
ambariMetaInfo.
I have changed it to put all the cluster services in the servicesMap.
- Madhuvanthi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/#review187503
---
On Oct. 12, 2017, 11:47 p.m., Madhuvanthi Radhakrishnan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62856/
> ---
>
> (Updated Oct. 12, 2017, 11:47 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan
> Shridhar.
>
>
> Bugs: AMBARI-22181
> https://issues.apache.org/jira/browse/AMBARI-22181
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Remove cluster-stackid dependency related to Configs
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
> 6726d30e80
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
> d0dd7e0d9c
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> 98b1edf6a4
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
> 29f8e2acbd
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
> bb7fcbed3d
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
> cf556609a4
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
> 8f9d8e1b0b
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> 3bde889b4b
>
>
> Diff: https://reviews.apache.org/r/62856/diff/3/
>
>
> Testing
> ---
>
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 11:01 min
> [INFO] Finished at: 2017-10-09T21:40:34-07:00
> [INFO] Final Memory: 359M/1174M
> [INFO]
>
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62802/#review187693
---
Ship it!
Ship It!
- Madhuvanthi Radhakrishnan
On Oct. 11, 2017, 8:24 p.m., Swapan Shridhar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62802/
> ---
>
> (Updated Oct. 11, 2017, 8:24 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
>
>
> Bugs: AMBARI-22196
> https://issues.apache.org/jira/browse/AMBARI-22196
>
>
> Repository: ambari
>
>
> Description
> ---
>
> **Following done as part of this JIRA:**
>
> - Move all non-stack specific configs in **cluster-env.xml** to
> **cluster-settings.xml**.
> - For example **cluster-env/security_enabled** is a cluster setting and
> shouldn't be associated with any **stack/mpack**.
> {code}
>
> security_enabled
> false
> Hadoop Security
>
>
> {code}
>
> - Add new file as : **/var/lib/ambari-server/resources/cluster-settings.xml**
> which includes all the read only cluster specific settings.
>
>
> - **New API Endpoint serving the cluster-settings** : api/v1/cluster_settings
>
>
> **Followup work :**
>
> - **AMBARI-22197** takes care of removing **cluster-env.xml** and associated
> code and API once we have **AMBARI-22198** completed.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/PropertyNotFoundException.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/ResourcesPathNotFoundException.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
> 7431f9d
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootClusterSettingsResourceDefinition.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
> fd15105
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootClusterSettingService.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
> 67d3a15
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
> f2c4c52
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> e9fa8db
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
> c56483d
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ReadOnlyConfigurationResponse.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootClusterSettingRequest.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
> fb31c19
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationRequest.java
> ea67207
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
> d33b5cb
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
> 0c5a579
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootClusterSettingsResourceProvider.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
> f8feef2
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
> 6f5b0f8
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
> 819507b
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
> a364c4c
>
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManager.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManagerFactory.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
> bb7fcbe
>
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java
> 63c850e
> ambari-server/src/main/resour
Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62802/#review187688
---
Ship it!
Ship It!
- Madhuvanthi Radhakrishnan
On Oct. 11, 2017, 8:13 a.m., Swapan Shridhar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62802/
> ---
>
> (Updated Oct. 11, 2017, 8:13 a.m.)
>
>
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
>
>
> Bugs: AMBARI-22196
> https://issues.apache.org/jira/browse/AMBARI-22196
>
>
> Repository: ambari
>
>
> Description
> ---
>
> **Following done as part of this JIRA:**
>
> - Move all non-stack specific configs in **cluster-env.xml** to
> **cluster-settings.xml**.
> - For example **cluster-env/security_enabled** is a cluster setting and
> shouldn't be associated with any **stack/mpack**.
> {code}
>
> security_enabled
> false
> Hadoop Security
>
>
> {code}
>
> - Add new file as : **/var/lib/ambari-server/resources/cluster-settings.xml**
> which includes all the read only cluster specific settings.
>
>
> - **New API Endpoint serving the cluster-settings** : api/v1/cluster_settings
>
>
> **Followup work :**
>
> - **AMBARI-22197** takes care of removing **cluster-env.xml** and associated
> code and API once we have **AMBARI-22198** completed.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/PropertyNotFoundException.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/ResourcesPathNotFoundException.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
> 7431f9d
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootClusterSettingsResourceDefinition.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
> fd15105
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootClusterSettingService.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
> 67d3a15
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
> f2c4c52
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> e9fa8db
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
> c56483d
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ReadOnlyConfigurationResponse.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootClusterSettingRequest.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
> fb31c19
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationRequest.java
> ea67207
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
> d33b5cb
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
> 0c5a579
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootClusterSettingsResourceProvider.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
> f8feef2
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
> 6f5b0f8
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
> 819507b
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
> a364c4c
>
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManager.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManagerFactory.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
> bb7fcbe
>
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java
> 63c850e
> ambari-server/src/main/resour
Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62895/#review187681 --- Ship it! We might want to add it to trunk itself. Thanks - Madhuvanthi Radhakrishnan On Oct. 11, 2017, 4:17 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62895/ > --- > > (Updated Oct. 11, 2017, 4:17 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jayush Luniya, and Madhuvanthi > Radhakrishnan. > > > Bugs: AMBARI-22209 > https://issues.apache.org/jira/browse/AMBARI-22209 > > > Repository: ambari > > > Description > --- > > Fix quick links in mpacks. > > > Diffs > - > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > 1cad4df > > > Diff: https://reviews.apache.org/r/62895/diff/1/ > > > Testing > --- > > will check tests after approve > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62802/#review187664
---
ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootClusterSettingsResourceDefinition.java
Lines 44 (patched)
<https://reviews.apache.org/r/62802/#comment264714>
Hi,
I guess we can remove this since clusterSettings will not have any
sub-resource.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootClusterSettingsResourceProvider.java
Lines 95 (patched)
<https://reviews.apache.org/r/62802/#comment264718>
Hi @Jayush,
Should it be getResourcesAuthorized?
- Madhuvanthi Radhakrishnan
On Oct. 11, 2017, 8:13 a.m., Swapan Shridhar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62802/
> ---
>
> (Updated Oct. 11, 2017, 8:13 a.m.)
>
>
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
>
>
> Bugs: AMBARI-22196
> https://issues.apache.org/jira/browse/AMBARI-22196
>
>
> Repository: ambari
>
>
> Description
> ---
>
> **Following done as part of this JIRA:**
>
> - Move all non-stack specific configs in **cluster-env.xml** to
> **cluster-settings.xml**.
> - For example **cluster-env/security_enabled** is a cluster setting and
> shouldn't be associated with any **stack/mpack**.
> {code}
>
> security_enabled
> false
> Hadoop Security
>
>
> {code}
>
> - Add new file as : **/var/lib/ambari-server/resources/cluster-settings.xml**
> which includes all the read only cluster specific settings.
>
>
> - **New API Endpoint serving the cluster-settings** : api/v1/cluster_settings
>
>
> **Followup work :**
>
> - **AMBARI-22197** takes care of removing **cluster-env.xml** and associated
> code and API once we have **AMBARI-22198** completed.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/PropertyNotFoundException.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/ResourcesPathNotFoundException.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
> 7431f9d
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootClusterSettingsResourceDefinition.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
> fd15105
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootClusterSettingService.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
> 67d3a15
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
> f2c4c52
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> e9fa8db
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
> c56483d
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ReadOnlyConfigurationResponse.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootClusterSettingRequest.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
> fb31c19
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationRequest.java
> ea67207
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
> d33b5cb
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
> 0c5a579
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootClusterSettingsResourceProvider.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
> f8feef2
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
> 6f5b0f8
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
> 819507b
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
> a364c4c
>
> ambari-server/src
Re: Review Request 62856: Remove cluster-stackid dependency related to Configs
> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > > Line 2445 (original), 2445 (patched) > > <https://reviews.apache.org/r/62856/diff/1/?file=1850075#file1850075line2445> > > > > I dont quite understand why we are iterating over all services to get > > the serviceType. For now this workaround is ok, but let's file a follow up > > JIRA for this to understand the logic correctly here. I have opened a follow up jira. - Madhuvanthi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62856/#review187503 ------- On Oct. 10, 2017, 8:09 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62856/ > --- > > (Updated Oct. 10, 2017, 8:09 p.m.) > > > Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan > Shridhar. > > > Bugs: AMBARI-22181 > https://issues.apache.org/jira/browse/AMBARI-22181 > > > Repository: ambari > > > Description > --- > > Remove cluster-stackid dependency related to Configs > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > 6726d30e80 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > d0dd7e0d9c > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > e9fa8db0d1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java > 29f8e2acbd > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > bb7fcbed3d > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java > 44d76afcd8 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java > cf556609a4 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > 8f9d8e1b0b > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 6b32d4c75e > > > Diff: https://reviews.apache.org/r/62856/diff/2/ > > > Testing > --- > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > -------- > [INFO] Total time: 11:01 min > [INFO] Finished at: 2017-10-09T21:40:34-07:00 > [INFO] Final Memory: 359M/1174M > [INFO] > > > > Thanks, > > Madhuvanthi Radhakrishnan > >
Re: Review Request 62856: Remove cluster-stackid dependency related to Configs
> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > > Line 616 (original), 619 (patched) > > <https://reviews.apache.org/r/62856/diff/1/?file=1850077#file1850077line619> > > > > Here > > Case 1: oldStack would be null if there are no services still added to > > the cluster. > > Case 2: oldStack will be set to the stack id of the last service in the > > list of cluster services. > > > > So the logic here looks wrong. > > > > I guess the logic to get stackProperties will go away once we break > > down cluster-env to cluster-settings and stack-settings. Ok. I will remove this change and revisit it later. - Madhuvanthi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62856/#review187503 --- On Oct. 10, 2017, 4:58 a.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62856/ > --- > > (Updated Oct. 10, 2017, 4:58 a.m.) > > > Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan > Shridhar. > > > Bugs: AMBARI-22181 > https://issues.apache.org/jira/browse/AMBARI-22181 > > > Repository: ambari > > > Description > --- > > Remove cluster-stackid dependency related to Configs > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > 6726d30e80 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > d0dd7e0d9c > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > e9fa8db0d1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java > 29f8e2acbd > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > ec4d383dee > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > bb7fcbed3d > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java > 44d76afcd8 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java > cf556609a4 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > 8f9d8e1b0b > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 6b32d4c75e > > > Diff: https://reviews.apache.org/r/62856/diff/1/ > > > Testing > --- > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > ---- > [INFO] Total time: 11:01 min > [INFO] Finished at: 2017-10-09T21:40:34-07:00 > [INFO] Final Memory: 359M/1174M > [INFO] > > > > Thanks, > > Madhuvanthi Radhakrishnan > >
Re: Review Request 62856: Remove cluster-stackid dependency related to Configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62856/ --- (Updated Oct. 10, 2017, 8:09 p.m.) Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan Shridhar. Changes --- Incorporated a few review comments Bugs: AMBARI-22181 https://issues.apache.org/jira/browse/AMBARI-22181 Repository: ambari Description --- Remove cluster-stackid dependency related to Configs Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java 6726d30e80 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d0dd7e0d9c ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e9fa8db0d1 ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java 29f8e2acbd ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java bb7fcbed3d ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 44d76afcd8 ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java cf556609a4 ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8f9d8e1b0b ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 6b32d4c75e Diff: https://reviews.apache.org/r/62856/diff/2/ Changes: https://reviews.apache.org/r/62856/diff/1-2/ Testing --- [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 11:01 min [INFO] Finished at: 2017-10-09T21:40:34-07:00 [INFO] Final Memory: 359M/1174M [INFO] Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 62856: Remove cluster-stackid dependency related to Configs
> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
> > Line 664 (original), 664 (patched)
> > <https://reviews.apache.org/r/62856/diff/1/?file=1850078#file1850078line664>
> >
> > We have to look at references to this function and see how the
> > servicesMap is populated.
> >
> > For example in configHelper.createUserGroupMap() we will end up
> > creating user to group mapping only for a single mpack instead of multiple
> > mpacks.
Hi Jayush,
The reason I went ahead with the change was that all the references to this and
its overloaded counterpart populates servicesMap based on a stackId that is
obtained from either a service or a serviceComponent. So it seemed that it is
not coming from the cluster's stackid.
For eg:
AmbariManagementControllerImpl
StackId stackId = scHost.getServiceComponent().getDesiredStackId();
StackInfo stackInfo = ambariMetaInfo.getStack(stackId.getStackName(),
stackId.getStackVersion());
Map servicesMap =
ambariMetaInfo.getServices(stackInfo.getName(), stackInfo.getVersion());
Map> userGroupsMap = configHelper.createUserGroupsMap(
cluster, clusterDesiredConfigs, servicesMap, stackProperties);
public Map> createUserGroupsMap(
Cluster cluster, Map desiredConfigs,
Map servicesMap, Set stackProperties)
throws AmbariException {
- Madhuvanthi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/#review187503
-----------
On Oct. 10, 2017, 4:58 a.m., Madhuvanthi Radhakrishnan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62856/
> ---
>
> (Updated Oct. 10, 2017, 4:58 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan
> Shridhar.
>
>
> Bugs: AMBARI-22181
> https://issues.apache.org/jira/browse/AMBARI-22181
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Remove cluster-stackid dependency related to Configs
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
> 6726d30e80
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
> d0dd7e0d9c
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> e9fa8db0d1
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
> 29f8e2acbd
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
> ec4d383dee
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
> bb7fcbed3d
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java
> 44d76afcd8
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
> cf556609a4
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
> 8f9d8e1b0b
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> 6b32d4c75e
>
>
> Diff: https://reviews.apache.org/r/62856/diff/1/
>
>
> Testing
> ---
>
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
> ----
> [INFO] Total time: 11:01 min
> [INFO] Finished at: 2017-10-09T21:40:34-07:00
> [INFO] Final Memory: 359M/1174M
> [INFO]
>
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62699/ --- (Updated Sept. 30, 2017, 5:31 a.m.) Review request for Ambari, Jayush Luniya and Swapan Shridhar. Changes --- Review comment Bugs: AMBARI-22100 https://issues.apache.org/jira/browse/AMBARI-22100 Repository: ambari Description --- Change temp directory for jceks file from service level to component level. Diffs (updated) - ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 8a433c83f4 Diff: https://reviews.apache.org/r/62699/diff/3/ Changes: https://reviews.apache.org/r/62699/diff/2-3/ Testing --- Ambari-2.6 HDP-2.6.0.0 Deploy Hive Deploy Oozie [root@storm-simple-patch-madhu-2 conf]# pwd /var/lib/ambari-agent/cred/conf [root@storm-simple-patch-madhu-2 conf]# ls hive_metastore hive_server mysql_server oozie_client oozie_server Run service checks Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62699/ --- (Updated Sept. 30, 2017, 5:03 a.m.) Review request for Ambari, Jayush Luniya and Swapan Shridhar. Changes --- Review comments Bugs: AMBARI-22100 https://issues.apache.org/jira/browse/AMBARI-22100 Repository: ambari Description --- Change temp directory for jceks file from service level to component level. Diffs (updated) - ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 8a433c83f4 Diff: https://reviews.apache.org/r/62699/diff/2/ Changes: https://reviews.apache.org/r/62699/diff/1-2/ Testing (updated) --- Ambari-2.6 HDP-2.6.0.0 Deploy Hive Deploy Oozie [root@storm-simple-patch-madhu-2 conf]# pwd /var/lib/ambari-agent/cred/conf [root@storm-simple-patch-madhu-2 conf]# ls hive_metastore hive_server mysql_server oozie_client oozie_server Run service checks Thanks, Madhuvanthi Radhakrishnan
Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62699/ --- Review request for Ambari, Jayush Luniya and Swapan Shridhar. Bugs: AMBARI-22100 https://issues.apache.org/jira/browse/AMBARI-22100 Repository: ambari Description --- Change temp directory for jceks file from service level to component level. Diffs - ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 8a433c83f4 Diff: https://reviews.apache.org/r/62699/diff/1/ Testing --- Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 62599: Remove user to group hardcoded logic in hooks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62599/#review186499 --- Ship it! - Madhuvanthi Radhakrishnan On Sept. 27, 2017, 9:52 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62599/ > --- > > (Updated Sept. 27, 2017, 9:52 p.m.) > > > Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. > > > Bugs: AMBARI-22068 > https://issues.apache.org/jira/browse/AMBARI-22068 > > > Repository: ambari > > > Description > --- > > We added feature to tag a user property with corresponding user-group > properties to which a user should be added. We no longer should need the > hardcoded logic in the hooks adding users to groups. This can be entirely > stack driven after we update the user config properties for all services. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml > e4aa21e > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml > 52a5e6a > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml > 4d33661 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml > 74d8600 > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml > f97ca98 > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml > 23b82e3 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml > f45199f > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-env.xml > ccbda1e > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml > 6393659 > > ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml > 733ca8b > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > bb671cc > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml > e292e6e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > b2c364c > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 54a62e2 > > ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-env.xml > 90ba1c8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml > ad81d66 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml > 680e81f > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/configuration/knox-env.xml > e1ca45a > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > e861b6e > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/configuration/mahout-env.xml > b2d60c6 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml > 7748176 > > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/configuration/oozie-env.xml > 0f67356 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml > cc62c8b > > ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/configuration/ranger-env.xml > ff44901 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml > e5c0673 > > ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/configuration/kms-env.xml > acecdfe > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml > 55d67cc > > ambari-server/src/main/resources/common-services/SPARK/2.2.0/configuration/livy-env.xml > cec8054 > > ambari-server/src/main/resources/common-services/SPARK/2.2.0/configuration/spark-env.xml > f980f9a > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml > 35d364f > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-env.xml >
Re: Review Request 62599: Remove user to group hardcoded logic in hooks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62599/#review186437 --- Ship it! Looks good. Thanks Vitaly! - Madhuvanthi Radhakrishnan On Sept. 26, 2017, 11:23 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62599/ > --- > > (Updated Sept. 26, 2017, 11:23 p.m.) > > > Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. > > > Bugs: AMBARI-22068 > https://issues.apache.org/jira/browse/AMBARI-22068 > > > Repository: ambari > > > Description > --- > > We added feature to tag a user property with corresponding user-group > properties to which a user should be added. We no longer should need the > hardcoded logic in the hooks adding users to groups. This can be entirely > stack driven after we update the user config properties for all services. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml > e4aa21e > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml > 52a5e6a > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml > 4d33661 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml > 74d8600 > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml > f97ca98 > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml > 23b82e3 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml > f45199f > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-env.xml > ccbda1e > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml > 6393659 > > ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml > 733ca8b > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > bb671cc > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml > e292e6e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > b2c364c > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 54a62e2 > > ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-env.xml > 90ba1c8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml > ad81d66 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml > 680e81f > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/configuration/knox-env.xml > e1ca45a > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > e861b6e > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/configuration/mahout-env.xml > b2d60c6 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml > 7748176 > > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/configuration/oozie-env.xml > 0f67356 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml > cc62c8b > > ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/configuration/ranger-env.xml > ff44901 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml > e5c0673 > > ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/configuration/kms-env.xml > acecdfe > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml > 55d67cc > > ambari-server/src/main/resources/common-services/SPARK/2.2.0/configuration/livy-env.xml > cec8054 > > ambari-server/src/main/resources/common-services/SPARK/2.2.0/configuration/spark-env.xml > f980f9a > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml > 35d364f > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/co
Re: Review Request 62599: Remove user to group hardcoded logic in hooks
> On Sept. 27, 2017, 12:20 a.m., Madhuvanthi Radhakrishnan wrote: > > Hi Vitaly, > > Kindly refer https://reviews.apache.org/r/56727/ to check the value of > > user_groups attribute. > > For eg: > > /resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml > > > > zeppelin_user > > zeppelin > > USER > > User zeppelin daemon runs as > > > > user > > false > > > > > > zeppelin-env > > zeppelin_group > > > > > > hadoop-env > > proxyuser_group > > > > > > > > > > > > > > Here, the user-group tag is able to tell the mapping between > > (zeppelin_group property in zeppellin-env file and proxyuser_group property > > in hadoop-env file) with the zeppelin_user. > > You can follow a similar pattern for the other services. > > Thanks for doing this. > > Jayush Luniya wrote: > @Madhu > I think we renamed to in the final patch. Can > you confirm? > > Vitalyi Brodetskyi wrote: > Jayush, you are right. I've tested my patch and it works with > Yes Jayush, my bad it is user-groups. I wanted to point out the and tags within the - Madhuvanthi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62599/#review186348 --- On Sept. 26, 2017, 11:23 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62599/ > --- > > (Updated Sept. 26, 2017, 11:23 p.m.) > > > Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. > > > Bugs: AMBARI-22068 > https://issues.apache.org/jira/browse/AMBARI-22068 > > > Repository: ambari > > > Description > --- > > We added feature to tag a user property with corresponding user-group > properties to which a user should be added. We no longer should need the > hardcoded logic in the hooks adding users to groups. This can be entirely > stack driven after we update the user config properties for all services. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml > e4aa21e > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml > 52a5e6a > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml > 4d33661 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml > 74d8600 > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml > f97ca98 > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml > 23b82e3 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml > f45199f > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-env.xml > ccbda1e > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml > 6393659 > > ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml > 733ca8b > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > bb671cc > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml > e292e6e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > b2c364c > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 54a62e2 > > ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-env.xml > 90ba1c8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml > ad81d66 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml > 680e81f > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/configuration/knox-env.xml > e1ca45a > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.
Re: Review Request 62599: Remove user to group hardcoded logic in hooks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62599/#review186348 --- Hi Vitaly, Kindly refer https://reviews.apache.org/r/56727/ to check the value of user_groups attribute. For eg: /resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml zeppelin_user zeppelin USER User zeppelin daemon runs as user false zeppelin-env zeppelin_group hadoop-env proxyuser_group Here, the user-group tag is able to tell the mapping between (zeppelin_group property in zeppellin-env file and proxyuser_group property in hadoop-env file) with the zeppelin_user. You can follow a similar pattern for the other services. Thanks for doing this. - Madhuvanthi Radhakrishnan On Sept. 26, 2017, 11:23 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62599/ > --- > > (Updated Sept. 26, 2017, 11:23 p.m.) > > > Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. > > > Bugs: AMBARI-22068 > https://issues.apache.org/jira/browse/AMBARI-22068 > > > Repository: ambari > > > Description > --- > > We added feature to tag a user property with corresponding user-group > properties to which a user should be added. We no longer should need the > hardcoded logic in the hooks adding users to groups. This can be entirely > stack driven after we update the user config properties for all services. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml > e4aa21e > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml > 52a5e6a > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml > 4d33661 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml > 74d8600 > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml > f97ca98 > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml > 23b82e3 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml > f45199f > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-env.xml > ccbda1e > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml > 6393659 > > ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml > 733ca8b > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > bb671cc > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml > e292e6e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > b2c364c > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 54a62e2 > > ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-env.xml > 90ba1c8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml > ad81d66 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml > 680e81f > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/configuration/knox-env.xml > e1ca45a > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > e861b6e > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/configuration/mahout-env.xml > b2d60c6 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml > 7748176 > > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/configuration/oozie-env.xml > 0f67356 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml > cc62c8b > > ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/configuration/ranger-env.xml > ff44901 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.
Re: Review Request 62224: NullPointerException during blueprint generation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62224/ --- (Updated Sept. 11, 2017, 10:16 p.m.) Review request for Ambari, Amarnath reddy pappu, Jayush Luniya, and Robert Nettleton. Changes --- Review comments. Bugs: AMBARI-21865 https://issues.apache.org/jira/browse/AMBARI-21865 Repository: ambari Description --- In an Namenode HA environment, export Blueprint throws NPE/Server Error for some missing configurations. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java b4e102737f Diff: https://reviews.apache.org/r/62224/diff/2/ Changes: https://reviews.apache.org/r/62224/diff/1-2/ Testing --- Installed Ambari-2.4.3 HDP-2.5.3.0. Added the properties to "Custom hdfs-site" dfs.nameservices=nonha,hacluster dfs.namenode.rpc-address.nonha=host-1.openstacklocal:8020 dfs.ha.namenodes.hacluster=nn1,nn2 dfs.namenode.rpc-address.hacluster.nn2=host-2.openstacklocal:8020 dfs.namenode.rpc-address.hacluster.nn1=host-tt-3.openstacklocal:8020 dfs.namenode.http-address.nonha=host-tt-1.openstacklocal:50070 dfs.client.failover.proxy.provider.hacluster=org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider dfs.nameservices.internal=nonha Added the fix/null-check and then exported the blueprint which was successful. Some properties will not be exported. Here is a snippet of the blueprint hdfs-site section "dfs.namenode.rpc-address.hacluster.nn2": "%HOSTGROUP::host_group_2%:8020", "dfs.namenode.rpc-address.hacluster.nn1": "%HOSTGROUP::host_group_3%:8020", "dfs.nameservices": "nonha,hacluster", "dfs.namenode.http-address.nonha": "host-1.openstacklocal:50070", "dfs.nameservices.internal": "nonha", "dfs.namenode.rpc-address": "%HOSTGROUP::host_group_1%:8020", "dfs.namenode.https-address": "%HOSTGROUP::host_group_1%:50470", "dfs.namenode.rpc-address.nonha": "host-1.openstacklocal:8020", "dfs.http.policy": "HTTP_ONLY", "dfs.client.failover.proxy.provider.hacluster": "org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider", "dfs.namenode.http-address": "%HOSTGROUP::host_group_1%:50070", "dfs.datanode.https.address": "0.0.0.0:50475", "dfs.ha.namenodes.hacluster": "nn1,nn2", "dfs.namenode.secondary.http-address": "%HOSTGROUP::host_group_2%:50090", "dfs.datanode.http.address": "0.0.0.0:50075" As you see because dfs.ha.namenodes.nonha does not exist, there will not be any properties like dfs.namenode.rpc-address.nonha. Thanks, Madhuvanthi Radhakrishnan
Review Request 62224: NullPointerException during blueprint generation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62224/ --- Review request for Ambari, Amarnath reddy pappu, Jayush Luniya, and Robert Nettleton. Bugs: AMBARI-21865 https://issues.apache.org/jira/browse/AMBARI-21865 Repository: ambari Description --- In an Namenode HA environment, export Blueprint throws NPE/Server Error for some missing configurations. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java b4e102737f Diff: https://reviews.apache.org/r/62224/diff/1/ Testing --- Installed Ambari-2.4.3 HDP-2.5.3.0. Added the properties to "Custom hdfs-site" dfs.nameservices=nonha,hacluster dfs.namenode.rpc-address.nonha=host-1.openstacklocal:8020 dfs.ha.namenodes.hacluster=nn1,nn2 dfs.namenode.rpc-address.hacluster.nn2=host-2.openstacklocal:8020 dfs.namenode.rpc-address.hacluster.nn1=host-tt-3.openstacklocal:8020 dfs.namenode.http-address.nonha=host-tt-1.openstacklocal:50070 dfs.client.failover.proxy.provider.hacluster=org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider dfs.nameservices.internal=nonha Added the fix/null-check and then exported the blueprint which was successful. Some properties will not be exported. Here is a snippet of the blueprint hdfs-site section "dfs.namenode.rpc-address.hacluster.nn2": "%HOSTGROUP::host_group_2%:8020", "dfs.namenode.rpc-address.hacluster.nn1": "%HOSTGROUP::host_group_3%:8020", "dfs.nameservices": "nonha,hacluster", "dfs.namenode.http-address.nonha": "host-1.openstacklocal:50070", "dfs.nameservices.internal": "nonha", "dfs.namenode.rpc-address": "%HOSTGROUP::host_group_1%:8020", "dfs.namenode.https-address": "%HOSTGROUP::host_group_1%:50470", "dfs.namenode.rpc-address.nonha": "host-1.openstacklocal:8020", "dfs.http.policy": "HTTP_ONLY", "dfs.client.failover.proxy.provider.hacluster": "org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider", "dfs.namenode.http-address": "%HOSTGROUP::host_group_1%:50070", "dfs.datanode.https.address": "0.0.0.0:50475", "dfs.ha.namenodes.hacluster": "nn1,nn2", "dfs.namenode.secondary.http-address": "%HOSTGROUP::host_group_2%:50090", "dfs.datanode.http.address": "0.0.0.0:50075" As you see because dfs.ha.namenodes.nonha does not exist, there will not be any properties like dfs.namenode.rpc-address.nonha. Thanks, Madhuvanthi Radhakrishnan
Review Request 61709: Ambari should expose whether a service is able to rolling-restart instead of hard coding service name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61709/ --- Review request for Ambari, Jaimin Jetly, Jayush Luniya, Koji Sekiguchi, and Sumit Mohanty. Bugs: AMBARI-21737 https://issues.apache.org/jira/browse/AMBARI-21737 Repository: ambari Description --- Add a new property called rollingRestartAllowed to metainfo.xml Existing logic of client components are not removed. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java 0b0a5da2b0 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java 764e394540 ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java a8a9a0faef ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/metainfo.xml f408ba38ac ambari-server/src/main/resources/common-services/KAFKA/0.8.1/metainfo.xml d322adc47b ambari-server/src/main/resources/properties.json 11ca7f678a ambari-web/app/mappers/stack_service_mapper.js 8931066f76 ambari-web/app/models/stack_service_component.js eb6f2dbff7 Diff: https://reviews.apache.org/r/61709/diff/1/ Testing --- [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 25:12 min [INFO] Finished at: 2017-08-17T00:01:59-07:00 [INFO] Final Memory: 85M/962M [INFO] Install ambari Deploy HDP Ensure no regression Kafka brokers allow rolling restart This property can be used for any other services which have components that are not clients but support rolling restart. Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61201/#review181844
---
Ship it!
Ship It!
- Madhuvanthi Radhakrishnan
On July 31, 2017, 9:06 p.m., Swapan Shridhar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61201/
> ---
>
> (Updated July 31, 2017, 9:06 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
>
>
> Bugs: AMBARI-21594
> https://issues.apache.org/jira/browse/AMBARI-21594
>
>
> Repository: ambari
>
>
> Description
> ---
>
> **ServiceGroup (SG)** : is defined as sub-resource of cluster. It would later
> be used to logically group a set of services (coming out of Management Pack
> selected).
>
> **Example of a Service groups can be a:**
> - “Core” Service Group containing HDFS and Zookeeper. This will be formed by
> default.
> - “Streaming” Service Group containing Kafka, Storm, Nifi.
> - “Data Science” Service Group containing Hive, Spark, Zeppelin.
> - “EDW” Service Group containing Hive, Spark.
>
> As part of this review, following has been implemented:
> - SG added as sub-resource of cluster.
> - GET, POST and DELETE API for SG.
>
>
>
> *API calls and response:*
>
> *1.*
>
> POST:
>
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups
> *Body :*
>
>
> [
> {
> "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "CORE"
> }
> },
> {
> "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "EDW"
> }
> }
> ]
>
>
> *Response:* 201 CREATED
>
>
> {
> "resources" : [
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE";,
> "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
> }
> },
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW";,
> "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 803,
> "service_group_name" : "EDW"
> }
> }
> ]
> }
>
>
> *2.*
> ===
> GET :
> ===
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/
>
> *Body:*
>
> []
>
>
> *Response:* 200 OK
>
>
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/";,
> "items" : [
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE";,
> "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "CORE"
> }
> },
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW";,
> "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "EDW"
> }
> }
> ]
> }
>
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE
>
> *Body:*
>
> []
>
>
> *Response:* 200 OK
>
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE";,
> "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
> }
> }
>
>
> *3.*
> ===
> DELETE:
> ===
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE
>
> *Body:*
>
> []
>
>
> *Response:* 200 OK
>
Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.
> On July 28, 2017, 10:47 p.m., Madhuvanthi Radhakrishnan wrote:
> > We also need to add ServiceGroupResourceProvider initialization in
> > DefaultProviderModule
>
> Swapan Shridhar wrote:
> I dont think that required, as I dont see CLuster, Service, HostComponent
> added there. Suggest ?
True, it does not break anything if added or not added. Since
DefaultResourceProvider defaults to getting the ResourceProvider from
AbstractControllerResourceProvider, if we define it in DefaultProviderModule it
need not go that extra step. You can mark this as fixed. Thank you.
- Madhuvanthi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61201/#review181741
---
On July 31, 2017, 6:53 a.m., Swapan Shridhar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61201/
> ---
>
> (Updated July 31, 2017, 6:53 a.m.)
>
>
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
>
>
> Bugs: AMBARI-21594
> https://issues.apache.org/jira/browse/AMBARI-21594
>
>
> Repository: ambari
>
>
> Description
> ---
>
> **ServiceGroup (SG)** : is defined as sub-resource of cluster. It would later
> be used to logically group a set of services (coming out of Management Pack
> selected).
>
> **Example of a Service groups can be a:**
> - “Core” Service Group containing HDFS and Zookeeper. This will be formed by
> default.
> - “Streaming” Service Group containing Kafka, Storm, Nifi.
> - “Data Science” Service Group containing Hive, Spark, Zeppelin.
> - “EDW” Service Group containing Hive, Spark.
>
> As part of this review, following has been implemented:
> - SG added as sub-resource of cluster.
> - GET, POST and DELETE API for SG.
>
>
>
> *API calls and response:*
>
> *1.*
>
> POST:
>
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups
> *Body :*
>
>
> [
> {
> "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "CORE"
> }
> },
> {
> "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "EDW"
> }
> }
> ]
>
>
> *Response:* 201 CREATED
>
>
> {
> "resources" : [
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE";,
> "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
> }
> },
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW";,
> "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 803,
> "service_group_name" : "EDW"
> }
> }
> ]
> }
>
>
> *2.*
> ===
> GET :
> ===
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/
>
> *Body:*
>
> []
>
>
> *Response:* 200 OK
>
>
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/";,
> "items" : [
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE";,
> "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "CORE"
> }
> },
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW";,
> "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "EDW"
> }
> }
> ]
> }
>
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE
>
> *Body:*
>
> []
>
>
> *Response:* 200 OK
>
> {
> "href&q
Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61201/#review181741
---
We also need to add ServiceGroupResourceProvider initialization in
DefaultProviderModule
- Madhuvanthi Radhakrishnan
On July 28, 2017, 10 p.m., Swapan Shridhar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61201/
> ---
>
> (Updated July 28, 2017, 10 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
>
>
> Bugs: AMBARI-21594
> https://issues.apache.org/jira/browse/AMBARI-21594
>
>
> Repository: ambari
>
>
> Description
> ---
>
> **ServiceGroup (SG)** : is defined as sub-resource of cluster. It would later
> be used to logically group a set of services (coming out of Management Pack
> selected).
>
> **Example of a Service groups can be a:**
> - “Core” Service Group containing HDFS and Zookeeper. This will be formed by
> default.
> - “Streaming” Service Group containing Kafka, Storm, Nifi.
> - “Data Science” Service Group containing Hive, Spark, Zeppelin.
> - “EDW” Service Group containing Hive, Spark.
>
> As part of this review, following has been implemented:
> - SG added as sub-resource of cluster.
> - GET, POST and DELETE API for SG.
>
>
>
> *API calls and response:*
>
> *1.*
>
> POST:
>
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups
> *Body :*
>
>
> [
> {
> "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "CORE"
> }
> },
> {
> "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "EDW"
> }
> }
> ]
>
>
> *Response:* 201 CREATED
>
>
> {
> "resources" : [
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE";,
> "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
> }
> },
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW";,
> "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 803,
> "service_group_name" : "EDW"
> }
> }
> ]
> }
>
>
> *2.*
> ===
> GET :
> ===
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/
>
> *Body:*
>
> []
>
>
> *Response:* 200 OK
>
>
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/";,
> "items" : [
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE";,
> "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "CORE"
> }
> },
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW";,
> "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "EDW"
> }
> }
> ]
> }
>
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE
>
> *Body:*
>
> []
>
>
> *Response:* 200 OK
>
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE";,
> "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
> }
> }
>
>
> *3.*
> ===
> DELETE:
> ===
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE
>
> *Bod
Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61201/#review181740
---
Ship it!
- Madhuvanthi Radhakrishnan
On July 28, 2017, 10 p.m., Swapan Shridhar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61201/
> ---
>
> (Updated July 28, 2017, 10 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
>
>
> Bugs: AMBARI-21594
> https://issues.apache.org/jira/browse/AMBARI-21594
>
>
> Repository: ambari
>
>
> Description
> ---
>
> **ServiceGroup (SG)** : is defined as sub-resource of cluster. It would later
> be used to logically group a set of services (coming out of Management Pack
> selected).
>
> **Example of a Service groups can be a:**
> - “Core” Service Group containing HDFS and Zookeeper. This will be formed by
> default.
> - “Streaming” Service Group containing Kafka, Storm, Nifi.
> - “Data Science” Service Group containing Hive, Spark, Zeppelin.
> - “EDW” Service Group containing Hive, Spark.
>
> As part of this review, following has been implemented:
> - SG added as sub-resource of cluster.
> - GET, POST and DELETE API for SG.
>
>
>
> *API calls and response:*
>
> *1.*
>
> POST:
>
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups
> *Body :*
>
>
> [
> {
> "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "CORE"
> }
> },
> {
> "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "EDW"
> }
> }
> ]
>
>
> *Response:* 201 CREATED
>
>
> {
> "resources" : [
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE";,
> "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
> }
> },
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW";,
> "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 803,
> "service_group_name" : "EDW"
> }
> }
> ]
> }
>
>
> *2.*
> ===
> GET :
> ===
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/
>
> *Body:*
>
> []
>
>
> *Response:* 200 OK
>
>
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/";,
> "items" : [
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE";,
> "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "CORE"
> }
> },
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW";,
> "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "EDW"
> }
> }
> ]
> }
>
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE
>
> *Body:*
>
> []
>
>
> *Response:* 200 OK
>
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE";,
> "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
> }
> }
>
>
> *3.*
> ===
> DELETE:
> ===
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE
>
> *Body:*
>
> []
>
>
> *Response:* 200 OK
>
>
>
Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61201/#review181739
---
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
Lines 230 (patched)
<https://reviews.apache.org/r/61201/#comment257390>
You can also choose to send a response back informing which key was deleted
or any other information using
DeleteStatusMetaData, the invoke method and return a DeleteStatusMetaData
object instead of RequestStatusResponse and then you can do an
deleteStatusMetaData.addDeletedKey());
getRequestStatus(null, null, deleteStatusMetaData);
ambari-server/src/main/resources/key_properties.json
Lines 9 (patched)
<https://reviews.apache.org/r/61201/#comment257392>
Do we want to avoid using key_properties.json? You can directly define it
in the ResourceProvider
ambari-server/src/main/resources/properties.json
Lines 15 (patched)
<https://reviews.apache.org/r/61201/#comment257391>
Do we want to avoid using properties.json? You can directly define it in
the ResourceProvider
- Madhuvanthi Radhakrishnan
On July 28, 2017, 10 p.m., Swapan Shridhar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61201/
> ---
>
> (Updated July 28, 2017, 10 p.m.)
>
>
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
>
>
> Bugs: AMBARI-21594
> https://issues.apache.org/jira/browse/AMBARI-21594
>
>
> Repository: ambari
>
>
> Description
> ---
>
> **ServiceGroup (SG)** : is defined as sub-resource of cluster. It would later
> be used to logically group a set of services (coming out of Management Pack
> selected).
>
> **Example of a Service groups can be a:**
> - “Core” Service Group containing HDFS and Zookeeper. This will be formed by
> default.
> - “Streaming” Service Group containing Kafka, Storm, Nifi.
> - “Data Science” Service Group containing Hive, Spark, Zeppelin.
> - “EDW” Service Group containing Hive, Spark.
>
> As part of this review, following has been implemented:
> - SG added as sub-resource of cluster.
> - GET, POST and DELETE API for SG.
>
>
>
> *API calls and response:*
>
> *1.*
>
> POST:
>
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups
> *Body :*
>
>
> [
> {
> "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "CORE"
> }
> },
> {
> "ServiceGroupInfo" : {
> "cluster_id": "2",
> "service_group_name": "EDW"
> }
> }
> ]
>
>
> *Response:* 201 CREATED
>
>
> {
> "resources" : [
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE";,
> "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 804,
> "service_group_name" : "CORE"
> }
> },
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW";,
> "ServiceGroupInfo" : {
> "cluster_id" : 2,
> "cluster_name" : "c1",
> "service_group_id" : 803,
> "service_group_name" : "EDW"
> }
> }
> ]
> }
>
>
> *2.*
> ===
> GET :
> ===
>
> API: http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/
>
> *Body:*
>
> []
>
>
> *Response:* 200 OK
>
>
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/";,
> "items" : [
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/CORE";,
> "ServiceGroupInfo" : {
> "cluster_name" : "c1",
> "service_group_name" : "CORE"
> }
> },
> {
> "href" :
> "http://c6404.ambari.apache.org:8080/api/v1/clusters/c1/servicegroups/EDW&
Re: Review Request 59113: Ambari fails to start due to NPE after installation of HDF mpack
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59113/ --- (Updated May 10, 2017, 12:21 a.m.) Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty. Changes --- Alternative patch which filters out only the relevant directories for the permissions update and not the complete set contained in NR_ADJUST_OWNERSHIP_LIST and NR_CHANGE_OWNERSHIP_LIST Bugs: AMBARI-20974 https://issues.apache.org/jira/browse/AMBARI-20974 Repository: ambari Description --- fix to update permissions after installing an mpack Diffs (updated) - ambari-server/src/main/python/ambari_server/setupMpacks.py 167f264b8f ambari-server/src/test/python/TestMpacks.py ef8194502e Diff: https://reviews.apache.org/r/59113/diff/2/ Changes: https://reviews.apache.org/r/59113/diff/1-2/ Testing --- Unit Testing: Total run:1170 Total errors:0 Total failures:0 OK [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server --- [INFO] Starting audit... Audit done. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 02:15 min [INFO] Finished at: 2017-05-09T14:30:43-07:00 [INFO] Final Memory: 94M/1439M Functional Testing: Install Ambari-2.5.1 using non-root ambari admin user Install HDP-2.6 (HDFS, Yarn, ZKFS, Storm, Kafka) Install HDF-3.0 ambari-server restart Add Nifi and start service. Verify that the permissions are set correctly in /var/lib/ambari-server/resources/mpacks, /var/lib/ambari-server/resources/extensions, /var/lib/ambari-server/common-services/NIFI, /var/lib/ambari-server/stacks/HDP/2.6/services/NIFI. Thanks, Madhuvanthi Radhakrishnan
Review Request 59115: Add NIFI Admin Toolkit StackFeatures to HDP StackFeatures
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59115/
---
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit
Mohanty.
Bugs: AMBARI-20975
https://issues.apache.org/jira/browse/AMBARI-20975
Repository: ambari
Description
---
Add to HDP stack_features.json
{
"name": "admin_toolkit_support",
"description": "Supports the nifi admin toolkit",
"min_version": "3.0.0.0"
},
{
"name": "tls_toolkit_san",
"description": "Support subject alternative name flag",
"min_version": "3.0.0.0"
}
Diffs
-
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
bbd8bfcb77
Diff: https://reviews.apache.org/r/59115/diff/1/
Testing
---
Thanks,
Madhuvanthi Radhakrishnan
Review Request 59113: Ambari fails to start due to NPE after installation of HDF mpack
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59113/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty. Bugs: AMBARI-20974 https://issues.apache.org/jira/browse/AMBARI-20974 Repository: ambari Description --- fix to update permissions after installing an mpack Diffs - ambari-server/src/main/python/ambari_server/setupMpacks.py 04b96f52d2 ambari-server/src/test/python/TestMpacks.py 32db005746 Diff: https://reviews.apache.org/r/59113/diff/1/ Testing --- Unit Testing: Total run:1170 Total errors:0 Total failures:0 OK [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server --- [INFO] Starting audit... Audit done. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 02:15 min [INFO] Finished at: 2017-05-09T14:30:43-07:00 [INFO] Final Memory: 94M/1439M Functional Testing: Install Ambari-2.5.1 using non-root ambari admin user Install HDP-2.6 (HDFS, Yarn, ZKFS, Storm, Kafka) Install HDF-3.0 ambari-server restart Add Nifi and start service. Verify that the permissions are set correctly in /var/lib/ambari-server/resources/mpacks, /var/lib/ambari-server/resources/extensions, /var/lib/ambari-server/common-services/NIFI, /var/lib/ambari-server/stacks/HDP/2.6/services/NIFI. Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py
> On May 2, 2017, 8:07 p.m., Jonathan Hurley wrote: > > What's the state of this review? Seems like it's been dormant for a week... Hi Jonathan, This patch was scraped for 2.5.1 since the changes were made in the HDF mpack instead. But we do want to keep this approach open for discussion for 3.0.0 - Madhuvanthi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58489/#review173637 --- On April 19, 2017, 7:29 a.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58489/ > --- > > (Updated April 19, 2017, 7:29 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush > Luniya, Nate Cole, and Sumit Mohanty. > > > Bugs: AMBARI-20775 > https://issues.apache.org/jira/browse/AMBARI-20775 > > > Repository: ambari > > > Description > --- > > All the commands.json files should always contain the versionAdvertised > field. If versionAdvertised is not set in command.json then we should assume > that versionAdvertised=False when calling stack_tools.py > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py > 463d61f53d > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > 93ec0b74f5 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 2c441ad5a0 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 3579fcbd2a > > ambari-server/src/test/python/custom_actions/configs/install_packages_config.json > c6575b51a7 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py > ab5e2cdaf9 > ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json > 0b5ba6a0ba > ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0a30 > ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 6ec9ec929c > ambari-server/src/test/python/stacks/2.0.6/configs/flume_only.json > 1550715d72 > ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json > 013bb8b8d2 > ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb9f4 > ambari-server/src/test/python/stacks/2.2/configs/default.json bcb021b74f > ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json > 7ded3a01e1 > ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json > 7a29ea0c0d > ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json > a9db11c645 > ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json > fb561f74f3 > ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json > 86ca03a4a3 > ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json > cbe8ebeb15 > > ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json > dc4c43b9e0 > ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json > 0da58ce2a5 > > > Diff: https://reviews.apache.org/r/58489/diff/3/ > > > Testing > --- > > Tested for service actions: > Start > Stop > Restart > Reconfigure > Service Check > Enable HA > > > Thanks, > > Madhuvanthi Radhakrishnan > >
Re: Review Request 58823: Trunk patch - Storm Log4J Regex Replacement on Upgrade Fails
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58823/ --- (Updated April 27, 2017, 11:14 p.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Sumit Mohanty, and Sriharsha Chintalapani. Bugs: AMBARI-20880 https://issues.apache.org/jira/browse/AMBARI-20880 Repository: ambari Description --- Since there were changes made to trunk patch for storm worker log directory and not to branch-2.5. There are some extra fixes required in this patch. With this, both 2.5 and trunk will be on same page w.r.t upgrade packs for storm. Diffs - ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java 5c0fba7fc6 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml ffa8e61f25 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 44367dcc47 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 9362ae6b87 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 698195502b ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 0440dd3148 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml f99e764cc2 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 3a428765fa ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml b812547100 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 50346274ea ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml fbd61eae5a ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 1c2ceff053 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml be8b750597 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 210c4e2d39 Diff: https://reviews.apache.org/r/58823/diff/1/ Testing (updated) --- branch2.5 Ref: https://reviews.apache.org/r/58815/ Total run:1169 Total errors:0 Total failures:0 OK [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server --- [INFO] Starting audit... Audit done. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 25:47 min [INFO] Finished at: 2017-04-27T15:42:48-07:00 [INFO] Final Memory: 71M/1001M [INFO] :ambari-server mradhakrishnan$ Thanks, Madhuvanthi Radhakrishnan
Review Request 58823: Trunk patch - Storm Log4J Regex Replacement on Upgrade Fails
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58823/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Sumit Mohanty, and Sriharsha Chintalapani. Bugs: AMBARI-20880 https://issues.apache.org/jira/browse/AMBARI-20880 Repository: ambari Description --- Since there were changes made to trunk patch for storm worker log directory and not to branch-2.5. There are some extra fixes required in this patch. With this, both 2.5 and trunk will be on same page w.r.t upgrade packs for storm. Diffs - ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java 5c0fba7fc6 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml ffa8e61f25 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 44367dcc47 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 9362ae6b87 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 698195502b ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 0440dd3148 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml f99e764cc2 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 3a428765fa ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml b812547100 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 50346274ea ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml fbd61eae5a ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 1c2ceff053 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml be8b750597 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 210c4e2d39 Diff: https://reviews.apache.org/r/58823/diff/1/ Testing --- branch2.5 Ref: https://reviews.apache.org/r/58815/ Total run:1169 Total errors:0 Total failures:0 OK [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server --- [INFO] Starting audit... Audit done. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 25:47 min [INFO] Finished at: 2017-04-27T15:42:48-07:00 [INFO] Final Memory: 71M/1001M [INFO] HW12614:ambari-server mradhakrishnan$ Thanks, Madhuvanthi Radhakrishnan
Review Request 58815: Storm Log4J Regex Replacement on Upgrade Fails
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58815/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Sumit Mohanty, and Sriharsha Chintalapani. Bugs: AMBARI-20880 https://issues.apache.org/jira/browse/AMBARI-20880 Repository: ambari Description --- Find keys require an update due to inheritance from Storm 1.0.1 from HDP2.5 onwards Diffs - ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java 5c0fba7fc6 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 898b120c0c ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml f42e0c8e49 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 285aff8c97 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml bc336bbf5e ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml fa3b496be1 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 9231c1222c ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml ec5f1bbfb6 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 819363a3dc ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 2d2e01c000 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 557976c165 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 44a9bd86a1 Diff: https://reviews.apache.org/r/58815/diff/1/ Testing --- Total run:1159 Total errors:0 Total failures:0 OK [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server --- [INFO] Starting audit... Audit done. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 31:43 min [INFO] Finished at: 2017-04-27T12:52:07-07:00 [INFO] Final Memory: 69M/999M [INFO] :ambari-server mradhakrishnan$ mvn clean test Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58568/#review172516 --- Ship it! Hi Vitaly, Please make note that for trunk, ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py there is a separate function called setup_metastore() where the snippet for the /tmp scratch directory will have to go. Thanks. - Madhuvanthi Radhakrishnan On April 20, 2017, 2:19 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58568/ > --- > > (Updated April 20, 2017, 2:19 p.m.) > > > Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and > Sebastian Toader. > > > Bugs: AMBARI-20802 > https://issues.apache.org/jira/browse/AMBARI-20802 > > > Repository: ambari > > > Description > --- > > When a minimal Blueprint install was attempted in that issue, some failures > occurred during the Blueprint deployment. > After some investigation, we determined that the Blueprints processor was > throwing a NullPointerException, due to some configuration types being > considered "updated", even though those configuration types are not included > in the "desired configuration" for the cluster, since the services associated > with those configuration types are not deployed in this current cluster. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > ce36208 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > be79331 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > 6cd6d35 > ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py > ad35688 > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 7ef5fad > ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py > f9fb1f5 > ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py > 2d7322d > > > Diff: https://reviews.apache.org/r/58568/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 58492: Add NIFI StackFeatures to HDP StackFeatures
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58492/
---
(Updated April 19, 2017, 7:28 p.m.)
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit
Mohanty.
Changes
---
Review comments
Bugs: AMBARI-20778
https://issues.apache.org/jira/browse/AMBARI-20778
Repository: ambari
Description
---
Add following properties to stack_Features.json
{
"name": "nifi_encrypt_config",
"description": "Encrypt sensitive properties written to nifi property
file",
"min_version": "2.1.0.0"
},
{
"name": "toolkit_config_update",
"description": "Support separate input and output for toolkit
configuration",
"min_version": "2.1.0.0"
},
Diffs (updated)
-
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
34f3c0769c
Diff: https://reviews.apache.org/r/58492/diff/2/
Changes: https://reviews.apache.org/r/58492/diff/1-2/
Testing
---
Thanks,
Madhuvanthi Radhakrishnan
Review Request 58492: Add NIFI StackFeatures to HDP StackFeatures
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58492/
---
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit
Mohanty.
Bugs: AMBARI-20778
https://issues.apache.org/jira/browse/AMBARI-20778
Repository: ambari
Description
---
Add following properties to stack_Features.json
{
"name": "nifi_encrypt_config",
"description": "Encrypt sensitive properties written to nifi property
file",
"min_version": "2.1.0.0"
},
{
"name": "toolkit_config_update",
"description": "Support separate input and output for toolkit
configuration",
"min_version": "2.1.0.0"
},
Diffs
-
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
34f3c0769c
Diff: https://reviews.apache.org/r/58492/diff/1/
Testing
---
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58489/ --- (Updated April 19, 2017, 7:29 a.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty. Changes --- Additional checks during install packages Bugs: AMBARI-20775 https://issues.apache.org/jira/browse/AMBARI-20775 Repository: ambari Description --- All the commands.json files should always contain the versionAdvertised field. If versionAdvertised is not set in command.json then we should assume that versionAdvertised=False when calling stack_tools.py Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py 463d61f53d ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 93ec0b74f5 ambari-common/src/main/python/resource_management/libraries/script/script.py 2c441ad5a0 ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 3579fcbd2a ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7 ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py ab5e2cdaf9 ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json 0b5ba6a0ba ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0a30 ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 6ec9ec929c ambari-server/src/test/python/stacks/2.0.6/configs/flume_only.json 1550715d72 ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 013bb8b8d2 ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb9f4 ambari-server/src/test/python/stacks/2.2/configs/default.json bcb021b74f ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json 7ded3a01e1 ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 7a29ea0c0d ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json a9db11c645 ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json fb561f74f3 ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 86ca03a4a3 ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json cbe8ebeb15 ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json dc4c43b9e0 ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json 0da58ce2a5 Diff: https://reviews.apache.org/r/58489/diff/3/ Changes: https://reviews.apache.org/r/58489/diff/2-3/ Testing --- Tested for service actions: Start Stop Restart Reconfigure Service Check Enable HA Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py
> On April 18, 2017, 12:36 a.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > > Line 52 (original), 52 (patched) > > <https://reviews.apache.org/r/58489/diff/1/?file=1693394#file1693394line52> > > > > Why would service_name be the string "null"? > > Madhuvanthi Radhakrishnan wrote: > During install_packages roleCommand, the service name is set to "null" > /var/lib/ambari-agent/data/command-5.json:"serviceName": "null", > > Nate Cole wrote: > If serviceName is the string "null" then that's pretty lame. :) That > should be fixed. > > Jayush Luniya wrote: > I agree we should not have serviceName = "null" :) However we ensure > there are no other side effects to it. Hi, On debugging it looks like during json.dumps (CustomServiceOrchestrator.py) it converts everything to string and hence null is converted to "null". I see that this is the case for not just serviceName but several other values. For eg: [root@jay-hdf-1 data]# grep \"null\" command-302.json "capacity-scheduler": "null", "_storm.min.ruid": "null", "topology.acker.executors": "null", "topology.max.task.parallelism": "null", "transactional.zookeeper.port": "null", "topology.worker.childopts": "null", "transactional.zookeeper.servers": "null", "topology.tick.tuple.freq.secs": "null", "ui.filter": "null", One way to fix this is in the AmbariActionExecutionHelper.java, where I can assign serviceName = "" instead of null and then remove the "null" check in stack_tools.py. This opens up a host of unit test failures where the expectation is null (java side) and test command.json files use "serviceName" : "null" (python side) Since the fix in this patch is a blocker for system tests, I can address the null issue in a follow up jira. - Madhuvanthi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58489/#review172160 --- On April 18, 2017, 11:30 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58489/ > --- > > (Updated April 18, 2017, 11:30 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush > Luniya, Nate Cole, and Sumit Mohanty. > > > Bugs: AMBARI-20775 > https://issues.apache.org/jira/browse/AMBARI-20775 > > > Repository: ambari > > > Description > --- > > All the commands.json files should always contain the versionAdvertised > field. If versionAdvertised is not set in command.json then we should assume > that versionAdvertised=False when calling stack_tools.py > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py > 463d61f53d > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > 93ec0b74f5 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 3579fcbd2a > ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py > ab5e2cdaf9 > ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json > 0b5ba6a0ba > ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0a30 > ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 6ec9ec929c > ambari-server/src/test/python/stacks/2.0.6/configs/flume_only.json > 1550715d72 > ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json > 013bb8b8d2 > ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb9f4 > ambari-server/src/test/python/stacks/2.2/configs/default.json bcb021b74f > ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json > 7ded3a01e1 > ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json > 7a29ea0c0d > ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json > a9db11c645 > ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json > fb561f74f3 > ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json > 86ca03a4a3 > ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json > cbe8ebeb15 > > ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json > dc4c43b9e0 > ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json > 0da58ce2a5 > > > Diff: https://reviews.apache.org/r/58489/diff/2/ > > > Testing > --- > > Tested for service actions: > Start > Stop > Restart > Reconfigure > Service Check > Enable HA > > > Thanks, > > Madhuvanthi Radhakrishnan > >
Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58489/ --- (Updated April 18, 2017, 11:30 p.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty. Changes --- Fixed unit tests. Incorporated review comments Bugs: AMBARI-20775 https://issues.apache.org/jira/browse/AMBARI-20775 Repository: ambari Description --- All the commands.json files should always contain the versionAdvertised field. If versionAdvertised is not set in command.json then we should assume that versionAdvertised=False when calling stack_tools.py Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py 463d61f53d ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 93ec0b74f5 ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 3579fcbd2a ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py ab5e2cdaf9 ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json 0b5ba6a0ba ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0a30 ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json 6ec9ec929c ambari-server/src/test/python/stacks/2.0.6/configs/flume_only.json 1550715d72 ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 013bb8b8d2 ambari-server/src/test/python/stacks/2.1/configs/default.json e04e1eb9f4 ambari-server/src/test/python/stacks/2.2/configs/default.json bcb021b74f ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json 7ded3a01e1 ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json 7a29ea0c0d ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json a9db11c645 ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json fb561f74f3 ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 86ca03a4a3 ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json cbe8ebeb15 ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json dc4c43b9e0 ambari-server/src/test/python/stacks/2.3/configs/hbase_default.json 0da58ce2a5 Diff: https://reviews.apache.org/r/58489/diff/2/ Changes: https://reviews.apache.org/r/58489/diff/1-2/ Testing --- Tested for service actions: Start Stop Restart Reconfigure Service Check Enable HA Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py
> On April 18, 2017, 12:36 a.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > > Line 52 (original), 52 (patched) > > <https://reviews.apache.org/r/58489/diff/1/?file=1693394#file1693394line52> > > > > Why would service_name be the string "null"? During install_packages roleCommand, the service name is set to "null" /var/lib/ambari-agent/data/command-5.json:"serviceName": "null", - Madhuvanthi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58489/#review172160 ------- On April 18, 2017, 12:31 a.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58489/ > --- > > (Updated April 18, 2017, 12:31 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush > Luniya, Nate Cole, and Sumit Mohanty. > > > Bugs: AMBARI-20775 > https://issues.apache.org/jira/browse/AMBARI-20775 > > > Repository: ambari > > > Description > --- > > All the commands.json files should always contain the versionAdvertised > field. If versionAdvertised is not set in command.json then we should assume > that versionAdvertised=False when calling stack_tools.py > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > 93ec0b74f5 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 03f53d490b > > > Diff: https://reviews.apache.org/r/58489/diff/1/ > > > Testing > --- > > Tested for service actions: > Start > Stop > Restart > Reconfigure > Service Check > Enable HA > > > Thanks, > > Madhuvanthi Radhakrishnan > >
Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58489/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty. Bugs: AMBARI-20775 https://issues.apache.org/jira/browse/AMBARI-20775 Repository: ambari Description --- All the commands.json files should always contain the versionAdvertised field. If versionAdvertised is not set in command.json then we should assume that versionAdvertised=False when calling stack_tools.py Diffs - ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 93ec0b74f5 ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 03f53d490b Diff: https://reviews.apache.org/r/58489/diff/1/ Testing --- Tested for service actions: Start Stop Restart Reconfigure Service Check Enable HA Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster
] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 42:32 min [INFO] Finished at: 2017-04-12T12:33:21-07:00 [INFO] Final Memory: 195M/1632M [INFO] $ mvn clean test Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/ --- (Updated April 12, 2017, 9:55 p.m.) Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty. Changes --- Review comments - add check for service_name. remove hive_env.xml fixes Bugs: AMBARI-20696 https://issues.apache.org/jira/browse/AMBARI-20696 Repository: ambari Description --- The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called. Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3 ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102 Diff: https://reviews.apache.org/r/58277/diff/6/ Changes: https://reviews.apache.org/r/58277/diff/5-6/ Testing --- Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry Python unit tests Java unit tests Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster
> On April 12, 2017, 7:20 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> > Lines 82 (patched)
> > <https://reviews.apache.org/r/58277/diff/5/?file=1691001#file1691001line82>
> >
> > I don't see this being used anywhere.
It is used in
~/hdf-ambari-mpack/src/main/resources/common-services/NIFI/1.0.0/package/scripts/params.py
stack_version_buildnum =
get_component_version_with_stack_selector("/usr/bin/hdf-select", "nifi")
- Madhuvanthi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171778
-------
On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
>
> (Updated April 12, 2017, 6:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and
> Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> ---
>
> The custom services do not advertise any version and hence will not
> participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -
>
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
> 79393b985f
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
> 02ae62daf3
>
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> ff00a1f38e
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
> 0d1ef13c21
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
> d5018f55b2
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> 751ce085d8
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
> e42bd45cc1
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
> ad668a2051
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
> 872120cc55
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
> 1609050409
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
> 71a02f5e5a
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
> 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/5/
>
>
> Testing
> ---
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine,
> Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster
> On April 11, 2017, 10:29 p.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > > Lines 421 (patched) > > <https://reviews.apache.org/r/58277/diff/2/?file=1689364#file1689364line421> > > > > Are we using this constant anywhere? No, removed it. - Madhuvanthi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/#review171651 --- On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58277/ > --- > > (Updated April 12, 2017, 6:04 p.m.) > > > Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and > Sumit Mohanty. > > > Bugs: AMBARI-20696 > https://issues.apache.org/jira/browse/AMBARI-20696 > > > Repository: ambari > > > Description > --- > > The custom services do not advertise any version and hence will not > participate in the HDP upgrade process. So selectors need not be called. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > 79393b985f > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > 02ae62daf3 > > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py > ff00a1f38e > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 0d1ef13c21 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > d5018f55b2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 751ce085d8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > e42bd45cc1 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > ad668a2051 > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 872120cc55 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py > 1609050409 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > 71a02f5e5a > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 554e089102 > > > Diff: https://reviews.apache.org/r/58277/diff/5/ > > > Testing > --- > > Installed HDP Regular services with HDF Custom services - Nifi, Strealine, > Registry > Python unit tests > Java unit tests > > > Thanks, > > Madhuvanthi Radhakrishnan > >
Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster
> On April 11, 2017, 10:09 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > > Lines 49 (patched) > > <https://reviews.apache.org/r/58277/diff/1/?file=1686585#file1686585line49> > > > > Please create a follow-up Jira to set this to False. > > I'm ok if this is a temporary patch to unblock some testing. I have created a follow-up jira and will work on any regressions that might cause the defaults as false. > On April 11, 2017, 10:09 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py > > Lines 102 (patched) > > <https://reviews.apache.org/r/58277/diff/1/?file=1686586#file1686586line102> > > > > Perhaps check that code is 0 and file length is non-zero before getting > > file contents. There is a follow up check- if code != 0 or out is None: - Madhuvanthi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/#review171639 --- On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58277/ > --- > > (Updated April 12, 2017, 6:04 p.m.) > > > Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and > Sumit Mohanty. > > > Bugs: AMBARI-20696 > https://issues.apache.org/jira/browse/AMBARI-20696 > > > Repository: ambari > > > Description > --- > > The custom services do not advertise any version and hence will not > participate in the HDP upgrade process. So selectors need not be called. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > 79393b985f > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > 02ae62daf3 > > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py > ff00a1f38e > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 0d1ef13c21 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > d5018f55b2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 751ce085d8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > e42bd45cc1 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > ad668a2051 > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 872120cc55 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py > 1609050409 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > 71a02f5e5a > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 554e089102 > > > Diff: https://reviews.apache.org/r/58277/diff/5/ > > > Testing > --- > > Installed HDP Regular services with HDF Custom services - Nifi, Strealine, > Registry > Python unit tests > Java unit tests > > > Thanks, > > Madhuvanthi Radhakrishnan > >
Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/ --- (Updated April 12, 2017, 6:04 p.m.) Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty. Changes --- Review comments incorporated - python variable name, string formatting. Bugs: AMBARI-20696 https://issues.apache.org/jira/browse/AMBARI-20696 Repository: ambari Description --- The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called. Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3 ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml ad668a2051 ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 872120cc55 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102 Diff: https://reviews.apache.org/r/58277/diff/5/ Changes: https://reviews.apache.org/r/58277/diff/4-5/ Testing --- Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry Python unit tests Java unit tests Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/ --- (Updated April 12, 2017, 6:15 a.m.) Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty. Changes --- ServicePropertiesTest was failing due to a recent patch - https://reviews.apache.org/r/57687/diff/2#index_header, fixed that in hive-env.xml Bugs: AMBARI-20696 https://issues.apache.org/jira/browse/AMBARI-20696 Repository: ambari Description --- The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called. Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3 ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml ad668a2051 ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml 872120cc55 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102 Diff: https://reviews.apache.org/r/58277/diff/4/ Changes: https://reviews.apache.org/r/58277/diff/3-4/ Testing --- Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry Python unit tests Java unit tests Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster
> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
> > Lines 219 (patched)
> > <https://reviews.apache.org/r/58277/diff/1/?file=1686583#file1686583line219>
> >
> > We should not hardcode any stack name or path.
> > If HDP stack needs to use "/usr/hdf", then consider passing a variable
> > to this function to overwrite the default stack_root.
> >
> > Even in traditional HDP stacks, /usr/hdf will not exist.
>
> Jayush Luniya wrote:
> Madhu, we can handle the RANGER changes in a separate JIRA and let RANGER
> team drive that change. I also see some deadcode that needs to be removed.
Removed this file from the list of changes
> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> > Lines 87 (patched)
> > <https://reviews.apache.org/r/58277/diff/1/?file=1686586#file1686586line87>
> >
> > If any are missing, throw an error.
> > Right now, this will pass if stay stack_selector_path is non null but
> > component_name is null
Hi Alejandro,
The existing code checks for component_name argument too.
if not stack_selector_path:
Logger.error("Stack selector path not provided")
elif not os.path.exists(stack_selector_path):
Logger.error("Stack selector path does not exist")
elif not component_name:
Logger.error("Component name not provided")
else:
tmpfile = tempfile.NamedTemporaryFile()
...
- Madhuvanthi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58277/#review171447
---
On April 12, 2017, 4:54 a.m., Madhuvanthi Radhakrishnan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58277/
> ---
>
> (Updated April 12, 2017, 4:54 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and
> Sumit Mohanty.
>
>
> Bugs: AMBARI-20696
> https://issues.apache.org/jira/browse/AMBARI-20696
>
>
> Repository: ambari
>
>
> Description
> ---
>
> The custom services do not advertise any version and hence will not
> participate in the HDP upgrade process. So selectors need not be called.
>
>
> Diffs
> -
>
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
> 79393b985f
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
> 02ae62daf3
>
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
> ff00a1f38e
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
> 0d1ef13c21
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
> d5018f55b2
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> 751ce085d8
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
> e42bd45cc1
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
> 1609050409
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
> 71a02f5e5a
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
> 554e089102
>
>
> Diff: https://reviews.apache.org/r/58277/diff/3/
>
>
> Testing
> ---
>
> Installed HDP Regular services with HDF Custom services - Nifi, Strealine,
> Registry
> Python unit tests
> Java unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/ --- (Updated April 12, 2017, 4:54 a.m.) Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty. Changes --- Incorporated Review comments Bugs: AMBARI-20696 https://issues.apache.org/jira/browse/AMBARI-20696 Repository: ambari Description --- The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called. Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3 ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102 Diff: https://reviews.apache.org/r/58277/diff/3/ Changes: https://reviews.apache.org/r/58277/diff/2-3/ Testing --- Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry Python unit tests Java unit tests Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/ --- (Updated April 11, 2017, 9:50 p.m.) Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty. Changes --- Incorporated review comments Bugs: AMBARI-20696 https://issues.apache.org/jira/browse/AMBARI-20696 Repository: ambari Description --- The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called. Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3 ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d5018f55b2 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102 Diff: https://reviews.apache.org/r/58277/diff/2/ Changes: https://reviews.apache.org/r/58277/diff/1-2/ Testing --- Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry Python unit tests Java unit tests Thanks, Madhuvanthi Radhakrishnan
Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/ --- Review request for Ambari, Jayush Luniya and Sumit Mohanty. Bugs: AMBARI-20696 https://issues.apache.org/jira/browse/AMBARI-20696 Repository: ambari Description --- The custom services do not advertise any version and hence will not participate in the HDP upgrade process. So selectors need not be called. Diffs - ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac060 ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py 79393b985f ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py 02ae62daf3 ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py ff00a1f38e ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 0d1ef13c21 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 77d5bf89db ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e42bd45cc1 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 1609050409 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 71a02f5e5a ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 554e089102 Diff: https://reviews.apache.org/r/58277/diff/1/ Testing --- Installed HDP Regular services with HDF Custom services - Nifi, Strealine, Registry Python unit tests Java unit tests Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster
> On March 30, 2017, 4:46 p.m., Jayush Luniya wrote:
> > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py
> > Lines 203 (patched)
> > <https://reviews.apache.org/r/58031/diff/3/?file=1680492#file1680492line203>
> >
> > Why is this commented out?
>
> Madhuvanthi Radhakrishnan wrote:
> The fix,
> if name != 'metastore':
> XmlConfig("mapred-site.xml",
> skips the mapred-site.xml resource for hive-metastore so this test was
> failing that resource not found. But that is expected so I thought we would
> not need this test anymore.
>
> Jayush Luniya wrote:
> But we should remove the deadcode and not comment it out right?
I will fix that. Thanks
- Madhuvanthi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/#review170595
-------
On March 29, 2017, 11:57 p.m., Madhuvanthi Radhakrishnan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58031/
> ---
>
> (Updated March 29, 2017, 11:57 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20615
> https://issues.apache.org/jira/browse/AMBARI-20615
>
>
> Repository: ambari
>
>
> Description
> ---
>
> HMS does not require mapred configs so we need to add a condition so that HMS
> can be deployed without yarn
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
> 5f566174b8
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
> b7b04a2095
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
> 2ed3e3a26a
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py
> b7b04a2095
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py
> 2ed3e3a26a
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py
> 9486e11e46
> ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py
> a159cd0370
>
>
> Diff: https://reviews.apache.org/r/58031/diff/3/
>
>
> Testing
> ---
>
> Deployed a single node cluster using HMS-Zookeeper only blueprint.
> Deployed a regular cluster and added hive service wih existing mysql.
> Verified that no regression occurs.
> Run python unit tests.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster
> On March 30, 2017, 4:46 p.m., Jayush Luniya wrote:
> > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py
> > Lines 203 (patched)
> > <https://reviews.apache.org/r/58031/diff/3/?file=1680492#file1680492line203>
> >
> > Why is this commented out?
The fix,
if name != 'metastore':
XmlConfig("mapred-site.xml",
skips the mapred-site.xml resource for hive-metastore so this test was failing
that resource not found. But that is expected so I thought we would not need
this test anymore.
- Madhuvanthi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/#review170595
-------
On March 29, 2017, 11:57 p.m., Madhuvanthi Radhakrishnan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58031/
> ---
>
> (Updated March 29, 2017, 11:57 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20615
> https://issues.apache.org/jira/browse/AMBARI-20615
>
>
> Repository: ambari
>
>
> Description
> ---
>
> HMS does not require mapred configs so we need to add a condition so that HMS
> can be deployed without yarn
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
> 5f566174b8
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
> b7b04a2095
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
> 2ed3e3a26a
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py
> b7b04a2095
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py
> 2ed3e3a26a
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py
> 9486e11e46
> ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py
> a159cd0370
>
>
> Diff: https://reviews.apache.org/r/58031/diff/3/
>
>
> Testing
> ---
>
> Deployed a single node cluster using HMS-Zookeeper only blueprint.
> Deployed a regular cluster and added hive service wih existing mysql.
> Verified that no regression occurs.
> Run python unit tests.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58031/ --- (Updated March 29, 2017, 11:57 p.m.) Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty. Changes --- Review comments. Commented some tests cases for test_hive_metastore.py which checks if mapred-site config exists. Made a change to hive-env.xml, java_home is not set anywhere in hive service. Bugs: AMBARI-20615 https://issues.apache.org/jira/browse/AMBARI-20615 Repository: ambari Description --- HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn Diffs (updated) - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 5f566174b8 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 2ed3e3a26a ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py b7b04a2095 ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py 2ed3e3a26a ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 9486e11e46 ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py a159cd0370 Diff: https://reviews.apache.org/r/58031/diff/3/ Changes: https://reviews.apache.org/r/58031/diff/2-3/ Testing (updated) --- Deployed a single node cluster using HMS-Zookeeper only blueprint. Deployed a regular cluster and added hive service wih existing mysql. Verified that no regression occurs. Run python unit tests. Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58031/ --- (Updated March 29, 2017, 5:45 p.m.) Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty. Changes --- Changed logic to identify hive-metastore component. Bugs: AMBARI-20615 https://issues.apache.org/jira/browse/AMBARI-20615 Repository: ambari Description --- HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn Diffs (updated) - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095 ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 2ed3e3a26a ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py b7b04a2095 ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py 2ed3e3a26a Diff: https://reviews.apache.org/r/58031/diff/2/ Changes: https://reviews.apache.org/r/58031/diff/1-2/ Testing --- Deployed a single node cluster using HMS-Zookeeper only blueprint. Run python unit tests. Thanks, Madhuvanthi Radhakrishnan
Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58031/ --- Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty. Bugs: AMBARI-20615 https://issues.apache.org/jira/browse/AMBARI-20615 Repository: ambari Description --- HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn Diffs - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095 Diff: https://reviews.apache.org/r/58031/diff/1/ Testing --- Deployed a single node cluster using HMS-Zookeeper only blueprint. Run python unit tests. Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 58009: Fetching running application logs results in 'java.io.IOException'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58009/ --- (Updated March 29, 2017, 12:20 a.m.) Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty. Changes --- Review comments Bugs: AMBARI-20612 https://issues.apache.org/jira/browse/AMBARI-20612 Repository: ambari Description --- A new property called yarn.log.server.web-service.url was added in HDP 2.6 It takes value from yarn.timeline-service.webapp.address if the yarn.http.policy is HTTP_ONLY and takes value from yarn.timeline-service.webapp.https.address if the yarn.http.policy is HTTPS_ONLY. The logic works on fresh installs but is not present during upgrades from HDP2.x to HDP2.6 Fix is to provide the upgrade packs for it. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml c8f93e436f ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 3c0769a720 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 53caa52c6b ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 66f1a64d9d ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 0d6f51b2e1 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 44d0a2a1d9 ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrlTest.java PRE-CREATION Diff: https://reviews.apache.org/r/58009/diff/3/ Changes: https://reviews.apache.org/r/58009/diff/2-3/ Testing --- HDP upgrade from 2.5->2.6 Unit tests Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 58009: Fetching running application logs results in 'java.io.IOException'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58009/ --- (Updated March 29, 2017, 12:06 a.m.) Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty. Changes --- Incorporated review comments Bugs: AMBARI-20612 https://issues.apache.org/jira/browse/AMBARI-20612 Repository: ambari Description --- A new property called yarn.log.server.web-service.url was added in HDP 2.6 It takes value from yarn.timeline-service.webapp.address if the yarn.http.policy is HTTP_ONLY and takes value from yarn.timeline-service.webapp.https.address if the yarn.http.policy is HTTPS_ONLY. The logic works on fresh installs but is not present during upgrades from HDP2.x to HDP2.6 Fix is to provide the upgrade packs for it. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml c8f93e436f ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 3c0769a720 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 53caa52c6b ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 66f1a64d9d ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 0d6f51b2e1 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 44d0a2a1d9 ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrlTest.java PRE-CREATION Diff: https://reviews.apache.org/r/58009/diff/2/ Changes: https://reviews.apache.org/r/58009/diff/1-2/ Testing --- HDP upgrade from 2.5->2.6 Unit tests Thanks, Madhuvanthi Radhakrishnan
Review Request 58009: Fetching running application logs results in 'java.io.IOException'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58009/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty. Bugs: AMBARI-20612 https://issues.apache.org/jira/browse/AMBARI-20612 Repository: ambari Description --- A new property called yarn.log.server.web-service.url was added in HDP 2.6 It takes value from yarn.timeline-service.webapp.address if the yarn.http.policy is HTTP_ONLY and takes value from yarn.timeline-service.webapp.https.address if the yarn.http.policy is HTTPS_ONLY. The logic works on fresh installs but is not present during upgrades from HDP2.x to HDP2.6 Fix is to provide the upgrade packs for it. Diffs - ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml c8f93e4 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 3c0769a ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 53caa52 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 66f1a64 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 0d6f51b ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 44d0a2a ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrlTest.java PRE-CREATION Diff: https://reviews.apache.org/r/58009/diff/1/ Testing --- HDP upgrade from 2.5->2.6 Unit tests Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 57863: Alerts Which Fallback To A Port In Absence of a URI Fail
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57863/ --- (Updated March 22, 2017, 11:58 p.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit Mohanty. Bugs: AMBARI-20536 https://issues.apache.org/jira/browse/AMBARI-20536 Repository: ambari Description --- get_port_from_url function parses an port only address incorrectly. Diffs (updated) - ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py 48e0aa0 ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py 7ff2a14 Diff: https://reviews.apache.org/r/57863/diff/2/ Changes: https://reviews.apache.org/r/57863/diff/1-2/ Testing --- Reproduced with the alert being shown as "Connection refused for http://:80/node/info With the fix, the alert did not appear. Ran python tests. Also checked for an empty hive.metastore.uri property and it allowed the value as per the fix for AMBARI-20427 Thanks, Madhuvanthi Radhakrishnan
Review Request 57863: Alerts Which Fallback To A Port In Absence of a URI Fail
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57863/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit Mohanty. Bugs: AMBARI-20536 https://issues.apache.org/jira/browse/AMBARI-20536 Repository: ambari Description --- get_port_from_url function parses an port only address incorrectly. Diffs - ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py 7ff2a14 Diff: https://reviews.apache.org/r/57863/diff/1/ Testing --- Reproduced with the alert being shown as "Connection refused for http://:80/node/info With the fix, the alert did not appear. Ran python tests. Also checked for an empty hive.metastore.uri property and it allowed the value as per the fix for AMBARI-20427 Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 57795: While generating hash for ambari-server to fill agent cache, all the symlinks should be traversed too.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57795/ --- (Updated March 21, 2017, 12:27 a.m.) Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty. Bugs: AMBARI-20512 https://issues.apache.org/jira/browse/AMBARI-20512 Repository: ambari Description --- the archive.zip and .hash is not getting generated on the server side when the package folder is under stacks///services//package instead of common-services///package On closer look, the issue was that when the directories are being traversed to look for hooks and package folders that need to be hashed/archived for having it in the agent cache, those directories that were symlinks were being skipped. Fix is to include them. Diffs (updated) - ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py baf8179 Diff: https://reviews.apache.org/r/57795/diff/2/ Changes: https://reviews.apache.org/r/57795/diff/1-2/ Testing --- Tested using a management pack Thanks, Madhuvanthi Radhakrishnan
Review Request 57795: While generating hash for ambari-server to fill agent cache, all the symlinks should be traversed too.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57795/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty. Bugs: AMBARI-20512 https://issues.apache.org/jira/browse/AMBARI-20512 Repository: ambari Description --- the archive.zip and .hash is not getting generated on the server side when the package folder is under stacks///services//package instead of common-services///package On closer look, the issue was that when the directories are being traversed to look for hooks and package folders that need to be hashed/archived for having it in the agent cache, those directories that were symlinks were being skipped. Fix is to include them. Diffs - ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py baf8179 Diff: https://reviews.apache.org/r/57795/diff/1/ Testing --- Tested using a management pack Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 57703: Add a new property to yarn-site.xml yarn.log.server.web-service.url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57703/ --- (Updated March 17, 2017, 12:24 a.m.) Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Changes --- reviwe comments Bugs: AMBARI-20469 https://issues.apache.org/jira/browse/AMBARI-20469 Repository: ambari Description --- Add a new property to yarn-site.xml yarn.log.server.web-service.url Diffs (updated) - ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml dd5e9a4 ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py 4fdf84f Diff: https://reviews.apache.org/r/57703/diff/3/ Changes: https://reviews.apache.org/r/57703/diff/2-3/ Testing --- >From https://reviews.apache.org/r/57672/ Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 57703: Add a new property to yarn-site.xml yarn.log.server.web-service.url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57703/ --- (Updated March 16, 2017, 9:08 p.m.) Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Changes --- Moved changes from stack_advisor to service_advisor Bugs: AMBARI-20469 https://issues.apache.org/jira/browse/AMBARI-20469 Repository: ambari Description --- Add a new property to yarn-site.xml yarn.log.server.web-service.url Diffs (updated) - ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml dd5e9a4 ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py 4fdf84f Diff: https://reviews.apache.org/r/57703/diff/2/ Changes: https://reviews.apache.org/r/57703/diff/1-2/ Testing --- >From https://reviews.apache.org/r/57672/ Thanks, Madhuvanthi Radhakrishnan
Review Request 57703: Add a new property to yarn-site.xml yarn.log.server.web-service.url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57703/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs: AMBARI-20469 https://issues.apache.org/jira/browse/AMBARI-20469 Repository: ambari Description --- Add a new property to yarn-site.xml yarn.log.server.web-service.url Diffs - ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml dd5e9a4 ambari-server/src/main/resources/stacks/stack_advisor.py 0b81700 Diff: https://reviews.apache.org/r/57703/diff/1/ Testing --- >From https://reviews.apache.org/r/57672/ Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 57672: Add a new property to yarn-site.xml yarn.log.server.web-service.url
> On March 16, 2017, 3:01 p.m., Robert Nettleton wrote:
> > Patch looks fine to me, although it would be good to add a unit test for
> > the change to the Blueprint config processor.
> >
> > I'd also recommend one additional manual test: Deploy a Blueprint with the
> > default configuration recommendation strategy (which is "NEVER_APPLY" when
> > not set in the Cluster Creation template). This test will verify that the
> > property updater functions properly and sets the expected host name in this
> > property even when the StackAdvisor is not consulted, which is the default
> > behavior.
> >
> > Thanks for providing this patch!
Tested with NEVER_APPLY and verified that it still replaces the %HOST correctly.
> On March 16, 2017, 3:01 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> > Lines 2492 (patched)
> > <https://reviews.apache.org/r/57672/diff/1/?file=1665879#file1665879line2492>
> >
> > It would probably be a good idea to add a unit test to verify that this
> > property updater is registered as expected.
I am providing an addendum patch and attaching it to the apache jira itself.
Thank you
- Madhuvanthi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57672/#review169159
---
On March 16, 2017, 12:21 a.m., Madhuvanthi Radhakrishnan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57672/
> ---
>
> (Updated March 16, 2017, 12:21 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Robert
> Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20469
> https://issues.apache.org/jira/browse/AMBARI-20469
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Add a new property to yarn-site.xml yarn.log.server.web-service.url
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> e604598
>
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-site.xml
> 4b97148
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py
> 0968d8b
>
>
> Diff: https://reviews.apache.org/r/57672/diff/1/
>
>
> Testing
> ---
>
> 1. Fresh Install : HDP 2.6
> Install Yarn. Check if the yarn.log.server.web-service.url is appropriately
> set i.e if policy = HTTP_ONLY, then the value is
> http://${yarn.resourcemanager.webapp.address}/ws/v1/applicationhistory
> Change the policy to HTTPS_ONLY, the UI will show a warning on Save Configs
> to change the yarn.log.server.web-service.url to
> https://${yarn.resourcemanager.webapp.https.address}/ws/v1/applicationhistory
>
> 2. Export Blueprint
> yarn.log.server.web-service.url =
> "http://%HOSTGROUP::host_group_2%:8188/ws/v1/applicationhistory";,
>
> 3. Deploy a cluster using Blueprint
> config_recommendation_strategy = ONLY_STACK_DEFAULTS_APPLY
> "yarn.log.server.web-service.url":
> "http://c6402.ambari.apache.org:8188/ws/v1/applicationhistory";,
> where:
> yarn.timeline-service.webapp.address": "c6402.ambari.apache.org:8188",
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Review Request 57672: Add a new property to yarn-site.xml yarn.log.server.web-service.url
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57672/
---
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Robert
Nettleton, and Sumit Mohanty.
Bugs: AMBARI-20469
https://issues.apache.org/jira/browse/AMBARI-20469
Repository: ambari
Description
---
Add a new property to yarn-site.xml yarn.log.server.web-service.url
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
e604598
ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-site.xml
4b97148
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py
0968d8b
Diff: https://reviews.apache.org/r/57672/diff/1/
Testing
---
1. Fresh Install : HDP 2.6
Install Yarn. Check if the yarn.log.server.web-service.url is appropriately set
i.e if policy = HTTP_ONLY, then the value is
http://${yarn.resourcemanager.webapp.address}/ws/v1/applicationhistory
Change the policy to HTTPS_ONLY, the UI will show a warning on Save Configs to
change the yarn.log.server.web-service.url to
https://${yarn.resourcemanager.webapp.https.address}/ws/v1/applicationhistory
2. Export Blueprint
yarn.log.server.web-service.url =
"http://%HOSTGROUP::host_group_2%:8188/ws/v1/applicationhistory";,
3. Deploy a cluster using Blueprint
config_recommendation_strategy = ONLY_STACK_DEFAULTS_APPLY
"yarn.log.server.web-service.url":
"http://c6402.ambari.apache.org:8188/ws/v1/applicationhistory";,
where:
yarn.timeline-service.webapp.address": "c6402.ambari.apache.org:8188",
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 57565: Ambari should allow empty string for hive.metastore.uris when running in embedded mode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57565/#review168923 --- Ship it! Ship It! - Madhuvanthi Radhakrishnan On March 13, 2017, 6:30 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57565/ > --- > > (Updated March 13, 2017, 6:30 p.m.) > > > Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-20427 > https://issues.apache.org/jira/browse/AMBARI-20427 > > > Repository: ambari > > > Description > --- > > Ambari UI prevents setting a value of null or empty string for > hive.metastore.uris > This is a valid use-case for embedded mode. > > > Diffs > - > > ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py > 4e6b6c3 > > ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py > ed4586c > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml > 3d08867 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > 45a8c07 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > fdc96db > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml > 856941f > > > Diff: https://reviews.apache.org/r/57565/diff/1/ > > > Testing > --- > > Verified on live cluster. > > mvn clean test > > > Thanks, > > Alejandro Fernandez > >
Re: Review Request 57565: Ambari should allow empty string for hive.metastore.uris when running in embedded mode
> On March 13, 2017, 7:29 p.m., Madhuvanthi Radhakrishnan wrote: > > Hi Alejandro, > > Do we not want the UnknownConfiguration scenario at all? > > Alejandro Fernandez wrote: > Can you explain in more detail? If the user intends to use an external > MetaStore and they forget to set a URI value then that's obviously a case we > can't identify since we don't know their intent. I meant that, in the current version, there is a check as is_empty(address). It is a Lazy failing for unknown configs. In the fixed version, "address is UnknownConfiguration, UnknownConfiguration will be returned." this check is removed. - Madhuvanthi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57565/#review168818 --- On March 13, 2017, 6:30 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57565/ > --- > > (Updated March 13, 2017, 6:30 p.m.) > > > Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-20427 > https://issues.apache.org/jira/browse/AMBARI-20427 > > > Repository: ambari > > > Description > --- > > Ambari UI prevents setting a value of null or empty string for > hive.metastore.uris > This is a valid use-case for embedded mode. > > > Diffs > - > > ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py > 4e6b6c3 > > ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py > ed4586c > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml > 3d08867 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > 45a8c07 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > fdc96db > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml > 856941f > > > Diff: https://reviews.apache.org/r/57565/diff/1/ > > > Testing > --- > > Verified on live cluster. > > mvn clean test > > > Thanks, > > Alejandro Fernandez > >
Re: Review Request 57565: Ambari should allow empty string for hive.metastore.uris when running in embedded mode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57565/#review168818 --- Hi Alejandro, Do we not want the UnknownConfiguration scenario at all? - Madhuvanthi Radhakrishnan On March 13, 2017, 6:30 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57565/ > --- > > (Updated March 13, 2017, 6:30 p.m.) > > > Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-20427 > https://issues.apache.org/jira/browse/AMBARI-20427 > > > Repository: ambari > > > Description > --- > > Ambari UI prevents setting a value of null or empty string for > hive.metastore.uris > This is a valid use-case for embedded mode. > > > Diffs > - > > ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py > 4e6b6c3 > > ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py > ed4586c > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml > 3d08867 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > 45a8c07 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > fdc96db > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml > 856941f > > > Diff: https://reviews.apache.org/r/57565/diff/1/ > > > Testing > --- > > Verified on live cluster. > > mvn clean test > > > Thanks, > > Alejandro Fernandez > >
Re: Review Request 57543: When agent retries commands it needs to handle credential store processing correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57543/#review168811 --- Ship it! - Madhuvanthi Radhakrishnan On March 12, 2017, 8:12 a.m., Sumit Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57543/ > --- > > (Updated March 12, 2017, 8:12 a.m.) > > > Review request for Ambari, Madhuvanthi Radhakrishnan, Swapan Shridhar, and > Vitalyi Brodetskyi. > > > Bugs: AMBARI-20407 > https://issues.apache.org/jira/browse/AMBARI-20407 > > > Repository: ambari > > > Description > --- > > When agent retries commands it needs to handle credential store processing > correctly (see bug for more details) > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py 15ae03d > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py > ee34685 > ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 8701a24 > > > Diff: https://reviews.apache.org/r/57543/diff/1/ > > > Testing > --- > > Ran unit tests locally > > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views .. SUCCESS [4.014s] > [INFO] utility ... SUCCESS [1.311s] > [INFO] Ambari Metrics Common . SUCCESS [8.301s] > [INFO] Ambari Agent .. SUCCESS [1:36.871s] > [INFO] > > [INFO] BUILD SUCCESS > > > Thanks, > > Sumit Mohanty > >
Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57517/ --- (Updated March 10, 2017, 7:59 p.m.) Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty. Bugs: AMBARI-20399 https://issues.apache.org/jira/browse/AMBARI-20399 Repository: ambari Description --- ServiceInfo was not being refreshed on stack upgrade Diffs - ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java b1bffef ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 70efeb5 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d12a8a3 ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java 2bfd176 Diff: https://reviews.apache.org/r/57517/diff/2/ Testing (updated) --- Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path) Verified that credential_store_supported = true for Oozie, Hive, Logsearch [INFO] Starting audit... Audit done. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 23:08 min [INFO] Finished at: 2017-03-10T11:56:37-08:00 [INFO] Final Memory: 66M/1105M [INFO] mradhakrishnan$ mvn clean test -Drat.skip=true Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57517/ --- (Updated March 10, 2017, 7:58 p.m.) Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty. Changes --- Incorporated review comments Bugs: AMBARI-20399 https://issues.apache.org/jira/browse/AMBARI-20399 Repository: ambari Description --- ServiceInfo was not being refreshed on stack upgrade Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java b1bffef ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 70efeb5 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d12a8a3 ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java 2bfd176 Diff: https://reviews.apache.org/r/57517/diff/2/ Changes: https://reviews.apache.org/r/57517/diff/1-2/ Testing --- Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path) Verified that credential_store_supported = true for Oozie, Hive, Logsearch Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters
> On March 10, 2017, 6:47 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > > Lines 198 (patched) > > <https://reviews.apache.org/r/57517/diff/1/?file=1661517#file1661517line198> > > > > This log statement isn't very helpful (since the logger itself outputs > > the class/method automatically). > > > > Also, you don't need `this` in `this.getName()` Sorry , i forgot to remove the log statements after my testing. Will clean it up. > On March 10, 2017, 6:47 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > > Lines 200-202 (patched) > > <https://reviews.apache.org/r/57517/diff/1/?file=1661517#file1661517line200> > > > > Shouldn't all metadata be refreshed in this, not just credential store? Here are the metadata for ServiceInfo "cluster_name": "",-->Does it require a refresh? "credential_store_enabled": "false", --> I believe we dont want this information to come from the stack i.e expectation is that after an upgrade this will still be in disabled state. Please correct me if I am wrong. "credential_store_supported": "true", --> refreshed "maintenance_state": "OFF", -->Does it require a refresh? "service_name": "OOZIE",-->Does it require a refresh? "state": "STARTED"-->Does it require a refresh? - Madhuvanthi ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57517/#review168646 --- On March 10, 2017, 6:39 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57517/ > --- > > (Updated March 10, 2017, 6:39 p.m.) > > > Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty. > > > Bugs: AMBARI-20399 > https://issues.apache.org/jira/browse/AMBARI-20399 > > > Repository: ambari > > > Description > --- > > ServiceInfo was not being refreshed on stack upgrade > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java > b1bffef > ambari-server/src/main/java/org/apache/ambari/server/state/Service.java > 70efeb5 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > d12a8a3 > > ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java > 2bfd176 > > > Diff: https://reviews.apache.org/r/57517/diff/1/ > > > Testing > --- > > Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path) > Verified that credential_store_supported = true for Oozie, Hive, Logsearch > > > Thanks, > > Madhuvanthi Radhakrishnan > >
Review Request 57517: [Upgrade] Unable to enable Credential store support on upgraded clusters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57517/ --- Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Sumit Mohanty. Bugs: AMBARI-20399 https://issues.apache.org/jira/browse/AMBARI-20399 Repository: ambari Description --- ServiceInfo was not being refreshed on stack upgrade Diffs - ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java b1bffef ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 70efeb5 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java d12a8a3 ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java 2bfd176 Diff: https://reviews.apache.org/r/57517/diff/1/ Testing --- Ambari2.4:HDP2.4->Ambari2.5->HDP2.6 (Upgrade path) Verified that credential_store_supported = true for Oozie, Hive, Logsearch Thanks, Madhuvanthi Radhakrishnan
Review Request 57306: HiveServer2 log rotation is setup incorrectly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57306/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty. Bugs: AMBARI-20312 https://issues.apache.org/jira/browse/AMBARI-20312 Repository: ambari Description --- Since hive2 has both timebased and sizebased triggering policy, the filepattern needs to be modified so that multiple log files created on the same day can persist instead of being overwritten based on the on the date. Diffs - ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml e6c925d ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml 0b3eddb Diff: https://reviews.apache.org/r/57306/diff/1/ Testing --- Thanks, Madhuvanthi Radhakrishnan
Re: Review Request 57253: Credential Store should be enabled by default on fresh installs
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57253/
---
(Updated March 2, 2017, 7:48 p.m.)
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit
Mohanty.
Bugs: AMBARI-20275
https://issues.apache.org/jira/browse/AMBARI-20275
Repository: ambari
Description
---
Credential Store should be enabled by default on fresh installs (Hive, Oozie,
Logsearch)
Diffs
-
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml
245a94d
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml
4230dd4
ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/metainfo.xml
75aa9d9
Diff: https://reviews.apache.org/r/57253/diff/1/
Testing (updated)
---
Manual Testing
===
*Scenario - 1 FRESH INSTALL*
Deploy Ambari 2.5 - HDP 2.6
0. Add services Hive, Oozie, Logsearch
1. GET http://:8080/api/v1/clusters/cl1/services/HIVE - Hive Credential
Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
….
}
2. GET http://:8080/api/v1/clusters/cl1/services/OOZIE - Oozie Credential
Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
…
}
3. GET http://:8080/api/v1/clusters/cl1/services/LOGSEARCH - Logsearch
Credential Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/LOGSEARCH",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
…
}
4. User is able to disable Hive and Oozie CS
PUT
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(HIVE)
{"ServiceInfo": {"credential_store_enabled": "false"}}
GET http://:8080/api/v1/clusters/cl1/services/HIVE
{
"href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "false",
"credential_store_supported": "true",
…
}
PUT
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(OOZIE)
{"ServiceInfo": {"credential_store_enabled": "false"}}
GET http://:8080/api/v1/clusters/cl1/services/OOZIE
{
"href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "false",
"credential_store_supported": "true",
….
}
5. User is not able to disable Logsearch
PUT
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(LOGSEARCH)
{"ServiceInfo": {"credential_store_enabled": "false"}}
Response:
{
"status" : 400,
"message" : "java.lang.IllegalArgumentException: Invalid arguments, cannot
disable credential store as it is required by the service. Service=LOGSEARCH"
}
*Scenario - 1 AMBARI UPGRADE*
1. Ambari upgrade 2.4->2.5 (HDP 2.5.0)
Hive, Oozie, Logsearch - disabled
2. User is able to enable Credential Store for Hive, Oozie, Logsearch post
upgrade
Thanks,
Madhuvanthi Radhakrishnan
Review Request 57253: Credential Store should be enabled by default on fresh installs
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57253/
---
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit
Mohanty.
Bugs: AMBARI-20275
https://issues.apache.org/jira/browse/AMBARI-20275
Repository: ambari
Description
---
Credential Store should be enabled by default on fresh installs (Hive, Oozie,
Logsearch)
Diffs
-
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml
245a94d
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml
4230dd4
ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/metainfo.xml
75aa9d9
Diff: https://reviews.apache.org/r/57253/diff/1/
Testing
---
Manual Testing
===
*Scenario - 1 FRESH INSTALL*
Deploy Ambari 2.5 - HDP 2.6
0. Add services Hive, Oozie, Logsearch
1. GET http://:8080/api/v1/clusters/cl1/services/HIVE - Hive Credential
Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
….
}
2. GET http://:8080/api/v1/clusters/cl1/services/OOZIE - Oozie Credential
Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
…
}
3. GET http://:8080/api/v1/clusters/cl1/services/LOGSEARCH - Logsearch
Credential Store enabled on fresh install
{
"href": "http://:8080/api/v1/clusters/cl1/services/LOGSEARCH",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "true",
"credential_store_supported": "true",
…
}
4. User is able to disable Hive and Oozie CS
PUT
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(HIVE)
{"ServiceInfo": {"credential_store_enabled": "false"}}
GET http://:8080/api/v1/clusters/cl1/services/HIVE
{
"href": "http://:8080/api/v1/clusters/cl1/services/HIVE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "false",
"credential_store_supported": "true",
…
}
PUT
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(OOZIE)
{"ServiceInfo": {"credential_store_enabled": "false"}}
GET http://:8080/api/v1/clusters/cl1/services/OOZIE
{
"href": "http://:8080/api/v1/clusters/cl1/services/OOZIE",
"ServiceInfo": {
"cluster_name": "cl1",
"credential_store_enabled": "false",
"credential_store_supported": "true",
….
}
5. User is not able to disable Logsearch
PUT
http://:8080/api/v1/clusters/cl1/services?ServiceInfo/service_name.in(LOGSEARCH)
{"ServiceInfo": {"credential_store_enabled": "false"}}
Response:
{
"status" : 400,
"message" : "java.lang.IllegalArgumentException: Invalid arguments, cannot
disable credential store as it is required by the service. Service=LOGSEARCH"
}
6. Ambari upgrade 2.4->2.5 (HDP 2.5.0)
Hive, Oozie, Logsearch - disabled
User is able to enable Credential Store for Hive, Oozie, Logsearch post
upgrade
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 56512: Add 'yarn.client.failover-proxy-provider' in yarn-site.xml by default for all HA enabled clusters - addendum
> On Feb. 10, 2017, 1:30 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-site.xml, > > line 22 > > <https://reviews.apache.org/r/56512/diff/1/?file=1628682#file1628682line22> > > > > Please also make this change in YARN common-services 3.0.0.3.0 This property was not present in the 3.0.0.3.0 yarn-site.xml so I have added it. https://issues.apache.org/jira/secure/attachment/12855272/AMBARI-19841_trunk.patch - Madhuvanthi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56512/#review165045 --- On Feb. 9, 2017, 7:27 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56512/ > --- > > (Updated Feb. 9, 2017, 7:27 p.m.) > > > Review request for Ambari, Jayush Luniya and Sumit Mohanty. > > > Bugs: AMBARI-19841 > https://issues.apache.org/jira/browse/AMBARI-19841 > > > Repository: ambari > > > Description > --- > > Incorrect value was set for yarn.client.failover-proxy-provider property > > > Diffs > - > > > ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-site.xml > 555768e > > Diff: https://reviews.apache.org/r/56512/diff/ > > > Testing > --- > > UI > > > Thanks, > > Madhuvanthi Radhakrishnan > >
Re: Review Request 57096: Remove HDP version check in KAFKA service
> On Feb. 27, 2017, 6:37 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py, > > line 25 > > <https://reviews.apache.org/r/57096/diff/1/?file=1650509#file1650509line25> > > > > Can we remove the import too? Changed to from resource_management.libraries.functions.version import format_stack_version - Madhuvanthi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57096/#review166904 --- On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57096/ > --- > > (Updated Feb. 27, 2017, 7:10 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jayush Luniya. > > > Bugs: AMBARI-20212 > https://issues.apache.org/jira/browse/AMBARI-20212 > > > Repository: ambari > > > Description > --- > > Remove HDP version check in KAFKA service > > > Diffs > - > > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py > 015e150 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > bc2e7a7 > > Diff: https://reviews.apache.org/r/57096/diff/ > > > Testing > --- > > > Thanks, > > Madhuvanthi Radhakrishnan > >
Re: Review Request 57096: Remove HDP version check in KAFKA service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57096/ --- (Updated Feb. 27, 2017, 7:10 p.m.) Review request for Ambari, Alejandro Fernandez and Jayush Luniya. Bugs: AMBARI-20212 https://issues.apache.org/jira/browse/AMBARI-20212 Repository: ambari Description --- Remove HDP version check in KAFKA service Diffs (updated) - ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py 015e150 ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json bc2e7a7 Diff: https://reviews.apache.org/r/57096/diff/ Testing --- Thanks, Madhuvanthi Radhakrishnan
