Re: Review Request 64155: Update the version of Ember and jQuery for Hive View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64155/#review192119 --- Ship it! Ship It! - Nitiraj Rathore On Nov. 29, 2017, 12:40 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64155/ > --- > > (Updated Nov. 29, 2017, 12:40 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj > Rathore. > > > Bugs: AMBARI-22542 > https://issues.apache.org/jira/browse/AMBARI-22542 > > > Repository: ambari > > > Description > --- > > Changed the ember and jquery versions. > > > Diffs > - > > contrib/views/files/src/main/resources/ui/bower.json f1472ee > contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json 62861b2 > > > Diff: https://reviews.apache.org/r/64155/diff/1/ > > > Testing > --- > > manually tested > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 62968: Handle upload of interpreter.json to remote storage in Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62968/#review187942 --- Ship it! Ship It! - Nitiraj Rathore On Oct. 13, 2017, 7:10 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62968/ > --- > > (Updated Oct. 13, 2017, 7:10 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, > Rohit Choudhary, Sumit Mohanty, and venkat sairam. > > > Bugs: AMBARI-9 > https://issues.apache.org/jira/browse/AMBARI-9 > > > Repository: ambari > > > Description > --- > > Zeppelin can read interpreter.json from HDFS based on hdfs-site.xml present > in classpath. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py > a8b1b321c8 > ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py > e5d024092b > > > Diff: https://reviews.apache.org/r/62968/diff/2/ > > > Testing > --- > > Manually > > > Thanks, > > Prabhjyot Singh > >
Review Request 62885: Hive View 2.0 in Ambari 2.5.1 does not use the specified YARN queue when using the "Upload Table" feature.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62885/ --- Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and venkat sairam. Bugs: AMBARI-22202 https://issues.apache.org/jira/browse/AMBARI-22202 Repository: ambari Description --- added global settings in all the system generated queries Diffs - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java 77857f9628 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadService.java 3164da09e1 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/InsertFromQueryInput.java b74ba9b0c1 contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js f47d820cbf Diff: https://reviews.apache.org/r/62885/diff/1/ Testing --- manual testing done. Thanks, Nitiraj Rathore
Re: Review Request 62711: HiveView 1.5 is not showing the "Visualization" page when accessed over Knox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62711/#review186780 --- Ship it! Ship It! - Nitiraj Rathore On Sept. 30, 2017, 9:17 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62711/ > --- > > (Updated Sept. 30, 2017, 9:17 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-22103 > https://issues.apache.org/jira/browse/AMBARI-22103 > > > Repository: ambari > > > Description > --- > > Changed the adapter URL to make Visualization page accessible via Knox proxy > > > Diffs > - > > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/application.js > 2c68b89 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/visualization-ui.js > c908afd > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/utils/constants.js > 348454b > > > Diff: https://reviews.apache.org/r/62711/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 62694: Entries related to hive query are found in RM UI after killing or stopping the execution of the query.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62694/#review186776 --- Ship it! Ship It! - Nitiraj Rathore On Sept. 29, 2017, 5:05 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62694/ > --- > > (Updated Sept. 29, 2017, 5:05 p.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-22096 > https://issues.apache.org/jira/browse/AMBARI-22096 > > > Repository: ambari > > > Description > --- > > Ember data API changes are made and the exceptions on JS side are handled > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 291c335 > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 36abf49 > > > Diff: https://reviews.apache.org/r/62694/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 62683: Hive view2.0 Jobs worksheets doesn't have hyperlink whereas view1.5 History worksheets had hyperlinks pointing to fetched results
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62683/#review186662 --- Ship it! Ship It! - Nitiraj Rathore On Sept. 29, 2017, 4:37 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62683/ > --- > > (Updated Sept. 29, 2017, 4:37 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-22091 > https://issues.apache.org/jira/browse/AMBARI-22091 > > > Repository: ambari > > > Description > --- > > Provided hyper link in jobs page which will fetch the jobs results. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/job-item.js > 42a3411 > contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js > 7e24843 > contrib/views/hive20/src/main/resources/ui/app/routes/jobs.js 3e88ac6 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js > 76a7439 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > f6256898 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 522b2d3 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs > 16caad0 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs > d29ca73 > contrib/views/hive20/src/main/resources/ui/app/templates/jobs.hbs 4382b7a > > > Diff: https://reviews.apache.org/r/62683/diff/1/ > > > Testing > --- > > Manual tetsing done > > > Thanks, > > venkat sairam > >
Re: Review Request 62612: Zeppelin JDBC queries should be split by default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62612/#review186376 --- Ship it! Ship It! - Nitiraj Rathore On Sept. 27, 2017, 5:43 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62612/ > --- > > (Updated Sept. 27, 2017, 5:43 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, > Rohit Choudhary, Sumit Mohanty, and venkat sairam. > > > Bugs: AMBARI-22069 > https://issues.apache.org/jira/browse/AMBARI-22069 > > > Repository: ambari > > > Description > --- > > With ZEPPELIN-2554 there's a new interpreter setting that restricts splitting > of JDBC queries. This is to make "default.splitQueries=true". > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py > 8bdfaece2d > ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py > 1fdbadb1e6 > > > Diff: https://reviews.apache.org/r/62612/diff/1/ > > > Testing > --- > > Manually > > > File Attachments > > > AMBARI-22069_branch-2.6_v1.patch > > https://reviews.apache.org/media/uploaded/files/2017/09/27/fe51e7ee-6a62-4822-a816-1062148a57b7__AMBARI-22069_branch-2.6_v1.patch > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 61961: Support for Zeppelin notebook storage in HDFS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61961/#review184241 --- Ship it! Ship It! - Nitiraj Rathore On Aug. 29, 2017, 4:53 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61961/ > --- > > (Updated Aug. 29, 2017, 4:53 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam. > > > Bugs: AMBARI-21835 > https://issues.apache.org/jira/browse/AMBARI-21835 > > > Repository: ambari > > > Description > --- > > With ZEPPELIN-1515 there is now support for storing Zeppelin's notebook in > HDFS, this patch is for making notebook to be stored by default in HDFS > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml > 13d726be97 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 7f506c5839 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 6912c3db8d > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-config.xml > c0ce71146c > > > Diff: https://reviews.apache.org/r/61961/diff/1/ > > > Testing > --- > > Manually on CentOS > > > Thanks, > > Prabhjyot Singh > >
Review Request 61910: Hive query failing randomly with Null point exception status 500
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61910/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-21799 https://issues.apache.org/jira/browse/AMBARI-21799 Repository: ambari Description --- Null Pointer Exception is coming while getting message of original exception. Added a null check. Diffs - contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java 90fa483ef7 Diff: https://reviews.apache.org/r/61910/diff/1/ Testing --- manual testing done. Thanks, Nitiraj Rathore
Re: Review Request 61205: Users randomly getting "HDFS020 Could not write file" exceptions while running query from Hive View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61205/#review181651 --- contrib/views/hive-next/src/main/resources/view.log4j.properties Line 28 (original), 28 (patched) <https://reviews.apache.org/r/61205/#comment257281> This line will create problem in log4j. Please correct. contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsUtil.java Lines 50 (patched) <https://reviews.apache.org/r/61205/#comment257282> Please use close stream in finally. - Nitiraj Rathore On July 28, 2017, 6:39 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61205/ > --- > > (Updated July 28, 2017, 6:39 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-21569 > https://issues.apache.org/jira/browse/AMBARI-21569 > > > Repository: ambari > > > Description > --- > > ServiceFormattedException:100 - > org.apache.ambari.view.utils.hdfs.HdfsApiException: HDFS020 Could not write > file /user/user/hive/jobs/hive-job-5290-2017-03-22_02-35/logs > > org.apache.ambari.view.utils.hdfs.HdfsApiException: HDFS020 Could not write > file /user/user/hive/jobs/hive-job-5290-2017-03-22_02-35/logs > at > org.apache.ambari.view.utils.hdfs.HdfsUtil.putStringToFile(HdfsUtil.java:51) > at > org.apache.ambari.view.hive.resources.jobs.viewJobs.JobControllerImpl.updateOperationLogs(JobControllerImpl.java:202) > at > org.apache.ambari.view.hive.resources.jobs.viewJobs.JobControllerImpl.update(JobControllerImpl.java:160) > at > org.apache.ambari.view.hive.resources.jobs.viewJobs.JobResourceManager.read(JobResourceManager.java:79) > at > org.apache.ambari.view.hive.resources.jobs.viewJobs.JobResourceManager.readController(JobResourceManager.java:95) > at > org.apache.ambari.view.hive.resources.jobs.JobService.getOne(JobService.java:133) > at sun.reflect.GeneratedMethodAccessor191.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:497) > at > com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) > at > com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205) > at > com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75) > at > com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.SubLocatorRule.accept(SubLocatorRule.java:137) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.SubLocatorRule.accept(SubLocatorRule.java:137) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.SubLocatorRule.accept(SubLocatorRule.java:137) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84) > at > com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542) > at > com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473) > at > com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419) > at > com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409) > at > com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409) > at > com.sun.jersey.spi.container.s
Re: Review Request 60859: Zeppelin does not start and returns: params.zookeeper_znode_parent not in interpreter['properties']['phoenix.url']: KeyError: 'phoenix.url'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60859/#review180663 --- Ship it! Ship It! - Nitiraj Rathore On July 14, 2017, 11:18 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60859/ > --- > > (Updated July 14, 2017, 11:18 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and > venkat sairam. > > > Bugs: AMBARI-21473 > https://issues.apache.org/jira/browse/AMBARI-21473 > > > Repository: ambari > > > Description > --- > > Zeppelin does not start and returns: params.zookeeper_znode_parent not in > interpreter['properties']['phoenix.url']: KeyError: 'phoenix.url' > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 0013ab0eb8 > > > Diff: https://reviews.apache.org/r/60859/diff/1/ > > > Testing > --- > > Manually on CentOS 6 with kerberos enabled > > > Thanks, > > Prabhjyot Singh > >
Review Request 59741: File View : Download using Concatenate results in incorrect data
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59741/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-21174 https://issues.apache.org/jira/browse/AMBARI-21174 Repository: ambari Description --- Earlier : incorrect copying of file input stream to output stream because of which leftover bytes were getting written In this patch: corrected the copying of stream using IOUtils Diffs - contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java 10b7c9edcc Diff: https://reviews.apache.org/r/59741/diff/1/ Testing --- Manual testing done. Thanks, Nitiraj Rathore
Re: Review Request 59704: Hive view not exporting/downloading the worksheet with entire number of rows to csv
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59704/ --- (Updated June 1, 2017, 8:02 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-21163 https://issues.apache.org/jira/browse/AMBARI-21163 Repository: ambari Description --- The root cause can be too many number of Inbox objects which create temporary actors. Some of these actors get killed before receiving the data back. In this patch : pulled the inbox object creation per object of NonPersistentCursor Diffs - contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/DeathWatch.java dbb6c3dd6d contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/NonPersistentCursor.java 0be2683371 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/DeathWatch.java 58cefcddb3 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/NonPersistentCursor.java 1d76e9cf16 Diff: https://reviews.apache.org/r/59704/diff/1/ Testing --- manual testing done. Files are downloading properly now. Thanks, Nitiraj Rathore
Review Request 59704: Hive view not exporting/downloading the worksheet with entire number of rows to csv
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59704/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-21163 https://issues.apache.org/jira/browse/AMBARI-21163 Repository: ambari Description --- The root cause can be too many number of Inbox objects which create temporary actors. Some of these actors get killed before receiving the data back. In this patch : pulled the inbox object creation per object of NonPersistentCursor Diffs - contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/DeathWatch.java dbb6c3dd6d contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/NonPersistentCursor.java 0be2683371 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/DeathWatch.java 58cefcddb3 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/NonPersistentCursor.java 1d76e9cf16 Diff: https://reviews.apache.org/r/59704/diff/1/ Testing --- manual testing done. Files are downloading properly now. Thanks, Nitiraj Rathore
Review Request 59526: Unable to upload table via Ambari Hive view if user does not have permission on default database
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59526/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-21108 https://issues.apache.org/jira/browse/AMBARI-21108 Repository: ambari Description --- Hive view 1.5 was using default DB for use statement in upload table feature. corrected it to use selected database Diffs - contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java a979dc9478 Diff: https://reviews.apache.org/r/59526/diff/1/ Testing --- manual testing done. Thanks, Nitiraj Rathore
Re: Review Request 59222: Hive 1.5.0 view does not load in Internet Explorer 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59222/#review175294
---
Ship it!
Ship It!
- Nitiraj Rathore
On May 12, 2017, 5:15 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59222/
> ---
>
> (Updated May 12, 2017, 5:15 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore,
> and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-21001
> https://issues.apache.org/jira/browse/AMBARI-21001
>
>
> Repository: ambari
>
>
> Description
> ---
>
> 1. Create a Hive 1.5.0 view instance and execute it in IE 11.
> 2. A blank page is displayed with the following error message in the web
> console:
> SCRIPT1002: Syntax error
> File: hive.js, Line: 8374, Column: 23
>
> The error is on this line in fetchServiceCheckPolicy in
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js
>
> this.fetchServiceCheckPolicy()
> .then((data) => {
>
> This is because the ES6 arrow (=>) functions are not supported in IE
>
>
> Diffs
> -
>
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js
> 087bab3
>
>
> Diff: https://reviews.apache.org/r/59222/diff/1/
>
>
> Testing
> ---
>
> Manual testing in FF, Chrome and IE
>
>
> Thanks,
>
> Sangeeta Ravindran
>
>
Review Request 59169: Hive 2.0 View Table Statistics overflows Integer Type convert to Long
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59169/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20981 https://issues.apache.org/jira/browse/AMBARI-20981 Repository: ambari Description --- converted the Integers to Longs to avoid overflow in case big ints are coming from hive Diffs - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java 5d0f307a52 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java 711cab9183 Diff: https://reviews.apache.org/r/59169/diff/1/ Testing --- manual testing done. Thanks, Nitiraj Rathore
Review Request 59087: Hive View 2.0 and 1.5 : The downloaded file name will be shown as ____.csv when we download the query result with the unicode name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59087/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Bugs: AMBARI-20962 https://issues.apache.org/jira/browse/AMBARI-20962 Repository: ambari Description --- made fileName as path param instead of query param. Now downloaded file's name preserves unicode characters. Diffs - contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java 5fa96bb0a8 contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js 8250dbbd84 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java f2e4ee9b6c contrib/views/hive20/src/main/resources/ui/app/adapters/job.js e40c0ba4ac Diff: https://reviews.apache.org/r/59087/diff/1/ Testing --- Done testing on various browsers manually. Thanks, Nitiraj Rathore
Re: Review Request 58997: Users are not able to login to ambari UI after Ambari upgrade from 2.4.x to 2.5.0
> On May 8, 2017, 9:32 a.m., Ashwin Rajeev wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > > Lines 692 (patched) > > <https://reviews.apache.org/r/58997/diff/1/?file=1709264#file1709264line692> > > > > Does it need to be hardcoded ? It's fine as it is specifically for that view only. - Nitiraj --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58997/#review174147 ------- On May 5, 2017, 9:12 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58997/ > --- > > (Updated May 5, 2017, 9:12 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Renjith Kamath, > Ashwin Rajeev, and Yusaku Sako. > > > Bugs: AMBARI-20936 > https://issues.apache.org/jira/browse/AMBARI-20936 > > > Repository: ambari > > > Description > --- > > Instead of deleting entries from DB directly, used uninstalling. Did > refactoring to take the DB related code out of the ViewRegistry (which is > anyway growing very big and is live object which cannot be used during > Upgrade process) to create ViewInstanceOperationHandler.java. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrivilegeEntity.java > ba39efb6a2 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java > 74de530ad7 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > b632c54043 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > d076a5c3b1 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceOperationHandler.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > d136db7e49 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > 190779add8 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceOperationHandlerTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > a3728d46b3 > > > Diff: https://reviews.apache.org/r/58997/diff/1/ > > > Testing > --- > > added : ViewInstanceOperationHandlerTest.java > updated : UpgradeCatalog250Test.java, ViewRegistryTest.java > > Manual testing to see if upgrade works fine with and without LDAP users and > privileges along with UI deletion of view instance. > > > Thanks, > > Nitiraj Rathore > >
Review Request 58997: Users are not able to login to ambari UI after Ambari upgrade from 2.4.x to 2.5.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58997/ --- Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Renjith Kamath, Ashwin Rajeev, and Yusaku Sako. Bugs: AMBARI-20936 https://issues.apache.org/jira/browse/AMBARI-20936 Repository: ambari Description --- Instead of deleting entries from DB directly, used uninstalling. Did refactoring to take the DB related code out of the ViewRegistry (which is anyway growing very big and is live object which cannot be used during Upgrade process) to create ViewInstanceOperationHandler.java. Diffs - ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrivilegeEntity.java ba39efb6a2 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java 74de530ad7 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java b632c54043 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java d076a5c3b1 ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceOperationHandler.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java d136db7e49 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 190779add8 ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceOperationHandlerTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a3728d46b3 Diff: https://reviews.apache.org/r/58997/diff/1/ Testing --- added : ViewInstanceOperationHandlerTest.java updated : UpgradeCatalog250Test.java, ViewRegistryTest.java Manual testing to see if upgrade works fine with and without LDAP users and privileges along with UI deletion of view instance. Thanks, Nitiraj Rathore
Re: Review Request 58886: Smartsense view do not load and shows blank
> On May 1, 2017, 6:59 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java > > Lines 186 (patched) > > <https://reviews.apache.org/r/58886/diff/1/?file=1704053#file1704053line186> > > > > Why does the cluster ID change? > > If that's the root cause, we should fix that instead. > > Nitiraj Rathore wrote: > So I think if the cluster install fails because of some reason. A > reattempt from UI is done and at that time the cluster id is changed. But > this change is not propogated to ViewRegistry and it does not delete already > created auto view instances or changes their cluster id. > Yes this solution is not elegant. Although this bug is rare but when it > comes it creates problems even in correcting the views from the UI. And so > the severity of the bug is high. > I think a better solution would be to fire one event like > "ClusterDeleted" which will be picked up by ViewRegistry and it will delete > the views which were created for that cluster id. > Auto instances will again get created with new cluster id. This solution > might take more time to implement as it touches more surface. > We will log another bug for this change. But the current patch handles > the sitution and keeps ambari and views properly running. > > Alejandro Fernandez wrote: > I'm on the fence about adding code that works around an existing bug, > especially since the root-cause may lead to other areas that need similar > logic. > Instead, I think it's better to reuse the existing cluster object > (especially if the name coincides with an entity that already exists). > Furthermore, if a cluster is deleted, shouldn't the views have FKs to the > cluster_id so that you can't have orphan views? > > Let's come up with a correct way of fixing this. ok - Nitiraj --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58886/#review173490 --- On May 2, 2017, 8:11 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58886/ > --- > > (Updated May 2, 2017, 8:11 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, venkat sairam, and Ashwin Rajeev. > > > Bugs: AMBARI-20905 > https://issues.apache.org/jira/browse/AMBARI-20905 > > > Repository: ambari > > > Description > --- > > If installation fails and is retried the cluster id changes but some view > instances keep older cluster ids which stop views from being displayed later > on. > remove the view instances which contains invalid cluster id before creating > any autoview instance. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java > 061c7223d6 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > b632c54043 > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 24eceb21c6 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java > 25afe92ce4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java > 8836af6ead > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > a3728d46b3 > > > Diff: https://reviews.apache.org/r/58886/diff/2/ > > > Testing > --- > > updated testcases where ever needed. Manual testing also done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 58886: Smartsense view do not load and shows blank
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58886/ --- (Updated May 2, 2017, 8:11 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, venkat sairam, and Ashwin Rajeev. Changes --- checking that the view should also be LOCAL_AMBARI view. Bugs: AMBARI-20905 https://issues.apache.org/jira/browse/AMBARI-20905 Repository: ambari Description --- If installation fails and is retried the cluster id changes but some view instances keep older cluster ids which stop views from being displayed later on. remove the view instances which contains invalid cluster id before creating any autoview instance. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java 061c7223d6 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java b632c54043 ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 24eceb21c6 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java 25afe92ce4 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java 8836af6ead ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a3728d46b3 Diff: https://reviews.apache.org/r/58886/diff/2/ Changes: https://reviews.apache.org/r/58886/diff/1-2/ Testing --- updated testcases where ever needed. Manual testing also done. Thanks, Nitiraj Rathore
Re: Review Request 58886: Smartsense view do not load and shows blank
> On May 1, 2017, 7:13 p.m., Gaurav Nagar wrote: > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > > Lines 1012 (patched) > > <https://reviews.apache.org/r/58886/diff/1/?file=1704055#file1704055line1012> > > > > I think, this will be called for each auto instance. > > Shouldn't we call this before installAutoInstance, so that it will > > execute only once. Should not be a problem, as we are thinking of another better way for next release. If I take it out then the code will spread to multiple places. > On May 1, 2017, 7:13 p.m., Gaurav Nagar wrote: > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > > Lines 1050 (patched) > > <https://reviews.apache.org/r/58886/diff/1/?file=1704055#file1704055line1050> > > > > You need to check if viewInstance's clusterType is LOCAL_AMBARI and > > Id's not contails in list. > > Otherwise it will delete REMOTE_AMBARI configured instances. Ok will do this check and update the patch. - Nitiraj --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58886/#review173491 --- On May 1, 2017, 6:57 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58886/ > --- > > (Updated May 1, 2017, 6:57 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, venkat sairam, and Ashwin Rajeev. > > > Bugs: AMBARI-20905 > https://issues.apache.org/jira/browse/AMBARI-20905 > > > Repository: ambari > > > Description > --- > > If installation fails and is retried the cluster id changes but some view > instances keep older cluster ids which stop views from being displayed later > on. > remove the view instances which contains invalid cluster id before creating > any autoview instance. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java > 061c7223d6 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > b632c54043 > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 24eceb21c6 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java > 25afe92ce4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java > 8836af6ead > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > a3728d46b3 > > > Diff: https://reviews.apache.org/r/58886/diff/1/ > > > Testing > --- > > updated testcases where ever needed. Manual testing also done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 58886: Smartsense view do not load and shows blank
> On May 1, 2017, 6:59 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java > > Lines 186 (patched) > > <https://reviews.apache.org/r/58886/diff/1/?file=1704053#file1704053line186> > > > > Why does the cluster ID change? > > If that's the root cause, we should fix that instead. So I think if the cluster install fails because of some reason. A reattempt from UI is done and at that time the cluster id is changed. But this change is not propogated to ViewRegistry and it does not delete already created auto view instances or changes their cluster id. Yes this solution is not elegant. Although this bug is rare but when it comes it creates problems even in correcting the views from the UI. And so the severity of the bug is high. I think a better solution would be to fire one event like "ClusterDeleted" which will be picked up by ViewRegistry and it will delete the views which were created for that cluster id. Auto instances will again get created with new cluster id. This solution might take more time to implement as it touches more surface. We will log another bug for this change. But the current patch handles the sitution and keeps ambari and views properly running. - Nitiraj --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58886/#review173490 ----------- On May 1, 2017, 6:57 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58886/ > --- > > (Updated May 1, 2017, 6:57 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, venkat sairam, and Ashwin Rajeev. > > > Bugs: AMBARI-20905 > https://issues.apache.org/jira/browse/AMBARI-20905 > > > Repository: ambari > > > Description > --- > > If installation fails and is retried the cluster id changes but some view > instances keep older cluster ids which stop views from being displayed later > on. > remove the view instances which contains invalid cluster id before creating > any autoview instance. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java > 061c7223d6 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > b632c54043 > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 24eceb21c6 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java > 25afe92ce4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java > 8836af6ead > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > a3728d46b3 > > > Diff: https://reviews.apache.org/r/58886/diff/1/ > > > Testing > --- > > updated testcases where ever needed. Manual testing also done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 58887: Sometimes: Command [ambari-server restart] failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58887/ --- (Updated May 1, 2017, 7:16 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Bugs: AMBARI-20906 https://issues.apache.org/jira/browse/AMBARI-20906 Repository: ambari Description --- So from logs it looks like the problem happens when the "view directory watcher" detects change in jar file tries to update the view. The solution to this is not with proof but a precautionary and preventive of nature. I have introduced a property "views.directory.watcher.disable" which can be set to "true" to disable the View Directory Watcher. Disabling will help if ambari does not work fine even after restarts. Another small change is that I have done the method in ViewRegistry to be synchronized. This will remove cases if any where in the view gets simultaneously updated. Diffs - ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java f01df9be7d ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e266dd5693 ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 24eceb21c6 Diff: https://reviews.apache.org/r/58887/diff/1/ Testing (updated) --- Tests cases are clearing. And ambari is coming up properly. Thanks, Nitiraj Rathore
Review Request 58887: Sometimes: Command [ambari-server restart] failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58887/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Bugs: AMBARI-20906 https://issues.apache.org/jira/browse/AMBARI-20906 Repository: ambari Description --- So from logs it looks like the problem happens when the "view directory watcher" detects change in jar file tries to update the view. The solution to this is not with proof but a precautionary and preventive of nature. I have introduced a property "views.directory.watcher.disable" which can be set to "true" to disable the View Directory Watcher. Disabling will help if ambari does not work fine even after restarts. Another small change is that I have done the method in ViewRegistry to be synchronized. This will remove cases if any where in the view gets simultaneously updated. Diffs - ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java f01df9be7d ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e266dd5693 ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 24eceb21c6 Diff: https://reviews.apache.org/r/58887/diff/1/ Testing --- Thanks, Nitiraj Rathore
Review Request 58886: Smartsense view do not load and shows blank
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58886/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, venkat sairam, and Ashwin Rajeev. Bugs: AMBARI-20905 https://issues.apache.org/jira/browse/AMBARI-20905 Repository: ambari Description --- If installation fails and is retried the cluster id changes but some view instances keep older cluster ids which stop views from being displayed later on. remove the view instances which contains invalid cluster id before creating any autoview instance. Diffs - ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java 061c7223d6 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java b632c54043 ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 24eceb21c6 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java 25afe92ce4 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java 8836af6ead ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a3728d46b3 Diff: https://reviews.apache.org/r/58886/diff/1/ Testing --- updated testcases where ever needed. Manual testing also done. Thanks, Nitiraj Rathore
Re: Review Request 58876: Need to show data in sorted order in Hive view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58876/#review173448 --- Ship it! Ship It! - Nitiraj Rathore On April 30, 2017, 10:15 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58876/ > --- > > (Updated April 30, 2017, 10:15 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20139 > https://issues.apache.org/jira/browse/AMBARI-20139 > > > Repository: ambari > > > Description > --- > > Data is shown in the folowing way. > Case 1: Tables list view in 'Query' Tab and 'Tables' tab > Tables should be listed in alphabetical order > Case 2: Jobs should be sorted based on Job Id in 'Jobs' tab. I guess > descending order makes sense. > Case 3 : 'Saved Queries' and 'UDFs' tab > Result should be sorted based on user action time. Recent action should come > first. > Case 4: 'Settings' tab : > Lexicographical order based on KEY. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js > be2771c > contrib/views/hive20/src/main/resources/ui/app/components/setting-list.js > 72a83a3 > contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js dc99fd1 > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > e896348 > contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 68e06a9 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 766157a > > contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs > 338828e > > contrib/views/hive20/src/main/resources/ui/app/templates/components/setting-list.hbs > c3f9c76 > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > ce7315f > contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs f2efaca > > > Diff: https://reviews.apache.org/r/58876/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Review Request 58877: hive view 2.0 : uploaded table does not contain any data.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58877/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20900 https://issues.apache.org/jira/browse/AMBARI-20900 Repository: ambari Description --- Semicolon was missing in the recently changed insert from query. Diffs - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java 19d4f06d71 Diff: https://reviews.apache.org/r/58877/diff/1/ Testing --- manual testing done. Thanks, Nitiraj Rathore
Re: Review Request 58695: HIVE 2 -UX changes- Part1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58695/#review173167 --- Ship it! Ship It! - Nitiraj Rathore On April 27, 2017, 6:10 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58695/ > --- > > (Updated April 27, 2017, 6:10 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20842 > https://issues.apache.org/jira/browse/AMBARI-20842 > > > Repository: ambari > > > Description > --- > > Made CSS related chages. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js > 6005444 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss ca3bc98 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs > 014691e > > contrib/views/hive20/src/main/resources/ui/app/templates/components/notification-message.hbs > c2b32a1 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/table-rename-form.hbs > b692a9c > > contrib/views/hive20/src/main/resources/ui/app/templates/components/table-statistics.hbs > cdcf762 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-edit.hbs > 24cb495 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-item.hbs > 929b91a > > contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-new.hbs > ddf34d7 > contrib/views/hive20/src/main/resources/ui/app/templates/databases.hbs > ecedef5 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 989cfc3 > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > c0b5e82 > contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs ef6a01c > > > Diff: https://reviews.apache.org/r/58695/diff/2/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 58206: Complete node name is not shown when node name is larger than 17 characters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58206/#review171323 --- Ship it! Ship It! - Nitiraj Rathore On April 5, 2017, 10:05 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58206/ > --- > > (Updated April 5, 2017, 10:05 a.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20678 > https://issues.apache.org/jira/browse/AMBARI-20678 > > > Repository: ambari > > > Description > --- > > Introduced ellipsis css class and showing complete name as tooltip. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss f4b63c5 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > 1cfcb15 > > > Diff: https://reviews.apache.org/r/58206/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Review Request 58232: Hive view holds the operational logs open and also fills /tmp
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58232/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Bugs: AMBARI-20690 https://issues.apache.org/jira/browse/AMBARI-20690 Repository: ambari Description --- sync connections were not getting closed after 10 mins window of inactivity. removed the incorrect call to stop scheduler Diffs - contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/HiveActor.java 36bc430b7f contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/JdbcConnector.java 997c28aab3 contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/OperationController.java 98e60f2610 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/HiveActor.java 384b7982bd contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java f93ecbffb3 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/OperationController.java f751d8f54b Diff: https://reviews.apache.org/r/58232/diff/1/ Testing --- manual testing done. Thanks, Nitiraj Rathore
Re: Review Request 58144: HiveView2.0 scrolling in query tab does not work properly for a longer query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58144/#review170861 --- Ship it! Ship It! - Nitiraj Rathore On April 3, 2017, 10:58 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58144/ > --- > > (Updated April 3, 2017, 10:58 a.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20660 > https://issues.apache.org/jira/browse/AMBARI-20660 > > > Repository: ambari > > > Description > --- > > Adding a bottom padding for fixing this issue. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss e083922 > > > Diff: https://reviews.apache.org/r/58144/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 58143: Notification widgets position have been fixed and size have been reduced
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58143/#review170860 --- Ship it! Ship It! - Nitiraj Rathore On April 3, 2017, 10:04 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58143/ > --- > > (Updated April 3, 2017, 10:04 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20659 > https://issues.apache.org/jira/browse/AMBARI-20659 > > > Repository: ambari > > > Description > --- > > Notification panel position have been fixed and it floats according to the > position of the screen, its size have been reduced. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss e083922 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/alert-message.hbs > 2f114f9 > > > Diff: https://reviews.apache.org/r/58143/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58142: Click of "NEW JOB" button doesn't create new worksheet tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58142/#review170858 --- Ship it! Ship It! contrib/views/hive20/src/main/resources/ui/app/templates/components/top-application-bar.hbs Line 27 (original), 27 (patched) <https://reviews.apache.org/r/58142/#comment243720> avoid whitespace-only changes in future patches. - Nitiraj Rathore On April 3, 2017, 9:45 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58142/ > --- > > (Updated April 3, 2017, 9:45 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20658 > https://issues.apache.org/jira/browse/AMBARI-20658 > > > Repository: ambari > > > Description > --- > > We are now checking the count of worksheets present and apeending it to the > worksheet name > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js > b48b8df > > contrib/views/hive20/src/main/resources/ui/app/templates/components/top-application-bar.hbs > f163dca > > > Diff: https://reviews.apache.org/r/58142/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58140: Usability: screen jumps when you scroll down
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58140/#review170857 --- Ship it! Ship It! - Nitiraj Rathore On April 3, 2017, 9:33 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58140/ > --- > > (Updated April 3, 2017, 9:33 a.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20657 > https://issues.apache.org/jira/browse/AMBARI-20657 > > > Repository: ambari > > > Description > --- > > Made the css changes related to min-height of the container. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss e083922 > > contrib/views/hive20/src/main/resources/ui/app/styles/bootstrap-overrides.scss > 4b7bec4 > contrib/views/hive20/src/main/resources/ui/app/templates/application.hbs > 53b2192 > > > Diff: https://reviews.apache.org/r/58140/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 57979: hive view 2.0 handling partition table statistics support added in hive server 2.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57979/ --- (Updated March 28, 2017, 11:02 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Changes --- implemented changes in review comments.. Bugs: AMBARI-20598 https://issues.apache.org/jira/browse/AMBARI-20598 Repository: ambari Description --- added support for stats of partitioned table for hive server version 2.1 and above Diffs (updated) - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/ConnectionDelegate.java f3c4e91e0b contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveJdbcConnectionDelegate.java 5cc60fbb75 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java 45fc786a38 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java c3ed14b2a3 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/GetDatabaseMetadataJob.java PRE-CREATION contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/ResultInformation.java 5b5e17c38d contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/job/Result.java f8c3ba0fb4 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegator.java baa82b4d12 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegatorImpl.java ef4f100ab1 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DatabaseMetadataWrapper.java PRE-CREATION contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnStats.java 190ecd36cb contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java 3048d22190 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/DatabaseMetadataExtractor.java PRE-CREATION contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParser.java aae23c8ba8 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java f2a1933d98 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java 0c93ba31c5 contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js 0310cbc005 contrib/views/hive20/src/main/resources/ui/app/services/stats-service.js 620bf9b61b contrib/views/hive20/src/main/resources/ui/app/templates/components/table-statistics.hbs 5f62fca4e7 Diff: https://reviews.apache.org/r/57979/diff/2/ Changes: https://reviews.apache.org/r/57979/diff/1-2/ Testing --- manual testing done for hive 2.1 and hive 1.2 for partitioned and non partitioned tables. Thanks, Nitiraj Rathore
Re: Review Request 57979: hive view 2.0 handling partition table statistics support added in hive server 2.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57979/ --- (Updated March 27, 2017, 11:29 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Summary (updated) - hive view 2.0 handling partition table statistics support added in hive server 2.1 Bugs: AMBARI-20598 https://issues.apache.org/jira/browse/AMBARI-20598 Repository: ambari Description --- added support for stats of partitioned table for hive server version 2.1 and above Diffs - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/ConnectionDelegate.java f3c4e91e0b contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveJdbcConnectionDelegate.java 5cc60fbb75 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java 45fc786a38 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java c3ed14b2a3 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/GetDatabaseMetadataJob.java PRE-CREATION contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/ResultInformation.java 5b5e17c38d contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/job/Result.java f8c3ba0fb4 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegator.java baa82b4d12 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegatorImpl.java ef4f100ab1 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DatabaseMetadataWrapper.java PRE-CREATION contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnStats.java 190ecd36cb contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java 3048d22190 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParser.java aae23c8ba8 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java f2a1933d98 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java 0c93ba31c5 contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js 0310cbc005 contrib/views/hive20/src/main/resources/ui/app/services/stats-service.js 620bf9b61b contrib/views/hive20/src/main/resources/ui/app/templates/components/table-statistics.hbs 5f62fca4e7 Diff: https://reviews.apache.org/r/57979/diff/1/ Testing --- manual testing done for hive 2.1 and hive 1.2 for partitioned and non partitioned tables. Thanks, Nitiraj Rathore
Re: Review Request 57979: Not able to compute the table statistics for partitioned table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57979/ --- (Updated March 27, 2017, 11:29 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Bugs: AMBARI-20598 https://issues.apache.org/jira/browse/AMBARI-20598 Repository: ambari Description --- added support for stats of partitioned table for hive server version 2.1 and above Diffs - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/ConnectionDelegate.java f3c4e91e0b contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveJdbcConnectionDelegate.java 5cc60fbb75 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java 45fc786a38 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java c3ed14b2a3 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/GetDatabaseMetadataJob.java PRE-CREATION contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/ResultInformation.java 5b5e17c38d contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/job/Result.java f8c3ba0fb4 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegator.java baa82b4d12 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegatorImpl.java ef4f100ab1 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DatabaseMetadataWrapper.java PRE-CREATION contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnStats.java 190ecd36cb contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java 3048d22190 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParser.java aae23c8ba8 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java f2a1933d98 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java 0c93ba31c5 contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js 0310cbc005 contrib/views/hive20/src/main/resources/ui/app/services/stats-service.js 620bf9b61b contrib/views/hive20/src/main/resources/ui/app/templates/components/table-statistics.hbs 5f62fca4e7 Diff: https://reviews.apache.org/r/57979/diff/1/ Testing --- manual testing done for hive 2.1 and hive 1.2 for partitioned and non partitioned tables. Thanks, Nitiraj Rathore
Review Request 57979: Not able to compute the table statistics for partitioned table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57979/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Bugs: AMBARI-20113 https://issues.apache.org/jira/browse/AMBARI-20113 Repository: ambari Description --- added support for stats of partitioned table for hive server version 2.1 and above Diffs - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/ConnectionDelegate.java f3c4e91e0b contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveJdbcConnectionDelegate.java 5cc60fbb75 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java 45fc786a38 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java c3ed14b2a3 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/GetDatabaseMetadataJob.java PRE-CREATION contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/ResultInformation.java 5b5e17c38d contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/job/Result.java f8c3ba0fb4 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegator.java baa82b4d12 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DDLDelegatorImpl.java ef4f100ab1 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/client/DatabaseMetadataWrapper.java PRE-CREATION contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnStats.java 190ecd36cb contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java 3048d22190 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParser.java aae23c8ba8 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java f2a1933d98 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java 0c93ba31c5 contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js 0310cbc005 contrib/views/hive20/src/main/resources/ui/app/services/stats-service.js 620bf9b61b contrib/views/hive20/src/main/resources/ui/app/templates/components/table-statistics.hbs 5f62fca4e7 Diff: https://reviews.apache.org/r/57979/diff/1/ Testing --- manual testing done for hive 2.1 and hive 1.2 for partitioned and non partitioned tables. Thanks, Nitiraj Rathore
Re: Review Request 57942: Issue in pig view after enabling strict mode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57942/#review170135 --- Ship it! Ship It! - Nitiraj Rathore On March 27, 2017, 4:01 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57942/ > --- > > (Updated March 27, 2017, 4:01 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20576 > https://issues.apache.org/jira/browse/AMBARI-20576 > > > Repository: ambari > > > Description > --- > > Fixed vairable undefined errors after enabling strict mode > > > Diffs > - > > contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js > 66e1c88 > > > Diff: https://reviews.apache.org/r/57942/diff/1/ > > > Testing > --- > > Manual tetsing done > > > Thanks, > > venkat sairam > >
Review Request 57835: make home directory check as optional in Pig view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57835/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Renjith Kamath. Bugs: AMBARI-20527 https://issues.apache.org/jira/browse/AMBARI-20527 Repository: ambari Description --- used property views.skip.home-directory-check.file-system.list in ambari.properties to skip home directory test based on the filesystem set in fs.defaultFS Diffs - ambari-server/conf/unix/ambari.properties 5866fe7 ambari-server/conf/windows/ambari.properties c1c0a99 contrib/views/pig/src/main/java/org/apache/ambari/view/pig/services/HelpService.java a67bfc5 contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/Constants.java PRE-CREATION contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/ServiceCheck.java PRE-CREATION contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js d1b571d contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js b30552d contrib/views/pig/src/main/resources/ui/pig-web/app/templates/splash.hbs c97d724 Diff: https://reviews.apache.org/r/57835/diff/1/ Testing --- Manual testing done. Thanks, Nitiraj Rathore
Re: Review Request 57776: Hive View2.0: Upload table fails, if one column is deleted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57776/#review169432 --- contrib/views/hive20/src/main/resources/ui/app/components/column-item.js Line 27 (original), 27 (patched) <https://reviews.apache.org/r/57776/#comment241776> Make this options object instead. - Nitiraj Rathore On March 20, 2017, 12:59 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57776/ > --- > > (Updated March 20, 2017, 12:59 p.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20497 > https://issues.apache.org/jira/browse/AMBARI-20497 > > > Repository: ambari > > > Description > --- > > Added a var 'fromUploadTable' as true when it comes from upload table > otherwise false. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/column-item.js > f2e45bd > contrib/views/hive20/src/main/resources/ui/app/components/create-table.js > 322aab5 > contrib/views/hive20/src/main/resources/ui/app/components/table-columns.js > 7d83353 > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js > e6b71fe > > contrib/views/hive20/src/main/resources/ui/app/templates/components/column-item.hbs > 762c77c > > contrib/views/hive20/src/main/resources/ui/app/templates/components/create-table.hbs > f369783 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/table-columns.hbs > b942136 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs > 0ee6b81 > > contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/upload-table.hbs > 0091ede > > > Diff: https://reviews.apache.org/r/57776/diff/1/ > > > Testing > --- > > manually test. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 57556: Hive View link in service page points to v1.5 auto instance
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57556/#review168854 --- Ship it! Ship It! - Nitiraj Rathore On March 13, 2017, 12:41 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57556/ > --- > > (Updated March 13, 2017, 12:41 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20418 > https://issues.apache.org/jira/browse/AMBARI-20418 > > > Repository: ambari > > > Description > --- > > On click of Hive view link in service page will now points to v2.0 hive view > auto instance > > > Diffs > - > > ambari-web/app/views/main/service/services/hive.js c8c341c > > > Diff: https://reviews.apache.org/r/57556/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57453: Fix up tez view version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57453/ --- (Updated March 14, 2017, 1:59 a.m.) Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Pallav Kulshreshtha, Rohit Choudhary, Sreenath Somarajapuram, and Ashwin Rajeev. Changes --- removed conflicts and uploaded updated patch Bugs: AMBARI-20370 https://issues.apache.org/jira/browse/AMBARI-20370 Repository: ambari Description --- tez view version and build removed and short url of auto instance used for property tez.tez-ui.history-url.base in tez-site Removed change of tez version from AbstractUpgradeCatalog. UpgardeCatalog250 now contains code to change the previous value of tez.tez-ui.history-url.base to http://HOST:PORT/#/main/view/TEZ/tez_cluster_instance changed stack_advisor.py in 2.2 and 2.3 for this change to reflect during installation Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 9be541f ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java e3afc33 ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py d45cf96 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 6d0ce38 ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 5fa7cac ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java ad21331 ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 5fce011 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py b1ec05b Diff: https://reviews.apache.org/r/57453/diff/2/ Changes: https://reviews.apache.org/r/57453/diff/1-2/ Testing --- Tested the upgrade from 2.4.0.2 to 2.5.0.0. Tested installation of fresh 2.5.0.0 Added test cases for changes in UpgardeCatalog250. updated test_stack_advisor.py test cases. Thanks, Nitiraj Rathore
Re: Review Request 57549: Export workflow will create a workflow with workflow name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57549/#review168742 --- Ship it! Ship It! - Nitiraj Rathore On March 13, 2017, 9:02 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57549/ > --- > > (Updated March 13, 2017, 9:02 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20411 > https://issues.apache.org/jira/browse/AMBARI-20411 > > > Repository: ambari > > > Description > --- > > Workflow exported will be created will be created with workflow name field > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > f542c07 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 5577239 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs > c190511 > > > Diff: https://reviews.apache.org/r/57549/diff/2/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Review Request 57453: Fix up tez view version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57453/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Pallav Kulshreshtha, Rohit Choudhary, Sreenath Somarajapuram, and Ashwin Rajeev. Bugs: AMBARI-20370 https://issues.apache.org/jira/browse/AMBARI-20370 Repository: ambari Description --- tez view version and build removed and short url of auto instance used for property tez.tez-ui.history-url.base in tez-site Removed change of tez version from AbstractUpgradeCatalog. UpgardeCatalog250 now contains code to change the previous value of tez.tez-ui.history-url.base to http://HOST:PORT/#/main/view/TEZ/tez_cluster_instance changed stack_advisor.py in 2.2 and 2.3 for this change to reflect during installation Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 9be541f ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 00d1c31 ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py d45cf96 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 6d0ce38 ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 5fa7cac ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 1a87433 ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 5fce011 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py b1ec05b Diff: https://reviews.apache.org/r/57453/diff/1/ Testing --- Tested the upgrade from 2.4.0.2 to 2.5.0.0. Tested installation of fresh 2.5.0.0 Added test cases for changes in UpgardeCatalog250. updated test_stack_advisor.py test cases. Thanks, Nitiraj Rathore
Re: Review Request 57416: [Hive2] JS error in udf delete
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57416/#review168285 --- Ship it! Ship It! - Nitiraj Rathore On March 8, 2017, 11:06 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57416/ > --- > > (Updated March 8, 2017, 11:06 a.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20357 > https://issues.apache.org/jira/browse/AMBARI-20357 > > > Repository: ambari > > > Description > --- > > Change the code to make sure the data get persists and no operation happens > in flight. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js > 44f56e5 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 08af7d4 > contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 138e85f > contrib/views/hive20/src/main/resources/ui/app/routes/udfs/new.js 84733e8 > contrib/views/hive20/src/main/resources/ui/app/services/auto-refresh.js > 2e8ec62 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-item.hbs > fec48fb > contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs ef6a01c > > > Diff: https://reviews.apache.org/r/57416/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 57370: Issue with toggling of Execute/Stop button in query page while successful and failure execution of query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57370/#review168251 --- Ship it! Ship It! - Nitiraj Rathore On March 7, 2017, 11:40 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57370/ > --- > > (Updated March 7, 2017, 11:40 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20340 > https://issues.apache.org/jira/browse/AMBARI-20340 > > > Repository: ambari > > > Description > --- > > We have passed the scope of controller to the function to execute it in the > respecitve scope as closure. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > e1ab620 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1b18955 > > > Diff: https://reviews.apache.org/r/57370/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57368: JS Lint warning removal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57368/#review168118 --- Ship it! Ship It! - Nitiraj Rathore On March 7, 2017, 11:25 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57368/ > --- > > (Updated March 7, 2017, 11:25 a.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20339 > https://issues.apache.org/jira/browse/AMBARI-20339 > > > Repository: ambari > > > Description > --- > > Corrected all the errros/warnings came through JS Lint > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/.jshintrc d421faa > contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js > a25adc7 > contrib/views/hive20/src/main/resources/ui/app/adapters/hdfs-viewer.js > dcd52b8 > contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 7559e9c > contrib/views/hive20/src/main/resources/ui/app/adapters/query.js 4913fe2 > contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js > a25adc7 > contrib/views/hive20/src/main/resources/ui/app/adapters/table-info.js > 46e7591 > contrib/views/hive20/src/main/resources/ui/app/adapters/table.js e133419 > contrib/views/hive20/src/main/resources/ui/app/adapters/udf.js c929de7 > contrib/views/hive20/src/main/resources/ui/app/adapters/upload-table.js > 3bfe15b > contrib/views/hive20/src/main/resources/ui/app/components/create-table.js > 670ebd7 > contrib/views/hive20/src/main/resources/ui/app/components/edit-table.js > 439dbcf > contrib/views/hive20/src/main/resources/ui/app/components/export-result.js > 517da1e > > contrib/views/hive20/src/main/resources/ui/app/components/fileresource-item.js > 12cfb5b > contrib/views/hive20/src/main/resources/ui/app/components/job-item.js > 8a6d318 > contrib/views/hive20/src/main/resources/ui/app/components/list-filter.js > db0b5c0 > > contrib/views/hive20/src/main/resources/ui/app/components/notification-message.js > 339e095 > contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js > c033e42 > > contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js > a2eb349 > > contrib/views/hive20/src/main/resources/ui/app/components/table-advanced-settings.js > 5e58cd8 > contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js > 9e11550 > contrib/views/hive20/src/main/resources/ui/app/components/udf-new.js > 285ef07 > > contrib/views/hive20/src/main/resources/ui/app/components/validated-text-field.js > 2379a15 > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js > 8f216d1 > contrib/views/hive20/src/main/resources/ui/app/configs/datatypes.js 0d07ce2 > contrib/views/hive20/src/main/resources/ui/app/controllers/service-check.js > 8a621db > contrib/views/hive20/src/main/resources/ui/app/helpers/extract-value.js > 76b3dee > > contrib/views/hive20/src/main/resources/ui/app/helpers/format-column-size.js > a24f797 > contrib/views/hive20/src/main/resources/ui/app/models/table-property.js > 751f55c > contrib/views/hive20/src/main/resources/ui/app/router.js 250f945 > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/new.js > b29d863 > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js > 2fa61b4 > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js > e4c543b > contrib/views/hive20/src/main/resources/ui/app/routes/jobs.js c27c74d > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > e1ab620 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/log.js > 52f8dcc > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > f3b27c8 > contrib/views/hive20/src/main/resources/ui/app/routes/settings.js f45881b > contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js fdb2cad > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js fe1b596 > contrib/views/hive20/src/main/resources/ui/app/services/query.js 6860f4d > contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js > 2752375 >
Re: Review Request 57291: HiveView2.0: Issues in worksheet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57291/#review167956 --- Ship it! Ship It! - Nitiraj Rathore On March 3, 2017, 3:11 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57291/ > --- > > (Updated March 3, 2017, 3:11 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20303 > https://issues.apache.org/jira/browse/AMBARI-20303 > > > Repository: ambari > > > Description > --- > > Worksheet tab is provided with the button to close the worksheet and upon > double-click of worksheet tab, rename modal will be opened. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js f820ea0 > contrib/views/hive20/src/main/resources/ui/app/routes/queries.js 4ef3834 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js > 7bd2214 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > d08a47b > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 6b7fc6a > contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs > b8e19da > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 8a771eb > > > Diff: https://reviews.apache.org/r/57291/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57279: Simple queries show "no tez plan found"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57279/#review167829 --- Ship it! Ship It! - Nitiraj Rathore On March 3, 2017, 11:10 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57279/ > --- > > (Updated March 3, 2017, 11:10 a.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20294 > https://issues.apache.org/jira/browse/AMBARI-20294 > > > Repository: ambari > > > Description > --- > > Added condition for showing the plan for simple queries. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js > fc7cf64 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > d08a47b > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/fallback.js > 2310b3c > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/index.js > 3513a23 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js > 48706cb > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > f69b1d4 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js > e6cf3f3 > > > Diff: https://reviews.apache.org/r/57279/diff/1/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 57137: Table statistics is not getting computed when 'include columns' is checked
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57137/ --- (Updated March 2, 2017, 4:31 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Changes --- updated patch after resolving conflicts. Bugs: AMBARI-20091 https://issues.apache.org/jira/browse/AMBARI-20091 Repository: ambari Description --- 1) analyze table compute stats for columns 2) analyze table compute stats First one is to collect column statistics and second one is to collect basic stats. numRows, dataSize etc. is computed via 2) To get all stats one has to run both statements. Hence implemented in that way. Diffs (updated) - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java dbe9d43 contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy 7bc5850 Diff: https://reviews.apache.org/r/57137/diff/2/ Changes: https://reviews.apache.org/r/57137/diff/1-2/ Testing --- added spock test AnalyzeTableQueryGeneratorSpecTest.groovy Thanks, Nitiraj Rathore
Re: Review Request 57198: HiveView2.0: Can not create a table with space in column name with upload table feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57198/ --- (Updated March 1, 2017, 6:16 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Changes --- update patch to remove conflicts Bugs: AMBARI-20181 https://issues.apache.org/jira/browse/AMBARI-20181 Repository: ambari Description --- added back ticks in the query Diffs (updated) - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java 9f179d1 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGenerator.java eab3a4b contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java b544100 contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/CreateTableQueryGeneratorTest.java f5a9778 contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGeneratorSpecTest.groovy PRE-CREATION Diff: https://reviews.apache.org/r/57198/diff/2/ Changes: https://reviews.apache.org/r/57198/diff/1-2/ Testing --- added InsertFromQueryGeneratorSpecTest.groovy test class Thanks, Nitiraj Rathore
Re: Review Request 56977: Not able to compute the table statistics for partitioned table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56977/ --- (Updated March 1, 2017, 5:37 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Changes --- resolved conflicts and uploaded new patch Bugs: AMBARI-20113 https://issues.apache.org/jira/browse/AMBARI-20113 Repository: ambari Description --- corrected the case of partitioned table in analyze query generation. Diffs (updated) - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java 1d68407 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java e433dc4 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java 89b9d84 contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy PRE-CREATION Diff: https://reviews.apache.org/r/56977/diff/2/ Changes: https://reviews.apache.org/r/56977/diff/1-2/ Testing --- AnalyzeTableQueryGeneratorSpecTest unit test case added. Thanks, Nitiraj Rathore
Review Request 57143: HiveView2.0 - settings not taking effect
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57143/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Bugs: AMBARI-20234 https://issues.apache.org/jira/browse/AMBARI-20234 Repository: ambari Description --- added global settings to forcedContent before sending REST call to server. Diffs - contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 8f0085c Diff: https://reviews.apache.org/r/57143/diff/ Testing --- manual testing done. Thanks, Nitiraj Rathore
Re: Review Request 57137: Table statistics is not getting computed when 'include columns' is checked
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57137/ --- (Updated Feb. 28, 2017, 11:24 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Bugs: AMBARI-20091 https://issues.apache.org/jira/browse/AMBARI-20091 Repository: ambari Description --- 1) analyze table compute stats for columns 2) analyze table compute stats First one is to collect column statistics and second one is to collect basic stats. numRows, dataSize etc. is computed via 2) To get all stats one has to run both statements. Hence implemented in that way. Diffs - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java 902d959 contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy PRE-CREATION Diff: https://reviews.apache.org/r/57137/diff/ Testing --- added spock test AnalyzeTableQueryGeneratorSpecTest.groovy Thanks, Nitiraj Rathore
Review Request 57129: revert pom.xml changes of AMBARI-19528 for views other than files view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57129/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Bugs: AMBARI-20226 https://issues.apache.org/jira/browse/AMBARI-20226 Repository: ambari Description --- removed exclusion of jars which were not required. Diffs - contrib/views/commons/pom.xml fb4deea contrib/views/hive-next/pom.xml cd26d5e contrib/views/hive20/pom.xml fe85a35 contrib/views/pig/pom.xml f99b2bb contrib/views/utils/pom.xml edb1a02 contrib/views/wfmanager/pom.xml a659de1 Diff: https://reviews.apache.org/r/57129/diff/ Testing --- manually tested all views with hdfs and also files view with s3 Thanks, Nitiraj Rathore
Re: Review Request 57124: Hive view 2.0 Fetch stats doesn't work when you point against LLAP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57124/#review167024 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 28, 2017, 5:32 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57124/ > --- > > (Updated Feb. 28, 2017, 5:32 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20223 > https://issues.apache.org/jira/browse/AMBARI-20223 > > > Repository: ambari > > > Description > --- > > For fetching stats we are using old query syntax that wont work in Hive 2.0. > Changed the query to newer syntax. > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGenerator.java > b119f6a > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java > 902d959 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/FetchColumnStatsQueryGenerator.java > 73b3698 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java > 42cec0a > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGenerator.java > 3406b80 > > contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGeneratorTest.java > 35ea416 > > contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGeneratorSpecTest.groovy > cce9e6c > > Diff: https://reviews.apache.org/r/57124/diff/ > > > Testing > --- > > Manually Tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 57079: All the workflow details are getting logged in UI console log
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57079/#review166845 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 27, 2017, 10:04 a.m., belliraj hb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57079/ > --- > > (Updated Feb. 27, 2017, 10:04 a.m.) > > > Review request for Ambari, Gaurav Nagar, Pallav Kulshreshtha, and Rohit > Choudhary. > > > Bugs: AMBARI-20132 > https://issues.apache.org/jira/browse/AMBARI-20132 > > > Repository: ambari > > > Description > --- > > All console logs are removed. duplicate methods are removed. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > 61d9f35e72 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 8597d72c23 > contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js > 00dedbb5ba > contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js > f65931738c > contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js > 01da55bbc5 > > contrib/views/wfmanager/src/main/resources/ui/app/components/sqoop-action.js > 67ba85aabe > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js > e19646df5f > > contrib/views/wfmanager/src/main/resources/ui/app/domain/action-type-resolver.js > 8cbcfafa91 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-generator.js > f2dcef931e > > contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-generator.js > 4c8d16f2c4 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js > bc61f1079d > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > 75ceecbe46 > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js > e05b782b26 > contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js > 67605ae4a6 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > ae566f29e3 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js > fa7a8b8f92 > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > be8d8de780 > > contrib/views/wfmanager/src/main/resources/ui/app/routes/design/proj-manager-tab.js > 685b49c90b > contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js > b9ea770ae5 > > contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js > c377eccf02 > contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js > 7ad4361b9e > > Diff: https://reviews.apache.org/r/57079/diff/ > > > Testing > --- > > Manual > > > Thanks, > > belliraj hb > >
Re: Review Request 57035: ambari-server package size increased from 645MB to 1GB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57035/ --- (Updated Feb. 24, 2017, 2:47 p.m.) Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Changes --- changed jar from dependencyManagement to dependencies. Bugs: AMBARI-20170 https://issues.apache.org/jira/browse/AMBARI-20170 Repository: ambari Description --- excluded the aws bundled jar from transitive dependency of hadoop-aws and included explicitly only in files view Diffs (updated) - contrib/views/files/pom.xml 410ed1e contrib/views/pom.xml dda956f contrib/views/utils/pom.xml 324fb1a Diff: https://reviews.apache.org/r/57035/diff/ Testing --- created build and tested the files sizes. The overall decrease in size would be 300 MB. Thanks, Nitiraj Rathore
Re: Review Request 57033: Hive 2: Compact Visual Explain Plan is not loading in firefox
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57033/#review166705 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 24, 2017, 11:17 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57033/ > --- > > (Updated Feb. 24, 2017, 11:17 a.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20168 > https://issues.apache.org/jira/browse/AMBARI-20168 > > > Repository: ambari > > > Description > --- > > Added a new function for handling firefox browser > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs > db1cea2 > > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs > 370e3ef > > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs > ef441b5 > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js > 5dbeb2b > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > 5fa5d2e > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js > 70647a8 > > Diff: https://reviews.apache.org/r/57033/diff/ > > > Testing > --- > > manually tested > > > Thanks, > > Pallav Kulshreshtha > >
Review Request 57035: ambari-server package size increased from 645MB to 1GB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57035/ --- Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Bugs: AMBARI-20170 https://issues.apache.org/jira/browse/AMBARI-20170 Repository: ambari Description --- excluded the aws bundled jar from transitive dependency of hadoop-aws and included explicitly only in files view Diffs - contrib/views/files/pom.xml 410ed1e contrib/views/pom.xml dda956f contrib/views/utils/pom.xml 324fb1a Diff: https://reviews.apache.org/r/57035/diff/ Testing --- created build and tested the files sizes. The overall decrease in size would be 300 MB. Thanks, Nitiraj Rathore
Re: Review Request 56975: File upload from Ambari File View does not work in Chrome 56.0.2924.87 and IE 11
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56975/#review166511 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 23, 2017, 8:59 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56975/ > --- > > (Updated Feb. 23, 2017, 8:59 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20137 > https://issues.apache.org/jira/browse/AMBARI-20137 > > > Repository: ambari > > > Description > --- > > 1. Fixed Cannot add directory issue in chrome > 2. Disable cache for ajax > 3. Handle filename in UTF-8 > > > Diffs > - > > > contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/UploadService.java > 26a4873 > contrib/views/files/src/main/resources/ui/app/adapters/application.js > 4042851 > contrib/views/files/src/main/resources/ui/app/components/upload-file.js > 96686db > > Diff: https://reviews.apache.org/r/56975/diff/ > > > Testing > --- > > Manually Tested. > > > Thanks, > > Gaurav Nagar > >
Review Request 56977: Not able to compute the table statistics for partitioned table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56977/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Bugs: AMBARI-20113 https://issues.apache.org/jira/browse/AMBARI-20113 Repository: ambari Description --- corrected the case of partitioned table in analyze query generation. Diffs - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java 902d959 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java e433dc4 contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java 89b9d84 contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy PRE-CREATION Diff: https://reviews.apache.org/r/56977/diff/ Testing --- AnalyzeTableQueryGeneratorSpecTest unit test case added. Thanks, Nitiraj Rathore
Re: Review Request 56915: AMBARI-20107.Action node shows unsupported properties even though there are none in workflow manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56915/#review166355 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 22, 2017, 6:32 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56915/ > --- > > (Updated Feb. 22, 2017, 6:32 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20107 > https://issues.apache.org/jira/browse/AMBARI-20107 > > > Repository: ambari > > > Description > --- > > The issue is because the jsog object id is appended to the xml. Fixed by > excluding jsog object id in the unsupported properties. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js > d09de7d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs > fae2d3d > > Diff: https://reviews.apache.org/r/56915/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56922: Hive2: Query in query editor is getting modified while navigating across different tabs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56922/#review166341 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 22, 2017, 7:24 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56922/ > --- > > (Updated Feb. 22, 2017, 7:24 a.m.) > > > Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20111 > https://issues.apache.org/jira/browse/AMBARI-20111 > > > Repository: ambari > > > Description > --- > > Saving the right value in the model. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/configs/result-tabs.js > f48dcd8 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 9196d8b > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > c2a0c8c > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > c3d907d > > Diff: https://reviews.apache.org/r/56922/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56915: AMBARI-20107.Action node shows unsupported properties even though there are none in workflow manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56915/#review166327 --- contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js (line 72) <https://reviews.apache.org/r/56915/#comment238276> It looks like this might break if some more internal keys are added to ember objects in later versions. Can you rely on something like : JSON.parse(JSON.stringify(unsupportedProperties)) to get plain js object. - Nitiraj Rathore On Feb. 22, 2017, 6:32 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56915/ > --- > > (Updated Feb. 22, 2017, 6:32 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20107 > https://issues.apache.org/jira/browse/AMBARI-20107 > > > Repository: ambari > > > Description > --- > > The issue is because the jsog object id is appended to the xml. Fixed by > excluding jsog object id in the unsupported properties. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js > d09de7d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs > fae2d3d > > Diff: https://reviews.apache.org/r/56915/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56882: Unique Name not created automatically when designing workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56882/#review166157 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 21, 2017, 12:17 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56882/ > --- > > (Updated Feb. 21, 2017, 12:17 p.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20095 > https://issues.apache.org/jira/browse/AMBARI-20095 > > > Repository: ambari > > > Description > --- > > Create a workflow > Keep adding actions and WFD shows error saying that node name should be > unique. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 190bb1a > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > a563c20 > > Diff: https://reviews.apache.org/r/56882/diff/ > > > Testing > --- > > Manual Testing done > > > Thanks, > > venkat sairam > >
Review Request 56786: Hive view 2.0 upload table feature does not show error notifications when errors occurs during the process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56786/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-20064 https://issues.apache.org/jira/browse/AMBARI-20064 Repository: ambari Description --- added notification in upload table feature. Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js 8df03e5 contrib/views/hive20/src/main/resources/ui/app/mixins/ui-logger.js 277f69c contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js a9bf9ea contrib/views/hive20/src/main/resources/ui/app/services/alert-messages.js a05fc7a contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs e4388f0 Diff: https://reviews.apache.org/r/56786/diff/ Testing --- manual testing done. Thanks, Nitiraj Rathore
Re: Review Request 56745: Workflow Manager workflow rendering is broken in designer page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56745/#review165831 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 16, 2017, 10:58 a.m., belliraj hb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56745/ > --- > > (Updated Feb. 16, 2017, 10:58 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav > Kulshreshtha. > > > Bugs: AMBARI-20040 > https://issues.apache.org/jira/browse/AMBARI-20040 > > > Repository: ambari > > > Description > --- > > Error nodes are now displayed if transition points to kill node on an > non-error condition. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > 4194d5e612 > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js > 5a074dfdac > > contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js > 5282544a93 > > Diff: https://reviews.apache.org/r/56745/diff/ > > > Testing > --- > > Manual testing > > > Thanks, > > belliraj hb > >
Review Request 56705: Hive server error on view navigation when wire encryption is enabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56705/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-20021 https://issues.apache.org/jira/browse/AMBARI-20021 Repository: ambari Description --- in ambari views : removed exclusion of httpcore and httpclient libraries and added in dependencyManagement to version 4.4 Diffs - contrib/views/commons/pom.xml 9dd18ac contrib/views/files/pom.xml 2e742df contrib/views/hive-next/pom.xml 19f55ee contrib/views/hive20/pom.xml cf5fdde contrib/views/pig/pom.xml 738d410 contrib/views/pom.xml c8a88cb contrib/views/utils/pom.xml ead33b2 contrib/views/wfmanager/pom.xml 06fbfeb Diff: https://reviews.apache.org/r/56705/diff/ Testing --- manual testing done on cluster with hdfs and s3 support Thanks, Nitiraj Rathore
Re: Review Request 56660: AMBARI-20005:Credentials from one workflow are getting associated across other workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56660/#review165503 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 14, 2017, 1:06 p.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56660/ > --- > > (Updated Feb. 14, 2017, 1:06 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20005 > https://issues.apache.org/jira/browse/AMBARI-20005 > > > Repository: ambari > > > Description > --- > > Fixed by clearing credentials array when creating a workflow > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > 1f02426 > > Diff: https://reviews.apache.org/r/56660/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56572: Hive2. Visual Explain -Show additional info when you click on a box, i.e. can drill down to get more info on operators.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56572/#review165251 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 11, 2017, 10:26 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56572/ > --- > > (Updated Feb. 11, 2017, 10:26 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19975 > https://issues.apache.org/jira/browse/AMBARI-19975 > > > Repository: ambari > > > Description > --- > > created visual explain detail component > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain-detail.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js > 6551974 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > dcf27b4 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1dc86d7 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain-detail.hbs > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs > 4238d43 > > Diff: https://reviews.apache.org/r/56572/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56572: Hive2. Visual Explain -Show additional info when you click on a box, i.e. can drill down to get more info on operators.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56572/#review165248 --- contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js (line 83) <https://reviews.apache.org/r/56572/#comment237078> is this false a typo. if it is please correct and ship - Nitiraj Rathore On Feb. 11, 2017, 10:26 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56572/ > --- > > (Updated Feb. 11, 2017, 10:26 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19975 > https://issues.apache.org/jira/browse/AMBARI-19975 > > > Repository: ambari > > > Description > --- > > created visual explain detail component > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain-detail.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js > 6551974 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > dcf27b4 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1dc86d7 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain-detail.hbs > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs > 4238d43 > > Diff: https://reviews.apache.org/r/56572/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56542: Hive View 2.0 - deleting a saved query is buggy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56542/#review165247 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 10, 2017, 12:27 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56542/ > --- > > (Updated Feb. 10, 2017, 12:27 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19958 > https://issues.apache.org/jira/browse/AMBARI-19958 > > > Repository: ambari > > > Description > --- > > Setting the controller value to reflect the changes. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js > 5ee757b > contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js > 27d43d5 > contrib/views/hive20/src/main/resources/ui/app/controllers/saved-query.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > dcf27b4 > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > 7b9cb09 > contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js > 29ef4b5 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 2d6c5aa > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > 36dc982 > > Diff: https://reviews.apache.org/r/56542/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56379: AMBARI-19418: Support setup queue priority in Ambari - Capacity scheduler view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56379/#review165096 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 10, 2017, 7:38 a.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56379/ > --- > > (Updated Feb. 10, 2017, 7:38 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Sreenath Somarajapuram. > > > Bugs: AMBARI-19418 > https://issues.apache.org/jira/browse/AMBARI-19418 > > > Repository: ambari > > > Description > --- > > Feature to support queue priority config settings in YARN > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js > 589dcd0 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js > 2f9f2fe > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > 9198aa5 > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js > 940d0f8 > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js dce00c1 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs > 87f00d9 > > Diff: https://reviews.apache.org/r/56379/diff/ > > > Testing > --- > > Manunal Unit Testing > > > Thanks, > > Akhil PB > >
Review Request 56538: Hive view 2.0 upload table does not provide first row is header check box.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56538/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-19955 https://issues.apache.org/jira/browse/AMBARI-19955 Repository: ambari Description --- added the first row is header checkbox and its functionality Diffs - contrib/views/hive20/src/main/resources/ui/app/components/csv-format-params.js 7a14ba8 contrib/views/hive20/src/main/resources/ui/app/models/column.js f38309b contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js ba3260c contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js a5be574 contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs a7cb862 Diff: https://reviews.apache.org/r/56538/diff/ Testing --- manual testing done. Thanks, Nitiraj Rathore
Re: Review Request 56488: Hive2: xxx; never returns
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56488/#review164899 --- contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js <https://reviews.apache.org/r/56488/#comment236740> Please set a meaningful summary. - Nitiraj Rathore On Feb. 9, 2017, 11:25 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56488/ > --- > > (Updated Feb. 9, 2017, 11:25 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19938 > https://issues.apache.org/jira/browse/AMBARI-19938 > > > Repository: ambari > > > Description > --- > > Added a modal for error. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > dcf27b4 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 8ee8e87 > > Diff: https://reviews.apache.org/r/56488/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56483: HiveView2.0: DB panel shows up on Query result full screen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56483/#review164891 --- contrib/views/hive20/src/main/resources/ui/app/services/query.js (line 83) <https://reviews.apache.org/r/56483/#comment236733> can this be put into jobs service. Also it would be more usable if this returns job object in resolve. Also if error we should check for status "cancelled". This will happen if user cancels the job from hive view UI or yarn UI or otherwise cancels a running job. - Nitiraj Rathore On Feb. 9, 2017, 9:16 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56483/ > --- > > (Updated Feb. 9, 2017, 9:16 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19931 > https://issues.apache.org/jira/browse/AMBARI-19931 > > > Repository: ambari > > > Description > --- > > Minor JS issue > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > dcf27b4 > contrib/views/hive20/src/main/resources/ui/app/services/query.js b484c74 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 4f73ef8 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 8ee8e87 > > Diff: https://reviews.apache.org/r/56483/diff/ > > > Testing > --- > > manuualy tested > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56443/#review164847 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 8, 2017, 4:22 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56443/ > --- > > (Updated Feb. 8, 2017, 4:22 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19922 > https://issues.apache.org/jira/browse/AMBARI-19922 > > > Repository: ambari > > > Description > --- > > Adding CSS class to deal such isssues. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 968d3b3 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs > 291def6 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/list-item.hbs > 4fbd86b > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > 0ab6cfd > > Diff: https://reviews.apache.org/r/56443/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56440: AMBARI-19920. Workfow Manger- Issue in flow graph active transitions in case of decision and fork.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56440/#review164669 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 8, 2017, 12:13 p.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56440/ > --- > > (Updated Feb. 8, 2017, 12:13 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-19920 > https://issues.apache.org/jira/browse/AMBARI-19920 > > > Repository: ambari > > > Description > --- > > Made all the transitions visited to green and not visited to grey > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js > d0c5d11 > contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js > e410262 > > Diff: https://reviews.apache.org/r/56440/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 56438: Reset Workflow on newly created workflow blocks UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56438/#review164665 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 8, 2017, 11:37 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56438/ > --- > > (Updated Feb. 8, 2017, 11:37 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-19918 > https://issues.apache.org/jira/browse/AMBARI-19918 > > > Repository: ambari > > > Description > --- > > Reset Workflow on newly created workflow blocks UI. > Steps. > create new worklow. > create a node. > click reset workflow. > Observe that UI is blocked by some modal. > > Expected behaviour-: the workflow should become empty workflow with only > start and end node. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > 445b86e > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > b045798 > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > 0b689b0 > contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js > 86c8dc9 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 90fba0d > contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 93ce758 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs > b29ae21 > > Diff: https://reviews.apache.org/r/56438/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 56115: Hive2: Unreasonable response time from query exeuction in hive view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56115/#review164653 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 31, 2017, 9:10 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56115/ > --- > > (Updated Jan. 31, 2017, 9:10 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19793 > https://issues.apache.org/jira/browse/AMBARI-19793 > > > Repository: ambari > > > Description > --- > > - Change the interval to 2 seconds. > - disable button when query is in progress. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 753b7f7 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 5cdc9b3 > > Diff: https://reviews.apache.org/r/56115/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56384: Hive2: Query Runtime Prediction: Compact Visual Explain Plan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56384/#review164652 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 7, 2017, 12:02 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56384/ > --- > > (Updated Feb. 7, 2017, 12:02 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19890 > https://issues.apache.org/jira/browse/AMBARI-19890 > > > Repository: ambari > > > Description > --- > > Visual Explain Plan Feature. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/adapters/query.js ccda9d4 > > contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js > 919127f > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > b6434c0 > contrib/views/hive20/src/main/resources/ui/app/services/query.js 1799f71 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 2f63854 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 62c97a2 > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/bower.json a4ce788 > contrib/views/hive20/src/main/resources/ui/ember-cli-build.js e41c8e8 > > Diff: https://reviews.apache.org/r/56384/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56345: Hive2 view UDF tab is blank always
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56345/#review164645 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 8, 2017, 7:04 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56345/ > --- > > (Updated Feb. 8, 2017, 7:04 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19883 > https://issues.apache.org/jira/browse/AMBARI-19883 > > > Repository: ambari > > > Description > --- > > UDF fearure > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/adapters/udf.js PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/components/fileresource-item.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/udf-edit.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/udf-item.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/udf-new.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/controllers/udfs/new.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/models/file-resource.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/models/udf.js PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/router.js 52361ff > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > b6434c0 > contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 8719170 > contrib/views/hive20/src/main/resources/ui/app/routes/udfs/new.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/services/file-resource.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/services/udf.js PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 2f63854 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/fileresource-item.hbs > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-edit.hbs > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-item.hbs > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/templates/components/udf-new.hbs > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 62c97a2 > contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs b776fd2 > contrib/views/hive20/src/main/resources/ui/app/templates/udfs/new.hbs > PRE-CREATION > > Diff: https://reviews.apache.org/r/56345/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Review Request 56430: incorrect imports in hive-next view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56430/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-19913 https://issues.apache.org/jira/browse/AMBARI-19913 Repository: ambari Description --- corrected the imports and packages. Diffs - contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/CSVParams.java 355ed6a contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java 0826945 contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/QueryGenerator.java 72f3b7a contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/RowFormat.java 4c1cb2b contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/TableInfo.java a440e51 contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java 1613b05 Diff: https://reviews.apache.org/r/56430/diff/ Testing --- manual testing done. Thanks, Nitiraj Rathore
Re: Review Request 56343: Search in recent projects should also search in path and search should be case insensitive
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56343/#review164499 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 7, 2017, 11:25 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56343/ > --- > > (Updated Feb. 7, 2017, 11:25 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, and Pallav Kulshreshtha. > > > Bugs: AMBARI-19882 > https://issues.apache.org/jira/browse/AMBARI-19882 > > > Repository: ambari > > > Description > --- > > Search in recent projects should be case insensitive and should search in > path also. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js > 33533db > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs > 802a8bc > > Diff: https://reviews.apache.org/r/56343/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 56343: Search in recent projects should also search in path and search should be case insensitive
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56343/#review164476 --- contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js (line 30) <https://reviews.apache.org/r/56343/#comment236233> can we avoid using eval - Nitiraj Rathore On Feb. 6, 2017, 8:53 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56343/ > --- > > (Updated Feb. 6, 2017, 8:53 p.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, and Pallav Kulshreshtha. > > > Bugs: AMBARI-19882 > https://issues.apache.org/jira/browse/AMBARI-19882 > > > Repository: ambari > > > Description > --- > > Search in recent projects should be case insensitive and should search in > path also. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js > 33533db > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs > 802a8bc > > Diff: https://reviews.apache.org/r/56343/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 56336: WFM: "Workflow Designer" title should be changed to "Workflow Manager" and Minor UI fixes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56336/#review164475 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 6, 2017, 6:35 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56336/ > --- > > (Updated Feb. 6, 2017, 6:35 p.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, and Pallav Kulshreshtha. > > > Bugs: AMBARI-19880 > https://issues.apache.org/jira/browse/AMBARI-19880 > > > Repository: ambari > > > Description > --- > > "Workflow Designer" title should be changed to "Workflow Manager" > Width and height of modal popups need to be responsive according to > resolution. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3707280 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs > 0bd7195 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/help-icon.hbs > 61893e2 > contrib/views/wfmanager/src/main/resources/ui/app/templates/dashboard.hbs > 41a23b1 > > Diff: https://reviews.apache.org/r/56336/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 56228: Recent workflows in Workflow designer should be in descending order of time of updation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56228/#review163999 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 2, 2017, 3:10 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56228/ > --- > > (Updated Feb. 2, 2017, 3:10 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-19849 > https://issues.apache.org/jira/browse/AMBARI-19849 > > > Repository: ambari > > > Description > --- > > Recent workflows in Workflow designer should be in descending order of > updated-at value both in recent list as well as Recent Projects screen. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > 16fca55 > contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js > 02483d4 > > Diff: https://reviews.apache.org/r/56228/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 56162: Recent workflows in Workflow designer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56162/#review163808 --- Ship it! Ship It! - Nitiraj Rathore On Feb. 1, 2017, 12:57 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56162/ > --- > > (Updated Feb. 1, 2017, 12:57 p.m.) > > > Review request for Ambari, belliraj hb and Nitiraj Rathore. > > > Bugs: AMBARI-19815 > https://issues.apache.org/jira/browse/AMBARI-19815 > > > Repository: ambari > > > Description > --- > > User needs to easily access his recently saved workflows. > Optionally he should be able to manager the recent workflows by having > ability to search recent workflow entry. > When user says open the recent entry, > - it should open the appropriate workflow. > -If the workflow is already opened it should tab and focus on the > -if the workflow is opened in multiple tables, focus should be on one of the > workflow tab. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > 5b517af > contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js > 885655a > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > f863656 > > contrib/views/wfmanager/src/main/resources/ui/app/components/recent-projects.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js > 80bea99 > > contrib/views/wfmanager/src/main/resources/ui/app/helpers/format-unicode-date.js > e6dd653 > contrib/views/wfmanager/src/main/resources/ui/app/models/wfproject.js > e90a613 > contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js b6beef8 > > contrib/views/wfmanager/src/main/resources/ui/app/routes/design/proj-manager-tab.js > b37ed83 > contrib/views/wfmanager/src/main/resources/ui/app/services/current-job.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 755a6ad > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs > 37150f5 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs > 13f3ae7 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs > 46a3f63 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs > 54ea25f > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/recent-projects.hbs > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/templates/design.hbs > 012d9e7 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/design/proj-manager-tab.hbs > b897a4c > > Diff: https://reviews.apache.org/r/56162/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 56082: Hive View : Logs are not complete for hive view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56082/#review163638 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 30, 2017, 3:37 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56082/ > --- > > (Updated Jan. 30, 2017, 3:37 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-19780 > https://issues.apache.org/jira/browse/AMBARI-19780 > > > Repository: ambari > > > Description > --- > > Changes for saving full query logs with multiple statement to file. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/LogAggregator.java > 9412f81 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/StatementExecutor.java > d7b4f54 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/message/StartLogAggregation.java > b56da08 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/LogAggregator.java > f9c21b4 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java > 03332d9 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/StartLogAggregation.java > 922ad1d > > Diff: https://reviews.apache.org/r/56082/diff/ > > > Testing > --- > > Manuall tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 56075: Hive2: LOGS tab is more prominently displayed than RESULTS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56075/#review163637 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 30, 2017, 11:47 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56075/ > --- > > (Updated Jan. 30, 2017, 11:47 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19765 > https://issues.apache.org/jira/browse/AMBARI-19765 > > > Repository: ambari > > > Description > --- > > UI changes > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 6a77633 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 753b7f7 > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 5db22d0 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 17abb65 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs > 4fe6f43 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 5cdc9b3 > > Diff: https://reviews.apache.org/r/56075/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56010: AMBARI-19709:XML generated for bundle's is not as per oozie xsd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56010/#review163475 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 27, 2017, 9:43 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56010/ > --- > > (Updated Jan. 27, 2017, 9:43 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav > Kulshreshtha. > > > Bugs: AMBARI-19709 > https://issues.apache.org/jira/browse/AMBARI-19709 > > > Repository: ambari > > > Description > --- > > Modified the tag control to controls as per the bundle xsd > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > e29935c > > contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-generator.js > 7dc05a9 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js > a2053c9 > > Diff: https://reviews.apache.org/r/56010/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56031: Hive2 View - Switching tabs after executing query loses state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56031/#review163473 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 27, 2017, 6:42 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56031/ > --- > > (Updated Jan. 27, 2017, 6:42 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19753 > https://issues.apache.org/jira/browse/AMBARI-19753 > > > Repository: ambari > > > Description > --- > > added a model parameter to save isQueryRunning state. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 23f16b0 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 2ecf967 > > Diff: https://reviews.apache.org/r/56031/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56051: Workflow Manager View : Separate log file into its own directory similar to other views
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56051/#review163469 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 28, 2017, 8:32 a.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56051/ > --- > > (Updated Jan. 28, 2017, 8:32 a.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, and Nitiraj Rathore. > > > Bugs: AMBARI-19763 > https://issues.apache.org/jira/browse/AMBARI-19763 > > > Repository: ambari > > > Description > --- > > Workflow manager view logs entries are currently in the ambari-server.log. > It should be separated into its own folder under /var/log/ambari-server > similar to the other views. > > > Diffs > - > > contrib/views/wfmanager/pom.xml 8016d7b > contrib/views/wfmanager/src/main/resources/view.log4j.properties > PRE-CREATION > > Diff: https://reviews.apache.org/r/56051/diff/ > > > Testing > --- > > Manual testing. > Verified that the Workflow Manager view logs are written to > wfmanager-view.log under /var/log/ambari-server/wfmanager-view > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 55923: AMBARI-19604:Need to perform sanity checks before starting the oozie view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55923/#review163467 --- contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js (line 99) <https://reviews.apache.org/r/55923/#comment234954> X-Requested-By is generally set to 'ambari'. is there any specific reason to set it to 'workflow-designer' contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs (line 21) <https://reviews.apache.org/r/55923/#comment234955> Extract constants to make it i18n compliant - Nitiraj Rathore On Jan. 25, 2017, 11:08 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55923/ > --- > > (Updated Jan. 25, 2017, 11:08 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-19604 > https://issues.apache.org/jira/browse/AMBARI-19604 > > > Repository: ambari > > > Description > --- > > Added sanity checks for oozie, hdfs and user home directory > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/controllers/index.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 23609e9 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/design-loading.hbs > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/templates/loading.hbs > 9f4fc79 > > Diff: https://reviews.apache.org/r/55923/diff/ > > > Testing > --- > > Manual testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56030: Hive View 2.0 execute button needs some feedback
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56030/#review163466 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 27, 2017, 6:20 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56030/ > --- > > (Updated Jan. 27, 2017, 6:20 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19752 > https://issues.apache.org/jira/browse/AMBARI-19752 > > > Repository: ambari > > > Description > --- > > Added fontawesome animation while query is in progress. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 5d7ce77 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss e178222 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 9e9e542 > > Diff: https://reviews.apache.org/r/56030/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 55921: AMBARI-19610:User is not able to import the draft version for a coordinator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55921/#review163462 --- contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java (line 100) <https://reviews.apache.org/r/55921/#comment234944> returning null here does not help, it will cover up some bugs somewhere else. throw an exception. contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java (line 112) <https://reviews.apache.org/r/55921/#comment234945> same here as well. returning null here does not help, it will cover up some bugs somewhere else. throw an exception. contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js (line 356) <https://reviews.apache.org/r/55921/#comment234947> I don't get the idea of generating X-XSRF-HEADER on client side. CSRF tokens are generated on serverside and clients resend it. Also as far as I know ambari does not checks for this token. Please explain its use or remove if not required. contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js (line 962) <https://reviews.apache.org/r/55921/#comment234949> there is no 'else' part to this 'if'. it may stuck the code execution. contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs (line 131) <https://reviews.apache.org/r/55921/#comment234950> extract this constant into a constants file to conform with i18n specs. contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs (line 346) <https://reviews.apache.org/r/55921/#comment234951> extract this constant into a constants file to conform with i18n specs. contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs (line 316) <https://reviews.apache.org/r/55921/#comment234952> extract this constant into a constants file to conform with i18n specs. - Nitiraj Rathore On Jan. 25, 2017, 10:45 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55921/ > --- > > (Updated Jan. 25, 2017, 10:45 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-19610 > https://issues.apache.org/jira/browse/AMBARI-19610 > > > Repository: ambari > > > Description > --- > > Modified backend to support import of draft versions and added methods in > front end to parse the imported draft version. > > > Diffs > - > > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Constants.java > f7c1936 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java > d029c39 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFileInfo.java > 6dbf30e > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java > 289e68b > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java > 7ce6081 > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > 2e0dadb > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > bba7793 > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > 422253d > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > c682ea9 > contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js > c6c0421 > > contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js > f5eb6e7 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs > 8b42447 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs > 296463d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 1758946 > > Diff: https://reviews.apache.org/r/55921/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Padma Priya N > >
