Re: Review Request 60459: Workflow Manager view build failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60459/#review178967 --- Ship it! Ship It! - belliraj hb On June 27, 2017, 9:22 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60459/ > --- > > (Updated June 27, 2017, 9:22 a.m.) > > > Review request for Ambari, belliraj hb, Nitiraj Rathore, Padma Priya N, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-21352 > https://issues.apache.org/jira/browse/AMBARI-21352 > > > Repository: ambari > > > Description > --- > > Changed pom.xml to fix the build failure > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/bower.json 06fc3e3 > > > Diff: https://reviews.apache.org/r/60459/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 60455: Styling Issues with newly implemented workflow manager file browser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60455/#review178962 --- Ship it! Ship It! - belliraj hb On June 27, 2017, 6:47 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60455/ > --- > > (Updated June 27, 2017, 6:47 a.m.) > > > Review request for Ambari, belliraj hb, Nitiraj Rathore, Padma Priya N, > Pallav Kulshreshtha, Rohit Choudhary, and Supreeth Sharma. > > > Bugs: AMBARI-21338 > https://issues.apache.org/jira/browse/AMBARI-21338 > > > Repository: ambari > > > Description > --- > > Changed styles as needed. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 597e2e8 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/styles/app.css > b46fa34 > contrib/views/wfmanager/src/main/resources/ui/yarn.lock e9ad6cc > > > Diff: https://reviews.apache.org/r/60455/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 60268: Convert Slider View to use yarn package manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60268/#review178468 --- Ship it! Ship It! - belliraj hb On June 21, 2017, 8:56 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60268/ > --- > > (Updated June 21, 2017, 8:56 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-21292 > https://issues.apache.org/jira/browse/AMBARI-21292 > > > Repository: ambari > > > Description > --- > > Versions in package.json have been updated to fix the build > > > Diffs > - > > contrib/views/slider/src/main/resources/ui/package.json f9f8793 > > > Diff: https://reviews.apache.org/r/60268/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 60114: Remove YARN client mode option from WFM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60114/#review178467 --- Ship it! Ship It! - belliraj hb On June 20, 2017, 5:59 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60114/ > --- > > (Updated June 20, 2017, 5:59 p.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, > and Rohit Choudhary. > > > Bugs: AMBARI-21255 > https://issues.apache.org/jira/browse/AMBARI-21255 > > > Repository: ambari > > > Description > --- > > YARN client mode have been removed from WFD as oozie doesnt support Yarn > client mode > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 1cfe755 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js > c9dc751 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 8c07d6d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs > de62e77 > contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js > bf858d8 > > > Diff: https://reviews.apache.org/r/60114/diff/2/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 60128: Integrate new hdfs-file browser in WFD
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60128/#review178365 --- Ship it! Ship It! - belliraj hb On June 15, 2017, 5:56 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60128/ > --- > > (Updated June 15, 2017, 5:56 p.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, > and Rohit Choudhary. > > > Bugs: AMBARI-21264 > https://issues.apache.org/jira/browse/AMBARI-21264 > > > Repository: ambari > > > Description > --- > > The new hdfs file-browser is integrated into WFD. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.css 48232f5 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs > 5779e36 > contrib/views/wfmanager/src/main/resources/ui/app/utils/hdfsviewer.js > 080409b > contrib/views/wfmanager/src/main/resources/ui/bower.json 75ac7a7 > contrib/views/wfmanager/src/main/resources/ui/config/environment.js 3e6d865 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/components/directory-viewer.js > 65746e8 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/styles/app.css > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs > 4083ad6 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/utils/viewer-config.js > 64773c6 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/bower.json > f016904 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/index.js > dc074d7 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/package.json > 66a7b20 > contrib/views/wfmanager/src/main/resources/ui/package.json b5973c1 > > > Diff: https://reviews.apache.org/r/60128/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 60112: Namenode variable should be auto populated for FS action node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60112/#review178366 --- Ship it! Ship It! - belliraj hb On June 15, 2017, 8:24 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60112/ > --- > > (Updated June 15, 2017, 8:24 a.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, > and Rohit Choudhary. > > > Bugs: AMBARI-21252 > https://issues.apache.org/jira/browse/AMBARI-21252 > > > Repository: ambari > > > Description > --- > > This is a regression which have been fixed > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js > 7bf3534 > > > Diff: https://reviews.apache.org/r/60112/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 60129: Workflow submission fails when action node names contain white space
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60129/#review178364 --- Ship it! Ship It! - belliraj hb On June 15, 2017, 7 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60129/ > --- > > (Updated June 15, 2017, 7 p.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, > and Rohit Choudhary. > > > Bugs: AMBARI-21266 > https://issues.apache.org/jira/browse/AMBARI-21266 > > > Repository: ambari > > > Description > --- > > Validations have been written to check for white space in action node name > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js > a6e1eeb > > > Diff: https://reviews.apache.org/r/60129/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 60114: Remove YARN client mode option from WFM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60114/#review178094 --- contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js Lines 401 (patched) <https://reviews.apache.org/r/60114/#comment251903> must check with exact match. must first check if the actionType is spark. i guess findby is generic search. - belliraj hb On June 15, 2017, 9:15 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60114/ > --- > > (Updated June 15, 2017, 9:15 a.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, > and Rohit Choudhary. > > > Bugs: AMBARI-21255 > https://issues.apache.org/jira/browse/AMBARI-21255 > > > Repository: ambari > > > Description > --- > > YARN client mode have been removed from WFD as oozie doesnt support Yarn > client mode > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 1cfe755 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js > c9dc751 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 8c07d6d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs > de62e77 > contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js > bf858d8 > > > Diff: https://reviews.apache.org/r/60114/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 59679: Hdfs directory viewer should be changed from tree view to list view.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59679/#review176429 --- Ship it! Ship It! - belliraj hb On May 31, 2017, 6:32 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59679/ > --- > > (Updated May 31, 2017, 6:32 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-21153 > https://issues.apache.org/jira/browse/AMBARI-21153 > > > Repository: ambari > > > Description > --- > > Hdfs directory viewer have been changed from tree view to list view with > added views. > > > Diffs > - > > > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/components/directory-viewer.js > 991d122 > > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/styles/app.css > PRE-CREATION > > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs > 75339c5 > > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/utils/viewer-config.js > 64773c6 > > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/bower.json > f016904 > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/index.js > dc074d7 > > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/package.json > 66a7b20 > > > Diff: https://reviews.apache.org/r/59679/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 59151: Workflow Designer View: Provide sorting of workflows on dashboard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59151/#review174614 --- I guess its a all client side. Would it not confuse the users. Oozie support for server side pagination is not there. This was a requiremnt long time backe , but we consciously decided not to do it. Ideal would be if ooze supports pagination on server side and the UI integrates with it. - belliraj hb On May 10, 2017, 6:33 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59151/ > --- > > (Updated May 10, 2017, 6:33 p.m.) > > > Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya > N, and Sangeeta Ravindran. > > > Bugs: AMBARI-20972 > https://issues.apache.org/jira/browse/AMBARI-20972 > > > Repository: ambari > > > Description > --- > > The workflows displayed on the worflow designer view dashboard are not > sortable. The ability to sort via Name, Status, User, Created Time, End Time > and jobId should be included > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js > 01eb4ea > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs > 86ab5a5 > > > Diff: https://reviews.apache.org/r/59151/diff/1/ > > > Testing > --- > > Tested manually > > > File Attachments > > > sort > > https://reviews.apache.org/media/uploaded/files/2017/05/10/325cfa3d-d3fb-43e8-8e9a-5d1315be299e__wfmSort.PNG > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 58179: For sort/partition operator, if there is only 1 reducer, display just "sort" rather than "sort/partition"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58179/#review174306 --- Ship it! Ship It! - belliraj hb On May 9, 2017, 10:54 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58179/ > --- > > (Updated May 9, 2017, 10:54 a.m.) > > > Review request for Ambari, Abhishek Kumar, Gaurav Nagar, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20673 > https://issues.apache.org/jira/browse/AMBARI-20673 > > > Repository: ambari > > > Description > --- > > Now when we have only one reducer, the label for aort/partition will be > displayed as partition. > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > 1cfcb15 > > > Diff: https://reviews.apache.org/r/58179/diff/1/ > > > Testing > --- > > Manual testing done > > > File Attachments > > > This patch contains code which should go along with other patch > > https://reviews.apache.org/media/uploaded/files/2017/05/09/0c59f3e2-aedf-4893-9214-be56628dcbef__AMBARI-20673-trunk.01.patch > > > Thanks, > > venkat sairam > >
Re: Review Request 58894: WFM: Include an option to clear filters in workflow dashboard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58894/#review174001 --- Ship it! Ship It! - belliraj hb On May 4, 2017, 7:09 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58894/ > --- > > (Updated May 4, 2017, 7:09 p.m.) > > > Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya > N, and Sangeeta Ravindran. > > > Bugs: AMBARI-20904 > https://issues.apache.org/jira/browse/AMBARI-20904 > > > Repository: ambari > > > Description > --- > > Currently the filters can be cleared only manually by removing the contents, > having a button to clear the filters on one click would be helpful. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > 4bfb5fa > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs > b9c6029 > > > Diff: https://reviews.apache.org/r/58894/diff/2/ > > > Testing > --- > > Tested manually > > > File Attachments > > > ClearFilters > > https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg > ClearFilters-updated > > https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 58894: WFM: Include an option to clear filters in workflow dashboard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58894/#review173719 --- I guess "clear filter" takes lot of space. I think clear filter should be a simpler icon (may be a X) and it should be before refresh. - belliraj hb On May 1, 2017, 10:15 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58894/ > --- > > (Updated May 1, 2017, 10:15 p.m.) > > > Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya > N, and Sangeeta Ravindran. > > > Bugs: AMBARI-20904 > https://issues.apache.org/jira/browse/AMBARI-20904 > > > Repository: ambari > > > Description > --- > > Currently the filters can be cleared only manually by removing the contents, > having a button to clear the filters on one click would be helpful. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > 4bfb5fa > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs > b9c6029 > > > Diff: https://reviews.apache.org/r/58894/diff/1/ > > > Testing > --- > > Tested manually > > > File Attachments > > > ClearFilters > > https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 58846: WFM view build failure with jsblump reference
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58846/#review173332 --- Ship it! Ship It! - belliraj hb On April 28, 2017, 3:10 p.m., Supreeth Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58846/ > --- > > (Updated April 28, 2017, 3:10 p.m.) > > > Review request for Ambari, belliraj hb and venkat sairam. > > > Bugs: AMBARI-20890 > https://issues.apache.org/jira/browse/AMBARI-20890 > > > Repository: ambari > > > Description > --- > > Removed the reference to jsplumb > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js 0979c39 > > > Diff: https://reviews.apache.org/r/58846/diff/1/ > > > Testing > --- > > Manually tested and build is passing. > > > Thanks, > > Supreeth Sharma > >
Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58780/#review173293 --- Ship it! Ship It! - belliraj hb On April 27, 2017, 4:41 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58780/ > --- > > (Updated April 27, 2017, 4:41 p.m.) > > > Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya > N, and Sangeeta Ravindran. > > > Bugs: AMBARI-20850 > https://issues.apache.org/jira/browse/AMBARI-20850 > > > Repository: ambari > > > Description > --- > > Clicking on search icon when the filter is empty in workflow dashboard throws > the error Remote API failed as in screenshot > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > 7e69dea > > > Diff: https://reviews.apache.org/r/58780/diff/2/ > > > Testing > --- > > Tested Manually > > > File Attachments > > > error > > https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 58785: AMBARI-20867.Cleanup Jsplumb specific code from WFM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58785/#review173177 --- Ship it! Ship It! - belliraj hb On April 27, 2017, 9:24 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58785/ > --- > > (Updated April 27, 2017, 9:24 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Pallav Kulshreshtha, > and venkat sairam. > > > Bugs: AMBARI-20867 > https://issues.apache.org/jira/browse/AMBARI-20867 > > > Repository: ambari > > > Description > --- > > Removed jsplumb dependency from bower and deleted unused jsplumb related code. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 17f21ee > > contrib/views/wfmanager/src/main/resources/ui/app/domain/jsplumb-flow-renderer.js > c3e3133 > contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager1.js > 0cd306a > contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager2.js > d82b89e > contrib/views/wfmanager/src/main/resources/ui/bower.json 7e1709b > > > Diff: https://reviews.apache.org/r/58785/diff/1/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 58784: AMBARI-20866.Distcp should take a single command rather than list of arguments to make it easier ot use.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58784/#review173173 --- Ship it! Ship It! - belliraj hb On April 27, 2017, 8:56 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58784/ > --- > > (Updated April 27, 2017, 8:56 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Pallav Kulshreshtha, > and venkat sairam. > > > Bugs: AMBARI-20866 > https://issues.apache.org/jira/browse/AMBARI-20866 > > > Repository: ambari > > > Description > --- > > Replaces the args list with a text area where the user can type the distcp > args. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/distcp-action.js > e5740e3 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/distcp-action.hbs > 28e67da > > > Diff: https://reviews.apache.org/r/58784/diff/1/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 58744: Bulk action is not functional in workflow dashboard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58744/#review173156 --- Ship it! Ship It! - belliraj hb On April 26, 2017, 6:19 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58744/ > --- > > (Updated April 26, 2017, 6:19 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20703 > https://issues.apache.org/jira/browse/AMBARI-20703 > > > Repository: ambari > > > Description > --- > > Bulk action have been commented out as it causes performance issues > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs > 4c18d5d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs > 7b5a625 > > > Diff: https://reviews.apache.org/r/58744/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58744: Bulk action is not functional in workflow dashboard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58744/#review173155 --- Ship it! Ship It! - belliraj hb On April 26, 2017, 6:19 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58744/ > --- > > (Updated April 26, 2017, 6:19 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20703 > https://issues.apache.org/jira/browse/AMBARI-20703 > > > Repository: ambari > > > Description > --- > > Bulk action have been commented out as it causes performance issues > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs > 4c18d5d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs > 7b5a625 > > > Diff: https://reviews.apache.org/r/58744/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58613: Need to show appropriate error message while deleting the workflow history in project manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58613/#review172649 --- Ship it! Ship It! - belliraj hb On April 21, 2017, 12:02 p.m., Supreeth Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58613/ > --- > > (Updated April 21, 2017, 12:02 p.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and > venkat sairam. > > > Repository: ambari > > > Description > --- > > Changed the message to indicate that item is getting deleted only from the > history and file will still be available in HDFS file path > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js > ed448d9 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less abb0637 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs > 05599e5 > > > Diff: https://reviews.apache.org/r/58613/diff/1/ > > > Testing > --- > > Manually tested the changes > > > Thanks, > > Supreeth Sharma > >
Re: Review Request 58614: Project manager window is not opening for the second time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58614/#review172648 --- Ship it! Ship It! - belliraj hb On April 21, 2017, 12:03 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58614/ > --- > > (Updated April 21, 2017, 12:03 p.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and > Supreeth Sharma. > > > Bugs: AMBARI-20793 > https://issues.apache.org/jira/browse/AMBARI-20793 > > > Repository: ambari > > > Description > --- > > We have handled the kepyboard and out of clicks scenario to resolve the issue > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js > ed448d9 > > contrib/views/wfmanager/src/main/resources/ui/app/components/recent-projects.js > bbc51cc > > > Diff: https://reviews.apache.org/r/58614/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58567: Need way to explicitly ask for workflow name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58567/#review172626 --- Ship it! Ship It! - belliraj hb On April 21, 2017, 8:35 a.m., Supreeth Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58567/ > --- > > (Updated April 21, 2017, 8:35 a.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and > venkat sairam. > > > Bugs: AMBARI-20729 > https://issues.apache.org/jira/browse/AMBARI-20729 > > > Repository: ambari > > > Description > --- > > Made the code change to explicitly ask for names while creating coordinator > and bundle > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > 99f4fa7 > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > fba4db5 > > > Diff: https://reviews.apache.org/r/58567/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > Supreeth Sharma > >
Re: Review Request 58564: Need to change the arrangement of the action buttons in project manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58564/#review172484 --- Ship it! Ship It! - belliraj hb On April 20, 2017, 12:01 p.m., Supreeth Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58564/ > --- > > (Updated April 20, 2017, 12:01 p.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and > venkat sairam. > > > Bugs: AMBARI-20800 > https://issues.apache.org/jira/browse/AMBARI-20800 > > > Repository: ambari > > > Description > --- > > Rearranged the Delete and Close buttons so as to keep the styling consistent. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs > ac28de3 > > > Diff: https://reviews.apache.org/r/58564/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > Supreeth Sharma > >
Re: Review Request 58416: Need to show decision conditions for decision node in Flow Graph tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58416/#review171853 --- Ship it! Ship It! - belliraj hb On April 13, 2017, 10:42 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58416/ > --- > > (Updated April 13, 2017, 10:42 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav > Kulshreshtha, and venkat sairam. > > > Bugs: AMBARI-20719 > https://issues.apache.org/jira/browse/AMBARI-20719 > > > Repository: ambari > > > Description > --- > > Added the conditions to show up on mouse move in flow graph > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js > e74c873 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs > 0c5257e > > > Diff: https://reviews.apache.org/r/58416/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58384: Coordinator Actions(workflows) are empty even when workflows are executed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58384/#review171713 --- Ship it! Ship It! - belliraj hb On April 12, 2017, 10:52 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58384/ > --- > > (Updated April 12, 2017, 10:52 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav > Kulshreshtha, and venkat sairam. > > > Bugs: AMBARI-20740 > https://issues.apache.org/jira/browse/AMBARI-20740 > > > Repository: ambari > > > Description > --- > > Added the api parameter(len 1000) to fetch all actions for a coordinator. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/routes/design/jobtab.js > 3fecbaa > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3c5e720 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs > b3f1097 > > > Diff: https://reviews.apache.org/r/58384/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58382: Need to disable upload file option from file browser window in workflow manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58382/#review171712 --- Ship it! Ship It! - belliraj hb On April 12, 2017, 9:17 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58382/ > --- > > (Updated April 12, 2017, 9:17 a.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary. > > > Bugs: AMBARI-20717 > https://issues.apache.org/jira/browse/AMBARI-20717 > > > Repository: ambari > > > Description > --- > > Upload button have been disabled in import section. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs > b674990 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs > 3b1b6a9 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 429e874 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs > 44f25c8 > > > Diff: https://reviews.apache.org/r/58382/diff/1/ > > > Testing > --- > > Manual testing have been done > > > Thanks, > > venkat sairam > >
Re: Review Request 58341: Issue while adding custom job.properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58341/#review171548 --- Ship it! Ship It! - belliraj hb On April 11, 2017, 10:10 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58341/ > --- > > (Updated April 11, 2017, 10:10 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20705 > https://issues.apache.org/jira/browse/AMBARI-20705 > > > Repository: ambari > > > Description > --- > > Added the custom properties if it is present even without clicking '+' > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/global-config.js > efe8385 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/global-config.hbs > e3d49ec > > > Diff: https://reviews.apache.org/r/58341/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58339: Need way to explicitly ask for workflow name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58339/#review171545 --- Ship it! Ship It! - belliraj hb On April 11, 2017, 9:52 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58339/ > --- > > (Updated April 11, 2017, 9:52 a.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary. > > > Bugs: AMBARI-20729 > https://issues.apache.org/jira/browse/AMBARI-20729 > > > Repository: ambari > > > Description > --- > > We have configured the mechanism of filling the workflow name by default.We > have disabled the configuration as per the configuration. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > cccf6d0 > > > Diff: https://reviews.apache.org/r/58339/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58335: User should not be allowed to validate/Submit the workflow in case of duplicate action nodes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58335/#review171534 --- Ship it! Ship It! - belliraj hb On April 11, 2017, 7:23 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58335/ > --- > > (Updated April 11, 2017, 7:23 a.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary. > > > Bugs: AMBARI-20718 > https://issues.apache.org/jira/browse/AMBARI-20718 > > > Repository: ambari > > > Description > --- > > We have added a validation check which will check the duplication of action > name. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > cccf6d0 > > > Diff: https://reviews.apache.org/r/58335/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58293: Need a way to indicate the action node type in workflow manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58293/#review171435 --- Ship it! Ship It! - belliraj hb On April 10, 2017, 11:06 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58293/ > --- > > (Updated April 10, 2017, 11:06 a.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary. > > > Bugs: AMBARI-20704 > https://issues.apache.org/jira/browse/AMBARI-20704 > > > Repository: ambari > > > Description > --- > > Currently there's no way for the user to know the action node type from > workflow designer page. > We have added images for each action for easy representation. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js > 5a85573 > contrib/views/wfmanager/src/main/resources/ui/app/index.html df243ad > contrib/views/wfmanager/src/main/resources/ui/public/assets/custom.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/distcp.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/email.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/fs.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/hive.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/hive2.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/java.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/map-reduce.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/pig.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/shell.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/spark.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/sqoop.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/ssh.png > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/public/assets/sub-workflow.png > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58293/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58230: Zooming workflows should happen more smoothly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58230/#review171418 --- Ship it! Ship It! - belliraj hb On April 6, 2017, 9:06 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58230/ > --- > > (Updated April 6, 2017, 9:06 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20689 > https://issues.apache.org/jira/browse/AMBARI-20689 > > > Repository: ambari > > > Description > --- > > Changed the zoom factor of the workflow. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > 03f0ae1 > > > Diff: https://reviews.apache.org/r/58230/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58204: User should be able to visualize inherited properties while submitting the workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58204/#review171109 --- Ship it! Ship It! - belliraj hb On April 5, 2017, 9:22 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58204/ > --- > > (Updated April 5, 2017, 9:22 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20676 > https://issues.apache.org/jira/browse/AMBARI-20676 > > > Repository: ambari > > > Description > --- > > Added the inherited properies such as resourceManager, nameNode to > job.properties while submitting the workflow. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js > 6aed9da > contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 6d94dfe > > contrib/views/wfmanager/src/main/resources/ui/app/services/workflow-manager-configs.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/workflow-manager-configs-test.js > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58204/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58205: Centering workflows for zoom breaks when multiple tabs exists
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58205/#review171108 --- Ship it! Ship It! - belliraj hb On April 5, 2017, 9:38 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58205/ > --- > > (Updated April 5, 2017, 9:38 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20677 > https://issues.apache.org/jira/browse/AMBARI-20677 > > > Repository: ambari > > > Description > --- > > Made the workflow to center while switching between the tabs for the first > time > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > 980904f > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > fa7c861 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > af84f86 > > > Diff: https://reviews.apache.org/r/58205/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58168: Need to auto populate the workflow parameters if its already defined in the global space
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58168/#review170967 --- Ship it! Ship It! - belliraj hb On April 4, 2017, 6:05 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58168/ > --- > > (Updated April 4, 2017, 6:05 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20662 > https://issues.apache.org/jira/browse/AMBARI-20662 > > > Repository: ambari > > > Description > --- > > Populated job.properties with default values if the property is defined in > workflow parameters > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js > e9c7c15 > > > Diff: https://reviews.apache.org/r/58168/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58170: The Zoom feature in WFM, hides the WF completely either with Maximum and Min
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58170/#review170966 --- Ship it! Ship It! - belliraj hb On April 4, 2017, 10:11 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58170/ > --- > > (Updated April 4, 2017, 10:11 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20413 > https://issues.apache.org/jira/browse/AMBARI-20413 > > > Repository: ambari > > > Description > --- > > Removed the panning by x and made the graph to center on start node. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > bfe59e2 > > > Diff: https://reviews.apache.org/r/58170/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58139: Coordinator and bundle should retain job.properties in submission modal window
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58139/#review170855 --- Ship it! Ship It! - belliraj hb On April 3, 2017, 9:28 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58139/ > --- > > (Updated April 3, 2017, 9:28 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20656 > https://issues.apache.org/jira/browse/AMBARI-20656 > > > Repository: ambari > > > Description > --- > > Stored the job.properties when coordinator or bundle is submitted. Retrieving > the submitted values and showing in the modal window. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > 7c63b47 > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > e8f8cc1 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs > 39ab06d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs > 0e35d0e > > > Diff: https://reviews.apache.org/r/58139/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58134: Bad user experience in workflow credential creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58134/#review170854 --- Ship it! Ship It! - belliraj hb On April 3, 2017, 8:07 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58134/ > --- > > (Updated April 3, 2017, 8:07 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20653 > https://issues.apache.org/jira/browse/AMBARI-20653 > > > Repository: ambari > > > Description > --- > > Removed the save button > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-credentials.js > 1072ca4 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 673ae6a > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/credentials-config.hbs > 366920d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-credentials.hbs > 464221f > > > Diff: https://reviews.apache.org/r/58134/diff/2/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58138: Need to improve the grouping of the nodes available in transition section of WFM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58138/#review170852 --- Ship it! Ship It! - belliraj hb On April 3, 2017, 9:04 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58138/ > --- > > (Updated April 3, 2017, 9:04 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20655 > https://issues.apache.org/jira/browse/AMBARI-20655 > > > Repository: ambari > > > Description > --- > > Moved the options inside optiongroup for ok to and error to transition > selections. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/transition-config.hbs > 83fe96c > > > Diff: https://reviews.apache.org/r/58138/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58134: Bad user experience in workflow credential creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58134/#review170853 --- Ship it! Ship It! - belliraj hb On April 3, 2017, 8:07 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58134/ > --- > > (Updated April 3, 2017, 8:07 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20653 > https://issues.apache.org/jira/browse/AMBARI-20653 > > > Repository: ambari > > > Description > --- > > Removed the save button > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-credentials.js > 1072ca4 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 673ae6a > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/credentials-config.hbs > 366920d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-credentials.hbs > 464221f > > > Diff: https://reviews.apache.org/r/58134/diff/2/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58135: Workflow should retain job.properties in submission modal window
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58135/#review170851 --- Ship it! Ship It! - belliraj hb On April 3, 2017, 7:10 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58135/ > --- > > (Updated April 3, 2017, 7:10 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20654 > https://issues.apache.org/jira/browse/AMBARI-20654 > > > Repository: ambari > > > Description > --- > > Stored the job.properties on submission and retrieving the values when > reopening the modal window > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 5f885e7 > contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js > 15c1fbf > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 0da9f71 > > > Diff: https://reviews.apache.org/r/58135/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57841: Make home directory check as optional in wfmanager view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57841/#review169984 --- Ship it! Ship It! - belliraj hb On March 24, 2017, 5:58 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57841/ > --- > > (Updated March 24, 2017, 5:58 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20529 > https://issues.apache.org/jira/browse/AMBARI-20529 > > > Repository: ambari > > > Description > --- > > Added property(views.skip.home-directory-check.file-system.list) to skip home > directory check > > > Diffs > - > > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java > d06eb07 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java > d82f928 > contrib/views/wfmanager/src/main/resources/ui/app/controllers/index.js > f4d93ea > contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 316ec0e > > > Diff: https://reviews.apache.org/r/57841/diff/2/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57841: Make home directory check as optional in wfmanager view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57841/#review169702 --- Ship it! Ship It! - belliraj hb On March 22, 2017, 1:27 p.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57841/ > --- > > (Updated March 22, 2017, 1:27 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallavi Rao. > > > Bugs: AMBARI-20529 > https://issues.apache.org/jira/browse/AMBARI-20529 > > > Repository: ambari > > > Description > --- > > Added property(views.skip.home-directory-check.file-system.list) to skip home > directory check > > > Diffs > - > > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java > d06eb07 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java > d82f928 > contrib/views/wfmanager/src/main/resources/ui/app/controllers/index.js > f4d93ea > contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 316ec0e > > > Diff: https://reviews.apache.org/r/57841/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57682: Workflow manager is only showing 10 actions for a workflow in dashboard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57682/#review169124 --- Ship it! Ship It! - belliraj hb On March 16, 2017, 11:10 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57682/ > --- > > (Updated March 16, 2017, 11:10 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, and Pallav > Kulshreshtha. > > > Bugs: AMBARI-20479 > https://issues.apache.org/jira/browse/AMBARI-20479 > > > Repository: ambari > > > Description > --- > > Removed the api parameter(len) to fetch all actions for a workflow. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > 5d8d0a0 > contrib/views/wfmanager/src/main/resources/ui/app/routes/design/jobtab.js > 7d0fa92 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 837276b > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-action.hbs > fe4c892 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs > dd972b9 > > > Diff: https://reviews.apache.org/r/57682/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57678: AMBARI-20475.Issue with cut/copy functionality in workflow manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57678/#review169100 --- Ship it! Ship It! - belliraj hb On March 16, 2017, 7:30 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57678/ > --- > > (Updated March 16, 2017, 7:30 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, and Pallav > Kulshreshtha. > > > Bugs: AMBARI-20475 > https://issues.apache.org/jira/browse/AMBARI-20475 > > > Repository: ambari > > > Description > --- > > Fixed by setting the node details in the clipboard in JSON format, so that > there are no references. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/services/workflow-clipboard.js > 8784cda > > > Diff: https://reviews.apache.org/r/57678/diff/1/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 57636: Need to improve log viewing on workflow manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57636/#review168980 --- Ship it! Ship It! - belliraj hb On March 15, 2017, 10:05 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57636/ > --- > > (Updated March 15, 2017, 10:05 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, and Pallav > Kulshreshtha. > > > Bugs: AMBARI-20455 > https://issues.apache.org/jira/browse/AMBARI-20455 > > > Repository: ambari > > > Description > --- > > Made the styling changes to show logs within workflow container > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 0d96af4 > > > Diff: https://reviews.apache.org/r/57636/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57552: AMBARI-20413. The Zoom feature in WFM, hides the WF completely either with Maximum and Min
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57552/#review168748 --- Ship it! Ship It! - belliraj hb On March 13, 2017, 10:04 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57552/ > --- > > (Updated March 13, 2017, 10:04 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20413 > https://issues.apache.org/jira/browse/AMBARI-20413 > > > Repository: ambari > > > Description > --- > > Made the cytoscape flow graph centered using the start node and panned y by 50 > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > bfe59e2 > > > Diff: https://reviews.apache.org/r/57552/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57549: Export workflow will create a workflow with workflow name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57549/#review168741 --- Ship it! Ship It! - belliraj hb On March 13, 2017, 9:02 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57549/ > --- > > (Updated March 13, 2017, 9:02 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20411 > https://issues.apache.org/jira/browse/AMBARI-20411 > > > Repository: ambari > > > Description > --- > > Workflow exported will be created will be created with workflow name field > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > f542c07 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 5577239 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs > c190511 > > > Diff: https://reviews.apache.org/r/57549/diff/2/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57508: AMBARI-20383.Not able to view the error log details on UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57508/#review168604 --- Ship it! Ship It! - belliraj hb On March 10, 2017, 12:42 p.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57508/ > --- > > (Updated March 10, 2017, 12:42 p.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20383 > https://issues.apache.org/jira/browse/AMBARI-20383 > > > Repository: ambari > > > Description > --- > > Fixed by adding a extra check to check if the data nodes are not empty > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/validators/workflow-dag.js > 18da25b > > > Diff: https://reviews.apache.org/r/57508/diff/1/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 57505: AMBARI-20360. Need to show appropriate error message in cases of UI failures
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57505/#review168599 --- Ship it! Ship It! - belliraj hb On March 10, 2017, 11:44 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57505/ > --- > > (Updated March 10, 2017, 11:44 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20360 > https://issues.apache.org/jira/browse/AMBARI-20360 > > > Repository: ambari > > > Description > --- > > Added error message to show if workflow xml doesn't contain workflow-app tag, > similarly coordinator-app tag for coordinator xml and bundle-app tag for > bundle xml. And also added the check for maximum number of nodes to render > and shown the error message if it exceeds maximum. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > e94d51a > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > c87ea99 > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js > fdb4f5e > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 37992be > > contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js > b3eed4b > > contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js > 12d923c > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > a076e3e > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs > 3cab194 > > > Diff: https://reviews.apache.org/r/57505/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57497: AMBARI-20381.User is not able to import workflows, coordinators and bundles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57497/#review168587 --- Ship it! Ship It! - belliraj hb On March 10, 2017, 7:21 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57497/ > --- > > (Updated March 10, 2017, 7:21 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, and Pallav > Kulshreshtha. > > > Bugs: AMBARI-20381 > https://issues.apache.org/jira/browse/AMBARI-20381 > > > Repository: ambari > > > Description > --- > > Fixed by removing the output stream close in the callback > > > Diffs > - > > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java > 8f427bd > > > Diff: https://reviews.apache.org/r/57497/diff/1/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 57454: WFM: Delete option in Manage recent list.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57454/#review168437 --- Ship it! Ship It! - belliraj hb On March 9, 2017, 10:44 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57454/ > --- > > (Updated March 9, 2017, 10:44 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20371 > https://issues.apache.org/jira/browse/AMBARI-20371 > > > Repository: ambari > > > Description > --- > > We have provided an option to delete the workflow from recent list. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > 0e49d70 > contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js > 1d01e9b > > contrib/views/wfmanager/src/main/resources/ui/app/components/recent-projects.js > 18a57f6 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less a30833c > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs > c8d8dc3 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs > 632d6bd > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/recent-projects.hbs > cd8f6af > > > Diff: https://reviews.apache.org/r/57454/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57445: AMBARI-20359. Not able to import workflow with fs action node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57445/#review168406 --- Ship it! Ship It! - belliraj hb On March 9, 2017, 6:21 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57445/ > --- > > (Updated March 9, 2017, 6:21 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20359 > https://issues.apache.org/jira/browse/AMBARI-20359 > > > Repository: ambari > > > Description > --- > > Added the xmlDoc parameter to handle import node functionality > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > ccf8209 > > > Diff: https://reviews.apache.org/r/57445/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57412: AMBARI-20353. Log error while importing the workflow from encrypted path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57412/#review168275 --- Ship it! Ship It! - belliraj hb On March 8, 2017, 11:10 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57412/ > --- > > (Updated March 8, 2017, 11:10 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20353 > https://issues.apache.org/jira/browse/AMBARI-20353 > > > Repository: ambari > > > Description > --- > > Logger added to log exception while steaming the output > > > Diffs > - > > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java > 9bf2f90 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java > 0b9adda > > > Diff: https://reviews.apache.org/r/57412/diff/2/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57414: AMBARI-20337. Need to show timer while loading coordinator name while bundle creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57414/#review168266 --- Ship it! Ship It! - belliraj hb On March 8, 2017, 10:14 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57414/ > --- > > (Updated March 8, 2017, 10:14 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20337 > https://issues.apache.org/jira/browse/AMBARI-20337 > > > Repository: ambari > > > Description > --- > > Added the loading icon while fetching the coordinator name. And also showing > the error message if any exception occurs. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-coord-config.js > 2280f82 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs > 2d374a5 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs > 56cacd6 > > > Diff: https://reviews.apache.org/r/57414/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57413: WFM. Import/Export asset label changes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57413/#review168254 --- Ship it! Ship It! - belliraj hb On March 8, 2017, 8:01 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57413/ > --- > > (Updated March 8, 2017, 8:01 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20355 > https://issues.apache.org/jira/browse/AMBARI-20355 > > > Repository: ambari > > > Description > --- > > Labels has to be changed from > > Import Asset > Import Assets to HDFS > Publish Asset > Publish Asset to HDFS > Import from HDFS > > to > > Import Asset from Local Ambari Database > Import Asset from Shared File System > Save Asset to Local Ambari Database > Save Asset to Shared File System > Import from Shared File System > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > b5c3807 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs > 75ec872 > > > Diff: https://reviews.apache.org/r/57413/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57412: AMBARI-20353. Log error while importing the workflow from encrypted path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57412/#review168253 --- Ship it! Ship It! - belliraj hb On March 8, 2017, 7:30 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57412/ > --- > > (Updated March 8, 2017, 7:30 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20353 > https://issues.apache.org/jira/browse/AMBARI-20353 > > > Repository: ambari > > > Description > --- > > Logger added to log exception while steaming the output > > > Diffs > - > > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java > 9bf2f90 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java > 0b9adda > > > Diff: https://reviews.apache.org/r/57412/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57374: AMBARI-20342.WFM:Performance improvement for adding node on a decision node in large workflow.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57374/#review168125 --- Ship it! Ship It! - belliraj hb On March 7, 2017, 1:32 p.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57374/ > --- > > (Updated March 7, 2017, 1:32 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20342 > https://issues.apache.org/jira/browse/AMBARI-20342 > > > Repository: ambari > > > Description > --- > > The issue was happening when the source node is a placeholder node. Fixed by > extracting the original source node transitions instead of finding the the > source of placeholder and processing the dag from start. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 01f8fe6 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > f8796ae > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less a424049 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > b5c3807 > > > Diff: https://reviews.apache.org/r/57374/diff/1/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 57289: AMBARI-20301. Ember should take node version specific to wfmanager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57289/#review167820 --- Ship it! Ship It! - belliraj hb On March 3, 2017, 1:47 p.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57289/ > --- > > (Updated March 3, 2017, 1:47 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20301 > https://issues.apache.org/jira/browse/AMBARI-20301 > > > Repository: ambari > > > Description > --- > > Changing the execution of ember from local node > > > Diffs > - > > contrib/views/wfmanager/pom.xml 564a82d > > > Diff: https://reviews.apache.org/r/57289/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57283: AMBARI-20295. Workflow manager view is not loading
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57283/#review167813 --- Ship it! Ship It! - belliraj hb On March 3, 2017, 12:06 p.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57283/ > --- > > (Updated March 3, 2017, 12:06 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20295 > https://issues.apache.org/jira/browse/AMBARI-20295 > > > Repository: ambari > > > Description > --- > > Latest version of cytoscape.js is having issues. So setting the bower working > versions. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/bower.json b44a83b > > > Diff: https://reviews.apache.org/r/57283/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57284: AMBARI-20296.Workflow Manger support for pointing to kill node in decision editor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57284/#review167812 --- Ship it! Ship It! - belliraj hb On March 3, 2017, 12:07 p.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57284/ > --- > > (Updated March 3, 2017, 12:07 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20296 > https://issues.apache.org/jira/browse/AMBARI-20296 > > > Repository: ambari > > > Description > --- > > Fixed by enabling the changing of target nodes for each condition in the > decision editor > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js > 41bb1e5 > > contrib/views/wfmanager/src/main/resources/ui/app/components/decision-config.js > 419be37 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 2f8455f > > contrib/views/wfmanager/src/main/resources/ui/app/components/transition-config.js > ce04863 > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js > 09bffe7 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > ae178b3 > contrib/views/wfmanager/src/main/resources/ui/app/domain/node.js d815df1 > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > 228f0e2 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/decision-config.hbs > cb7ff46 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > d428815 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/transition-config.hbs > fe46446 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs > 788916b > > contrib/views/wfmanager/src/main/resources/ui/app/validators/workflow-dag.js > PRE-CREATION > > > Diff: https://reviews.apache.org/r/57284/diff/1/ > > > Testing > --- > > Manual testing > > > Thanks, > > Padma Priya N > >
Review Request 57275: WFM FS editor needs to maintain order of FS operations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57275/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20293 https://issues.apache.org/jira/browse/AMBARI-20293 Repository: ambari Description --- WFM FS editor needs to maintain order of FS operations Diffs - contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 305861010c contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js 12d12d2754 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js dd63a3a995 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js 72235815e0 Diff: https://reviews.apache.org/r/57275/diff/1/ Testing --- Manual testing. Thanks, belliraj hb
Re: Review Request 57267: AMBARI-20247. Show full error while importing the workflow from encrypted file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57267/#review167796 --- Ship it! Ship It! - belliraj hb On March 3, 2017, 6:46 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57267/ > --- > > (Updated March 3, 2017, 6:46 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20247 > https://issues.apache.org/jira/browse/AMBARI-20247 > > > Repository: ambari > > > Description > --- > > Showing the full stack trace on the UI if there is an exception. And also > added the loggers. > > > Diffs > - > > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java > c4e5bbd > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java > 3355c85 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmWebException.java > fd4ce80 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java > e1a5808 > > > Diff: https://reviews.apache.org/r/57267/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57240: AMBARI-20268.WFM generates duplicate kill nodes in XML if decision paths have multiple transition to kill node.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57240/#review167665 --- Ship it! Ship It! - belliraj hb On March 2, 2017, 10:22 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57240/ > --- > > (Updated March 2, 2017, 10:22 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20268 > https://issues.apache.org/jira/browse/AMBARI-20268 > > > Repository: ambari > > > Description > --- > > Fixed by storing nodes by name instead of id in the visited nodes array > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js > eb8534b > > > Diff: https://reviews.apache.org/r/57240/diff/1/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 57237: AMBARI-20266.Duplicate node error is shown if kill node transition exists from decision node in WFM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57237/#review167657 --- Ship it! Ship It! - belliraj hb On March 2, 2017, 9:11 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57237/ > --- > > (Updated March 2, 2017, 9:11 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20266 > https://issues.apache.org/jira/browse/AMBARI-20266 > > > Repository: ambari > > > Description > --- > > Added to check to avoid kill tranisitions while validating > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js > 7336d6e > > > Diff: https://reviews.apache.org/r/57237/diff/1/ > > > Testing > --- > > Manual testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 57189: AMBARI-20246.Not able to preview the xml for coordinator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57189/#review167243 --- Ship it! Ship It! - belliraj hb On March 1, 2017, 9:55 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57189/ > --- > > (Updated March 1, 2017, 9:55 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20246 > https://issues.apache.org/jira/browse/AMBARI-20246 > > > Repository: ambari > > > Description > --- > > Fixed by changing slainfo property to slaInfo > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > b5592a6 > contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js > be5d6f9 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js > 5101181 > > > Diff: https://reviews.apache.org/r/57189/diff/1/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 57181: AMBARI-20206.Workflow manager is allowing to have empty action node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57181/#review167226 --- Ship it! Ship It! - belliraj hb On March 1, 2017, 7:25 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57181/ > --- > > (Updated March 1, 2017, 7:25 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20206 > https://issues.apache.org/jira/browse/AMBARI-20206 > > > Repository: ambari > > > Description > --- > > Modified validation to check for empty action node name. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 2d326d1 > contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 8aac32b > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs > 00cb8a6 > contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs > d96be85 > > contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js > 86e5182 > > contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-kill-node-name.js > b8770c2 > > > Diff: https://reviews.apache.org/r/57181/diff/1/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 57179: AMBARI-20131.Workflow details are lost upon refreshing the browser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57179/#review167210 --- Ship it! Ship It! - belliraj hb On March 1, 2017, 6:34 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57179/ > --- > > (Updated March 1, 2017, 6:34 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20131 > https://issues.apache.org/jira/browse/AMBARI-20131 > > > Repository: ambari > > > Description > --- > > Fixed by creating the tabs observer after tabs are initializes > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > 74de3b7 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js > 2e937e5 > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > 9fd8286 > contrib/views/wfmanager/src/main/resources/ui/app/services/user-info.js > 7c59f40 > > contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js > e77ef7f > > > Diff: https://reviews.apache.org/r/57179/diff/1/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 57136: Pom.xml change in Workflow manager to fix the version of front end plugin to make it compatible with the maven version used in ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57136/#review167044 --- Ship it! Ship It! - belliraj hb On Feb. 28, 2017, 11:24 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57136/ > --- > > (Updated Feb. 28, 2017, 11:24 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20230 > https://issues.apache.org/jira/browse/AMBARI-20230 > > > Repository: ambari > > > Description > --- > > The version for front end plugin has to be changed to make it compatible with > the maven version used in Amabri > > > Diffs > - > > contrib/views/wfmanager/pom.xml 6f0b848 > > Diff: https://reviews.apache.org/r/57136/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57130: Clicking save button keeps the dialog window open, When job is submitted, the dialog stays open
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57130/#review167033 --- Ship it! Ship It! - belliraj hb On Feb. 28, 2017, 9:25 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57130/ > --- > > (Updated Feb. 28, 2017, 9:25 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20227 > https://issues.apache.org/jira/browse/AMBARI-20227 > > > Repository: ambari > > > Description > --- > > The dialog box will be closed on successful saving and submission of workflow > and the success message is shown on the parent window. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > e94d51a > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > f6e11b6 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 9eb20aa > contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js > 15c1fbf > contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js > 017bc61 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs > 2d374a5 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs > 0e35d0e > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 4ff9d87 > > Diff: https://reviews.apache.org/r/57130/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57079: All the workflow details are getting logged in UI console log
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57079/#review166843 --- Ship it! Ship It! - belliraj hb On Feb. 27, 2017, 10:04 a.m., belliraj hb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57079/ > --- > > (Updated Feb. 27, 2017, 10:04 a.m.) > > > Review request for Ambari, Gaurav Nagar, Pallav Kulshreshtha, and Rohit > Choudhary. > > > Bugs: AMBARI-20132 > https://issues.apache.org/jira/browse/AMBARI-20132 > > > Repository: ambari > > > Description > --- > > All console logs are removed. duplicate methods are removed. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > 61d9f35e72 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 8597d72c23 > contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js > 00dedbb5ba > contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js > f65931738c > contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js > 01da55bbc5 > > contrib/views/wfmanager/src/main/resources/ui/app/components/sqoop-action.js > 67ba85aabe > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js > e19646df5f > > contrib/views/wfmanager/src/main/resources/ui/app/domain/action-type-resolver.js > 8cbcfafa91 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-generator.js > f2dcef931e > > contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-generator.js > 4c8d16f2c4 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js > bc61f1079d > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > 75ceecbe46 > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js > e05b782b26 > contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js > 67605ae4a6 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > ae566f29e3 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js > fa7a8b8f92 > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > be8d8de780 > > contrib/views/wfmanager/src/main/resources/ui/app/routes/design/proj-manager-tab.js > 685b49c90b > contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js > b9ea770ae5 > > contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js > c377eccf02 > contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js > 7ad4361b9e > > Diff: https://reviews.apache.org/r/57079/diff/ > > > Testing > --- > > Manual > > > Thanks, > > belliraj hb > >
Review Request 57079: All the workflow details are getting logged in UI console log
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57079/ --- Review request for Ambari, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-20132 https://issues.apache.org/jira/browse/AMBARI-20132 Repository: ambari Description --- All console logs are removed. duplicate methods are removed. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 61d9f35e72 contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 8597d72c23 contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 00dedbb5ba contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js f65931738c contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 01da55bbc5 contrib/views/wfmanager/src/main/resources/ui/app/components/sqoop-action.js 67ba85aabe contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js e19646df5f contrib/views/wfmanager/src/main/resources/ui/app/domain/action-type-resolver.js 8cbcfafa91 contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-generator.js f2dcef931e contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-generator.js 4c8d16f2c4 contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js bc61f1079d contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 75ceecbe46 contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js e05b782b26 contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js 67605ae4a6 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js ae566f29e3 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js fa7a8b8f92 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js be8d8de780 contrib/views/wfmanager/src/main/resources/ui/app/routes/design/proj-manager-tab.js 685b49c90b contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js b9ea770ae5 contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js c377eccf02 contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 7ad4361b9e Diff: https://reviews.apache.org/r/57079/diff/ Testing --- Manual Thanks, belliraj hb
Re: Review Request 57029: AMBARI-20167. importing from workflow from the coordinator setup hangs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57029/#review166671 --- Ship it! Ship It! - belliraj hb On Feb. 24, 2017, 10:19 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57029/ > --- > > (Updated Feb. 24, 2017, 10:19 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20167 > https://issues.apache.org/jira/browse/AMBARI-20167 > > > Repository: ambari > > > Description > --- > > Validating the path before import. Disabling the import if path has variables. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > 4a57e37 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs > 7db5ce2 > > Diff: https://reviews.apache.org/r/57029/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57028: AMBARI-20166.Workflow Manager. Nominal time should accept variables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57028/#review19 --- Ship it! Ship It! - belliraj hb On Feb. 24, 2017, 10:18 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57028/ > --- > > (Updated Feb. 24, 2017, 10:18 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20166 > https://issues.apache.org/jira/browse/AMBARI-20166 > > > Repository: ambari > > > Description > --- > > Fixed by using existing date-with-expr component for nominal time instead of > date field. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js > bcc209b > contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js > 153b538 > contrib/views/wfmanager/src/main/resources/ui/app/domain/sla-info.js > 9d90280 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs > 2ebc259 > > Diff: https://reviews.apache.org/r/57028/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 57027: AMBARI-20142. Job Link URL not working
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57027/#review18 --- Ship it! Ship It! - belliraj hb On Feb. 24, 2017, 10:09 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57027/ > --- > > (Updated Feb. 24, 2017, 10:09 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20142 > https://issues.apache.org/jira/browse/AMBARI-20142 > > > Repository: ambari > > > Description > --- > > Showing the Job Url link if it starts with http > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-action.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-details.js > 7a868fa > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-action.hbs > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs > b5565c8 > contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js > 309c281 > > contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-job-action-test.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/57027/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 57025: AMBARI-20164.Kill a workflow jumps to another tab in WFM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57025/#review14 --- Ship it! Ship It! - belliraj hb On Feb. 24, 2017, 9:34 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57025/ > --- > > (Updated Feb. 24, 2017, 9:34 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20164 > https://issues.apache.org/jira/browse/AMBARI-20164 > > > Repository: ambari > > > Description > --- > > Fixed by handling and updating the affected jobs rather than refreshing the > route when bulk action is complete. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js > 2b40392 > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js > c8df452 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js > 691cc26 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs > d28a497 > > Diff: https://reviews.apache.org/r/57025/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 57024: AMBARI-20161.Workflow Manager-mapred action contains duplicates in editor if user saves and reopens editor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57024/#review12 --- Ship it! Ship It! - belliraj hb On Feb. 24, 2017, 9:18 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57024/ > --- > > (Updated Feb. 24, 2017, 9:18 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20161 > https://issues.apache.org/jira/browse/AMBARI-20161 > > > Repository: ambari > > > Description > --- > > Fixed by removing duplicate values in the properties array. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > de72c6d > > contrib/views/wfmanager/src/main/resources/ui/app/components/map-red-action.js > 3eb8545 > > Diff: https://reviews.apache.org/r/57024/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56981: AMBARI-20141.Command text lost when toggling from Command to Args on sqoop in Workflow manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56981/#review166517 --- Ship it! Ship It! - belliraj hb On Feb. 23, 2017, 12:42 p.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56981/ > --- > > (Updated Feb. 23, 2017, 12:42 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20141 > https://issues.apache.org/jira/browse/AMBARI-20141 > > > Repository: ambari > > > Description > --- > > Fixed by retaining both command and args and deleting the unused one on > destroy of the component. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/hive-action.js > ac85a9a > > contrib/views/wfmanager/src/main/resources/ui/app/components/hive2-action.js > f23cca7 > contrib/views/wfmanager/src/main/resources/ui/app/components/java-action.js > 18a3702 > > contrib/views/wfmanager/src/main/resources/ui/app/components/sqoop-action.js > 2756700 > contrib/views/wfmanager/src/main/resources/ui/app/components/ssh-action.js > 8da7eef > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive-action.hbs > 3d59e23 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive2-action.hbs > 8adf64c > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/java-action.hbs > 3de5677 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs > db69864 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs > a29a2ec > contrib/views/wfmanager/src/main/resources/ui/app/validators/arg-length.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/56981/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56979: AMBARI-20050. Issue while importing workflow with insufficient permissions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56979/#review166508 --- Ship it! Ship It! - belliraj hb On Feb. 23, 2017, 12:04 p.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56979/ > --- > > (Updated Feb. 23, 2017, 12:04 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20050 > https://issues.apache.org/jira/browse/AMBARI-20050 > > > Repository: ambari > > > Description > --- > > Exception handling properly > > > Diffs > - > > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieDelegate.java > 55c4312 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java > 6603a9c > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java > ef3b508 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/ErrorCode.java > PRE-CREATION > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmException.java > PRE-CREATION > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmWebException.java > PRE-CREATION > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java > a0aa234 > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > 3ccbc07 > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > bbd619d > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js > 7a7c38d > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > f97add8 > > contrib/views/wfmanager/src/main/resources/ui/app/components/stack-trace-dialog.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less e98d182 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs > ca58431 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs > 7b607ca > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs > 8438255 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 1a73421 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/stack-trace-dialog.hbs > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/stack-trace-dialog-test.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/56979/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 56971: Changes/Overwrites to Bundles and Coordinators Show as Workflow, Not able to select text from worflow 'Definition' tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56971/#review166485 --- Ship it! Ship It! - belliraj hb On Feb. 23, 2017, 6:30 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56971/ > --- > > (Updated Feb. 23, 2017, 6:30 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20133 > https://issues.apache.org/jira/browse/AMBARI-20133 > > > Repository: ambari > > > Description > --- > > When saving and/or overwriting coordinator or bundle files, UI appears to > have a typo. States that "Workflow" has been saved instead. > Not able to select text from workflow 'Definition' tab. > Dashboard - Select Workflow - Definition Tab - try selecting text. (browser: > chrome) > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js > 17ee0fd > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 86c1dd3 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs > aee2072 > > Diff: https://reviews.apache.org/r/56971/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 56972: Improper action node name after importing the asset
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56972/#review166484 --- Ship it! Ship It! - belliraj hb On Feb. 23, 2017, 6:44 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56972/ > --- > > (Updated Feb. 23, 2017, 6:44 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20134 > https://issues.apache.org/jira/browse/AMBARI-20134 > > > Repository: ambari > > > Description > --- > > Action node name is not proper after importing asset. Once user imports the > asset, the node name is displayed as _undefined. > Instead of this, if there are no other action nodes of this type, then just > show the actual node name. > And if there are already existing nodes of this type, then show > _. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > b2b9c68 > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > 0fc5d6c > > Diff: https://reviews.apache.org/r/56972/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 56881: Cannot edit join node name in Workflow Manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56881/#review166365 --- Ship it! Ship It! - belliraj hb On Feb. 21, 2017, 12:15 p.m., belliraj hb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56881/ > --- > > (Updated Feb. 21, 2017, 12:15 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav > Kulshreshtha. > > > Bugs: AMBARI-20093 > https://issues.apache.org/jira/browse/AMBARI-20093 > > > Repository: ambari > > > Description > --- > > Editing join node is now enabled by making it a non static node. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > 51e0461f26 > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js > 2eb01d151b > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 0356e9cab6 > > Diff: https://reviews.apache.org/r/56881/diff/ > > > Testing > --- > > Manual testing > > > Thanks, > > belliraj hb > >
Re: Review Request 56915: AMBARI-20107.Action node shows unsupported properties even though there are none in workflow manager.
> On Feb. 22, 2017, 7:20 a.m., Nitiraj Rathore wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js, > > line 72 > > <https://reviews.apache.org/r/56915/diff/2/?file=1642201#file1642201line72> > > > > It looks like this might break if some more internal keys are added to > > ember objects in later versions. > > Can you rely on something like : > > JSON.parse(JSON.stringify(unsupportedProperties)) > > to get plain js object. > > belliraj hb wrote: > This deletes only one property __jsogObjectId which is added > automatically by JSOG library which is the only thing we want to remove. it > doesnt affect other internal keys added to ember object. Dint want to use Json with the code as the domain model of wofklow will have cyclic dependency. hence using JSOG notation. __jsogObjectID is a documented field in the JSOG library. Hence we are removing JSOG added properties. - belliraj --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56915/#review166327 --- On Feb. 22, 2017, 6:32 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56915/ > ------- > > (Updated Feb. 22, 2017, 6:32 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20107 > https://issues.apache.org/jira/browse/AMBARI-20107 > > > Repository: ambari > > > Description > --- > > The issue is because the jsog object id is appended to the xml. Fixed by > excluding jsog object id in the unsupported properties. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js > d09de7d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs > fae2d3d > > Diff: https://reviews.apache.org/r/56915/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56915: AMBARI-20107.Action node shows unsupported properties even though there are none in workflow manager.
> On Feb. 22, 2017, 7:20 a.m., Nitiraj Rathore wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js, > > line 72 > > <https://reviews.apache.org/r/56915/diff/2/?file=1642201#file1642201line72> > > > > It looks like this might break if some more internal keys are added to > > ember objects in later versions. > > Can you rely on something like : > > JSON.parse(JSON.stringify(unsupportedProperties)) > > to get plain js object. This deletes only one property __jsogObjectId which is added automatically by JSOG library which is the only thing we want to remove. it doesnt affect other internal keys added to ember object. - belliraj --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56915/#review166327 --- On Feb. 22, 2017, 6:32 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56915/ > --- > > (Updated Feb. 22, 2017, 6:32 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20107 > https://issues.apache.org/jira/browse/AMBARI-20107 > > > Repository: ambari > > > Description > --- > > The issue is because the jsog object id is appended to the xml. Fixed by > excluding jsog object id in the unsupported properties. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js > d09de7d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs > fae2d3d > > Diff: https://reviews.apache.org/r/56915/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56915: AMBARI-20107.Action node shows unsupported properties even though there are none in workflow manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56915/#review166338 --- Ship it! Ship It! - belliraj hb On Feb. 22, 2017, 6:32 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56915/ > --- > > (Updated Feb. 22, 2017, 6:32 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20107 > https://issues.apache.org/jira/browse/AMBARI-20107 > > > Repository: ambari > > > Description > --- > > The issue is because the jsog object id is appended to the xml. Fixed by > excluding jsog object id in the unsupported properties. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js > d09de7d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs > fae2d3d > > Diff: https://reviews.apache.org/r/56915/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56882: Unique Name not created automatically when designing workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56882/#review166154 --- Ship it! Ship It! - belliraj hb On Feb. 21, 2017, 12:17 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56882/ > --- > > (Updated Feb. 21, 2017, 12:17 p.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20095 > https://issues.apache.org/jira/browse/AMBARI-20095 > > > Repository: ambari > > > Description > --- > > Create a workflow > Keep adding actions and WFD shows error saying that node name should be > unique. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 190bb1a > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > a563c20 > > Diff: https://reviews.apache.org/r/56882/diff/ > > > Testing > --- > > Manual Testing done > > > Thanks, > > venkat sairam > >
Review Request 56881: Cannot edit join node name in Workflow Manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56881/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20093 https://issues.apache.org/jira/browse/AMBARI-20093 Repository: ambari Description --- Editing join node is now enabled by making it a non static node. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 51e0461f26 contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 2eb01d151b contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 0356e9cab6 Diff: https://reviews.apache.org/r/56881/diff/ Testing --- Manual testing Thanks, belliraj hb
Re: Review Request 56871: AMBARI-20090.On submit of bundle, if any coordinator path contains variables, user should be notified about custom variables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56871/#review166138 --- Ship it! Ship It! - belliraj hb On Feb. 21, 2017, 9:56 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56871/ > --- > > (Updated Feb. 21, 2017, 9:56 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20090 > https://issues.apache.org/jira/browse/AMBARI-20090 > > > Repository: ambari > > > Description > --- > > Fixed by showing a warning message on the job submit modal if the underlying > coordinator path or workflow path of bundle a contains variables. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > 9201d5c > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > c7da381 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js > e30750f > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs > 749a173 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs > 2ac56e8 > > Diff: https://reviews.apache.org/r/56871/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56863: AMBARI-20084.Cut Node feature is broken in workflow manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56863/#review166129 --- Ship it! Ship It! - belliraj hb On Feb. 21, 2017, 6:04 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56863/ > --- > > (Updated Feb. 21, 2017, 6:04 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20084 > https://issues.apache.org/jira/browse/AMBARI-20084 > > > Repository: ambari > > > Description > --- > > The incoming transition list of the node to be cut was passed as an argument > to deleteNode. Fixed by passing the list of incoming tranistions to delete > node. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > c1bd4be > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > 6f46fdc > > Diff: https://reviews.apache.org/r/56863/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56849: AMBARI-20080.WFM does not issue confirmation message when workflow is suspended or killed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56849/#review166086 --- Ship it! Ship It! - belliraj hb On Feb. 20, 2017, 11:45 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56849/ > --- > > (Updated Feb. 20, 2017, 11:45 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20080 > https://issues.apache.org/jira/browse/AMBARI-20080 > > > Repository: ambari > > > Description > --- > > Fixed by showing a confirmation message after the action request has > successfully executed. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js > 1dd580e > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js > b2f2a57 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs > 5c15493 > > Diff: https://reviews.apache.org/r/56849/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56848: AMBARI-20079.Unable to filter by job id
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56848/#review166085 --- Ship it! Ship It! - belliraj hb On Feb. 20, 2017, 11:27 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56848/ > --- > > (Updated Feb. 20, 2017, 11:27 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20079 > https://issues.apache.org/jira/browse/AMBARI-20079 > > > Repository: ambari > > > Description > --- > > The issue was because the filtering was failing when there was no space > between job and id in the filter term job id. The fix has enabed the user to > search with both job id and jobid filter terms. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > e6f7ec8 > > Diff: https://reviews.apache.org/r/56848/diff/ > > > Testing > --- > > Manual testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56846: AMBARI-20078.When uploading a file using the WFM, need a message to say that either the file upload succeeded or failed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56846/#review166083 --- Ship it! Ship It! - belliraj hb On Feb. 20, 2017, 10:31 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56846/ > --- > > (Updated Feb. 20, 2017, 10:31 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20078 > https://issues.apache.org/jira/browse/AMBARI-20078 > > > Repository: ambari > > > Description > --- > > Fixed by displaying success message when upload is complete. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js > 1af9f4d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs > b8da4a0 > > Diff: https://reviews.apache.org/r/56846/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56843: AMBARI-20077. Server Error when trying to save and not overwrite
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56843/#review166070 --- Ship it! Ship It! - belliraj hb On Feb. 20, 2017, 9:32 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56843/ > --- > > (Updated Feb. 20, 2017, 9:32 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20077 > https://issues.apache.org/jira/browse/AMBARI-20077 > > > Repository: ambari > > > Description > --- > > Saving recent workflow has been changed to make it per user and also draft > file save will be overwritten automatically. This solves the server errors > in the bug described. > > > Diffs > - > > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java > a119a7e > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieUtils.java > 9791c47 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java > 61d878e > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java > 24c263b > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java > fc08b80 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java > 7513107 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java > 1fc0c5f > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > db7a180 > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > 369481f > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 29c9dd2 > contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js > 75cdaf9 > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > 26e72d5 > > Diff: https://reviews.apache.org/r/56843/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 56746: Custom job.properties are not retained in the workflow designer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56746/#review165829 --- Ship it! Ship It! - belliraj hb On Feb. 16, 2017, 11:40 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56746/ > --- > > (Updated Feb. 16, 2017, 11:40 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, and Pallav Kulshreshtha. > > > Bugs: AMBARI-20041 > https://issues.apache.org/jira/browse/AMBARI-20041 > > > Repository: ambari > > > Description > --- > > Custom job.properties are not retained in the workflow designer. > > Steps to reproduce : > 1) Submit a workflow with custom job properties say > oozie.action.sharelib.for.sqoop=sqoop,hive. > 2) From the dashboard, select this workflow. > 3) When user tries to submit it again, previously included properties are not > visible to the user. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > f93e1b8 > contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js > f364e30 > contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js > fe60793 > contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 25a3266 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > ff92f7d > > Diff: https://reviews.apache.org/r/56746/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Review Request 56745: Workflow Manager workflow rendering is broken in designer page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56745/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-20040 https://issues.apache.org/jira/browse/AMBARI-20040 Repository: ambari Description --- Error nodes are now displayed if transition points to kill node on an non-error condition. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 4194d5e612 contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 5a074dfdac contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js 5282544a93 Diff: https://reviews.apache.org/r/56745/diff/ Testing --- Manual testing Thanks, belliraj hb
Re: Review Request 56704: Issue while resetting the coordinator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56704/#review165811 --- Ship it! Ship It! - belliraj hb On Feb. 16, 2017, 6:48 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56704/ > --- > > (Updated Feb. 16, 2017, 6:48 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-19979 > https://issues.apache.org/jira/browse/AMBARI-19979 > > > Repository: ambari > > > Description > --- > > User is not able to reset the coordinator. > Steps to reproduce : > 1) Import the attached coordinator. > 2) Import the same coordinator in different window > 3) Try to preview the xml or reset the coordinator. The UI is getting hung. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > aa2e791 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less f4869e4 > > Diff: https://reviews.apache.org/r/56704/diff/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 56701: AMBARI-20019:WFM Dashboard Actions menu items not working properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56701/#review165674 --- Ship it! Ship It! - belliraj hb On Feb. 15, 2017, 9:59 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56701/ > --- > > (Updated Feb. 15, 2017, 9:59 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20019 > https://issues.apache.org/jira/browse/AMBARI-20019 > > > Repository: ambari > > > Description > --- > > Added condition to disable kill for a succeeded job. > Disabled kill action when the kill button is disabled. > Added tooltips for all action buttons > Added a loader icon when action request is in progress > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js > 2a5fc22 > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > e9bc44f > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js > 714de66 > > contrib/views/wfmanager/src/main/resources/ui/app/controllers/design/dashboardtab.js > 9760ddb > > contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js > 95d06fc > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3f24000 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs > a4a0cc2 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs > be9310e > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs > eccc95d > > Diff: https://reviews.apache.org/r/56701/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56696: AMBARI-19978:Coordinator tag sequence is not maintained
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56696/#review165668 --- Ship it! Ship It! - belliraj hb On Feb. 15, 2017, 6:07 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56696/ > --- > > (Updated Feb. 15, 2017, 6:07 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-19978 > https://issues.apache.org/jira/browse/AMBARI-19978 > > > Repository: ambari > > > Description > --- > > Modified the ordering of properties in the coordinator object and modified > the xml generation in par with the xsd. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > 658cbc0 > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > 39b9d11 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-generator.js > cbefa99 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js > ddb2b43 > > Diff: https://reviews.apache.org/r/56696/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56698: AMBARI-20003:Not able to preview the workflow xml
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56698/#review165667 --- Ship it! Ship It! - belliraj hb On Feb. 15, 2017, 6:09 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56698/ > --- > > (Updated Feb. 15, 2017, 6:09 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20003 > https://issues.apache.org/jira/browse/AMBARI-20003 > > > Repository: ambari > > > Description > --- > > Modified sqoop action model and sqoop action job handler to handle arg field > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/sqoop-action.js > 13eb6e5 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js > 2a82c24 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs > fb59149 > > Diff: https://reviews.apache.org/r/56698/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56699: AMBARI-20007:Args value is not retained for ssh node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56699/#review165666 --- Ship it! Ship It! - belliraj hb On Feb. 15, 2017, 6:55 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56699/ > --- > > (Updated Feb. 15, 2017, 6:55 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20007 > https://issues.apache.org/jira/browse/AMBARI-20007 > > > Repository: ambari > > > Description > --- > > Modified the handling of args while switching the arg ang args radio buttons. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/java-action.js > 9d43fe7 > contrib/views/wfmanager/src/main/resources/ui/app/components/ssh-action.js > d879a0c > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/shell-action.hbs > 2cd8207 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs > 64f3906 > > Diff: https://reviews.apache.org/r/56699/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56660: AMBARI-20005:Credentials from one workflow are getting associated across other workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56660/#review165499 --- Ship it! Ship It! - belliraj hb On Feb. 14, 2017, 1:06 p.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56660/ > --- > > (Updated Feb. 14, 2017, 1:06 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20005 > https://issues.apache.org/jira/browse/AMBARI-20005 > > > Repository: ambari > > > Description > --- > > Fixed by clearing credentials array when creating a workflow > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > 1f02426 > > Diff: https://reviews.apache.org/r/56660/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
