Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51890/#review149089
---


Ship it!




Ship It!

- Alejandro Fernandez


On Sept. 15, 2016, 5:26 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51890/
> ---
> 
> (Updated Sept. 15, 2016, 5:26 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18386
> https://issues.apache.org/jira/browse/AMBARI-18386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> From ambari stacks for Ranger: enable ranger hive plugin takes care of using 
> right jdbc url for repo configs that are set for creating a repository in 
> Ranger for Secure and simple install of hive. 
> However in HiverServer2 HA env, jdbc url needs to change in repo config with 
> zk url.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  169fbff 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5e3e233 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  8c838db 
> 
> Diff: https://reviews.apache.org/r/51890/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger hive plugin with Ranger install on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51890/#review149076
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 15, 2016, 5:26 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51890/
> ---
> 
> (Updated Sept. 15, 2016, 5:26 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18386
> https://issues.apache.org/jira/browse/AMBARI-18386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> From ambari stacks for Ranger: enable ranger hive plugin takes care of using 
> right jdbc url for repo configs that are set for creating a repository in 
> Ranger for Secure and simple install of hive. 
> However in HiverServer2 HA env, jdbc url needs to change in repo config with 
> zk url.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  169fbff 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5e3e233 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  8c838db 
> 
> Diff: https://reviews.apache.org/r/51890/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger hive plugin with Ranger install on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5

[Mugdha Varadkar]

> On Sept. 14, 2016, 5:58 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py,
> >  line 694
> > 
> >
> > Why using stack_supports_ranger_kerberos? It sounds like a workaround 
> > for >= HDP-2.5+.
> 
> Mugdha Varadkar wrote:
> Yes, using stack_supports_ranger_kerberos feature here only for stack 2.5 
> onwards, since this feature is also introduced from stack 2.5
> Do you want me to add new feature here ?

Added feature in updated patch


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51890/#review148939
---


On Sept. 15, 2016, 5:26 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51890/
> ---
> 
> (Updated Sept. 15, 2016, 5:26 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18386
> https://issues.apache.org/jira/browse/AMBARI-18386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> From ambari stacks for Ranger: enable ranger hive plugin takes care of using 
> right jdbc url for repo configs that are set for creating a repository in 
> Ranger for Secure and simple install of hive. 
> However in HiverServer2 HA env, jdbc url needs to change in repo config with 
> zk url.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  169fbff 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5e3e233 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  8c838db 
> 
> Diff: https://reviews.apache.org/r/51890/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger hive plugin with Ranger install on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51890/
---

(Updated Sept. 15, 2016, 5:26 a.m.)


Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and 
Velmurugan Periasamy.


Changes
---

Added stack feature in updated patch

Ran 268 tests in 6.913s

OK
--
Total run:1126
Total errors:0
Total failures:0


Bugs: AMBARI-18386
https://issues.apache.org/jira/browse/AMBARI-18386


Repository: ambari


Description
---

>From ambari stacks for Ranger: enable ranger hive plugin takes care of using 
>right jdbc url for repo configs that are set for creating a repository in 
>Ranger for Secure and simple install of hive. 
However in HiverServer2 HA env, jdbc url needs to change in repo config with zk 
url.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 169fbff 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 5e3e233 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 8c838db 

Diff: https://reviews.apache.org/r/51890/diff/


Testing
---

Tested Ranger hive plugin with Ranger install on centos6


Thanks,

Mugdha Varadkar

Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5

[Mugdha Varadkar]

> On Sept. 14, 2016, 5:58 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py,
> >  line 694
> > 
> >
> > Why using stack_supports_ranger_kerberos? It sounds like a workaround 
> > for >= HDP-2.5+.

Yes, using stack_supports_ranger_kerberos feature here only for stack 2.5 
onwards, since this feature is also introduced from stack 2.5
Do you want me to add new feature here ?


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51890/#review148939
---


On Sept. 14, 2016, 4:32 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51890/
> ---
> 
> (Updated Sept. 14, 2016, 4:32 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18386
> https://issues.apache.org/jira/browse/AMBARI-18386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> From ambari stacks for Ranger: enable ranger hive plugin takes care of using 
> right jdbc url for repo configs that are set for creating a repository in 
> Ranger for Secure and simple install of hive. 
> However in HiverServer2 HA env, jdbc url needs to change in repo config with 
> zk url.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5e3e233 
> 
> Diff: https://reviews.apache.org/r/51890/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger hive plugin with Ranger install on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51890/#review148939
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 (line 694)


Why using stack_supports_ranger_kerberos? It sounds like a workaround for 
>= HDP-2.5+.


- Jayush Luniya


On Sept. 14, 2016, 4:32 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51890/
> ---
> 
> (Updated Sept. 14, 2016, 4:32 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18386
> https://issues.apache.org/jira/browse/AMBARI-18386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> From ambari stacks for Ranger: enable ranger hive plugin takes care of using 
> right jdbc url for repo configs that are set for creating a repository in 
> Ranger for Secure and simple install of hive. 
> However in HiverServer2 HA env, jdbc url needs to change in repo config with 
> zk url.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5e3e233 
> 
> Diff: https://reviews.apache.org/r/51890/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger hive plugin with Ranger install on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5

[Velmurugan Periasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51890/#review148924
---


Ship it!




Ship It!

- Velmurugan Periasamy


On Sept. 14, 2016, 4:32 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51890/
> ---
> 
> (Updated Sept. 14, 2016, 4:32 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18386
> https://issues.apache.org/jira/browse/AMBARI-18386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> From ambari stacks for Ranger: enable ranger hive plugin takes care of using 
> right jdbc url for repo configs that are set for creating a repository in 
> Ranger for Secure and simple install of hive. 
> However in HiverServer2 HA env, jdbc url needs to change in repo config with 
> zk url.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5e3e233 
> 
> Diff: https://reviews.apache.org/r/51890/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger hive plugin with Ranger install on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5

[Mugdha Varadkar]

> On Sept. 14, 2016, 3:25 p.m., Velmurugan Periasamy wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py,
> >  line 696
> > 
> >
> > Should we use zookeeper based URL even if HA is not enabled? That would 
> > cover any additional parameters that need to be added for Hive (like http 
> > transport mode etc)

Updated in latest patch


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51890/#review148907
---


On Sept. 14, 2016, 4:32 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51890/
> ---
> 
> (Updated Sept. 14, 2016, 4:32 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18386
> https://issues.apache.org/jira/browse/AMBARI-18386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> From ambari stacks for Ranger: enable ranger hive plugin takes care of using 
> right jdbc url for repo configs that are set for creating a repository in 
> Ranger for Secure and simple install of hive. 
> However in HiverServer2 HA env, jdbc url needs to change in repo config with 
> zk url.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5e3e233 
> 
> Diff: https://reviews.apache.org/r/51890/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger hive plugin with Ranger install on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51890/
---

(Updated Sept. 14, 2016, 4:32 p.m.)


Review request for Ambari, Gautam Borad, Jayush Luniya, Sumit Mohanty, and 
Velmurugan Periasamy.


Changes
---

Updated patch removed hive-server2 HA check. Updating the jdbc url config from 
2.5 stack onwards


Summary (updated)
-

AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5


Bugs: AMBARI-18386
https://issues.apache.org/jira/browse/AMBARI-18386


Repository: ambari


Description
---

>From ambari stacks for Ranger: enable ranger hive plugin takes care of using 
>right jdbc url for repo configs that are set for creating a repository in 
>Ranger for Secure and simple install of hive. 
However in HiverServer2 HA env, jdbc url needs to change in repo config with zk 
url.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 5e3e233 

Diff: https://reviews.apache.org/r/51890/diff/


Testing
---

Tested Ranger hive plugin with Ranger install on centos6


Thanks,

Mugdha Varadkar