Re: Review Request 52043: AMBARI-18419. Allow setting EclipseLink weave log level in build process

2016-09-21 Thread Attila Doroszlai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52043/
---

(Updated Sept. 21, 2016, 11:21 a.m.)


Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Oliver Szabo, 
and Sebastian Toader.


Changes
---

Rebased to current trunk


Bugs: AMBARI-18419
https://issues.apache.org/jira/browse/AMBARI-18419


Repository: ambari


Description
---

Introduce Maven project property `el.log` to control log level for 
eclipselink-staticweave-maven-plugin


Diffs (updated)
-

  ambari-server/pom.xml 32267c8 

Diff: https://reviews.apache.org/r/52043/diff/


Testing
---

```bash
mvn -pl ambari-server -Drat.skip -DskipTests test-compile
# -> verify output contains all messages from EclipseLink, including lines 
starting with "[EL Config]" and "[EL Finest]"

mvn -pl ambari-server -Drat.skip -DskipTests -Del.log=INFO test-compile
# -> verify output does not contain lines starting with "[EL Config]" and "[EL 
Finest]", only "[EL Warning]"

mvn -pl ambari-server -Drat.skip -DskipTests -Del.log=OFF test-compile
# -> verify output does not contain any lines starting with "[EL "
```


Thanks,

Attila Doroszlai



Re: Review Request 52043: AMBARI-18419. Allow setting EclipseLink weave log level in build process

2016-09-21 Thread Sebastian Toader

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52043/#review149797
---


Ship it!




Ship It!

- Sebastian Toader


On Sept. 19, 2016, 7:21 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52043/
> ---
> 
> (Updated Sept. 19, 2016, 7:21 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Oliver 
> Szabo, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18419
> https://issues.apache.org/jira/browse/AMBARI-18419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Introduce Maven project property `el.log` to control log level for 
> eclipselink-staticweave-maven-plugin
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 323ce22 
> 
> Diff: https://reviews.apache.org/r/52043/diff/
> 
> 
> Testing
> ---
> 
> ```bash
> mvn -pl ambari-server -Drat.skip -DskipTests test-compile
> # -> verify output contains all messages from EclipseLink, including lines 
> starting with "[EL Config]" and "[EL Finest]"
> 
> mvn -pl ambari-server -Drat.skip -DskipTests -Del.log=INFO test-compile
> # -> verify output does not contain lines starting with "[EL Config]" and 
> "[EL Finest]", only "[EL Warning]"
> 
> mvn -pl ambari-server -Drat.skip -DskipTests -Del.log=OFF test-compile
> # -> verify output does not contain any lines starting with "[EL "
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>



Re: Review Request 52043: AMBARI-18419. Allow setting EclipseLink weave log level in build process

2016-09-19 Thread Laszlo Puskas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52043/#review149480
---


Ship it!




- Laszlo Puskas


On Sept. 19, 2016, 3:21 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52043/
> ---
> 
> (Updated Sept. 19, 2016, 3:21 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Oliver 
> Szabo, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18419
> https://issues.apache.org/jira/browse/AMBARI-18419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Introduce Maven project property `el.log` to control log level for 
> eclipselink-staticweave-maven-plugin
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 323ce22 
> 
> Diff: https://reviews.apache.org/r/52043/diff/
> 
> 
> Testing
> ---
> 
> ```bash
> mvn -pl ambari-server -Drat.skip -DskipTests test-compile
> # -> verify output contains all messages from EclipseLink, including lines 
> starting with "[EL Config]" and "[EL Finest]"
> 
> mvn -pl ambari-server -Drat.skip -DskipTests -Del.log=INFO test-compile
> # -> verify output does not contain lines starting with "[EL Config]" and 
> "[EL Finest]", only "[EL Warning]"
> 
> mvn -pl ambari-server -Drat.skip -DskipTests -Del.log=OFF test-compile
> # -> verify output does not contain any lines starting with "[EL "
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>