Re: Review Request 53565: Add ability to Skip Host check option on bootstrap page

2016-11-08 Thread Xi Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53565/#review155386
---


Ship it!




Ship It!

- Xi Wang


On Nov. 8, 2016, 12:09 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53565/
> ---
> 
> (Updated Nov. 8, 2016, 12:09 p.m.)
> 
> 
> Review request for Ambari, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18817
> https://issues.apache.org/jira/browse/AMBARI-18817
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of this work experimental flag has been added by which host checks 
> can be disabled while going thorugh "Add Host Wizard"
> 
> 
> Diffs
> -
> 
>   ambari-web/app/config.js 06faf27 
>   ambari-web/app/controllers/wizard/step3_controller.js 0ccf2ed 
>   ambari-web/app/templates/wizard/step3.hbs f5648e1 
> 
> Diff: https://reviews.apache.org/r/53565/diff/
> 
> 
> Testing
> ---
> 
> manually verified the patch on the lcuster
> verified that all ambar-web unit tests passes
>   29248 tests complete (30 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 53565: Add ability to Skip Host check option on bootstrap page

2016-11-08 Thread Richard Zang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53565/#review155349
---


Ship it!




Ship It!

- Richard Zang


On Nov. 8, 2016, 8:09 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53565/
> ---
> 
> (Updated Nov. 8, 2016, 8:09 p.m.)
> 
> 
> Review request for Ambari, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18817
> https://issues.apache.org/jira/browse/AMBARI-18817
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of this work experimental flag has been added by which host checks 
> can be disabled while going thorugh "Add Host Wizard"
> 
> 
> Diffs
> -
> 
>   ambari-web/app/config.js 06faf27 
>   ambari-web/app/controllers/wizard/step3_controller.js 0ccf2ed 
>   ambari-web/app/templates/wizard/step3.hbs f5648e1 
> 
> Diff: https://reviews.apache.org/r/53565/diff/
> 
> 
> Testing
> ---
> 
> manually verified the patch on the lcuster
> verified that all ambar-web unit tests passes
>   29248 tests complete (30 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 53565: Add ability to Skip Host check option on bootstrap page

2016-11-08 Thread Vivek Ratnavel Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53565/#review155343
---


Ship it!




Ship It!

- Vivek Ratnavel Subramanian


On Nov. 8, 2016, 8:09 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53565/
> ---
> 
> (Updated Nov. 8, 2016, 8:09 p.m.)
> 
> 
> Review request for Ambari, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18817
> https://issues.apache.org/jira/browse/AMBARI-18817
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of this work experimental flag has been added by which host checks 
> can be disabled while going thorugh "Add Host Wizard"
> 
> 
> Diffs
> -
> 
>   ambari-web/app/config.js 06faf27 
>   ambari-web/app/controllers/wizard/step3_controller.js 0ccf2ed 
>   ambari-web/app/templates/wizard/step3.hbs f5648e1 
> 
> Diff: https://reviews.apache.org/r/53565/diff/
> 
> 
> Testing
> ---
> 
> manually verified the patch on the lcuster
> verified that all ambar-web unit tests passes
>   29248 tests complete (30 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 53565: Add ability to Skip Host check option on bootstrap page

2016-11-08 Thread Jaimin Jetly 


> On Nov. 8, 2016, 8 p.m., Vivek Ratnavel Subramanian wrote:
> > ambari-web/app/controllers/wizard/step3_controller.js, line 228
> > 
> >
> > Variable is not used

2nd version of the patch uploaded to fix this issue


- Jaimin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53565/#review155339
---


On Nov. 8, 2016, 8:09 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53565/
> ---
> 
> (Updated Nov. 8, 2016, 8:09 p.m.)
> 
> 
> Review request for Ambari, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18817
> https://issues.apache.org/jira/browse/AMBARI-18817
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of this work experimental flag has been added by which host checks 
> can be disabled while going thorugh "Add Host Wizard"
> 
> 
> Diffs
> -
> 
>   ambari-web/app/config.js 06faf27 
>   ambari-web/app/controllers/wizard/step3_controller.js 0ccf2ed 
>   ambari-web/app/templates/wizard/step3.hbs f5648e1 
> 
> Diff: https://reviews.apache.org/r/53565/diff/
> 
> 
> Testing
> ---
> 
> manually verified the patch on the lcuster
> verified that all ambar-web unit tests passes
>   29248 tests complete (30 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 53565: Add ability to Skip Host check option on bootstrap page

2016-11-08 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53565/
---

(Updated Nov. 8, 2016, 8:09 p.m.)


Review request for Ambari, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, 
and Yusaku Sako.


Changes
---

Removes an unused declared variable


Bugs: AMBARI-18817
https://issues.apache.org/jira/browse/AMBARI-18817


Repository: ambari


Description
---

As part of this work experimental flag has been added by which host checks can 
be disabled while going thorugh "Add Host Wizard"


Diffs (updated)
-

  ambari-web/app/config.js 06faf27 
  ambari-web/app/controllers/wizard/step3_controller.js 0ccf2ed 
  ambari-web/app/templates/wizard/step3.hbs f5648e1 

Diff: https://reviews.apache.org/r/53565/diff/


Testing
---

manually verified the patch on the lcuster
verified that all ambar-web unit tests passes
  29248 tests complete (30 seconds)
  154 tests pending


Thanks,

Jaimin Jetly

Re: Review Request 53565: Add ability to Skip Host check option on bootstrap page

2016-11-08 Thread Vivek Ratnavel Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53565/#review155339
---




ambari-web/app/controllers/wizard/step3_controller.js (line 228)


Variable is not used


- Vivek Ratnavel Subramanian


On Nov. 8, 2016, 3:29 a.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53565/
> ---
> 
> (Updated Nov. 8, 2016, 3:29 a.m.)
> 
> 
> Review request for Ambari, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18817
> https://issues.apache.org/jira/browse/AMBARI-18817
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of this work experimental flag has been added by which host checks 
> can be disabled while going thorugh "Add Host Wizard"
> 
> 
> Diffs
> -
> 
>   ambari-web/app/config.js 06faf27 
>   ambari-web/app/controllers/wizard/step3_controller.js 0ccf2ed 
>   ambari-web/app/templates/wizard/step3.hbs f5648e1 
> 
> Diff: https://reviews.apache.org/r/53565/diff/
> 
> 
> Testing
> ---
> 
> manually verified the patch on the lcuster
> verified that all ambar-web unit tests passes
>   29248 tests complete (30 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>