Re: Review Request 54050: AMBARI-18981 - Manage JournalNodes Wizard: Display only the steps needed for DELETE ONLY task

2016-12-05 Thread Xi Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54050/#review158099
---


Ship it!




Ship It!

- Xi Wang


On Dec. 5, 2016, 5:43 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54050/
> ---
> 
> (Updated Dec. 5, 2016, 5:43 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18981
> https://issues.apache.org/jira/browse/AMBARI-18981
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Display only the steps needed for DELETE ONLY task
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/global/update_controller.js 4631f09 
>   
> ambari-web/app/controllers/main/admin/highAvailability/journalNode/wizard_controller.js
>  2305524 
>   ambari-web/app/routes/manage_journalnode_routes.js e13a338 
>   ambari-web/app/templates/main/admin/highAvailability/journalNode/wizard.hbs 
> 844e1c8 
>   ambari-web/app/views/main/admin/highAvailability/journalNode/step2_view.js 
> 656c487 
> 
> Diff: https://reviews.apache.org/r/54050/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   25461 tests complete (23 seconds)
>   57 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>



Re: Review Request 54050: AMBARI-18981 - Manage JournalNodes Wizard: Display only the steps needed for DELETE ONLY task

2016-12-05 Thread Richard Zang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54050/
---

(Updated Dec. 6, 2016, 1:13 a.m.)


Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako.


Changes
---

update patch according to latest trunk code


Bugs: AMBARI-18981
https://issues.apache.org/jira/browse/AMBARI-18981


Repository: ambari


Description
---

Display only the steps needed for DELETE ONLY task


Diffs (updated)
-

  ambari-web/app/controllers/global/update_controller.js 4631f09 
  
ambari-web/app/controllers/main/admin/highAvailability/journalNode/wizard_controller.js
 2305524 
  ambari-web/app/routes/manage_journalnode_routes.js e13a338 
  ambari-web/app/templates/main/admin/highAvailability/journalNode/wizard.hbs 
844e1c8 
  ambari-web/app/views/main/admin/highAvailability/journalNode/step2_view.js 
656c487 

Diff: https://reviews.apache.org/r/54050/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
  25461 tests complete (23 seconds)
  57 tests pending


Thanks,

Richard Zang