Re: Review Request 55427: Sqlline-thin is unable to connect to phoenix

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55427/#review161273
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
(line 358)


Don't we need a test for this logic?


- Dmitro Lisnichenko


On Jan. 11, 2017, 5:07 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55427/
> ---
> 
> (Updated Jan. 11, 2017, 5:07 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Robert 
> Levas.
> 
> 
> Bugs: AMBARI-19466
> https://issues.apache.org/jira/browse/AMBARI-19466
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> problem with stack advisor that does not respect previously recommended 
> proxyuser values during execution.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 9b217b3 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> 6ae29cb 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> eb81655 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f244cb9 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 355e211 
> 
> Diff: https://reviews.apache.org/r/55427/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 55427: Sqlline-thin is unable to connect to phoenix

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55427/#review161248
---


Ship it!




Ship It!

- Robert Levas


On Jan. 11, 2017, 10:07 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55427/
> ---
> 
> (Updated Jan. 11, 2017, 10:07 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Robert 
> Levas.
> 
> 
> Bugs: AMBARI-19466
> https://issues.apache.org/jira/browse/AMBARI-19466
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> problem with stack advisor that does not respect previously recommended 
> proxyuser values during execution.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 9b217b3 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> 6ae29cb 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> eb81655 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f244cb9 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 355e211 
> 
> Diff: https://reviews.apache.org/r/55427/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>