Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-02-03 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review164123
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 (lines 1151 - 1154)


I know this has been submitted, but how exactly is this change affecting 
performance.  I'm betting 0%.


- Nate Cole


On Jan. 31, 2017, 7:45 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Jan. 31, 2017, 7:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  93f4a8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0fce72b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> d304bb3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  0381e38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-31 Thread Myroslav Papirkovskyy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163663
---


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Січ. 31, 2017, 2:45 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Січ. 31, 2017, 2:45 після полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  93f4a8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0fce72b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> d304bb3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  0381e38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-31 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163653
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 31, 2017, 2:45 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Jan. 31, 2017, 2:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  93f4a8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0fce72b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> d304bb3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  0381e38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-31 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/
---

(Updated Січ. 31, 2017, 12:45 після полудня)


Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid 
Wagle.


Repository: ambari


Description
---

I've deployed cluster with 3000 agents and started my little test script on it. 
Script is doing only three actions in loop: 1) Stop All services 2) Start All 
services 3) Update zk config.
After few days of work these actions need much more time to be executed. For 
example before stop/start all actions took near 7-8 minutes.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
 c53a73d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 93f4a8f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 0fce72b 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
d304bb3 
  ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 04b2104 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 0381e38 
  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
3c7b040 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 1bcffe4 

Diff: https://reviews.apache.org/r/55989/diff/


Testing
---


Thanks,

Vitalyi Brodetskyi

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-31 Thread Vitalyi Brodetskyi 


> On Січ. 31, 2017, 10:19 до полудня, Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java,
> >  line 759
> > 
> >
> > is not this issue critical - maybe rethrow exception?

There was no exception before for a long time and i'm not sure it's good idea 
to add it.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163644
---


On Січ. 30, 2017, 11:12 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Січ. 30, 2017, 11:12 після полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  93f4a8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0fce72b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> d304bb3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  0381e38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-31 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163647
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 


Please don't move imports unnecessarily.


- Attila Doroszlai


On Jan. 31, 2017, 12:12 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Jan. 31, 2017, 12:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  93f4a8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0fce72b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> d304bb3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  0381e38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-31 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163645
---


Ship it!




Ship It!

- Dmytro Sen


On Янв. 30, 2017, 11:12 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Янв. 30, 2017, 11:12 п.п.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  93f4a8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0fce72b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> d304bb3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  0381e38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-31 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163644
---




ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
(line 759)


is not this issue critical - maybe rethrow exception?


- Dmitro Lisnichenko


On Jan. 31, 2017, 1:12 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Jan. 31, 2017, 1:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  93f4a8f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0fce72b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> d304bb3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  0381e38 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-30 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/
---

(Updated Січ. 30, 2017, 11:12 після полудня)


Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid 
Wagle.


Repository: ambari


Description
---

I've deployed cluster with 3000 agents and started my little test script on it. 
Script is doing only three actions in loop: 1) Stop All services 2) Start All 
services 3) Update zk config.
After few days of work these actions need much more time to be executed. For 
example before stop/start all actions took near 7-8 minutes.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
 c53a73d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 93f4a8f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 0fce72b 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
d304bb3 
  ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 04b2104 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 0381e38 
  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
3c7b040 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 1bcffe4 

Diff: https://reviews.apache.org/r/55989/diff/


Testing
---


Thanks,

Vitalyi Brodetskyi

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-26 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163155
---


Ship it!




Nicely done!

- Alejandro Fernandez


On Jan. 26, 2017, 7:36 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Jan. 26, 2017, 7:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  8b851ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  cb4fdbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 5ce2a90 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  5dfa8ec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-26 Thread Vitalyi Brodetskyi 


> On Січ. 26, 2017, 6:11 після полудня, Alejandro Fernandez wrote:
> > What is the performance after these changes?

For newly installed cluster it gives near 1-2 seconds. "Stop all" generates 
commands for 17-18 seconds. "Start all" - 20 seconds. But for long running 
cluster which has host_role_command table for 5 GB and execution_command table 
for 2 GB it will give profit near 5 seconds. So as many commands/components, as 
much profit we will have from these changes.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163141
---


On Січ. 26, 2017, 7:29 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Січ. 26, 2017, 7:29 після полудня)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  8b851ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  cb4fdbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 5ce2a90 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  5dfa8ec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-26 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/
---

(Updated Січ. 26, 2017, 7:29 після полудня)


Review request for Ambari and Myroslav Papirkovskyy.


Repository: ambari


Description
---

I've deployed cluster with 3000 agents and started my little test script on it. 
Script is doing only three actions in loop: 1) Stop All services 2) Start All 
services 3) Update zk config.
After few days of work these actions need much more time to be executed. For 
example before stop/start all actions took near 7-8 minutes.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
 c53a73d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 8b851ac 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 cb4fdbe 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
5ce2a90 
  ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 04b2104 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 5dfa8ec 
  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
3c7b040 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 1bcffe4 

Diff: https://reviews.apache.org/r/55989/diff/


Testing
---


Thanks,

Vitalyi Brodetskyi

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-26 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163141
---



What is the performance after these changes?


ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
(line 754)


Let's put a try-catch around this and return null and log it in case of an 
error.


- Alejandro Fernandez


On Jan. 26, 2017, 5:54 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55989/
> ---
> 
> (Updated Jan. 26, 2017, 5:54 p.m.)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've deployed cluster with 3000 agents and started my little test script on 
> it. Script is doing only three actions in loop: 1) Stop All services 2) Start 
> All services 3) Update zk config.
> After few days of work these actions need much more time to be executed. For 
> example before stop/start all actions took near 7-8 minutes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  c53a73d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  8b851ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  cb4fdbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 5ce2a90 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 
> 04b2104 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 3c7b040 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  1bcffe4 
> 
> Diff: https://reviews.apache.org/r/55989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55989: Perf: start/stop all actions works much slower after few days of testing

2017-01-26 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/
---

(Updated Січ. 26, 2017, 5:54 після полудня)


Review request for Ambari and Myroslav Papirkovskyy.


Repository: ambari


Description
---

I've deployed cluster with 3000 agents and started my little test script on it. 
Script is doing only three actions in loop: 1) Stop All services 2) Start All 
services 3) Update zk config.
After few days of work these actions need much more time to be executed. For 
example before stop/start all actions took near 7-8 minutes.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
 c53a73d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 8b851ac 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 cb4fdbe 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
5ce2a90 
  ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 04b2104 
  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
3c7b040 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 1bcffe4 

Diff: https://reviews.apache.org/r/55989/diff/


Testing
---


Thanks,

Vitalyi Brodetskyi