Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-27 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/#review163246
---


Ship it!




Ship It!

- Robert Levas


On Jan. 27, 2017, 6:25 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56013/
> ---
> 
> (Updated Jan. 27, 2017, 6:25 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-19741
> https://issues.apache.org/jira/browse/AMBARI-19741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fixing filed tests
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
>  e756491 
> 
> Diff: https://reviews.apache.org/r/56013/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-27 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/#review163248
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 27, 2017, 1:25 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56013/
> ---
> 
> (Updated Jan. 27, 2017, 1:25 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-19741
> https://issues.apache.org/jira/browse/AMBARI-19741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fixing filed tests
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
>  e756491 
> 
> Diff: https://reviews.apache.org/r/56013/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-30 Thread Eugene Chekanskiy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/
---

(Updated Jan. 30, 2017, 10:30 a.m.)


Review request for Ambari, Dmitro Lisnichenko and Robert Levas.


Changes
---

fixed java 7 capture issue.


Bugs: AMBARI-19741
https://issues.apache.org/jira/browse/AMBARI-19741


Repository: ambari


Description
---

fixing filed tests


Diffs (updated)
-

  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
 e756491 

Diff: https://reviews.apache.org/r/56013/diff/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-30 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/#review163492
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 30, 2017, 12:30 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56013/
> ---
> 
> (Updated Jan. 30, 2017, 12:30 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-19741
> https://issues.apache.org/jira/browse/AMBARI-19741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fixing filed tests
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
>  e756491 
> 
> Diff: https://reviews.apache.org/r/56013/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-30 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/#review163493
---


Fix it, then Ship it!





ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
 


Please make sure tests pass on `trunk`, too, not only on `branch-2.5`.

```
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server 
---
[INFO] Starting audit...
[ERROR] 
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java:47:
 'com.google.inject.AbstractModule' should be separated from previous imports. 
[ImportOrder]
Audit done.
```


- Attila Doroszlai


On Jan. 30, 2017, 11:30 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56013/
> ---
> 
> (Updated Jan. 30, 2017, 11:30 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-19741
> https://issues.apache.org/jira/browse/AMBARI-19741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fixing filed tests
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
>  e756491 
> 
> Diff: https://reviews.apache.org/r/56013/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-30 Thread Eugene Chekanskiy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/
---

(Updated Jan. 30, 2017, 1:10 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Robert Levas.


Changes
---

fixed imports


Bugs: AMBARI-19741
https://issues.apache.org/jira/browse/AMBARI-19741


Repository: ambari


Description
---

fixing filed tests


Diffs (updated)
-

  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
 e756491 

Diff: https://reviews.apache.org/r/56013/diff/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-30 Thread Eugene Chekanskiy 


> On Jan. 30, 2017, 11:29 a.m., Attila Doroszlai wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java,
> >  line 47
> > 
> >
> > Please make sure tests pass on `trunk`, too, not only on `branch-2.5`.
> > 
> > ```
> > [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ 
> > ambari-server ---
> > [INFO] Starting audit...
> > [ERROR] 
> > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java:47:
> >  'com.google.inject.AbstractModule' should be separated from previous 
> > imports. [ImportOrder]
> > Audit done.
> > ```

thanks, fixed


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/#review163493
---


On Jan. 30, 2017, 1:10 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56013/
> ---
> 
> (Updated Jan. 30, 2017, 1:10 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-19741
> https://issues.apache.org/jira/browse/AMBARI-19741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fixing filed tests
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
>  e756491 
> 
> Diff: https://reviews.apache.org/r/56013/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-30 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/#review163508
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Jan. 30, 2017, 3:10 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56013/
> ---
> 
> (Updated Jan. 30, 2017, 3:10 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-19741
> https://issues.apache.org/jira/browse/AMBARI-19741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fixing filed tests
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
>  e756491 
> 
> Diff: https://reviews.apache.org/r/56013/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 56013: Ambari Server Unit Test failure on branch-2.5/trunk for testUpdateConfigForceSecurityEnabled

2017-01-30 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/#review163520
---


Ship it!




Ship It!

- Robert Levas


On Jan. 30, 2017, 8:10 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56013/
> ---
> 
> (Updated Jan. 30, 2017, 8:10 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
> 
> 
> Bugs: AMBARI-19741
> https://issues.apache.org/jira/browse/AMBARI-19741
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fixing filed tests
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java
>  e756491 
> 
> Diff: https://reviews.apache.org/r/56013/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>