Re: Review Request 56870: HiveView2.0: Add new UDF is not working

2017-02-21 Thread Nitiraj Rathore

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56870/#review166158
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 21, 2017, 11:27 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56870/
> ---
> 
> (Updated Feb. 21, 2017, 11:27 a.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20089
> https://issues.apache.org/jira/browse/AMBARI-20089
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change the data call to store.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/udfs/new.js cdccbb3 
> 
> Diff: https://reviews.apache.org/r/56870/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 56870: HiveView2.0: Add new UDF is not working

2017-02-21 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56870/#review166150
---


Ship it!




Ship It!

- venkat sairam


On Feb. 21, 2017, 11:27 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56870/
> ---
> 
> (Updated Feb. 21, 2017, 11:27 a.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20089
> https://issues.apache.org/jira/browse/AMBARI-20089
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change the data call to store.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/udfs/new.js cdccbb3 
> 
> Diff: https://reviews.apache.org/r/56870/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 56870: HiveView2.0: Add new UDF is not working

2017-02-21 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56870/#review166141
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 21, 2017, 9:49 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56870/
> ---
> 
> (Updated Feb. 21, 2017, 9:49 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20089
> https://issues.apache.org/jira/browse/AMBARI-20089
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change the data call to store.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/udfs/new.js cdccbb3 
> 
> Diff: https://reviews.apache.org/r/56870/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>