Re: Review Request 59427: AMBARI-21082 - Ambari 3.0: Outstanding wizard issues

2017-05-22 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59427/#review175744
---


Ship it!




Ship It!

- Jaimin Jetly


On May 23, 2017, 1:49 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59427/
> ---
> 
> (Updated May 23, 2017, 1:49 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21082
> https://issues.apache.org/jira/browse/AMBARI-21082
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix step indicator
> Fix service selection click
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less 2fc1cf2 
>   ambari-web/app/templates/wizard/step4.hbs 9f1d7df 
>   ambari-web/app/views/wizard/step4_view.js 137b9f5 
> 
> 
> Diff: https://reviews.apache.org/r/59427/diff/3/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster, all unit tests passed.
>   20699 passing (22s)
>   128 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 59427: AMBARI-21082 - Ambari 3.0: Outstanding wizard issues

2017-05-22 Thread Richard Zang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59427/
---

(Updated May 23, 2017, 1:49 a.m.)


Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Changes
---

update {{{}}} wrap to show links correctly


Bugs: AMBARI-21082
https://issues.apache.org/jira/browse/AMBARI-21082


Repository: ambari


Description
---

Fix step indicator
Fix service selection click


Diffs (updated)
-

  ambari-web/app/styles/application.less 2fc1cf2 
  ambari-web/app/templates/wizard/step4.hbs 9f1d7df 
  ambari-web/app/views/wizard/step4_view.js 137b9f5 


Diff: https://reviews.apache.org/r/59427/diff/3/

Changes: https://reviews.apache.org/r/59427/diff/2-3/


Testing
---

Manually tested on live cluster, all unit tests passed.
  20699 passing (22s)
  128 pending


Thanks,

Richard Zang

Re: Review Request 59427: AMBARI-21082 - Ambari 3.0: Outstanding wizard issues

2017-05-22 Thread Richard Zang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59427/
---

(Updated May 22, 2017, 8:46 p.m.)


Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Changes
---

Pixel adjustment


Bugs: AMBARI-21082
https://issues.apache.org/jira/browse/AMBARI-21082


Repository: ambari


Description
---

Fix step indicator
Fix service selection click


Diffs (updated)
-

  ambari-web/app/styles/application.less 2fc1cf2 
  ambari-web/app/templates/wizard/step4.hbs 9f1d7df 
  ambari-web/app/views/wizard/step4_view.js 137b9f5 


Diff: https://reviews.apache.org/r/59427/diff/2/

Changes: https://reviews.apache.org/r/59427/diff/1-2/


Testing
---

Manually tested on live cluster, all unit tests passed.
  20699 passing (22s)
  128 pending


Thanks,

Richard Zang