Re: Review Request 59639: Blueprint export should allow tokenized values in SingleHostUpdater

2017-06-08 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59639/#review177337
---



Pushed to trunk, commit b98f07f9093a0b9635443f317e96768b2d8b8ef7

- Alejandro Fernandez


On June 5, 2017, 5:42 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59639/
> ---
> 
> (Updated June 5, 2017, 5:42 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Di Li, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-21137
> https://issues.apache.org/jira/browse/AMBARI-21137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During upgrade Biginsights stack tokenizes value for 
> 'yarn.resourcemanager.webapp.https.address', therefore this property gets 
> removed by SingleHostUpdater during blueprint export. Next time when the 
> blueprint is used to create a cluster, this property is assigned default 
> value 'localhost' and  exception is thrown.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  508bf1552d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  24fc3c7435 
> 
> 
> Diff: https://reviews.apache.org/r/59639/diff/2/
> 
> 
> Testing
> ---
> 
> Updated test cases to address the scenario.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59639: Blueprint export should allow tokenized values in SingleHostUpdater

2017-06-05 Thread Amruta Borkar 


> On June 5, 2017, 5:34 p.m., Alejandro Fernandez wrote:
> > Ship It!

Thank you Alejandro, could you please help push this to trunk?


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59639/#review176927
---


On June 1, 2017, 9:58 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59639/
> ---
> 
> (Updated June 1, 2017, 9:58 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21137
> https://issues.apache.org/jira/browse/AMBARI-21137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During upgrade Biginsights stack tokenizes value for 
> 'yarn.resourcemanager.webapp.https.address', therefore this property gets 
> removed by SingleHostUpdater during blueprint export. Next time when the 
> blueprint is used to create a cluster, this property is assigned default 
> value 'localhost' and  exception is thrown.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  508bf1552d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  24fc3c7435 
> 
> 
> Diff: https://reviews.apache.org/r/59639/diff/2/
> 
> 
> Testing
> ---
> 
> Updated test cases to address the scenario.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59639: Blueprint export should allow tokenized values in SingleHostUpdater

2017-06-05 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59639/#review176927
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 1, 2017, 9:58 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59639/
> ---
> 
> (Updated June 1, 2017, 9:58 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21137
> https://issues.apache.org/jira/browse/AMBARI-21137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During upgrade Biginsights stack tokenizes value for 
> 'yarn.resourcemanager.webapp.https.address', therefore this property gets 
> removed by SingleHostUpdater during blueprint export. Next time when the 
> blueprint is used to create a cluster, this property is assigned default 
> value 'localhost' and  exception is thrown.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  508bf1552d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  24fc3c7435 
> 
> 
> Diff: https://reviews.apache.org/r/59639/diff/2/
> 
> 
> Testing
> ---
> 
> Updated test cases to address the scenario.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59639: Blueprint export should allow tokenized values in SingleHostUpdater

2017-06-05 Thread Di Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59639/#review176917
---


Ship it!




Ship It!

- Di Li


On June 1, 2017, 9:58 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59639/
> ---
> 
> (Updated June 1, 2017, 9:58 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21137
> https://issues.apache.org/jira/browse/AMBARI-21137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During upgrade Biginsights stack tokenizes value for 
> 'yarn.resourcemanager.webapp.https.address', therefore this property gets 
> removed by SingleHostUpdater during blueprint export. Next time when the 
> blueprint is used to create a cluster, this property is assigned default 
> value 'localhost' and  exception is thrown.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  508bf1552d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  24fc3c7435 
> 
> 
> Diff: https://reviews.apache.org/r/59639/diff/2/
> 
> 
> Testing
> ---
> 
> Updated test cases to address the scenario.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59639: Blueprint export should allow tokenized values in SingleHostUpdater

2017-06-01 Thread Amruta Borkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59639/
---

(Updated June 1, 2017, 7:56 p.m.)


Review request for Ambari, Di Li and Robert Nettleton.


Bugs: AMBARI-21137
https://issues.apache.org/jira/browse/AMBARI-21137


Repository: ambari


Description
---

During upgrade Biginsights stack tokenizes value for 
'yarn.resourcemanager.webapp.https.address', therefore this property gets 
removed by SingleHostUpdater during blueprint export. Next time when the 
blueprint is used to create a cluster, this property is assigned default value 
'localhost' and  exception is thrown.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 508bf1552d 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 24fc3c7435 


Diff: https://reviews.apache.org/r/59639/diff/2/

Changes: https://reviews.apache.org/r/59639/diff/1-2/


Testing
---

Updated test cases to address the scenario.


Thanks,

Amruta Borkar

Re: Review Request 59639: Blueprint export should allow tokenized values in SingleHostUpdater

2017-05-31 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59639/#review176425
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Lines 1153 (patched)


I think the method should be named `isPlaceholder`, since the pattern has 
nothing to do with addresses.  It may be reused for other properties.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Lines 1154 (patched)


`PLACEHOLDER` should be a `static final` member, not a local variable, 
since the pattern does not change.



ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
Lines 453 (patched)


`assertTrue(... != null)` can be simplified as `assertNotNull(...)`


- Attila Doroszlai


On May 30, 2017, 9:44 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59639/
> ---
> 
> (Updated May 30, 2017, 9:44 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21137
> https://issues.apache.org/jira/browse/AMBARI-21137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During upgrade Biginsights stack tokenizes value for 
> 'yarn.resourcemanager.webapp.https.address', therefore this property gets 
> removed by SingleHostUpdater during blueprint export. Next time when the 
> blueprint is used to create a cluster, this property is assigned default 
> value 'localhost' and  exception is thrown.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  508bf1552d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  24fc3c7435 
> 
> 
> Diff: https://reviews.apache.org/r/59639/diff/1/
> 
> 
> Testing
> ---
> 
> Updated test cases to address the scenario.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>