Re: Review Request 60117: Add ambari prefix for utility and serviceadvisor modules

2017-06-15 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60117/#review178056
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 15, 2017, 1:52 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60117/
> ---
> 
> (Updated June 15, 2017, 1:52 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jonathan 
> Hurley, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21257
> https://issues.apache.org/jira/browse/AMBARI-21257
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - use org.apache.ambari groups (makes sense to use the same group with ambari 
> modules)
> - in this apache project, the convention is to use ambari prefix for ambari 
> modules (can be without it as well, see e.g.: apache spark), to not mix both 
> method, add ambari prefix to utility and serviceadvisor modules
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml 7690fcf 
>   ambari-infra/pom.xml a5a5b38 
>   ambari-logsearch/pom.xml 6f78abe 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 3419f16 
>   ambari-metrics/pom.xml 02f9574 
>   ambari-project/pom.xml b06bd18 
>   ambari-server/pom.xml ca3b2da 
>   pom.xml 4e27ca6 
>   serviceadvisor/pom.xml ecf6d8b 
>   
> serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisor.java
>   
>   
> serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisorCommandType.java
>   
>   utility/checkstyle.xml  
>   utility/pom.xml ac91474 
>   utility/src/main/java/category/AlertTest.java  
>   utility/src/main/java/category/AmbariUpgradeTest.java  
>   utility/src/main/java/category/BlueprintTest.java  
>   utility/src/main/java/category/FastTest.java  
>   utility/src/main/java/category/KerberosTest.java  
>   utility/src/main/java/category/MetricsTest.java  
>   utility/src/main/java/category/SlowTest.java  
>   utility/src/main/java/category/StackUpgradeTest.java  
>   utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java  
>   
> utility/src/main/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheck.java
>   
>   
> utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
>   
>   utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java  
>   utility/src/main/resources/checkstyle_packages.xml  
>   
> utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java
>   
>   
> utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
>   
>   
> utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java  
>   utility/src/test/resources/log4j.properties  
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
>   
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputTransactionalOnPrivateMethods.java
>   
> 
> 
> Diff: https://reviews.apache.org/r/60117/diff/2/
> 
> 
> Testing
> ---
> 
> done. modules could find each other
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60117: Add ambari prefix for utility and serviceadvisor modules

2017-06-15 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60117/#review178004
---


Ship it!




Ship It!

- Attila Doroszlai


On June 15, 2017, 3:52 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60117/
> ---
> 
> (Updated June 15, 2017, 3:52 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jonathan 
> Hurley, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21257
> https://issues.apache.org/jira/browse/AMBARI-21257
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - use org.apache.ambari groups (makes sense to use the same group with ambari 
> modules)
> - in this apache project, the convention is to use ambari prefix for ambari 
> modules (can be without it as well, see e.g.: apache spark), to not mix both 
> method, add ambari prefix to utility and serviceadvisor modules
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml 7690fcf 
>   ambari-infra/pom.xml a5a5b38 
>   ambari-logsearch/pom.xml 6f78abe 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 3419f16 
>   ambari-metrics/pom.xml 02f9574 
>   ambari-project/pom.xml b06bd18 
>   ambari-server/pom.xml ca3b2da 
>   pom.xml 4e27ca6 
>   serviceadvisor/pom.xml ecf6d8b 
>   
> serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisor.java
>   
>   
> serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisorCommandType.java
>   
>   utility/checkstyle.xml  
>   utility/pom.xml ac91474 
>   utility/src/main/java/category/AlertTest.java  
>   utility/src/main/java/category/AmbariUpgradeTest.java  
>   utility/src/main/java/category/BlueprintTest.java  
>   utility/src/main/java/category/FastTest.java  
>   utility/src/main/java/category/KerberosTest.java  
>   utility/src/main/java/category/MetricsTest.java  
>   utility/src/main/java/category/SlowTest.java  
>   utility/src/main/java/category/StackUpgradeTest.java  
>   utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java  
>   
> utility/src/main/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheck.java
>   
>   
> utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
>   
>   utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java  
>   utility/src/main/resources/checkstyle_packages.xml  
>   
> utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java
>   
>   
> utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
>   
>   
> utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java  
>   utility/src/test/resources/log4j.properties  
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
>   
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputTransactionalOnPrivateMethods.java
>   
> 
> 
> Diff: https://reviews.apache.org/r/60117/diff/2/
> 
> 
> Testing
> ---
> 
> done. modules could find each other
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60117: Add ambari prefix for utility and serviceadvisor modules

2017-06-15 Thread Oliver Szabo 


> On June 15, 2017, 1:42 p.m., Attila Doroszlai wrote:
> > ambari-server/pom.xml
> > Line 1683 (original), 1683 (patched)
> > 
> >
> > There are some files left over in `utility`, which causes build error:
> > 
> > ```
> > utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java
> > 
> > utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java
> > utility/src/test/resources/log4j.properties
> > ```
> > 
> > ```
> > [ERROR] Failed to execute goal 
> > com.github.kongchen:swagger-maven-plugin:3.1.4:generate (default) on 
> > project ambari-server: Cannot load Swagger API reader: 
> > org.apache.ambari.swagger.AmbariSwaggerReader -> [Help 1]
> > ```

thanks i guess that happened because i needed to rebase (those renames was not 
in my change)


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60117/#review178002
---


On June 15, 2017, 1:52 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60117/
> ---
> 
> (Updated June 15, 2017, 1:52 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jonathan 
> Hurley, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21257
> https://issues.apache.org/jira/browse/AMBARI-21257
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - use org.apache.ambari groups (makes sense to use the same group with ambari 
> modules)
> - in this apache project, the convention is to use ambari prefix for ambari 
> modules (can be without it as well, see e.g.: apache spark), to not mix both 
> method, add ambari prefix to utility and serviceadvisor modules
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml 7690fcf 
>   ambari-infra/pom.xml a5a5b38 
>   ambari-logsearch/pom.xml 6f78abe 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 3419f16 
>   ambari-metrics/pom.xml 02f9574 
>   ambari-project/pom.xml b06bd18 
>   ambari-server/pom.xml ca3b2da 
>   pom.xml 4e27ca6 
>   serviceadvisor/pom.xml ecf6d8b 
>   
> serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisor.java
>   
>   
> serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisorCommandType.java
>   
>   utility/checkstyle.xml  
>   utility/pom.xml ac91474 
>   utility/src/main/java/category/AlertTest.java  
>   utility/src/main/java/category/AmbariUpgradeTest.java  
>   utility/src/main/java/category/BlueprintTest.java  
>   utility/src/main/java/category/FastTest.java  
>   utility/src/main/java/category/KerberosTest.java  
>   utility/src/main/java/category/MetricsTest.java  
>   utility/src/main/java/category/SlowTest.java  
>   utility/src/main/java/category/StackUpgradeTest.java  
>   utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java  
>   
> utility/src/main/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheck.java
>   
>   
> utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
>   
>   utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java  
>   utility/src/main/resources/checkstyle_packages.xml  
>   
> utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java
>   
>   
> utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
>   
>   
> utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java  
>   utility/src/test/resources/log4j.properties  
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
>   
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputTransactionalOnPrivateMethods.java
>   
> 
> 
> Diff: https://reviews.apache.org/r/60117/diff/2/
> 
> 
> Testing
> ---
> 
> done. modules could find each other
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60117: Add ambari prefix for utility and serviceadvisor modules

2017-06-15 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60117/
---

(Updated June 15, 2017, 1:52 p.m.)


Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jonathan 
Hurley, Robert Levas, and Sebastian Toader.


Changes
---

rebase patch -> move new files


Bugs: AMBARI-21257
https://issues.apache.org/jira/browse/AMBARI-21257


Repository: ambari


Description
---

- use org.apache.ambari groups (makes sense to use the same group with ambari 
modules)
- in this apache project, the convention is to use ambari prefix for ambari 
modules (can be without it as well, see e.g.: apache spark), to not mix both 
method, add ambari prefix to utility and serviceadvisor modules


Diffs (updated)
-

  ambari-agent/pom.xml 7690fcf 
  ambari-infra/pom.xml a5a5b38 
  ambari-logsearch/pom.xml 6f78abe 
  ambari-metrics/ambari-metrics-timelineservice/pom.xml 3419f16 
  ambari-metrics/pom.xml 02f9574 
  ambari-project/pom.xml b06bd18 
  ambari-server/pom.xml ca3b2da 
  pom.xml 4e27ca6 
  serviceadvisor/pom.xml ecf6d8b 
  
serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisor.java
  
  
serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisorCommandType.java
  
  utility/checkstyle.xml  
  utility/pom.xml ac91474 
  utility/src/main/java/category/AlertTest.java  
  utility/src/main/java/category/AmbariUpgradeTest.java  
  utility/src/main/java/category/BlueprintTest.java  
  utility/src/main/java/category/FastTest.java  
  utility/src/main/java/category/KerberosTest.java  
  utility/src/main/java/category/MetricsTest.java  
  utility/src/main/java/category/SlowTest.java  
  utility/src/main/java/category/StackUpgradeTest.java  
  utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java  
  
utility/src/main/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheck.java
  
  
utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
  
  utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java  
  utility/src/main/resources/checkstyle_packages.xml  
  
utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java
  
  
utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
  
  utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java  
  utility/src/test/resources/log4j.properties  
  
utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
  
  
utility/src/test/resources/org/apache/ambari/checkstyle/InputTransactionalOnPrivateMethods.java
  


Diff: https://reviews.apache.org/r/60117/diff/2/

Changes: https://reviews.apache.org/r/60117/diff/1-2/


Testing
---

done. modules could find each other


Thanks,

Oliver Szabo

Re: Review Request 60117: Add ambari prefix for utility and serviceadvisor modules

2017-06-15 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60117/#review178002
---




ambari-server/pom.xml
Line 1683 (original), 1683 (patched)


There are some files left over in `utility`, which causes build error:

```
utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java
utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java
utility/src/test/resources/log4j.properties
```

```
[ERROR] Failed to execute goal 
com.github.kongchen:swagger-maven-plugin:3.1.4:generate (default) on project 
ambari-server: Cannot load Swagger API reader: 
org.apache.ambari.swagger.AmbariSwaggerReader -> [Help 1]
```


- Attila Doroszlai


On June 15, 2017, 1:53 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60117/
> ---
> 
> (Updated June 15, 2017, 1:53 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jonathan 
> Hurley, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21257
> https://issues.apache.org/jira/browse/AMBARI-21257
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - use org.apache.ambari groups (makes sense to use the same group with ambari 
> modules)
> - in this apache project, the convention is to use ambari prefix for ambari 
> modules (can be without it as well, see e.g.: apache spark), to not mix both 
> method, add ambari prefix to utility and serviceadvisor modules
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml c1cb056 
>   ambari-infra/pom.xml a5a5b38 
>   ambari-logsearch/pom.xml 6f78abe 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 3419f16 
>   ambari-metrics/pom.xml 02f9574 
>   ambari-project/pom.xml 9bb2e26 
>   ambari-server/pom.xml a1cd239 
>   pom.xml 4e27ca6 
>   serviceadvisor/pom.xml ecf6d8b 
>   
> serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisor.java
>   
>   
> serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisorCommandType.java
>   
>   utility/checkstyle.xml  
>   utility/pom.xml 918080e 
>   utility/src/main/java/category/AlertTest.java  
>   utility/src/main/java/category/AmbariUpgradeTest.java  
>   utility/src/main/java/category/BlueprintTest.java  
>   utility/src/main/java/category/FastTest.java  
>   utility/src/main/java/category/KerberosTest.java  
>   utility/src/main/java/category/MetricsTest.java  
>   utility/src/main/java/category/SlowTest.java  
>   utility/src/main/java/category/StackUpgradeTest.java  
>   utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java  
>   
> utility/src/main/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheck.java
>   
>   
> utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
>   
>   utility/src/main/resources/checkstyle_packages.xml  
>   
> utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java
>   
>   
> utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
>   
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
>   
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputTransactionalOnPrivateMethods.java
>   
> 
> 
> Diff: https://reviews.apache.org/r/60117/diff/1/
> 
> 
> Testing
> ---
> 
> done. modules could find each other
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60117: Add ambari prefix for utility and serviceadvisor modules

2017-06-15 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60117/#review178001
---


Ship it!




Ship It!

- Sebastian Toader


On June 15, 2017, 1:53 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60117/
> ---
> 
> (Updated June 15, 2017, 1:53 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jonathan 
> Hurley, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21257
> https://issues.apache.org/jira/browse/AMBARI-21257
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - use org.apache.ambari groups (makes sense to use the same group with ambari 
> modules)
> - in this apache project, the convention is to use ambari prefix for ambari 
> modules (can be without it as well, see e.g.: apache spark), to not mix both 
> method, add ambari prefix to utility and serviceadvisor modules
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml c1cb056 
>   ambari-infra/pom.xml a5a5b38 
>   ambari-logsearch/pom.xml 6f78abe 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 3419f16 
>   ambari-metrics/pom.xml 02f9574 
>   ambari-project/pom.xml 9bb2e26 
>   ambari-server/pom.xml a1cd239 
>   pom.xml 4e27ca6 
>   serviceadvisor/pom.xml ecf6d8b 
>   
> serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisor.java
>   
>   
> serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisorCommandType.java
>   
>   utility/checkstyle.xml  
>   utility/pom.xml 918080e 
>   utility/src/main/java/category/AlertTest.java  
>   utility/src/main/java/category/AmbariUpgradeTest.java  
>   utility/src/main/java/category/BlueprintTest.java  
>   utility/src/main/java/category/FastTest.java  
>   utility/src/main/java/category/KerberosTest.java  
>   utility/src/main/java/category/MetricsTest.java  
>   utility/src/main/java/category/SlowTest.java  
>   utility/src/main/java/category/StackUpgradeTest.java  
>   utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java  
>   
> utility/src/main/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheck.java
>   
>   
> utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
>   
>   utility/src/main/resources/checkstyle_packages.xml  
>   
> utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java
>   
>   
> utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
>   
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
>   
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputTransactionalOnPrivateMethods.java
>   
> 
> 
> Diff: https://reviews.apache.org/r/60117/diff/1/
> 
> 
> Testing
> ---
> 
> done. modules could find each other
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60117: Add ambari prefix for utility and serviceadvisor modules

2017-06-15 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60117/#review177999
---


Ship it!




Ship It!

- Jonathan Hurley


On June 15, 2017, 7:53 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60117/
> ---
> 
> (Updated June 15, 2017, 7:53 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jonathan 
> Hurley, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21257
> https://issues.apache.org/jira/browse/AMBARI-21257
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - use org.apache.ambari groups (makes sense to use the same group with ambari 
> modules)
> - in this apache project, the convention is to use ambari prefix for ambari 
> modules (can be without it as well, see e.g.: apache spark), to not mix both 
> method, add ambari prefix to utility and serviceadvisor modules
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml c1cb056 
>   ambari-infra/pom.xml a5a5b38 
>   ambari-logsearch/pom.xml 6f78abe 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 3419f16 
>   ambari-metrics/pom.xml 02f9574 
>   ambari-project/pom.xml 9bb2e26 
>   ambari-server/pom.xml a1cd239 
>   pom.xml 4e27ca6 
>   serviceadvisor/pom.xml ecf6d8b 
>   
> serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisor.java
>   
>   
> serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisorCommandType.java
>   
>   utility/checkstyle.xml  
>   utility/pom.xml 918080e 
>   utility/src/main/java/category/AlertTest.java  
>   utility/src/main/java/category/AmbariUpgradeTest.java  
>   utility/src/main/java/category/BlueprintTest.java  
>   utility/src/main/java/category/FastTest.java  
>   utility/src/main/java/category/KerberosTest.java  
>   utility/src/main/java/category/MetricsTest.java  
>   utility/src/main/java/category/SlowTest.java  
>   utility/src/main/java/category/StackUpgradeTest.java  
>   utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java  
>   
> utility/src/main/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheck.java
>   
>   
> utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
>   
>   utility/src/main/resources/checkstyle_packages.xml  
>   
> utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java
>   
>   
> utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
>   
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
>   
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputTransactionalOnPrivateMethods.java
>   
> 
> 
> Diff: https://reviews.apache.org/r/60117/diff/1/
> 
> 
> Testing
> ---
> 
> done. modules could find each other
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60117: Add ambari prefix for utility and serviceadvisor modules

2017-06-15 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60117/#review177998
---


Ship it!




Ship It!

- Robert Levas


On June 15, 2017, 7:53 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60117/
> ---
> 
> (Updated June 15, 2017, 7:53 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jonathan 
> Hurley, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21257
> https://issues.apache.org/jira/browse/AMBARI-21257
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - use org.apache.ambari groups (makes sense to use the same group with ambari 
> modules)
> - in this apache project, the convention is to use ambari prefix for ambari 
> modules (can be without it as well, see e.g.: apache spark), to not mix both 
> method, add ambari prefix to utility and serviceadvisor modules
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml c1cb056 
>   ambari-infra/pom.xml a5a5b38 
>   ambari-logsearch/pom.xml 6f78abe 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 3419f16 
>   ambari-metrics/pom.xml 02f9574 
>   ambari-project/pom.xml 9bb2e26 
>   ambari-server/pom.xml a1cd239 
>   pom.xml 4e27ca6 
>   serviceadvisor/pom.xml ecf6d8b 
>   
> serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisor.java
>   
>   
> serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisorCommandType.java
>   
>   utility/checkstyle.xml  
>   utility/pom.xml 918080e 
>   utility/src/main/java/category/AlertTest.java  
>   utility/src/main/java/category/AmbariUpgradeTest.java  
>   utility/src/main/java/category/BlueprintTest.java  
>   utility/src/main/java/category/FastTest.java  
>   utility/src/main/java/category/KerberosTest.java  
>   utility/src/main/java/category/MetricsTest.java  
>   utility/src/main/java/category/SlowTest.java  
>   utility/src/main/java/category/StackUpgradeTest.java  
>   utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java  
>   
> utility/src/main/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheck.java
>   
>   
> utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java
>   
>   utility/src/main/resources/checkstyle_packages.xml  
>   
> utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java
>   
>   
> utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java
>   
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java
>   
>   
> utility/src/test/resources/org/apache/ambari/checkstyle/InputTransactionalOnPrivateMethods.java
>   
> 
> 
> Diff: https://reviews.apache.org/r/60117/diff/1/
> 
> 
> Testing
> ---
> 
> done. modules could find each other
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>