Re: Review Request 60702: Apply ZEPPELIN-2698 related changes in Ambari

2017-07-12 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60702/#review180285
---


Ship it!




Ship It!

- Gaurav Nagar


On July 7, 2017, 6:52 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60702/
> ---
> 
> (Updated July 7, 2017, 6:52 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21426
> https://issues.apache.org/jira/browse/AMBARI-21426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the merge of ZEPPELIN-2698, LAUNCH_KERBEROS_REFRESH_INTERVAL is renamed 
> to KERBEROS_REFRESH_INTERVAL.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  4032b2c45d 
> 
> 
> Diff: https://reviews.apache.org/r/60702/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on centOS 6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60702: Apply ZEPPELIN-2698 related changes in Ambari

2017-07-08 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60702/#review179981
---


Ship it!




Ship It!

- venkat sairam


On July 7, 2017, 6:52 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60702/
> ---
> 
> (Updated July 7, 2017, 6:52 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21426
> https://issues.apache.org/jira/browse/AMBARI-21426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the merge of ZEPPELIN-2698, LAUNCH_KERBEROS_REFRESH_INTERVAL is renamed 
> to KERBEROS_REFRESH_INTERVAL.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  4032b2c45d 
> 
> 
> Diff: https://reviews.apache.org/r/60702/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on centOS 6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60702: Apply ZEPPELIN-2698 related changes in Ambari

2017-07-07 Thread Prabhjyot Singh


> On July 7, 2017, 10:52 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
> > Line 98 (original), 98 (patched)
> > 
> >
> > How will this impact existing installs?

Installation will happen without any problem, it's just that this variable is 
renamed (Ref: 
https://github.com/apache/zeppelin/blob/master/conf/zeppelin-env.sh.template#L59),
 and when user wants to use this feature it may cause confusion.


- Prabhjyot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60702/#review179891
---


On July 7, 2017, 12:22 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60702/
> ---
> 
> (Updated July 7, 2017, 12:22 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21426
> https://issues.apache.org/jira/browse/AMBARI-21426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the merge of ZEPPELIN-2698, LAUNCH_KERBEROS_REFRESH_INTERVAL is renamed 
> to KERBEROS_REFRESH_INTERVAL.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  4032b2c45d 
> 
> 
> Diff: https://reviews.apache.org/r/60702/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on centOS 6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60702: Apply ZEPPELIN-2698 related changes in Ambari

2017-07-07 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60702/#review179891
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
Line 98 (original), 98 (patched)


How will this impact existing installs?


- Alejandro Fernandez


On July 7, 2017, 6:52 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60702/
> ---
> 
> (Updated July 7, 2017, 6:52 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21426
> https://issues.apache.org/jira/browse/AMBARI-21426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the merge of ZEPPELIN-2698, LAUNCH_KERBEROS_REFRESH_INTERVAL is renamed 
> to KERBEROS_REFRESH_INTERVAL.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  4032b2c45d 
> 
> 
> Diff: https://reviews.apache.org/r/60702/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on centOS 6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60702: Apply ZEPPELIN-2698 related changes in Ambari

2017-07-07 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60702/#review179855
---



Where is the value exported used in the application?

- venkat sairam


On July 7, 2017, 6:52 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60702/
> ---
> 
> (Updated July 7, 2017, 6:52 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21426
> https://issues.apache.org/jira/browse/AMBARI-21426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the merge of ZEPPELIN-2698, LAUNCH_KERBEROS_REFRESH_INTERVAL is renamed 
> to KERBEROS_REFRESH_INTERVAL.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  4032b2c45d 
> 
> 
> Diff: https://reviews.apache.org/r/60702/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on centOS 6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>