Re: Review Request 42155: AMBARI-14605 '[RAM_DISK]' configured in dfs.datanode.data.dir fails to validate

2016-05-03 Thread yao lei


> On 五月 4, 2016, 4:14 a.m., Matt wrote:
> > You may close this review as it has been submitted already.

ok,thanks,Matt


- yao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42155/#review131621
---


On 五月 3, 2016, 4:57 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42155/
> ---
> 
> (Updated 五月 3, 2016, 4:57 a.m.)
> 
> 
> Review request for Ambari and Matt.
> 
> 
> Bugs: AMBARI-14605
> https://issues.apache.org/jira/browse/AMBARI-14605
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDFS now support four kinds of heterogeneous storage types: ARCHIVE, DISK, 
> SSD and RAM_DISK.
> If we configure dfs.datanode.data.dir as [RAM_DISK]/anydir,it fails to 
> validate.
> please see 
> https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/ArchivalStorage.html#Configuration
> A
> 
> 
> Diffs
> -
> 
>   ambari-web/app/utils/validator.js 9d11746 
>   ambari-web/test/utils/validator_test.js ef90561 
> 
> Diff: https://reviews.apache.org/r/42155/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> But Ambari Web Unit Test fails in trunk for other reasons described in 
> https://builds.apache.org/job/Ambari-trunk-test-patch/4848//artifact/patch-work/testrun_ambari-web.txt
> 
> 
> Thanks,
> 
> yao lei
> 
>



Re: Review Request 42155: AMBARI-14605 '[RAM_DISK]' configured in dfs.datanode.data.dir fails to validate

2016-05-03 Thread Matt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42155/#review131621
---



You may close this review as it has been submitted already.

- Matt


On May 2, 2016, 9:57 p.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42155/
> ---
> 
> (Updated May 2, 2016, 9:57 p.m.)
> 
> 
> Review request for Ambari and Matt.
> 
> 
> Bugs: AMBARI-14605
> https://issues.apache.org/jira/browse/AMBARI-14605
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDFS now support four kinds of heterogeneous storage types: ARCHIVE, DISK, 
> SSD and RAM_DISK.
> If we configure dfs.datanode.data.dir as [RAM_DISK]/anydir,it fails to 
> validate.
> please see 
> https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/ArchivalStorage.html#Configuration
> A
> 
> 
> Diffs
> -
> 
>   ambari-web/app/utils/validator.js 9d11746 
>   ambari-web/test/utils/validator_test.js ef90561 
> 
> Diff: https://reviews.apache.org/r/42155/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> But Ambari Web Unit Test fails in trunk for other reasons described in 
> https://builds.apache.org/job/Ambari-trunk-test-patch/4848//artifact/patch-work/testrun_ambari-web.txt
> 
> 
> Thanks,
> 
> yao lei
> 
>



Re: Review Request 42155: AMBARI-14605 '[RAM_DISK]' configured in dfs.datanode.data.dir fails to validate

2016-05-02 Thread yao lei

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42155/
---

(Updated 五月 3, 2016, 4:57 a.m.)


Review request for Ambari and Matt.


Changes
---

I have rebuilt the patch based on the latest codebase of trunk


Bugs: AMBARI-14605
https://issues.apache.org/jira/browse/AMBARI-14605


Repository: ambari


Description
---

HDFS now support four kinds of heterogeneous storage types: ARCHIVE, DISK, SSD 
and RAM_DISK.
If we configure dfs.datanode.data.dir as [RAM_DISK]/anydir,it fails to validate.
please see 
https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/ArchivalStorage.html#Configuration
A


Diffs (updated)
-

  ambari-web/app/utils/validator.js 9d11746 
  ambari-web/test/utils/validator_test.js ef90561 

Diff: https://reviews.apache.org/r/42155/diff/


Testing
---

Manually Tested.
But Ambari Web Unit Test fails in trunk for other reasons described in 
https://builds.apache.org/job/Ambari-trunk-test-patch/4848//artifact/patch-work/testrun_ambari-web.txt


Thanks,

yao lei