Re: Review Request 45289: RBAC based user access to view instances are not honoured

2016-03-24 Thread Swapan Shridhar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45289/#review125296
---


Ship it!




Ship It!

- Swapan Shridhar


On March 24, 2016, 2:59 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45289/
> ---
> 
> (Updated March 24, 2016, 2:59 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-15543
> https://issues.apache.org/jira/browse/AMBARI-15543
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> 1. Create a cluster 
> 2. Create some view instances in amber
> 3. Create a local non-admin ambari user
> 4. Grant the newly created user access to one of the view instances
> 
> Log-in with the non-admin user. The user should only see the view instances 
> it has permission instead of all view instances.
> 
> This seems to have been introduced by 
> https://issues.apache.org/jira/browse/AMBARI-14194
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java
>  b136182 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
>  62f719d 
> 
> Diff: https://reviews.apache.org/r/45289/diff/
> 
> 
> Testing
> ---
> 
> Running 
> org.apache.ambari.server.security.authorization.AuthorizationHelperTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.081 sec - 
> in org.apache.ambari.server.security.authorization.AuthorizationHelperTest
> 
> 
> Thanks,
> 
> Robert Levas
> 
>



Re: Review Request 45289: RBAC based user access to view instances are not honoured

2016-03-24 Thread Oliver Szabo

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45289/#review125298
---


Ship it!




Ship It!

- Oliver Szabo


On March 24, 2016, 2:59 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45289/
> ---
> 
> (Updated March 24, 2016, 2:59 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-15543
> https://issues.apache.org/jira/browse/AMBARI-15543
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem:
> 1. Create a cluster 
> 2. Create some view instances in amber
> 3. Create a local non-admin ambari user
> 4. Grant the newly created user access to one of the view instances
> 
> Log-in with the non-admin user. The user should only see the view instances 
> it has permission instead of all view instances.
> 
> This seems to have been introduced by 
> https://issues.apache.org/jira/browse/AMBARI-14194
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java
>  b136182 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
>  62f719d 
> 
> Diff: https://reviews.apache.org/r/45289/diff/
> 
> 
> Testing
> ---
> 
> Running 
> org.apache.ambari.server.security.authorization.AuthorizationHelperTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.081 sec - 
> in org.apache.ambari.server.security.authorization.AuthorizationHelperTest
> 
> 
> Thanks,
> 
> Robert Levas
> 
>



Review Request 45289: RBAC based user access to view instances are not honoured

2016-03-24 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45289/
---

Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Swapan Shridhar.


Bugs: AMBARI-15543
https://issues.apache.org/jira/browse/AMBARI-15543


Repository: ambari


Description
---

Problem:
1. Create a cluster 
2. Create some view instances in amber
3. Create a local non-admin ambari user
4. Grant the newly created user access to one of the view instances

Log-in with the non-admin user. The user should only see the view instances it 
has permission instead of all view instances.

This seems to have been introduced by 
https://issues.apache.org/jira/browse/AMBARI-14194


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java
 b136182 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
 62f719d 

Diff: https://reviews.apache.org/r/45289/diff/


Testing
---

Running org.apache.ambari.server.security.authorization.AuthorizationHelperTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.081 sec - in 
org.apache.ambari.server.security.authorization.AuthorizationHelperTest


Thanks,

Robert Levas