Re: Review Request 45294: Add OS button on Edit repository version page shows extra space when no repositories have been selected for removal
> On March 28, 2016, 6:56 p.m., Alexandr Antonenko wrote: > > Ship It! Thank you Alexander. Can you please help push the fix? - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45294/#review125711 --- On March 27, 2016, 8:27 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45294/ > --- > > (Updated March 27, 2016, 8:27 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Oleg Nechiporenko, and Xi Wang. > > > Bugs: AMBARI-15548 > https://issues.apache.org/jira/browse/AMBARI-15548 > > > Repository: ambari > > > Description > --- > > The Add OS button shows an empty drop down when there are no entries in the > list i.e. when no repositories have been deleted. > Need to hide the drop-down when none of the repositories are selected for > deletion. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js > 2c3f000 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > a7dcaa5 > > Diff: https://reviews.apache.org/r/45294/diff/ > > > Testing > --- > > Manual testing. > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 45294: Add OS button on Edit repository version page shows extra space when no repositories have been selected for removal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45294/#review125711 --- Ship it! Ship It! - Alexandr Antonenko On March 27, 2016, 8:27 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45294/ > --- > > (Updated March 27, 2016, 8:27 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Oleg Nechiporenko, and Xi Wang. > > > Bugs: AMBARI-15548 > https://issues.apache.org/jira/browse/AMBARI-15548 > > > Repository: ambari > > > Description > --- > > The Add OS button shows an empty drop down when there are no entries in the > list i.e. when no repositories have been deleted. > Need to hide the drop-down when none of the repositories are selected for > deletion. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js > 2c3f000 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > a7dcaa5 > > Diff: https://reviews.apache.org/r/45294/diff/ > > > Testing > --- > > Manual testing. > > > Thanks, > > Sangeeta Ravindran > >
Review Request 45294: Add OS button on Edit repository version page shows extra space when no repositories have been selected for removal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45294/ --- Review request for Ambari, Oleg Nechiporenko and Xi Wang. Bugs: AMBARI-15548 https://issues.apache.org/jira/browse/AMBARI-15548 Repository: ambari Description --- The Add OS button shows an empty drop down when there are no entries in the list i.e. when no repositories have been deleted. Need to hide the drop-down when none of the repositories are selected for deletion. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js 2c3f000 ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html a7dcaa5 Diff: https://reviews.apache.org/r/45294/diff/ Testing --- Manual testing. Thanks, Sangeeta Ravindran
