Review Request 46941: Add Zookeeper dependency to LogSearch components for better Blueprint validation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46941/ --- Review request for Ambari, Don Bosco Durai, Miklos Gergely, Oliver Szabo, and Sumit Mohanty. Bugs: AMBARI-16227 https://issues.apache.org/jira/browse/AMBARI-16227 Repository: ambari Description --- This patch resolves AMBARI-16227. This patch implements the following: - Updates the LogSearch stack metadata (metainfo.xml), in order to add the dependency on the "ZOOKEEPER_SERVER" component. All LogSearch components require access to the Zookeeper quorum, so any inclusion of a LogSearch component should also include the ZOOKEEPER_SERVER. - This fix will provide better validation for Blueprint deployments. Adding this change will cause invalid Blueprints to fail when a user attempts to POST the Blueprint to ambari-server. This can help with Blueprint creation and debugging, since omission of the Zookeeper quorum will eventually cause a Cluster deployment with LogSearch to fail. Adding the validation here provides for a simpler debugging experience. Diffs - ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 3f96571 Diff: https://reviews.apache.org/r/46941/diff/ Testing --- 1. Tested this stack change against a 3-node HDFS, Yarn, and LogSearch Blueprint deployment. With this patch applied, an attempt to POST a Blueprint with LogSearch, but without the "ZOOKEEPER_SERVER" component included, causes a failure at POST time. Verified that adding the "ZOOKEEPER_SERVER" to the Blueprint allows the POST to succeed, and that the cluster itself deploys properly as well. 2. Ran the ambari-server "mvn clean test" suite, which passed completely with this patch applied. Thanks, Robert Nettleton
Re: Review Request 46941: Add Zookeeper dependency to LogSearch components for better Blueprint validation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46941/#review131531 --- Ship it! Ship It! - Oliver Szabo On May 3, 2016, 4:42 p.m., Robert Nettleton wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46941/ > --- > > (Updated May 3, 2016, 4:42 p.m.) > > > Review request for Ambari, Don Bosco Durai, Miklos Gergely, Oliver Szabo, and > Sumit Mohanty. > > > Bugs: AMBARI-16227 > https://issues.apache.org/jira/browse/AMBARI-16227 > > > Repository: ambari > > > Description > --- > > This patch resolves AMBARI-16227. > > This patch implements the following: > > - Updates the LogSearch stack metadata (metainfo.xml), in order to add the > dependency on the "ZOOKEEPER_SERVER" component. All LogSearch components > require access to the Zookeeper quorum, so any inclusion of a LogSearch > component should also include the ZOOKEEPER_SERVER. > - This fix will provide better validation for Blueprint deployments. Adding > this change will cause invalid Blueprints to fail when a user attempts to > POST the Blueprint to ambari-server. This can help with Blueprint creation > and debugging, since omission of the Zookeeper quorum will eventually cause a > Cluster deployment with LogSearch to fail. Adding the validation here > provides for a simpler debugging experience. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml > 3f96571 > > Diff: https://reviews.apache.org/r/46941/diff/ > > > Testing > --- > > 1. Tested this stack change against a 3-node HDFS, Yarn, and LogSearch > Blueprint deployment. With this patch applied, an attempt to POST a > Blueprint with LogSearch, but without the "ZOOKEEPER_SERVER" component > included, causes a failure at POST time. Verified that adding the > "ZOOKEEPER_SERVER" to the Blueprint allows the POST to succeed, and that the > cluster itself deploys properly as well. > 2. Ran the ambari-server "mvn clean test" suite, which passed completely with > this patch applied. > > > Thanks, > > Robert Nettleton > >
Re: Review Request 46941: Add Zookeeper dependency to LogSearch components for better Blueprint validation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46941/#review131695 --- Ship it! Ship It! - Miklos Gergely On May 3, 2016, 4:42 p.m., Robert Nettleton wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46941/ > --- > > (Updated May 3, 2016, 4:42 p.m.) > > > Review request for Ambari, Don Bosco Durai, Miklos Gergely, Oliver Szabo, and > Sumit Mohanty. > > > Bugs: AMBARI-16227 > https://issues.apache.org/jira/browse/AMBARI-16227 > > > Repository: ambari > > > Description > --- > > This patch resolves AMBARI-16227. > > This patch implements the following: > > - Updates the LogSearch stack metadata (metainfo.xml), in order to add the > dependency on the "ZOOKEEPER_SERVER" component. All LogSearch components > require access to the Zookeeper quorum, so any inclusion of a LogSearch > component should also include the ZOOKEEPER_SERVER. > - This fix will provide better validation for Blueprint deployments. Adding > this change will cause invalid Blueprints to fail when a user attempts to > POST the Blueprint to ambari-server. This can help with Blueprint creation > and debugging, since omission of the Zookeeper quorum will eventually cause a > Cluster deployment with LogSearch to fail. Adding the validation here > provides for a simpler debugging experience. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml > 3f96571 > > Diff: https://reviews.apache.org/r/46941/diff/ > > > Testing > --- > > 1. Tested this stack change against a 3-node HDFS, Yarn, and LogSearch > Blueprint deployment. With this patch applied, an attempt to POST a > Blueprint with LogSearch, but without the "ZOOKEEPER_SERVER" component > included, causes a failure at POST time. Verified that adding the > "ZOOKEEPER_SERVER" to the Blueprint allows the POST to succeed, and that the > cluster itself deploys properly as well. > 2. Ran the ambari-server "mvn clean test" suite, which passed completely with > this patch applied. > > > Thanks, > > Robert Nettleton > >
