Review Request 46953: AMBARI-16239: Incorrect warning for not selecting nfs_gateway_hosts

2016-05-03 Thread Richard Zang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46953/
---

Review request for Ambari, Andriy Babiichuk and Zhe (Joe) Wang.


Bugs: AMBARI-16239
https://issues.apache.org/jira/browse/AMBARI-16239


Repository: ambari


Description
---

Fix empty value check for [] case;


Diffs
-

  ambari-web/app/models/configs/objects/service_config_property.js a244dfd 

Diff: https://reviews.apache.org/r/46953/diff/


Testing
---

Manually tested for live cluster.
All unit tests passed.
  27526 tests complete (26 seconds)
  154 tests pending


Thanks,

Richard Zang



Re: Review Request 46953: AMBARI-16239: Incorrect warning for not selecting nfs_gateway_hosts

2016-05-03 Thread Zhe (Joe) Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46953/#review131597
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On May 4, 2016, 12:36 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46953/
> ---
> 
> (Updated May 4, 2016, 12:36 a.m.)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Zhe (Joe) Wang.
> 
> 
> Bugs: AMBARI-16239
> https://issues.apache.org/jira/browse/AMBARI-16239
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix empty value check for [] case;
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/configs/objects/service_config_property.js a244dfd 
> 
> Diff: https://reviews.apache.org/r/46953/diff/
> 
> 
> Testing
> ---
> 
> Manually tested for live cluster.
> All unit tests passed.
>   27526 tests complete (26 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>