Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47074/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Nate Cole, Robert Levas, Sumit Mohanty, and Velmurugan Periasamy. Bugs: AMBARI-16290 https://issues.apache.org/jira/browse/AMBARI-16290 Repository: ambari Description --- **Problem Statement :** 1) Hive Restart fails to create repository in Ranger and goes for retries due to missing principal after enabling hive plugin in in kerberized environment. 2) Yarn Restart fails to create repository in Ranger in simple environment. ** Proposed Solution : ** 1) Fixing principal required for hive server, adding new parameters required for Ranger service creation. 2) Fixing call for repository creation in simple environemnt. Diffs - ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py 4f319ea ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py 4a071ca ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py d3fc173 ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py 864d937 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py f42185e ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py 72eb3ad ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py ec43fea ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 92eaaab ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py 12ccef6 ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 1dd25ce ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c5f8940 ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py d715a25 ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py ba4c777 ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py cf01965 Diff: https://reviews.apache.org/r/47074/diff/ Testing --- 1) Verified Enable Hive Plugin and Ranger service creation after enabling plugin in kerberos / simple environment. 2) Verified Enable Yarn Plugin and Ranger service creation after enabling plugin in simple environment. Thanks, Gautam Borad
Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47074/#review132286 --- There should be python tests to cover the new code paths. - Nate Cole On May 9, 2016, 5:56 a.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47074/ > --- > > (Updated May 9, 2016, 5:56 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, > Nate Cole, Robert Levas, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-16290 > https://issues.apache.org/jira/browse/AMBARI-16290 > > > Repository: ambari > > > Description > --- > > **Problem Statement :** > 1) Hive Restart fails to create repository in Ranger and goes for retries due > to missing principal after enabling hive plugin in in kerberized environment. > > 2) Yarn Restart fails to create repository in Ranger in simple environment. > > ** Proposed Solution : ** > 1) Fixing principal required for hive server, adding new parameters required > for Ranger service creation. > 2) Fixing call for repository creation in simple environemnt. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py > 4f319ea > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 4a071ca > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > d3fc173 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py > 864d937 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > f42185e > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > 72eb3ad > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > ec43fea > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py > 92eaaab > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 12ccef6 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 1dd25ce > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py > c5f8940 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > d715a25 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py > ba4c777 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > cf01965 > > Diff: https://reviews.apache.org/r/47074/diff/ > > > Testing > --- > > 1) Verified Enable Hive Plugin and Ranger service creation after enabling > plugin in kerberos / simple environment. > > 2) Verified Enable Yarn Plugin and Ranger service creation after enabling > plugin in simple environment. > > > Thanks, > > Gautam Borad > >
Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47074/#review133026 --- Ship it! Please add unit tests in a new jira asap! - Mahadev Konar On May 9, 2016, 9:56 a.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47074/ > --- > > (Updated May 9, 2016, 9:56 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, > Nate Cole, Robert Levas, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-16290 > https://issues.apache.org/jira/browse/AMBARI-16290 > > > Repository: ambari > > > Description > --- > > **Problem Statement :** > 1) Hive Restart fails to create repository in Ranger and goes for retries due > to missing principal after enabling hive plugin in in kerberized environment. > > 2) Yarn Restart fails to create repository in Ranger in simple environment. > > ** Proposed Solution : ** > 1) Fixing principal required for hive server, adding new parameters required > for Ranger service creation. > 2) Fixing call for repository creation in simple environemnt. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py > 4f319ea > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 4a071ca > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > d3fc173 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py > 864d937 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > f42185e > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > 72eb3ad > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > ec43fea > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py > 92eaaab > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 12ccef6 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 1dd25ce > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py > c5f8940 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > d715a25 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py > ba4c777 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > cf01965 > > Diff: https://reviews.apache.org/r/47074/diff/ > > > Testing > --- > > 1) Verified Enable Hive Plugin and Ranger service creation after enabling > plugin in kerberos / simple environment. > > 2) Verified Enable Yarn Plugin and Ranger service creation after enabling > plugin in simple environment. > > > Thanks, > > Gautam Borad > >
Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments
> On May 13, 2016, 4 a.m., Mahadev Konar wrote: > > Please add unit tests in a new jira asap! Thanks Mahadev. Create https://issues.apache.org/jira/browse/AMBARI-16650 for the unit test cases. Thanks. - Gautam --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47074/#review133026 --- On May 9, 2016, 9:56 a.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47074/ > --- > > (Updated May 9, 2016, 9:56 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, > Nate Cole, Robert Levas, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-16290 > https://issues.apache.org/jira/browse/AMBARI-16290 > > > Repository: ambari > > > Description > --- > > **Problem Statement :** > 1) Hive Restart fails to create repository in Ranger and goes for retries due > to missing principal after enabling hive plugin in in kerberized environment. > > 2) Yarn Restart fails to create repository in Ranger in simple environment. > > ** Proposed Solution : ** > 1) Fixing principal required for hive server, adding new parameters required > for Ranger service creation. > 2) Fixing call for repository creation in simple environemnt. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py > 4f319ea > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 4a071ca > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > d3fc173 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py > 864d937 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > f42185e > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > 72eb3ad > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > ec43fea > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py > 92eaaab > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 12ccef6 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 1dd25ce > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py > c5f8940 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > d715a25 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py > ba4c777 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > cf01965 > > Diff: https://reviews.apache.org/r/47074/diff/ > > > Testing > --- > > 1) Verified Enable Hive Plugin and Ranger service creation after enabling > plugin in kerberos / simple environment. > > 2) Verified Enable Yarn Plugin and Ranger service creation after enabling > plugin in simple environment. > > > Thanks, > > Gautam Borad > >
Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47074/#review133070 --- Ship it! Ship It! - Robert Levas On May 9, 2016, 5:56 a.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47074/ > --- > > (Updated May 9, 2016, 5:56 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, > Nate Cole, Robert Levas, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-16290 > https://issues.apache.org/jira/browse/AMBARI-16290 > > > Repository: ambari > > > Description > --- > > **Problem Statement :** > 1) Hive Restart fails to create repository in Ranger and goes for retries due > to missing principal after enabling hive plugin in in kerberized environment. > > 2) Yarn Restart fails to create repository in Ranger in simple environment. > > ** Proposed Solution : ** > 1) Fixing principal required for hive server, adding new parameters required > for Ranger service creation. > 2) Fixing call for repository creation in simple environemnt. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py > 4f319ea > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 4a071ca > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > d3fc173 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py > 864d937 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > f42185e > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > 72eb3ad > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > ec43fea > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py > 92eaaab > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 12ccef6 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 1dd25ce > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py > c5f8940 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > d715a25 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py > ba4c777 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > cf01965 > > Diff: https://reviews.apache.org/r/47074/diff/ > > > Testing > --- > > 1) Verified Enable Hive Plugin and Ranger service creation after enabling > plugin in kerberos / simple environment. > > 2) Verified Enable Yarn Plugin and Ranger service creation after enabling > plugin in simple environment. > > > Thanks, > > Gautam Borad > >