Re: Review Request 47134: HAWQ Password handling updated

2016-05-12 Thread bhuvnesh chaudhary 


> On May 12, 2016, 4:43 a.m., Matt wrote:
> > ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py, line 31
> > 
> >
> > This is not required. Refer comment on the test_hawqsegment.py file.

Thanks Matt for the suggestion. Used getConfig.


- bhuvnesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132812
---


On May 12, 2016, 1:07 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 12, 2016, 1:07 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-05-09 12:54:41,978 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case11 (test_hawqmaster.TestHawqMast

Re: Review Request 47134: HAWQ Password handling updated

2016-05-12 Thread bhuvnesh chaudhary 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/
---

(Updated May 12, 2016, 4:26 p.m.)


Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
Diachenko.


Changes
---

Applied feedback


Bugs: AMBARI-16386
https://issues.apache.org/jira/browse/AMBARI-16386


Repository: ambari


Description
---

Updated salt used while creating HAWQ user, and also ensured that the password 
is treated exactly as entered on the HAWQ config ui.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 1bdc85a 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 670a58b 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 

Diff: https://reviews.apache.org/r/47134/diff/


Testing
---

yes.
bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
test_hawq_master_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_segment_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_standby_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_exception_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
handlers could be found for logger "ambari_alerts"
ok
test_missing_configs 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_slave_file 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_successful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_empty_db_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status_plural 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
HAWQ Standby Master ...
ok
test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
Standby Master Re-Sync started in fast mode...
ok
test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
ok
test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
Kerberized ... 2016-05-09 12:54:41,978 - Executing HAWQ Check ...
ok
test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
Kerberized ... 2016-05-09 12:54:41,987 - Executing HAWQ Check ...
ok
test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, 
Kerberized ... 2016-05-09 12:54:41,997 - Executing HAWQ Check ...
ok
test_run_hawq_check_case2 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 2: Non HDFS-HA, Standalone Resource Management, 
Kerberized ... 2016-05-09 12:54:42,009 - Executing HAWQ Check ...
ok
test_run_hawq_check_case3 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 3: Non HDFS-HA, YARN Resource Management Non YARN_HA, 
Not Kerberized ... 2016-05-09 12:54:42,021 - Executing HAWQ Check ...
ok
test_run_hawq_check_case4 (test_hawqmast

Re: Review Request 47134: HAWQ Password handling updated

2016-05-11 Thread Matt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132812
---


Fix it, then Ship it!





ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py (line 30)


This is not required.



ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py (line 49)


For this implementation, you do not need the config_dict to be loaded as 
json. This was required in HAWQMASTER test for updating the configs after 
loading within each unit test for testing different scenarios.

This would work:

```password = 
crypt.crypt(self.getConfig()['configurations']['hawq-env']['hawq_password'], 
"$1$salt$")```



ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py (line 31)


This is not required. Refer comment on the test_hawqsegment.py file.


- Matt


On May 11, 2016, 6:07 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 11, 2016, 6:07 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ

Re: Review Request 47134: HAWQ Password handling updated

2016-05-11 Thread bhuvnesh chaudhary 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/
---

(Updated May 12, 2016, 1:07 a.m.)


Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
Diachenko.


Changes
---

Updated test cases


Bugs: AMBARI-16386
https://issues.apache.org/jira/browse/AMBARI-16386


Repository: ambari


Description
---

Updated salt used while creating HAWQ user, and also ensured that the password 
is treated exactly as entered on the HAWQ config ui.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 1bdc85a 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 670a58b 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 

Diff: https://reviews.apache.org/r/47134/diff/


Testing
---

yes.
bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
test_hawq_master_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_segment_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_standby_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_exception_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
handlers could be found for logger "ambari_alerts"
ok
test_missing_configs 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_slave_file 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_successful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_empty_db_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status_plural 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
HAWQ Standby Master ...
ok
test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
Standby Master Re-Sync started in fast mode...
ok
test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
ok
test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
Kerberized ... 2016-05-09 12:54:41,978 - Executing HAWQ Check ...
ok
test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
Kerberized ... 2016-05-09 12:54:41,987 - Executing HAWQ Check ...
ok
test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, 
Kerberized ... 2016-05-09 12:54:41,997 - Executing HAWQ Check ...
ok
test_run_hawq_check_case2 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 2: Non HDFS-HA, Standalone Resource Management, 
Kerberized ... 2016-05-09 12:54:42,009 - Executing HAWQ Check ...
ok
test_run_hawq_check_case3 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 3: Non HDFS-HA, YARN Resource Management Non YARN_HA, 
Not Kerberized ... 2016-05-09 12:54:42,021 - Executing HAWQ Check ...
ok
test_run_hawq_check_case4 (test_hawqma

Re: Review Request 47134: HAWQ Password handling updated

2016-05-09 Thread Alexander Denissov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132347
---


Ship it!




Ship It!

- Alexander Denissov


On May 9, 2016, 7:55 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 9, 2016, 7:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-05-09 12:54:41,978 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
> Kerberized ... 2016-05-09 12:54:41,987 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, 
> Kerberized .

Re: Review Request 47134: HAWQ Password handling updated

2016-05-09 Thread jun aoki 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132339
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 (line 54)


Could you add a comment why "$1$salt$"? it is so magic if you are not 
familier with crpyt(I'm one of them)
$1 to be MD5 instead of default DES and more

https://en.wikipedia.org/wiki/Crypt_(C)#Key_Derivation_Functions_Supported_by_crypt


- jun aoki


On May 9, 2016, 7:55 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 9, 2016, 7:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-05-09 12:54:41,978

Re: Review Request 47134: HAWQ Password handling updated

2016-05-09 Thread jun aoki 


> On May 9, 2016, 8:06 p.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py,
> >  line 54
> > 
> >
> > json.dumps ensures that quotes and special characters are escaped?
> > 
> > Did you consider && and giving an additional command? Or is this a new 
> > JIRA?
> 
> bhuvnesh chaudhary wrote:
> It ensures that whatever is input is passed as a string as interpreted by 
> bash. I tested && as well.
> Some of the password which i tested..
> "';//\p@ssw&&rd;touch abc.txt;
> "';//p@ssw&&rd

I'm a bit surprised with this json. Bhuvnesh, what you said make sense totally 
but maybe a good idea to have a comment.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132319
---


On May 9, 2016, 7:55 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 9, 2016, 7:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.Test

Re: Review Request 47134: HAWQ Password handling updated

2016-05-09 Thread bhuvnesh chaudhary 


> On May 9, 2016, 8:06 p.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py,
> >  line 54
> > 
> >
> > json.dumps ensures that quotes and special characters are escaped?
> > 
> > Did you consider && and giving an additional command? Or is this a new 
> > JIRA?

It ensures that whatever is input is passed as a string as interpreted by bash. 
I tested && as well.
Some of the password which i tested..
"';//\p@ssw&&rd;touch abc.txt;
"';//p@ssw&&rd


- bhuvnesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132319
---


On May 9, 2016, 7:55 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 9, 2016, 7:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
> ok
> test_ru

Re: Review Request 47134: HAWQ Password handling updated

2016-05-09 Thread Matt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132319
---


Ship it!





ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 (line 53)


json.dumps ensures that quotes and special characters are escaped?

Did you consider && and giving an additional command? Or is this a new JIRA?


- Matt


On May 9, 2016, 12:55 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 9, 2016, 12:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-05-09 12:54:41,978 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
> Runn

Re: Review Request 47134: HAWQ Password handling updated

2016-05-09 Thread Goutam Tadi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/#review132318
---


Ship it!




Ship It!

- Goutam Tadi


On May 9, 2016, 7:55 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47134/
> ---
> 
> (Updated May 9, 2016, 7:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16386
> https://issues.apache.org/jira/browse/AMBARI-16386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated salt used while creating HAWQ user, and also ensured that the 
> password is treated exactly as entered on the HAWQ config ui.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  1bdc85a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
>  670a58b 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 
> 
> Diff: https://reviews.apache.org/r/47134/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-05-09 12:54:41,978 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
> Kerberized ... 2016-05-09 12:54:41,987 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, 
> Kerberized ... 2016

Review Request 47134: HAWQ Password handling updated

2016-05-09 Thread bhuvnesh chaudhary 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47134/
---

Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
Diachenko.


Bugs: AMBARI-16386
https://issues.apache.org/jira/browse/AMBARI-16386


Repository: ambari


Description
---

Updated salt used while creating HAWQ user, and also ensured that the password 
is treated exactly as entered on the HAWQ config ui.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 1bdc85a 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
 670a58b 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 2671202 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 7963b3d 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 605f49a 

Diff: https://reviews.apache.org/r/47134/diff/


Testing
---

yes.
bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
test_hawq_master_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_segment_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_standby_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_exception_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
handlers could be found for logger "ambari_alerts"
ok
test_missing_configs 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_slave_file 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_successful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_empty_db_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status_plural 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Remove HAWQ Standby ... 2016-05-09 12:54:41,958 - Removing 
HAWQ Standby Master ...
ok
test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Resync HAWQ Standby ... 2016-05-09 12:54:41,963 - HAWQ 
Standby Master Re-Sync started in fast mode...
ok
test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
Kerberized ... 2016-05-09 12:54:41,968 - Executing HAWQ Check ...
ok
test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
Kerberized ... 2016-05-09 12:54:41,978 - Executing HAWQ Check ...
ok
test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
Kerberized ... 2016-05-09 12:54:41,987 - Executing HAWQ Check ...
ok
test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, 
Kerberized ... 2016-05-09 12:54:41,997 - Executing HAWQ Check ...
ok
test_run_hawq_check_case2 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 2: Non HDFS-HA, Standalone Resource Management, 
Kerberized ... 2016-05-09 12:54:42,009 - Executing HAWQ Check ...
ok
test_run_hawq_check_case3 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 3: Non HDFS-HA, YARN Resource Management Non YARN_HA, 
Not Kerberized ... 2016-05-09 12:54:42,021 - Executing HAWQ Check ...
ok
test_run_hawq_check_case4 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 4: Non HDFS-HA, YARN Resource Managemen