Re: Review Request 48953: Open Advanced logsearch-admin-json upon install

2016-06-20 Thread Oliver Szabo

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48953/#review138609
---


Ship it!




Ship It!

- Oliver Szabo


On June 20, 2016, 2:35 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48953/
> ---
> 
> (Updated June 20, 2016, 2:35 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17312
> https://issues.apache.org/jira/browse/AMBARI-17312
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During the installation of the Log Search service via Ambari the user has to 
> specify the logsearch admin password. For convenience the 'Advanced 
> logsearch-admin-json' properties panel should be open by default.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/data/HDP2/site_properties.js 09b2572 
>   ambari-web/app/models/stack_service.js c1a5bf5 
> 
> Diff: https://reviews.apache.org/r/48953/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>



Re: Review Request 48953: Open Advanced logsearch-admin-json upon install

2016-06-20 Thread Robert Nettleton

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48953/#review138608
---


Ship it!




Looks fine to me. 

It might be a good idea to have somebody on the Ambari UI team review this 
change as well.

- Robert Nettleton


On June 20, 2016, 2:35 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48953/
> ---
> 
> (Updated June 20, 2016, 2:35 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17312
> https://issues.apache.org/jira/browse/AMBARI-17312
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During the installation of the Log Search service via Ambari the user has to 
> specify the logsearch admin password. For convenience the 'Advanced 
> logsearch-admin-json' properties panel should be open by default.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/data/HDP2/site_properties.js 09b2572 
>   ambari-web/app/models/stack_service.js c1a5bf5 
> 
> Diff: https://reviews.apache.org/r/48953/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>



Review Request 48953: Open Advanced logsearch-admin-json upon install

2016-06-20 Thread Miklos Gergely

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48953/
---

Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-17312
https://issues.apache.org/jira/browse/AMBARI-17312


Repository: ambari


Description
---

During the installation of the Log Search service via Ambari the user has to 
specify the logsearch admin password. For convenience the 'Advanced 
logsearch-admin-json' properties panel should be open by default.


Diffs
-

  ambari-web/app/data/HDP2/site_properties.js 09b2572 
  ambari-web/app/models/stack_service.js c1a5bf5 

Diff: https://reviews.apache.org/r/48953/diff/


Testing
---


Thanks,

Miklos Gergely