Re: Review Request 49755: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation

2016-07-15 Thread Akhil PB 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49755/
---

(Updated July 15, 2016, 7:29 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath 
Somarajapuram.


Changes
---

Patch updated with FIX for HDP-2.5 node labels API compatability issue.


Bugs: AMBARI-17602
https://issues.apache.org/jira/browse/AMBARI-17602


Repository: ambari


Description
---

Fetching current rm configuration of queues.
Updating queue states based on states in configuration.
Preemption implementation.
Bug fixes.


Diffs (updated)
-

  
contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
 03520fe 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 
068c241 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
 bf74af6 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
 9b31e57 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
 7bb3f82 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
 bfcd4b6 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 545d348 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 f42d2e4 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 683bc6f 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
e91c90f 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 49363d4 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
c3976b4 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 4a9c6b0 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 e849ad4 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
6e310ad 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 b75237f 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
 e659f5c 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
 b4891cd 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
 bb82025 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
 b1a8708 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 2848fed 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/trace.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
 9e25cc6 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
 c430a44 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs
 96cbe99 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
 bd49c50 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
 ef5663d 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
a5d0ef6 

Diff: https://reviews.apache.org/r/49755/diff/


Testing
---

Manual Unit Testing


Thanks,

Akhil PB

Re: Review Request 49755: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation

2016-07-14 Thread Akhil PB 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49755/
---

(Updated July 14, 2016, 10:28 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath 
Somarajapuram.


Changes
---

Updated with review comments


Bugs: AMBARI-17602
https://issues.apache.org/jira/browse/AMBARI-17602


Repository: ambari


Description
---

Fetching current rm configuration of queues.
Updating queue states based on states in configuration.
Preemption implementation.
Bug fixes.


Diffs (updated)
-

  
contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
 03520fe 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 
068c241 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
 bf74af6 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
 9b31e57 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
 7bb3f82 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
 bfcd4b6 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 545d348 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 f42d2e4 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 683bc6f 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
e91c90f 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 49363d4 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
c3976b4 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 4a9c6b0 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 e849ad4 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
6e310ad 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 b75237f 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
 e659f5c 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
 b4891cd 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
 bb82025 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
 b1a8708 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 2848fed 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/trace.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
 9e25cc6 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
 c430a44 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs
 96cbe99 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
 bd49c50 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
 ef5663d 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
a5d0ef6 

Diff: https://reviews.apache.org/r/49755/diff/


Testing
---

Manual Unit Testing


Thanks,

Akhil PB

Re: Review Request 49755: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation

2016-07-11 Thread Sreenath Somarajapuram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49755/#review141661
---




contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
 (line 286)


Trailing spaces.



contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
 (line 33)


Commented code.



contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
 (line 36)


Commented code.


- Sreenath Somarajapuram


On July 7, 2016, 1:10 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49755/
> ---
> 
> (Updated July 7, 2016, 1:10 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17602
> https://issues.apache.org/jira/browse/AMBARI-17602
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fetching current rm configuration of queues.
> Updating queue states based on states in configuration.
> Preemption implementation.
> Bug fixes.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
>  03520fe 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 
> 068c241 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  bf74af6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  9b31e57 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  7bb3f82 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  bfcd4b6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  545d348 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  f42d2e4 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  683bc6f 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> e91c90f 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> 49363d4 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> c3976b4 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 4a9c6b0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  e849ad4 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 6e310ad 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  b75237f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  e659f5c 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  b4891cd 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  bb82025 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b1a8708 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  2848fed 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/trace.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  9e25cc6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  c430a44 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs
>  96cbe99 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  bd49c50 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  ef5663d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
> a5d0ef6 
> 
> Diff: https://reviews.apache.org/r/49755/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Review Request 49755: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation

2016-07-07 Thread Akhil PB 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49755/
---

Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath 
Somarajapuram.


Bugs: AMBARI-17602
https://issues.apache.org/jira/browse/AMBARI-17602


Repository: ambari


Description
---

Fetching current rm configuration of queues.
Updating queue states based on states in configuration.
Preemption implementation.
Bug fixes.


Diffs
-

  
contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
 03520fe 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 
068c241 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
 bf74af6 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
 9b31e57 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
 7bb3f82 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
 bfcd4b6 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 545d348 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 f42d2e4 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 683bc6f 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
e91c90f 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 49363d4 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
c3976b4 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 4a9c6b0 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 e849ad4 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
6e310ad 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 b75237f 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
 e659f5c 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
 b4891cd 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
 bb82025 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
 b1a8708 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 2848fed 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/trace.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
 9e25cc6 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
 c430a44 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs
 96cbe99 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
 bd49c50 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
 ef5663d 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
a5d0ef6 

Diff: https://reviews.apache.org/r/49755/diff/


Testing
---

Manual Unit Testing


Thanks,

Akhil PB