Review Request 49944: optimize log description of ambari agent stop

2016-07-11 Thread wang yaoxin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49944/
---

Review request for Ambari.


Bugs: AMBARI-17668
https://issues.apache.org/jira/browse/AMBARI-17668


Repository: ambari


Description
---

excute ambari agent ?going to execute kill -9?but none output log


Diffs
-

  ambari-agent/src/main/python/ambari_agent/main.py 1fc445e 

Diff: https://reviews.apache.org/r/49944/diff/


Testing
---

done


Thanks,

wang yaoxin

Re: Review Request 49944: optimize log description of ambari agent stop

2016-08-12 Thread Kuldeep Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49944/#review145601
---


Ship it!




Ship It!

- Kuldeep Mishra


On Aug. 4, 2016, 1:17 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49944/
> ---
> 
> (Updated Aug. 4, 2016, 1:17 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17668
> https://issues.apache.org/jira/browse/AMBARI-17668
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> excute ambari agent ?going to execute kill -9?but none output log
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/main.py 1fc445e 
> 
> Diff: https://reviews.apache.org/r/49944/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 49944: optimize log description of ambari agent stop

2016-08-12 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49944/#review145646
---


Fix it, then Ship it!





ambari-agent/src/main/python/ambari_agent/main.py (line 282)


Extra space right after "stopped"


- Alejandro Fernandez


On Aug. 4, 2016, 1:17 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49944/
> ---
> 
> (Updated Aug. 4, 2016, 1:17 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17668
> https://issues.apache.org/jira/browse/AMBARI-17668
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> excute ambari agent ?going to execute kill -9?but none output log
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/main.py 1fc445e 
> 
> Diff: https://reviews.apache.org/r/49944/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 49944: optimize log description of ambari agent stop

2016-08-15 Thread wang yaoxin 


> On 八月 12, 2016, 6:09 p.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/python/ambari_agent/main.py, line 282
> > 
> >
> > Extra space right after "stopped"

Thank you?
I hava attached a new patch AMBARI-17668-1.patch ,can you help me ship it!


- wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49944/#review145646
---


On 八月 4, 2016, 1:17 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49944/
> ---
> 
> (Updated 八月 4, 2016, 1:17 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17668
> https://issues.apache.org/jira/browse/AMBARI-17668
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> excute ambari agent ?going to execute kill -9?but none output log
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/main.py 1fc445e 
> 
> Diff: https://reviews.apache.org/r/49944/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 49944: optimize log description of ambari agent stop

2016-08-22 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49944/#review146457
---



Pushed to trunk, commit 91cd8274ae299f4fd4e6553bbd7f58f54148b65e

- Alejandro Fernandez


On Aug. 4, 2016, 1:17 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49944/
> ---
> 
> (Updated Aug. 4, 2016, 1:17 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17668
> https://issues.apache.org/jira/browse/AMBARI-17668
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> excute ambari agent ?going to execute kill -9?but none output log
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/main.py 1fc445e 
> 
> Diff: https://reviews.apache.org/r/49944/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>