Re: Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

2016-09-06 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51562/#review147888
---


Ship it!




Ship It!

- Alejandro Fernandez


On Sept. 1, 2016, 6:11 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51562/
> ---
> 
> (Updated Sept. 1, 2016, 6:11 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18289
> https://issues.apache.org/jira/browse/AMBARI-18289
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> Negative values are being reported for IOPS in the "system servers" dashboard
> 
> BUG
> This was a dockerized environment. Negative rate values were seen because 
> read/write counters were dropping below the previous values at random times. 
> On further investigation, it revealed that this was due to the docker volume 
> groups present on the host. It is expected of docker containers to add/remove 
> the volume groups during the lifecyle of a container. So, when a volume group 
> goes away, the read/write counters do not contribute to the total counter 
> values, thus making the value go below the last seen value.
> 
> FIX
> Have a provision to discard such "special" disk partitions through a skip 
> pattern. If skipped, they will not contribute to the global counter metric. 
> Individual disk counter metrics can be used to get disk specific counter 
> values.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> 3e5d861 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  02f0ce3 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py
>  845b270 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4135d32 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  2503c43 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  383a0de 
> 
> Diff: https://reviews.apache.org/r/51562/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

2016-09-02 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51562/#review147642
---


Ship it!




Ship It!

- Dmytro Sen


On Сен. 1, 2016, 6:11 п.п., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51562/
> ---
> 
> (Updated Сен. 1, 2016, 6:11 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18289
> https://issues.apache.org/jira/browse/AMBARI-18289
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> Negative values are being reported for IOPS in the "system servers" dashboard
> 
> BUG
> This was a dockerized environment. Negative rate values were seen because 
> read/write counters were dropping below the previous values at random times. 
> On further investigation, it revealed that this was due to the docker volume 
> groups present on the host. It is expected of docker containers to add/remove 
> the volume groups during the lifecyle of a container. So, when a volume group 
> goes away, the read/write counters do not contribute to the total counter 
> values, thus making the value go below the last seen value.
> 
> FIX
> Have a provision to discard such "special" disk partitions through a skip 
> pattern. If skipped, they will not contribute to the global counter metric. 
> Individual disk counter metrics can be used to get disk specific counter 
> values.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> 3e5d861 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  02f0ce3 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py
>  845b270 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4135d32 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  2503c43 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  383a0de 
> 
> Diff: https://reviews.apache.org/r/51562/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

2016-09-01 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51562/
---

(Updated Sept. 1, 2016, 6:11 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18289
https://issues.apache.org/jira/browse/AMBARI-18289


Repository: ambari


Description
---

PROBLEM
Negative values are being reported for IOPS in the "system servers" dashboard

BUG
This was a dockerized environment. Negative rate values were seen because 
read/write counters were dropping below the previous values at random times. On 
further investigation, it revealed that this was due to the docker volume 
groups present on the host. It is expected of docker containers to add/remove 
the volume groups during the lifecyle of a container. So, when a volume group 
goes away, the read/write counters do not contribute to the total counter 
values, thus making the value go below the last seen value.

FIX
Have a provision to discard such "special" disk partitions through a skip 
pattern. If skipped, they will not contribute to the global counter metric. 
Individual disk counter metrics can be used to get disk specific counter values.


Diffs (updated)
-

  ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
3e5d861 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 02f0ce3 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 
845b270 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
 4135d32 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 2503c43 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 383a0de 

Diff: https://reviews.apache.org/r/51562/diff/


Testing
---

Manually tested.


Thanks,

Aravindan Vijayan

Re: Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

2016-09-01 Thread Aravindan Vijayan 


> On Sept. 1, 2016, 4:59 a.m., Alejandro Fernandez wrote:
> > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py,
> >  line 266
> > 
> >
> > Where is allowed_disks populated?

In line 274


- Aravindan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51562/#review147542
---


On Sept. 1, 2016, 3:51 a.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51562/
> ---
> 
> (Updated Sept. 1, 2016, 3:51 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18289
> https://issues.apache.org/jira/browse/AMBARI-18289
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> Negative values are being reported for IOPS in the "system servers" dashboard
> 
> BUG
> This was a dockerized environment. Negative rate values were seen because 
> read/write counters were dropping below the previous values at random times. 
> On further investigation, it revealed that this was due to the docker volume 
> groups present on the host. It is expected of docker containers to add/remove 
> the volume groups during the lifecyle of a container. So, when a volume group 
> goes away, the read/write counters do not contribute to the total counter 
> values, thus making the value go below the last seen value.
> 
> FIX
> Have a provision to discard such "special" disk partitions through a skip 
> pattern. If skipped, they will not contribute to the global counter metric. 
> Individual disk counter metrics can be used to get disk specific counter 
> values.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> 3e5d861 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  02f0ce3 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py
>  845b270 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4135d32 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  2503c43 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  383a0de 
> 
> Diff: https://reviews.apache.org/r/51562/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

2016-09-01 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51562/#review147555
---




ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
 (line 85)


Is "true" a correct default value for pattern ?


- Dmytro Sen


On Сен. 1, 2016, 3:51 д.п., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51562/
> ---
> 
> (Updated Сен. 1, 2016, 3:51 д.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18289
> https://issues.apache.org/jira/browse/AMBARI-18289
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> Negative values are being reported for IOPS in the "system servers" dashboard
> 
> BUG
> This was a dockerized environment. Negative rate values were seen because 
> read/write counters were dropping below the previous values at random times. 
> On further investigation, it revealed that this was due to the docker volume 
> groups present on the host. It is expected of docker containers to add/remove 
> the volume groups during the lifecyle of a container. So, when a volume group 
> goes away, the read/write counters do not contribute to the total counter 
> values, thus making the value go below the last seen value.
> 
> FIX
> Have a provision to discard such "special" disk partitions through a skip 
> pattern. If skipped, they will not contribute to the global counter metric. 
> Individual disk counter metrics can be used to get disk specific counter 
> values.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> 3e5d861 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  02f0ce3 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py
>  845b270 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4135d32 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  2503c43 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  383a0de 
> 
> Diff: https://reviews.apache.org/r/51562/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

2016-08-31 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51562/#review147542
---




ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 
(line 266)


Where is allowed_disks populated?


- Alejandro Fernandez


On Sept. 1, 2016, 3:51 a.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51562/
> ---
> 
> (Updated Sept. 1, 2016, 3:51 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18289
> https://issues.apache.org/jira/browse/AMBARI-18289
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> Negative values are being reported for IOPS in the "system servers" dashboard
> 
> BUG
> This was a dockerized environment. Negative rate values were seen because 
> read/write counters were dropping below the previous values at random times. 
> On further investigation, it revealed that this was due to the docker volume 
> groups present on the host. It is expected of docker containers to add/remove 
> the volume groups during the lifecyle of a container. So, when a volume group 
> goes away, the read/write counters do not contribute to the total counter 
> values, thus making the value go below the last seen value.
> 
> FIX
> Have a provision to discard such "special" disk partitions through a skip 
> pattern. If skipped, they will not contribute to the global counter metric. 
> Individual disk counter metrics can be used to get disk specific counter 
> values.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> 3e5d861 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  02f0ce3 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py
>  845b270 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4135d32 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  2503c43 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  383a0de 
> 
> Diff: https://reviews.apache.org/r/51562/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

2016-08-31 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51562/#review147536
---


Ship it!




Ship It!

- Sid Wagle


On Sept. 1, 2016, 3:51 a.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51562/
> ---
> 
> (Updated Sept. 1, 2016, 3:51 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18289
> https://issues.apache.org/jira/browse/AMBARI-18289
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> Negative values are being reported for IOPS in the "system servers" dashboard
> 
> BUG
> This was a dockerized environment. Negative rate values were seen because 
> read/write counters were dropping below the previous values at random times. 
> On further investigation, it revealed that this was due to the docker volume 
> groups present on the host. It is expected of docker containers to add/remove 
> the volume groups during the lifecyle of a container. So, when a volume group 
> goes away, the read/write counters do not contribute to the total counter 
> values, thus making the value go below the last seen value.
> 
> FIX
> Have a provision to discard such "special" disk partitions through a skip 
> pattern. If skipped, they will not contribute to the global counter metric. 
> Individual disk counter metrics can be used to get disk specific counter 
> values.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> 3e5d861 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  02f0ce3 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py
>  845b270 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4135d32 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  2503c43 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  383a0de 
> 
> Diff: https://reviews.apache.org/r/51562/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

2016-08-31 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51562/
---

(Updated Sept. 1, 2016, 3:51 a.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18289
https://issues.apache.org/jira/browse/AMBARI-18289


Repository: ambari


Description
---

PROBLEM
Negative values are being reported for IOPS in the "system servers" dashboard

BUG
This was a dockerized environment. Negative rate values were seen because 
read/write counters were dropping below the previous values at random times. On 
further investigation, it revealed that this was due to the docker volume 
groups present on the host. It is expected of docker containers to add/remove 
the volume groups during the lifecyle of a container. So, when a volume group 
goes away, the read/write counters do not contribute to the total counter 
values, thus making the value go below the last seen value.

FIX
Have a provision to discard such "special" disk partitions through a skip 
pattern. If skipped, they will not contribute to the global counter metric. 
Individual disk counter metrics can be used to get disk specific counter values.


Diffs (updated)
-

  ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
3e5d861 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 02f0ce3 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 
845b270 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
 4135d32 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 2503c43 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 383a0de 

Diff: https://reviews.apache.org/r/51562/diff/


Testing
---

Manually tested.


Thanks,

Aravindan Vijayan

Re: Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

2016-08-31 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51562/#review147528
---




ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 
(line 261)


Shouldn't we return from here?


- Sid Wagle


On Aug. 31, 2016, 11:41 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51562/
> ---
> 
> (Updated Aug. 31, 2016, 11:41 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18289
> https://issues.apache.org/jira/browse/AMBARI-18289
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> Negative values are being reported for IOPS in the "system servers" dashboard
> 
> BUG
> This was a dockerized environment. Negative rate values were seen because 
> read/write counters were dropping below the previous values at random times. 
> On further investigation, it revealed that this was due to the docker volume 
> groups present on the host. It is expected of docker containers to add/remove 
> the volume groups during the lifecyle of a container. So, when a volume group 
> goes away, the read/write counters do not contribute to the total counter 
> values, thus making the value go below the last seen value.
> 
> FIX
> Have a provision to discard such "special" disk partitions through a skip 
> pattern. If skipped, they will not contribute to the global counter metric. 
> Individual disk counter metrics can be used to get disk specific counter 
> values.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> 3e5d861 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  02f0ce3 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py
>  845b270 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4135d32 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  2503c43 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  383a0de 
> 
> Diff: https://reviews.apache.org/r/51562/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

2016-08-31 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51562/
---

(Updated Aug. 31, 2016, 11:41 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18289
https://issues.apache.org/jira/browse/AMBARI-18289


Repository: ambari


Description
---

PROBLEM
Negative values are being reported for IOPS in the "system servers" dashboard

BUG
This was a dockerized environment. Negative rate values were seen because 
read/write counters were dropping below the previous values at random times. On 
further investigation, it revealed that this was due to the docker volume 
groups present on the host. It is expected of docker containers to add/remove 
the volume groups during the lifecyle of a container. So, when a volume group 
goes away, the read/write counters do not contribute to the total counter 
values, thus making the value go below the last seen value.

FIX
Have a provision to discard such "special" disk partitions through a skip 
pattern. If skipped, they will not contribute to the global counter metric. 
Individual disk counter metrics can be used to get disk specific counter values.


Diffs (updated)
-

  ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
3e5d861 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 02f0ce3 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 
845b270 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
 4135d32 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 2503c43 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 383a0de 

Diff: https://reviews.apache.org/r/51562/diff/


Testing
---

Manually tested.


Thanks,

Aravindan Vijayan

Re: Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

2016-08-31 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51562/#review147467
---




ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 
(line 260)


This will break a long running process, this should log as error but not 
result in a pkill.



ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 
(line 262)


How about inversion of control here? Store allowed values as a dict and 
check against it? If not in allowed values then check pattern and either add to 
allowed or not.



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
 (line 84)


Sink interval should also be in ams-env instead of ams-site.


- Sid Wagle


On Aug. 31, 2016, 6:49 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51562/
> ---
> 
> (Updated Aug. 31, 2016, 6:49 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18289
> https://issues.apache.org/jira/browse/AMBARI-18289
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM
> Negative values are being reported for IOPS in the "system servers" dashboard
> 
> BUG
> This was a dockerized environment. Negative rate values were seen because 
> read/write counters were dropping below the previous values at random times. 
> On further investigation, it revealed that this was due to the docker volume 
> groups present on the host. It is expected of docker containers to add/remove 
> the volume groups during the lifecyle of a container. So, when a volume group 
> goes away, the read/write counters do not contribute to the total counter 
> values, thus making the value go below the last seen value.
> 
> FIX
> Have a provision to discard such "special" disk partitions through a skip 
> pattern. If skipped, they will not contribute to the global counter metric. 
> Individual disk counter metrics can be used to get disk specific counter 
> values.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> 3e5d861 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  02f0ce3 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py
>  845b270 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4135d32 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  2503c43 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  383a0de 
> 
> Diff: https://reviews.apache.org/r/51562/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Review Request 51562: AMBARI-18289 : Invalid negative values for some AMS metrics

2016-08-31 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51562/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18289
https://issues.apache.org/jira/browse/AMBARI-18289


Repository: ambari


Description
---

PROBLEM
Negative values are being reported for IOPS in the "system servers" dashboard

BUG
This was a dockerized environment. Negative rate values were seen because 
read/write counters were dropping below the previous values at random times. On 
further investigation, it revealed that this was due to the docker volume 
groups present on the host. It is expected of docker containers to add/remove 
the volume groups during the lifecyle of a container. So, when a volume group 
goes away, the read/write counters do not contribute to the total counter 
values, thus making the value go below the last seen value.

FIX
Have a provision to discard such "special" disk partitions through a skip 
pattern. If skipped, they will not contribute to the global counter metric. 
Individual disk counter metrics can be used to get disk specific counter values.


Diffs
-

  ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
3e5d861 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 02f0ce3 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 
845b270 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
 4135d32 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 2503c43 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 383a0de 

Diff: https://reviews.apache.org/r/51562/diff/


Testing
---

Manually tested.


Thanks,

Aravindan Vijayan