Re: Review Request 51579: Database Consistency Check Fails With NPE With Missing Service From Stack

2016-09-02 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51579/#review147690
---


Ship it!




Ship It!

- Sumit Mohanty


On Sept. 2, 2016, 4:24 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51579/
> ---
> 
> (Updated Sept. 2, 2016, 4:24 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18296
> https://issues.apache.org/jira/browse/AMBARI-18296
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The database consistency checker can fail if a service configuration exists 
> for a service which is no longer on the current stack:
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  36a2d99 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  a7c77e1 
> 
> Diff: https://reviews.apache.org/r/51579/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51579: Database Consistency Check Fails With NPE With Missing Service From Stack

2016-09-02 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51579/#review147676
---




ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 543)


Does it cover both the scenarios:
* service missing in definiton
* orphaned row in serviceconfig table


- Sumit Mohanty


On Sept. 2, 2016, 4:24 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51579/
> ---
> 
> (Updated Sept. 2, 2016, 4:24 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18296
> https://issues.apache.org/jira/browse/AMBARI-18296
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The database consistency checker can fail if a service configuration exists 
> for a service which is no longer on the current stack:
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  36a2d99 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  a7c77e1 
> 
> Diff: https://reviews.apache.org/r/51579/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 51579: Database Consistency Check Fails With NPE With Missing Service From Stack

2016-09-02 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51579/
---

(Updated Вер. 2, 2016, 4:24 після полудня)


Review request for Ambari, Jonathan Hurley and Sumit Mohanty.


Bugs: AMBARI-18296
https://issues.apache.org/jira/browse/AMBARI-18296


Repository: ambari


Description
---

The database consistency checker can fail if a service configuration exists for 
a service which is no longer on the current stack:


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 36a2d99 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 a7c77e1 

Diff: https://reviews.apache.org/r/51579/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 51579: Database Consistency Check Fails With NPE With Missing Service From Stack

2016-09-02 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51579/#review147659
---




ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 549)


I don't think that this situation should prevent Ambari from starting up, 
however I do think we should at least log it.


- Jonathan Hurley


On Sept. 1, 2016, 3:05 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51579/
> ---
> 
> (Updated Sept. 1, 2016, 3:05 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18296
> https://issues.apache.org/jira/browse/AMBARI-18296
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The database consistency checker can fail if a service configuration exists 
> for a service which is no longer on the current stack:
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  9f7419c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  d8f538e 
> 
> Diff: https://reviews.apache.org/r/51579/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 51579: Database Consistency Check Fails With NPE With Missing Service From Stack

2016-09-01 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51579/
---

Review request for Ambari, Jonathan Hurley and Sumit Mohanty.


Bugs: AMBARI-18296
https://issues.apache.org/jira/browse/AMBARI-18296


Repository: ambari


Description
---

The database consistency checker can fail if a service configuration exists for 
a service which is no longer on the current stack:


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 9f7419c 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 d8f538e 

Diff: https://reviews.apache.org/r/51579/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi