Re: Review Request 51588: AMBARI-18299: Support open files ulimit for ambari-agent

2016-09-06 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51588/#review147862
---


Ship it!




Ship It!

- Sumit Mohanty


On Sept. 1, 2016, 11:25 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51588/
> ---
> 
> (Updated Sept. 1, 2016, 11:25 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18299
> https://issues.apache.org/jira/browse/AMBARI-18299
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18299: Support open files ulimit for ambari-agent
> 
> ** Fix **: Added ulimit.open.files property to ambari-agent.ini.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 
> ae938dcd2a94a01fbff0c6412a95910bddf210d7 
>   ambari-agent/src/main/python/ambari_agent/main.py 
> d7864b3bfb24b0f0f671686b2ec506708c16bd8c 
>   ambari-agent/src/test/python/ambari_agent/TestAmbariConfig.py 
> 78f29fe019e59eea8444d5326246822653e732ec 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 
> 23cdb13d2d6ec9c6a0343fceb50d2f917eae02e0 
> 
> Diff: https://reviews.apache.org/r/51588/diff/
> 
> 
> Testing
> ---
> 
> Deployed a VM with the changes and tested manually by providing a value for 
> ulimit.open.files and verified that the limit was set. If the property is not 
> present, no action is taken.
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>



Review Request 51588: AMBARI-18299: Support open files ulimit for ambari-agent

2016-09-01 Thread Nahappan Somasundaram

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51588/
---

Review request for Ambari, Jonathan Hurley and Sumit Mohanty.


Bugs: AMBARI-18299
https://issues.apache.org/jira/browse/AMBARI-18299


Repository: ambari


Description
---

AMBARI-18299: Support open files ulimit for ambari-agent

** Fix **: Added ulimit.open.files property to ambari-agent.ini.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 
ae938dcd2a94a01fbff0c6412a95910bddf210d7 
  ambari-agent/src/main/python/ambari_agent/main.py 
d7864b3bfb24b0f0f671686b2ec506708c16bd8c 
  ambari-agent/src/test/python/ambari_agent/TestAmbariConfig.py 
78f29fe019e59eea8444d5326246822653e732ec 
  ambari-agent/src/test/python/ambari_agent/TestMain.py 
23cdb13d2d6ec9c6a0343fceb50d2f917eae02e0 

Diff: https://reviews.apache.org/r/51588/diff/


Testing
---

Deployed a VM with the changes and tested manually by providing a value for 
ulimit.open.files and verified that the limit was set. If the property is not 
present, no action is taken.


Thanks,

Nahappan Somasundaram