Re: Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env

2016-10-05 Thread Mugdha Varadkar 


> On Oct. 5, 2016, 5:10 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java,
> >  line 171
> > 
> >
> > You can set this to null and use StringUtils.isBlank() check

Updated in latest patch


> On Oct. 5, 2016, 5:10 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java,
> >  line 186
> > 
> >
> > StringUtils.isBlank()

Updated in latest patch


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52504/#review151518
---


On Oct. 6, 2016, 5:57 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52504/
> ---
> 
> (Updated Oct. 6, 2016, 5:57 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18521
> https://issues.apache.org/jira/browse/AMBARI-18521
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack changes required while upgrading to stack 2.5 in secure env
> - Remove adding spnego principal value to 
> ranger-admin-site/ranger.spnego.kerberos.principal
> - Get storm principal bare name and update it accordingly to 
> ranger-admin-site.xml/ranger.plugins.storm.serviceuser
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
>  c3d71c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculationTest.java
>  133a9e3 
> 
> Diff: https://reviews.apache.org/r/52504/diff/
> 
> 
> Testing
> ---
> 
> mvn -DskipPythonTests -Dtest=RangerKerberosConfigCalculationTest test
> ---
>  T E S T S
> ---
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; 
> support was removed in 8.0
> Running 
> org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.359 sec - 
> in 
> org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest
> 
> Results :
> 
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 47.998 s
> [INFO] Finished at: 2016-10-04T06:15:35+00:00
> [INFO] Final Memory: 67M/1203M
> [INFO] 
> 
> 
> 
> Tested Ranger EU from 2.4 to 2.5 stack in secure env on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env

2016-10-05 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52504/
---

(Updated Oct. 6, 2016, 5:57 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, 
and Velmurugan Periasamy.


Bugs: AMBARI-18521
https://issues.apache.org/jira/browse/AMBARI-18521


Repository: ambari


Description
---

Stack changes required while upgrading to stack 2.5 in secure env
- Remove adding spnego principal value to 
ranger-admin-site/ranger.spnego.kerberos.principal
- Get storm principal bare name and update it accordingly to 
ranger-admin-site.xml/ranger.plugins.storm.serviceuser


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
 c3d71c0 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculationTest.java
 133a9e3 

Diff: https://reviews.apache.org/r/52504/diff/


Testing
---

mvn -DskipPythonTests -Dtest=RangerKerberosConfigCalculationTest test
---
 T E S T S
---
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; 
support was removed in 8.0
Running 
org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.359 sec - in 
org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 47.998 s
[INFO] Finished at: 2016-10-04T06:15:35+00:00
[INFO] Final Memory: 67M/1203M
[INFO] 


Tested Ranger EU from 2.4 to 2.5 stack in secure env on centos6


Thanks,

Mugdha Varadkar

Re: Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env

2016-10-05 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52504/#review151518
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
 (line 170)


You can set this to null and use StringUtils.isBlank() check



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
 (line 185)


StringUtils.isBlank()


- Jonathan Hurley


On Oct. 4, 2016, 4:38 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52504/
> ---
> 
> (Updated Oct. 4, 2016, 4:38 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18521
> https://issues.apache.org/jira/browse/AMBARI-18521
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack changes required while upgrading to stack 2.5 in secure env
> - Remove adding spnego principal value to 
> ranger-admin-site/ranger.spnego.kerberos.principal
> - Get storm principal bare name and update it accordingly to 
> ranger-admin-site.xml/ranger.plugins.storm.serviceuser
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
>  c3d71c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculationTest.java
>  133a9e3 
> 
> Diff: https://reviews.apache.org/r/52504/diff/
> 
> 
> Testing
> ---
> 
> mvn -DskipPythonTests -Dtest=RangerKerberosConfigCalculationTest test
> ---
>  T E S T S
> ---
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; 
> support was removed in 8.0
> Running 
> org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.359 sec - 
> in 
> org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest
> 
> Results :
> 
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 47.998 s
> [INFO] Finished at: 2016-10-04T06:15:35+00:00
> [INFO] Final Memory: 67M/1203M
> [INFO] 
> 
> 
> 
> Tested Ranger EU from 2.4 to 2.5 stack in secure env on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env

2016-10-04 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52504/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, 
and Velmurugan Periasamy.


Bugs: AMBARI-18521
https://issues.apache.org/jira/browse/AMBARI-18521


Repository: ambari


Description
---

Stack changes required while upgrading to stack 2.5 in secure env
- Remove adding spnego principal value to 
ranger-admin-site/ranger.spnego.kerberos.principal
- Get storm principal bare name and update it accordingly to 
ranger-admin-site.xml/ranger.plugins.storm.serviceuser


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
 c3d71c0 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculationTest.java
 133a9e3 

Diff: https://reviews.apache.org/r/52504/diff/


Testing
---

mvn -DskipPythonTests -Dtest=RangerKerberosConfigCalculationTest test
---
 T E S T S
---
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; 
support was removed in 8.0
Running 
org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.359 sec - in 
org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 47.998 s
[INFO] Finished at: 2016-10-04T06:15:35+00:00
[INFO] Final Memory: 67M/1203M
[INFO] 


Tested Ranger EU from 2.4 to 2.5 stack in secure env on centos6


Thanks,

Mugdha Varadkar