Re: Review Request 52654: At "Add Service Wizard", when the installation is going on, if I click the close (X) on the wizard, the service will only get INSTALLED not STARTED.

2016-10-10 Thread Zhe (Joe) Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52654/#review152075
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On Oct. 7, 2016, 10:14 p.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52654/
> ---
> 
> (Updated Oct. 7, 2016, 10:14 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi 
> Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18559
> https://issues.apache.org/jira/browse/AMBARI-18559
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Typically being in "Add Service Wizard", user expects the INSTALL and START 
> of sevices components.
> - However, if user clicks on the close (X) on the wizard, the service will 
> only get INSTALLED not STARTED.
> 
> - Either apprising the user that only INSTALL will take place and START will 
> be skipped will help OR even if the  close (X) on the wizard is hit, context 
> for START is still maintained.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js 5eafad2 
>   ambari-web/app/routes/add_service_routes.js 30c8e07 
> 
> Diff: https://reviews.apache.org/r/52654/diff/
> 
> 
> Testing
> ---
> 
> Verified Manually.
> Ambari-web unit tests pass.
> 30374 tests complete (26 seconds)
> 151 tests pending
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>

Review Request 52654: At "Add Service Wizard", when the installation is going on, if I click the close (X) on the wizard, the service will only get INSTALLED not STARTED.

2016-10-07 Thread Vivek Ratnavel Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52654/
---

Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi Wang, 
and Yusaku Sako.


Bugs: AMBARI-18559
https://issues.apache.org/jira/browse/AMBARI-18559


Repository: ambari


Description
---

- Typically being in "Add Service Wizard", user expects the INSTALL and START 
of sevices components.
- However, if user clicks on the close (X) on the wizard, the service will only 
get INSTALLED not STARTED.

- Either apprising the user that only INSTALL will take place and START will be 
skipped will help OR even if the  close (X) on the wizard is hit, context for 
START is still maintained.


Diffs
-

  ambari-web/app/messages.js 5eafad2 
  ambari-web/app/routes/add_service_routes.js 30c8e07 

Diff: https://reviews.apache.org/r/52654/diff/


Testing
---

Verified Manually.
Ambari-web unit tests pass.
30374 tests complete (26 seconds)
151 tests pending


Thanks,

Vivek Ratnavel Subramanian