Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-26 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/
---

(Updated Oct. 26, 2016, 6:51 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

merged with latest 2.5


Bugs: AMBARI-18651
https://issues.apache.org/jira/browse/AMBARI-18651


Repository: ambari


Description
---

Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, the 
metainfo for ZKFC used {{false}}.  It 
was recently discovered that 2.5.0.0-1154+ has added this capability.

* Change versionAdvertised
* Add code to ZKFC python to hdp-select.  This code MUST check the 
stack_feature to ensure that it is executed ONLY for HDP-2.5+


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 1396bd8 
  ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
912c441 
  
ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 87247eb 
  
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java
 5b32c4e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 a07d0e6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 f91a958 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 f383e80 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 aa0ab0f 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 dbde58b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
a3e4a64 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
 d22622e 

Diff: https://reviews.apache.org/r/53066/diff/


Testing
---

few runs on live cluster

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-26 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/#review153882
---


Ship it!




Ship It!

- Nate Cole


On Oct. 25, 2016, 12:21 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53066/
> ---
> 
> (Updated Oct. 25, 2016, 12:21 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-18651
> https://issues.apache.org/jira/browse/AMBARI-18651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, 
> the metainfo for ZKFC used {{false}}.  
> It was recently discovered that 2.5.0.0-1154+ has added this capability.
> 
> * Change versionAdvertised
> * Add code to ZKFC python to hdp-select.  This code MUST check the 
> stack_feature to ensure that it is executed ONLY for HDP-2.5+
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  1396bd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> 912c441 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java
>  5b32c4e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a07d0e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
>  983cbdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  3e805a0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  aa0ab0f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  dbde58b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
> a3e4a64 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java
>  3479334 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
>  18e2d3f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
>  d22622e 
> 
> Diff: https://reviews.apache.org/r/53066/diff/
> 
> 
> Testing
> ---
> 
> few runs on live cluster
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-25 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/
---

(Updated Oct. 25, 2016, 7:21 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

Added javadoc


Bugs: AMBARI-18651
https://issues.apache.org/jira/browse/AMBARI-18651


Repository: ambari


Description
---

Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, the 
metainfo for ZKFC used {{false}}.  It 
was recently discovered that 2.5.0.0-1154+ has added this capability.

* Change versionAdvertised
* Add code to ZKFC python to hdp-select.  This code MUST check the 
stack_feature to ensure that it is executed ONLY for HDP-2.5+


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 1396bd8 
  ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
912c441 
  
ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 87247eb 
  
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java
 5b32c4e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 a07d0e6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 983cbdf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 3e805a0 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 aa0ab0f 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 dbde58b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
a3e4a64 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java
 3479334 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
 18e2d3f 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
 d22622e 

Diff: https://reviews.apache.org/r/53066/diff/


Testing
---

few runs on live cluster

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-25 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/#review153801
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 (line 146)


Some JavaDoc here.


- Jonathan Hurley


On Oct. 25, 2016, 11:38 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53066/
> ---
> 
> (Updated Oct. 25, 2016, 11:38 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-18651
> https://issues.apache.org/jira/browse/AMBARI-18651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, 
> the metainfo for ZKFC used {{false}}.  
> It was recently discovered that 2.5.0.0-1154+ has added this capability.
> 
> * Change versionAdvertised
> * Add code to ZKFC python to hdp-select.  This code MUST check the 
> stack_feature to ensure that it is executed ONLY for HDP-2.5+
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  1396bd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> 912c441 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java
>  5b32c4e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a07d0e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
>  983cbdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  3e805a0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  aa0ab0f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  dbde58b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
> a3e4a64 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java
>  3479334 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
>  18e2d3f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
>  d22622e 
> 
> Diff: https://reviews.apache.org/r/53066/diff/
> 
> 
> Testing
> ---
> 
> few runs on live cluster
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-25 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/
---

(Updated Oct. 25, 2016, 6:38 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

Fixed review comments and unit tests


Bugs: AMBARI-18651
https://issues.apache.org/jira/browse/AMBARI-18651


Repository: ambari


Description
---

Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, the 
metainfo for ZKFC used {{false}}.  It 
was recently discovered that 2.5.0.0-1154+ has added this capability.

* Change versionAdvertised
* Add code to ZKFC python to hdp-select.  This code MUST check the 
stack_feature to ensure that it is executed ONLY for HDP-2.5+


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 1396bd8 
  ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
912c441 
  
ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 87247eb 
  
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java
 5b32c4e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 a07d0e6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 983cbdf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 3e805a0 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 aa0ab0f 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 dbde58b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
a3e4a64 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java
 3479334 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
 18e2d3f 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
 d22622e 

Diff: https://reviews.apache.org/r/53066/diff/


Testing
---

few runs on live cluster

unit tests are being added


Thanks,

Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-25 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/
---

(Updated Oct. 25, 2016, 6:38 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-18651
https://issues.apache.org/jira/browse/AMBARI-18651


Repository: ambari


Description
---

Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, the 
metainfo for ZKFC used {{false}}.  It 
was recently discovered that 2.5.0.0-1154+ has added this capability.

* Change versionAdvertised
* Add code to ZKFC python to hdp-select.  This code MUST check the 
stack_feature to ensure that it is executed ONLY for HDP-2.5+


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 1396bd8 
  ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
912c441 
  
ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 87247eb 
  
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java
 5b32c4e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 a07d0e6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 983cbdf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 3e805a0 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 aa0ab0f 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 dbde58b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
a3e4a64 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java
 3479334 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
 18e2d3f 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
 d22622e 

Diff: https://reviews.apache.org/r/53066/diff/


Testing (updated)
---

few runs on live cluster

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-24 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/#review153710
---




ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java
 (line 22)


The stack upgrade being finished should be its own event derived from 
ClusterEvent directly; doesn't make sense to make it a version change event 
since it's not based on components changing versions explicitely.



ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
 (line 74)


When checking versions, you can just use the enum AmbariEventType instead 
of instanceof.

However, in this case since you're returning if it's not an instance of the 
event, why not just listen for the StackUpgradeFinishEvent directly?



ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 (lines 92 - 96)


Same as above comment - why listen for a broader event, check instance 
type, and then return when you could just listen for the concrete event you 
care about?


- Jonathan Hurley


On Oct. 24, 2016, 12:35 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53066/
> ---
> 
> (Updated Oct. 24, 2016, 12:35 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-18651
> https://issues.apache.org/jira/browse/AMBARI-18651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, 
> the metainfo for ZKFC used {{false}}.  
> It was recently discovered that 2.5.0.0-1154+ has added this capability.
> 
> * Change versionAdvertised
> * Add code to ZKFC python to hdp-select.  This code MUST check the 
> stack_feature to ensure that it is executed ONLY for HDP-2.5+
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  1396bd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ChangeVersionEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionAdvertisedEvent.java
>  d40aade 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java
>  5b32c4e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a07d0e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
>  983cbdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  3e805a0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  aa0ab0f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  dbde58b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
> a3e4a64 
> 
> Diff: https://reviews.apache.org/r/53066/diff/
> 
> 
> Testing
> ---
> 
> few runs on live cluster
> 
> unit tests are being added
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-24 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/
---

(Updated Oct. 24, 2016, 7:35 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-18651
https://issues.apache.org/jira/browse/AMBARI-18651


Repository: ambari


Description
---

Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, the 
metainfo for ZKFC used {{false}}.  It 
was recently discovered that 2.5.0.0-1154+ has added this capability.

* Change versionAdvertised
* Add code to ZKFC python to hdp-select.  This code MUST check the 
stack_feature to ensure that it is executed ONLY for HDP-2.5+


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 1396bd8 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ChangeVersionEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionAdvertisedEvent.java
 d40aade 
  
ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 87247eb 
  
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java
 5b32c4e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 a07d0e6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 983cbdf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 3e805a0 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 aa0ab0f 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 dbde58b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
a3e4a64 

Diff: https://reviews.apache.org/r/53066/diff/


Testing (updated)
---

few runs on live cluster

unit tests are being added


Thanks,

Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-24 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/
---

(Updated Oct. 24, 2016, 7:34 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-18651
https://issues.apache.org/jira/browse/AMBARI-18651


Repository: ambari


Description
---

Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, the 
metainfo for ZKFC used {{false}}.  It 
was recently discovered that 2.5.0.0-1154+ has added this capability.

* Change versionAdvertised
* Add code to ZKFC python to hdp-select.  This code MUST check the 
stack_feature to ensure that it is executed ONLY for HDP-2.5+


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 1396bd8 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ChangeVersionEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionAdvertisedEvent.java
 d40aade 
  
ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 87247eb 
  
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java
 5b32c4e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 a07d0e6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 983cbdf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 3e805a0 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 aa0ab0f 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 dbde58b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
a3e4a64 

Diff: https://reviews.apache.org/r/53066/diff/


Testing
---

few runs on live cluster


Thanks,

Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-24 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/
---

(Updated Oct. 24, 2016, 7:30 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

New patch draft


Bugs: AMBARI-18651
https://issues.apache.org/jira/browse/AMBARI-18651


Repository: ambari


Description
---

Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, the 
metainfo for ZKFC used {{false}}.  It 
was recently discovered that 2.5.0.0-1154+ has added this capability.

* Change versionAdvertised
* Add code to ZKFC python to hdp-select.  This code MUST check the 
stack_feature to ensure that it is executed ONLY for HDP-2.5+


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 1396bd8 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ChangeVersionEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionAdvertisedEvent.java
 d40aade 
  
ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 87247eb 
  
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java
 5b32c4e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 a07d0e6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 983cbdf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 3e805a0 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 aa0ab0f 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 dbde58b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
a3e4a64 

Diff: https://reviews.apache.org/r/53066/diff/


Testing
---

few runs on live cluster


Thanks,

Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-20 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/#review153439
---




ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 (line 112)


Please add some javadoc for how this is supposed to be used.



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 (line 48)


This should use the stack_features.json file
since this python file is shared with older stacks.


- Alejandro Fernandez


On Oct. 20, 2016, 4:26 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53066/
> ---
> 
> (Updated Oct. 20, 2016, 4:26 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-18651
> https://issues.apache.org/jira/browse/AMBARI-18651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, 
> the metainfo for ZKFC used {{false}}.  
> It was recently discovered that 2.5.0.0-1154+ has added this capability.
> 
> * Change versionAdvertised
> * Add code to ZKFC python to hdp-select.  This code MUST check the 
> stack_feature to ensure that it is executed ONLY for HDP-2.5+
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a07d0e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
>  983cbdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  3e805a0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  aa0ab0f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
> a3e4a64 
> 
> Diff: https://reviews.apache.org/r/53066/diff/
> 
> 
> Testing
> ---
> 
> few runs on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-20 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/#review153424
---




ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 (lines 72 - 75)


Don't do this; instead use a Provider



ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 (line 152)


Make this a little easier and just return if the string is blank - no need 
to indent the entire method.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 (lines 304 - 308)


Should we have an event for this to make it more de-coupled? A 
StackUpgradeCompletedEvent ?

This way, the code here and down below gets centralized in a listener and 
you only need to fire the event.



ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 (line 108)


JavaDoc.



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 (lines 46 - 47)


I don't think this is needed



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 (line 48)


no need to check params.version - the compare_versions does that for you.



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 (line 49)


Remove.



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 (line 199)


No need to check params.version - compare_versions does that already


- Jonathan Hurley


On Oct. 20, 2016, 12:26 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53066/
> ---
> 
> (Updated Oct. 20, 2016, 12:26 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-18651
> https://issues.apache.org/jira/browse/AMBARI-18651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, 
> the metainfo for ZKFC used {{false}}.  
> It was recently discovered that 2.5.0.0-1154+ has added this capability.
> 
> * Change versionAdvertised
> * Add code to ZKFC python to hdp-select.  This code MUST check the 
> stack_feature to ensure that it is executed ONLY for HDP-2.5+
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a07d0e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
>  983cbdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  3e805a0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  aa0ab0f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
> a3e4a64 
> 
> Diff: https://reviews.apache.org/r/53066/diff/
> 
> 
> Testing
> ---
> 
> few runs on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-20 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/#review153418
---


Ship it!





ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 (line 200)


No need to check params.version again.


- Nate Cole


On Oct. 20, 2016, 12:26 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53066/
> ---
> 
> (Updated Oct. 20, 2016, 12:26 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-18651
> https://issues.apache.org/jira/browse/AMBARI-18651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, 
> the metainfo for ZKFC used {{false}}.  
> It was recently discovered that 2.5.0.0-1154+ has added this capability.
> 
> * Change versionAdvertised
> * Add code to ZKFC python to hdp-select.  This code MUST check the 
> stack_feature to ensure that it is executed ONLY for HDP-2.5+
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a07d0e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
>  983cbdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  3e805a0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  aa0ab0f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
> a3e4a64 
> 
> Diff: https://reviews.apache.org/r/53066/diff/
> 
> 
> Testing
> ---
> 
> few runs on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-20 Thread Dmitro Lisnichenko 


> On Oct. 20, 2016, 7:25 p.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java,
> >  line 127
> > 
> >
> > ComponentInfo refers to previous stack version during upgrade (and was 
> > never reloaded before this patch)

that's why I have to extract it from stack metainfo


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/#review153410
---


On Oct. 20, 2016, 7:26 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53066/
> ---
> 
> (Updated Oct. 20, 2016, 7:26 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-18651
> https://issues.apache.org/jira/browse/AMBARI-18651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, 
> the metainfo for ZKFC used {{false}}.  
> It was recently discovered that 2.5.0.0-1154+ has added this capability.
> 
> * Change versionAdvertised
> * Add code to ZKFC python to hdp-select.  This code MUST check the 
> stack_feature to ensure that it is executed ONLY for HDP-2.5+
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a07d0e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
>  983cbdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  3e805a0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  aa0ab0f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
> a3e4a64 
> 
> Diff: https://reviews.apache.org/r/53066/diff/
> 
> 
> Testing
> ---
> 
> few runs on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-20 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/
---

(Updated Oct. 20, 2016, 7:26 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-18651
https://issues.apache.org/jira/browse/AMBARI-18651


Repository: ambari


Description
---

Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, the 
metainfo for ZKFC used {{false}}.  It 
was recently discovered that 2.5.0.0-1154+ has added this capability.

* Change versionAdvertised
* Add code to ZKFC python to hdp-select.  This code MUST check the 
stack_feature to ensure that it is executed ONLY for HDP-2.5+


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 87247eb 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 a07d0e6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 983cbdf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 3e805a0 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 aa0ab0f 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
a3e4a64 

Diff: https://reviews.apache.org/r/53066/diff/


Testing
---

few runs on live cluster


Thanks,

Dmitro Lisnichenko

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-20 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/#review153410
---




ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 (line 127)


ComponentInfo refers to previous stack version during upgrade (and was 
never reloaded before this patch)


- Dmitro Lisnichenko


On Oct. 20, 2016, 7:24 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53066/
> ---
> 
> (Updated Oct. 20, 2016, 7:24 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-18651
> https://issues.apache.org/jira/browse/AMBARI-18651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, 
> the metainfo for ZKFC used {{false}}.  
> It was recently discovered that 2.5.0.0-1154+ has added this capability.
> 
> * Change versionAdvertised
> * Add code to ZKFC python to hdp-select.  This code MUST check the 
> stack_feature to ensure that it is executed ONLY for HDP-2.5+
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a07d0e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
>  983cbdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  3e805a0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  aa0ab0f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
> a3e4a64 
> 
> Diff: https://reviews.apache.org/r/53066/diff/
> 
> 
> Testing
> ---
> 
> few runs on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-20 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/
---

(Updated Oct. 20, 2016, 7:24 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-18651
https://issues.apache.org/jira/browse/AMBARI-18651


Repository: ambari


Description
---

Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, the 
metainfo for ZKFC used {{false}}.  It 
was recently discovered that 2.5.0.0-1154+ has added this capability.

* Change versionAdvertised
* Add code to ZKFC python to hdp-select.  This code MUST check the 
stack_feature to ensure that it is executed ONLY for HDP-2.5+


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 87247eb 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 a07d0e6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 983cbdf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 3e805a0 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 aa0ab0f 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
a3e4a64 

Diff: https://reviews.apache.org/r/53066/diff/


Testing (updated)
---

few runs on live cluster


Thanks,

Dmitro Lisnichenko

Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

2016-10-20 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-18651
https://issues.apache.org/jira/browse/AMBARI-18651


Repository: ambari


Description
---

Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, the 
metainfo for ZKFC used {{false}}.  It 
was recently discovered that 2.5.0.0-1154+ has added this capability.

* Change versionAdvertised
* Add code to ZKFC python to hdp-select.  This code MUST check the 
stack_feature to ensure that it is executed ONLY for HDP-2.5+


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 87247eb 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 a07d0e6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 983cbdf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 3e805a0 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 aa0ab0f 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
a3e4a64 

Diff: https://reviews.apache.org/r/53066/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko