Re: Review Request 53914: Perf: Fix bugs in deploy-gce-perf-cluster.py to generate correct config file

2016-11-21 Thread Vitalyi Brodetskyi


> On Лис. 21, 2016, 8:13 до полудня, Dmitro Lisnichenko wrote:
> > contrib/utils/perf/deploy-gce-perf-cluster.py, line 227
> > 
> >
> > why do we need this sleep?

because we are not able to ssh to cluster hosts immediately


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53914/#review156445
---


On Лис. 19, 2016, 12:12 до полудня, Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53914/
> ---
> 
> (Updated Лис. 19, 2016, 12:12 до полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Sumit Mohanty, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18940
> https://issues.apache.org/jira/browse/AMBARI-18940
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The script to create VMs on GCE for the perf cluster has a bug where each VM 
> will have the exact same agent-multiplier config file with start=1 and 
> num=50, thereby preventing more than 50 agents.
> This is because a single server.sh and agent.sh file is written out, and 
> copied to all VMs.
> We need to create a custom config file for each VM instead.
> 
> 
> Diffs
> -
> 
>   contrib/utils/perf/deploy-gce-perf-cluster.py da45f8f 
> 
> Diff: https://reviews.apache.org/r/53914/diff/
> 
> 
> Testing
> ---
> 
> Verified by deploying a cluster to GCE.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>



Re: Review Request 53914: Perf: Fix bugs in deploy-gce-perf-cluster.py to generate correct config file

2016-11-21 Thread Dmitro Lisnichenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53914/#review156445
---


Fix it, then Ship it!





contrib/utils/perf/deploy-gce-perf-cluster.py (line 220)


why do we need this sleep?


- Dmitro Lisnichenko


On Nov. 19, 2016, 2:12 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53914/
> ---
> 
> (Updated Nov. 19, 2016, 2:12 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Sumit Mohanty, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18940
> https://issues.apache.org/jira/browse/AMBARI-18940
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The script to create VMs on GCE for the perf cluster has a bug where each VM 
> will have the exact same agent-multiplier config file with start=1 and 
> num=50, thereby preventing more than 50 agents.
> This is because a single server.sh and agent.sh file is written out, and 
> copied to all VMs.
> We need to create a custom config file for each VM instead.
> 
> 
> Diffs
> -
> 
>   contrib/utils/perf/deploy-gce-perf-cluster.py da45f8f 
> 
> Diff: https://reviews.apache.org/r/53914/diff/
> 
> 
> Testing
> ---
> 
> Verified by deploying a cluster to GCE.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>



Re: Review Request 53914: Perf: Fix bugs in deploy-gce-perf-cluster.py to generate correct config file

2016-11-19 Thread Vitalyi Brodetskyi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53914/#review156411
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Лис. 19, 2016, 12:12 до полудня, Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53914/
> ---
> 
> (Updated Лис. 19, 2016, 12:12 до полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Sumit Mohanty, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18940
> https://issues.apache.org/jira/browse/AMBARI-18940
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The script to create VMs on GCE for the perf cluster has a bug where each VM 
> will have the exact same agent-multiplier config file with start=1 and 
> num=50, thereby preventing more than 50 agents.
> This is because a single server.sh and agent.sh file is written out, and 
> copied to all VMs.
> We need to create a custom config file for each VM instead.
> 
> 
> Diffs
> -
> 
>   contrib/utils/perf/deploy-gce-perf-cluster.py da45f8f 
> 
> Diff: https://reviews.apache.org/r/53914/diff/
> 
> 
> Testing
> ---
> 
> Verified by deploying a cluster to GCE.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>



Re: Review Request 53914: Perf: Fix bugs in deploy-gce-perf-cluster.py to generate correct config file

2016-11-18 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53914/#review156380
---


Ship it!




Ship It!

- Sumit Mohanty


On Nov. 19, 2016, 12:12 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53914/
> ---
> 
> (Updated Nov. 19, 2016, 12:12 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Sumit Mohanty, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18940
> https://issues.apache.org/jira/browse/AMBARI-18940
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The script to create VMs on GCE for the perf cluster has a bug where each VM 
> will have the exact same agent-multiplier config file with start=1 and 
> num=50, thereby preventing more than 50 agents.
> This is because a single server.sh and agent.sh file is written out, and 
> copied to all VMs.
> We need to create a custom config file for each VM instead.
> 
> 
> Diffs
> -
> 
>   contrib/utils/perf/deploy-gce-perf-cluster.py da45f8f 
> 
> Diff: https://reviews.apache.org/r/53914/diff/
> 
> 
> Testing
> ---
> 
> Verified by deploying a cluster to GCE.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>



Re: Review Request 53914: Perf: Fix bugs in deploy-gce-perf-cluster.py to generate correct config file

2016-11-18 Thread Sid Wagle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53914/#review156373
---


Ship it!




Ship It!

- Sid Wagle


On Nov. 19, 2016, 12:12 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53914/
> ---
> 
> (Updated Nov. 19, 2016, 12:12 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Sumit Mohanty, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18940
> https://issues.apache.org/jira/browse/AMBARI-18940
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The script to create VMs on GCE for the perf cluster has a bug where each VM 
> will have the exact same agent-multiplier config file with start=1 and 
> num=50, thereby preventing more than 50 agents.
> This is because a single server.sh and agent.sh file is written out, and 
> copied to all VMs.
> We need to create a custom config file for each VM instead.
> 
> 
> Diffs
> -
> 
>   contrib/utils/perf/deploy-gce-perf-cluster.py da45f8f 
> 
> Diff: https://reviews.apache.org/r/53914/diff/
> 
> 
> Testing
> ---
> 
> Verified by deploying a cluster to GCE.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>



Review Request 53914: Perf: Fix bugs in deploy-gce-perf-cluster.py to generate correct config file

2016-11-18 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53914/
---

Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Sumit Mohanty, Sid 
Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-18940
https://issues.apache.org/jira/browse/AMBARI-18940


Repository: ambari


Description
---

The script to create VMs on GCE for the perf cluster has a bug where each VM 
will have the exact same agent-multiplier config file with start=1 and num=50, 
thereby preventing more than 50 agents.
This is because a single server.sh and agent.sh file is written out, and copied 
to all VMs.
We need to create a custom config file for each VM instead.


Diffs
-

  contrib/utils/perf/deploy-gce-perf-cluster.py da45f8f 

Diff: https://reviews.apache.org/r/53914/diff/


Testing
---

Verified by deploying a cluster to GCE.


Thanks,

Alejandro Fernandez