Re: Review Request 55614: AMBARI-19581. Need to show proper error message in scenarios of failures with asset import
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55614/#review162033 --- Ship it! Ship It! - Gaurav Nagar On Jan. 17, 2017, 12:02 p.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55614/ > --- > > (Updated Jan. 17, 2017, 12:02 p.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, and Pallav Kulshreshtha. > > > Bugs: AMBARI-19581 > https://issues.apache.org/jira/browse/AMBARI-19581 > > > Repository: ambari > > > Description > --- > > Need to show proper error message in scenarios of failures with asset import. > While importing the asset for a given action node, its better to show only > assets belonging to that particular type. > Steps to reproduce : > 1) Save hive node settings as an asset. > 2) Now try to import that setting for hive2 or node other than hive. > 3) user is shown with the message 'Invalid asset settings'. > Either user should be shown only the assets of that particular type or > appropriate error message should be displayed as why import setting has > failed. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js > 2ea82b0 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > d0c05d6 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less bc0e419 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs > 4ee6d05 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs > d377d2c > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs > 0fa86b0 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 80af968 > > Diff: https://reviews.apache.org/r/55614/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 55614: AMBARI-19581. Need to show proper error message in scenarios of failures with asset import
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55614/#review161856 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 17, 2017, 12:02 p.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55614/ > --- > > (Updated Jan. 17, 2017, 12:02 p.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, and Pallav Kulshreshtha. > > > Bugs: AMBARI-19581 > https://issues.apache.org/jira/browse/AMBARI-19581 > > > Repository: ambari > > > Description > --- > > Need to show proper error message in scenarios of failures with asset import. > While importing the asset for a given action node, its better to show only > assets belonging to that particular type. > Steps to reproduce : > 1) Save hive node settings as an asset. > 2) Now try to import that setting for hive2 or node other than hive. > 3) user is shown with the message 'Invalid asset settings'. > Either user should be shown only the assets of that particular type or > appropriate error message should be displayed as why import setting has > failed. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js > 2ea82b0 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > d0c05d6 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less bc0e419 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs > 4ee6d05 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs > d377d2c > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs > 0fa86b0 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 80af968 > > Diff: https://reviews.apache.org/r/55614/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 55614: AMBARI-19581. Need to show proper error message in scenarios of failures with asset import
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55614/#review161855 --- Ship it! Ship It! - belliraj hb On Jan. 17, 2017, 12:02 p.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55614/ > --- > > (Updated Jan. 17, 2017, 12:02 p.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, and Pallav Kulshreshtha. > > > Bugs: AMBARI-19581 > https://issues.apache.org/jira/browse/AMBARI-19581 > > > Repository: ambari > > > Description > --- > > Need to show proper error message in scenarios of failures with asset import. > While importing the asset for a given action node, its better to show only > assets belonging to that particular type. > Steps to reproduce : > 1) Save hive node settings as an asset. > 2) Now try to import that setting for hive2 or node other than hive. > 3) user is shown with the message 'Invalid asset settings'. > Either user should be shown only the assets of that particular type or > appropriate error message should be displayed as why import setting has > failed. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js > 2ea82b0 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > d0c05d6 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less bc0e419 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs > 4ee6d05 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs > d377d2c > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs > 0fa86b0 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 80af968 > > Diff: https://reviews.apache.org/r/55614/diff/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Review Request 55614: AMBARI-19581. Need to show proper error message in scenarios of failures with asset import
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55614/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19581 https://issues.apache.org/jira/browse/AMBARI-19581 Repository: ambari Description --- Need to show proper error message in scenarios of failures with asset import. While importing the asset for a given action node, its better to show only assets belonging to that particular type. Steps to reproduce : 1) Save hive node settings as an asset. 2) Now try to import that setting for hive2 or node other than hive. 3) user is shown with the message 'Invalid asset settings'. Either user should be shown only the assets of that particular type or appropriate error message should be displayed as why import setting has failed. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js 2ea82b0 contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js d0c05d6 contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less bc0e419 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs 4ee6d05 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs d377d2c contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs 0fa86b0 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 80af968 Diff: https://reviews.apache.org/r/55614/diff/ Testing --- Manual Thanks, Madhan Reddy