Re: Review Request 56298: AMBARI-19871 - Config version switch/compare/revert doesn't work

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56298/#review164337
---


Ship it!




Ship It!

- Andrii Tkach


On Feb. 4, 2017, 3:32 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56298/
> ---
> 
> (Updated Feb. 4, 2017, 3:32 a.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19871
> https://issues.apache.org/jira/browse/AMBARI-19871
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix version state variable usage.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/configs/config_history_flow.js c216890 
> 
> Diff: https://reviews.apache.org/r/56298/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   20325 passing (23s)
>   153 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 56298: AMBARI-19871 - Config version switch/compare/revert doesn't work

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56298/#review164336
---




ambari-web/app/views/common/configs/config_history_flow.js (line 52)


Please remove hoveredServiceVersion completely since we don't use it


- Andrii Tkach


On Feb. 4, 2017, 3:32 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56298/
> ---
> 
> (Updated Feb. 4, 2017, 3:32 a.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19871
> https://issues.apache.org/jira/browse/AMBARI-19871
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix version state variable usage.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/configs/config_history_flow.js c216890 
> 
> Diff: https://reviews.apache.org/r/56298/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   20325 passing (23s)
>   153 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Review Request 56298: AMBARI-19871 - Config version switch/compare/revert doesn't work

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56298/
---

Review request for Ambari, Andrii Tkach, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-19871
https://issues.apache.org/jira/browse/AMBARI-19871


Repository: ambari


Description
---

Fix version state variable usage.


Diffs
-

  ambari-web/app/views/common/configs/config_history_flow.js c216890 

Diff: https://reviews.apache.org/r/56298/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
  20325 passing (23s)
  153 pending


Thanks,

Richard Zang