Re: Review Request 56869: Log Search should handle turned off Credential Store too
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56869/#review166173 --- Ship it! Ship It! - Robert Nettleton On Feb. 21, 2017, 11:13 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56869/ > --- > > (Updated Feb. 21, 2017, 11:13 a.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-20088 > https://issues.apache.org/jira/browse/AMBARI-20088 > > > Repository: ambari > > > Description > --- > > Log Search uses Credential Store to store keystore/truststore passwords, but > it should also work if it's turned off. In this case the passwords will be > stored in text files. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > a023f2f > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py > 6952c2c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > f96bfd0 > ambari-server/src/test/python/stacks/2.4/configs/default.json d4e6064 > > Diff: https://reviews.apache.org/r/56869/diff/ > > > Testing > --- > > Tested on local cluster. > > After turning the off the Credential Store the Log Search Portal and the Log > Feeders used text files to store their passwords. > After turning the on again the Credential Store the Log Search Portal and the > Log Feeders used jceks files to store their passwords. > > > Thanks, > > Miklos Gergely > >
Re: Review Request 56869: Log Search should handle turned off Credential Store too
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56869/#review166149 --- Ship it! Ship It! - Oliver Szabo On Feb. 21, 2017, 11:13 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56869/ > --- > > (Updated Feb. 21, 2017, 11:13 a.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-20088 > https://issues.apache.org/jira/browse/AMBARI-20088 > > > Repository: ambari > > > Description > --- > > Log Search uses Credential Store to store keystore/truststore passwords, but > it should also work if it's turned off. In this case the passwords will be > stored in text files. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > a023f2f > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py > 6952c2c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > f96bfd0 > ambari-server/src/test/python/stacks/2.4/configs/default.json d4e6064 > > Diff: https://reviews.apache.org/r/56869/diff/ > > > Testing > --- > > Tested on local cluster. > > After turning the off the Credential Store the Log Search Portal and the Log > Feeders used text files to store their passwords. > After turning the on again the Credential Store the Log Search Portal and the > Log Feeders used jceks files to store their passwords. > > > Thanks, > > Miklos Gergely > >
Re: Review Request 56869: Log Search should handle turned off Credential Store too
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56869/ --- (Updated Feb. 21, 2017, 11:13 a.m.) Review request for Ambari, Oliver Szabo and Robert Nettleton. Changes --- delete potentially leftover text files if Credential Store is used Bugs: AMBARI-20088 https://issues.apache.org/jira/browse/AMBARI-20088 Repository: ambari Description --- Log Search uses Credential Store to store keystore/truststore passwords, but it should also work if it's turned off. In this case the passwords will be stored in text files. Diffs (updated) - ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py a023f2f ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 6952c2c ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py f96bfd0 ambari-server/src/test/python/stacks/2.4/configs/default.json d4e6064 Diff: https://reviews.apache.org/r/56869/diff/ Testing --- Tested on local cluster. After turning the off the Credential Store the Log Search Portal and the Log Feeders used text files to store their passwords. After turning the on again the Credential Store the Log Search Portal and the Log Feeders used jceks files to store their passwords. Thanks, Miklos Gergely
Review Request 56869: Log Search should handle turned off Credential Store too
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56869/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs: AMBARI-20088 https://issues.apache.org/jira/browse/AMBARI-20088 Repository: ambari Description --- Log Search uses Credential Store to store keystore/truststore passwords, but it should also work if it's turned off. In this case the passwords will be stored in text files. Diffs - ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py a023f2f ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 6952c2c ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py f96bfd0 ambari-server/src/test/python/stacks/2.4/configs/default.json d4e6064 Diff: https://reviews.apache.org/r/56869/diff/ Testing --- Tested on local cluster. After turning the off the Credential Store the Log Search Portal and the Log Feeders used text files to store their passwords. After turning the on again the Credential Store the Log Search Portal and the Log Feeders used jceks files to store their passwords. Thanks, Miklos Gergely
