Re: Review Request 56977: Not able to compute the table statistics for partitioned table

2017-03-01 Thread DIPAYAN BHOWMICK

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56977/#review167293
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On March 1, 2017, 5:37 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56977/
> ---
> 
> (Updated March 1, 2017, 5:37 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20113
> https://issues.apache.org/jira/browse/AMBARI-20113
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> corrected the case of partitioned table in analyze query generation.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
>  1d68407 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
>  e433dc4 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
>  89b9d84 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/56977/diff/2/
> 
> 
> Testing
> ---
> 
> AnalyzeTableQueryGeneratorSpecTest unit test case added.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Re: Review Request 56977: Not able to compute the table statistics for partitioned table

2017-03-01 Thread Nitiraj Rathore

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56977/
---

(Updated March 1, 2017, 5:37 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Changes
---

resolved conflicts and uploaded new patch


Bugs: AMBARI-20113
https://issues.apache.org/jira/browse/AMBARI-20113


Repository: ambari


Description
---

corrected the case of partitioned table in analyze query generation.


Diffs (updated)
-

  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
 1d68407 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
 e433dc4 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
 89b9d84 
  
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy
 PRE-CREATION 


Diff: https://reviews.apache.org/r/56977/diff/2/

Changes: https://reviews.apache.org/r/56977/diff/1-2/


Testing
---

AnalyzeTableQueryGeneratorSpecTest unit test case added.


Thanks,

Nitiraj Rathore



Re: Review Request 56977: Not able to compute the table statistics for partitioned table

2017-02-23 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56977/#review166510
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 23, 2017, 9:30 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56977/
> ---
> 
> (Updated Feb. 23, 2017, 9:30 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20113
> https://issues.apache.org/jira/browse/AMBARI-20113
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> corrected the case of partitioned table in analyze query generation.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
>  902d959 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
>  e433dc4 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
>  89b9d84 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56977/diff/
> 
> 
> Testing
> ---
> 
> AnalyzeTableQueryGeneratorSpecTest unit test case added.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Re: Review Request 56977: Not able to compute the table statistics for partitioned table

2017-02-23 Thread DIPAYAN BHOWMICK

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56977/#review166504
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 23, 2017, 9:30 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56977/
> ---
> 
> (Updated Feb. 23, 2017, 9:30 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20113
> https://issues.apache.org/jira/browse/AMBARI-20113
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> corrected the case of partitioned table in analyze query generation.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
>  902d959 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
>  e433dc4 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
>  89b9d84 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56977/diff/
> 
> 
> Testing
> ---
> 
> AnalyzeTableQueryGeneratorSpecTest unit test case added.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Review Request 56977: Not able to compute the table statistics for partitioned table

2017-02-23 Thread Nitiraj Rathore

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56977/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-20113
https://issues.apache.org/jira/browse/AMBARI-20113


Repository: ambari


Description
---

corrected the case of partitioned table in analyze query generation.


Diffs
-

  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
 902d959 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
 e433dc4 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
 89b9d84 
  
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy
 PRE-CREATION 

Diff: https://reviews.apache.org/r/56977/diff/


Testing
---

AnalyzeTableQueryGeneratorSpecTest unit test case added.


Thanks,

Nitiraj Rathore