Re: Review Request 57027: AMBARI-20142. Job Link URL not working

2017-02-24 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57027/#review166677
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 24, 2017, 10:09 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57027/
> ---
> 
> (Updated Feb. 24, 2017, 10:09 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20142
> https://issues.apache.org/jira/browse/AMBARI-20142
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Showing the Job Url link if it starts with http
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-action.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-details.js
>  7a868fa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-action.hbs
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
>  b5565c8 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
> 309c281 
>   
> contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-job-action-test.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/57027/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>



Re: Review Request 57027: AMBARI-20142. Job Link URL not working

2017-02-24 Thread belliraj hb

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57027/#review18
---


Ship it!




Ship It!

- belliraj hb


On Feb. 24, 2017, 10:09 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57027/
> ---
> 
> (Updated Feb. 24, 2017, 10:09 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20142
> https://issues.apache.org/jira/browse/AMBARI-20142
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Showing the Job Url link if it starts with http
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-action.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-details.js
>  7a868fa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-action.hbs
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
>  b5565c8 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
> 309c281 
>   
> contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-job-action-test.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/57027/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>



Review Request 57027: AMBARI-20142. Job Link URL not working

2017-02-24 Thread Madhan Reddy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57027/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.


Bugs: AMBARI-20142
https://issues.apache.org/jira/browse/AMBARI-20142


Repository: ambari


Description
---

Showing the Job Url link if it starts with http


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-action.js
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-details.js
 7a868fa 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-action.hbs
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs
 b5565c8 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
309c281 
  
contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-job-action-test.js
 PRE-CREATION 

Diff: https://reviews.apache.org/r/57027/diff/


Testing
---

Manual


Thanks,

Madhan Reddy