Re: Review Request 57141: Hive View 2.0: Code hints for query editor are not working

2017-02-28 Thread DIPAYAN BHOWMICK

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57141/#review167127
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 28, 2017, 12:23 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57141/
> ---
> 
> (Updated Feb. 28, 2017, 12:23 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19673
> https://issues.apache.org/jira/browse/AMBARI-19673
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User should be able to see code hints and syntax colorization while typing 
> hive queries.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 
> 3175a35 
>   contrib/views/hive20/src/main/resources/ui/ember-cli-build.js c88799a 
> 
> Diff: https://reviews.apache.org/r/57141/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 57141: Hive View 2.0: Code hints for query editor are not working

2017-02-28 Thread Ashwin Rajeev

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57141/#review167094
---


Ship it!




Ship It!

- Ashwin Rajeev


On Feb. 28, 2017, 12:23 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57141/
> ---
> 
> (Updated Feb. 28, 2017, 12:23 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19673
> https://issues.apache.org/jira/browse/AMBARI-19673
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User should be able to see code hints and syntax colorization while typing 
> hive queries.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 
> 3175a35 
>   contrib/views/hive20/src/main/resources/ui/ember-cli-build.js c88799a 
> 
> Diff: https://reviews.apache.org/r/57141/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 57141: Hive View 2.0: Code hints for query editor are not working

2017-02-28 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57141/#review167093
---


Ship it!




Ship It!

- venkat sairam


On Feb. 28, 2017, 12:23 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57141/
> ---
> 
> (Updated Feb. 28, 2017, 12:23 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19673
> https://issues.apache.org/jira/browse/AMBARI-19673
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User should be able to see code hints and syntax colorization while typing 
> hive queries.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 
> 3175a35 
>   contrib/views/hive20/src/main/resources/ui/ember-cli-build.js c88799a 
> 
> Diff: https://reviews.apache.org/r/57141/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Review Request 57141: Hive View 2.0: Code hints for query editor are not working

2017-02-28 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57141/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-19673
https://issues.apache.org/jira/browse/AMBARI-19673


Repository: ambari


Description
---

User should be able to see code hints and syntax colorization while typing hive 
queries.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js 
3175a35 
  contrib/views/hive20/src/main/resources/ui/ember-cli-build.js c88799a 

Diff: https://reviews.apache.org/r/57141/diff/


Testing
---

Manually tested


Thanks,

Pallav Kulshreshtha