Re: Review Request 57203: Log Search upgrade to 2.5 should handle renamed properties safely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57203/#review167545 --- Ship it! Ship It! - Alejandro Fernandez On March 1, 2017, 3:33 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57203/ > --- > > (Updated March 1, 2017, 3:33 p.m.) > > > Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-20257 > https://issues.apache.org/jira/browse/AMBARI-20257 > > > Repository: ambari > > > Description > --- > > Log Search upgrade to 2.5 renames some variables. If for some reason the > upgrade is repeated, it tries to rename them again, which causes some > problem, as the original variables are not present anymore. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 39a129d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml > d57b98b > > > Diff: https://reviews.apache.org/r/57203/diff/1/ > > > Testing > --- > > Tested on local cluster by upgrading it, re-set 2.4.2 in the database, then > upgradeing it again. > > > Thanks, > > Miklos Gergely > >
Re: Review Request 57203: Log Search upgrade to 2.5 should handle renamed properties safely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57203/#review167284 --- Ship it! Ship It! - Robert Nettleton On March 1, 2017, 3:33 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57203/ > --- > > (Updated March 1, 2017, 3:33 p.m.) > > > Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-20257 > https://issues.apache.org/jira/browse/AMBARI-20257 > > > Repository: ambari > > > Description > --- > > Log Search upgrade to 2.5 renames some variables. If for some reason the > upgrade is repeated, it tries to rename them again, which causes some > problem, as the original variables are not present anymore. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 39a129d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml > d57b98b > > > Diff: https://reviews.apache.org/r/57203/diff/1/ > > > Testing > --- > > Tested on local cluster by upgrading it, re-set 2.4.2 in the database, then > upgradeing it again. > > > Thanks, > > Miklos Gergely > >
Re: Review Request 57203: Log Search upgrade to 2.5 should handle renamed properties safely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57203/#review167279 --- Ship it! Ship It! - Oliver Szabo On March 1, 2017, 3:10 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57203/ > --- > > (Updated March 1, 2017, 3:10 p.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-20257 > https://issues.apache.org/jira/browse/AMBARI-20257 > > > Repository: ambari > > > Description > --- > > Log Search upgrade to 2.5 renames some variables. If for some reason the > upgrade is repeated, it tries to rename them again, which causes some > problem, as the original variables are not present anymore. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 39a129d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml > d57b98b > > > Diff: https://reviews.apache.org/r/57203/diff/1/ > > > Testing > --- > > Tested on local cluster by upgrading it, re-set 2.4.2 in the database, then > upgradeing it again. > > > Thanks, > > Miklos Gergely > >
Review Request 57203: Log Search upgrade to 2.5 should handle renamed properties safely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57203/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs: AMBARI-20257 https://issues.apache.org/jira/browse/AMBARI-20257 Repository: ambari Description --- Log Search upgrade to 2.5 renames some variables. If for some reason the upgrade is repeated, it tries to rename them again, which causes some problem, as the original variables are not present anymore. Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java 39a129d ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml d57b98b Diff: https://reviews.apache.org/r/57203/diff/1/ Testing --- Tested on local cluster by upgrading it, re-set 2.4.2 in the database, then upgradeing it again. Thanks, Miklos Gergely
