Re: Review Request 58884: Mask passwords in Request resource responses
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58884/#review173584 --- Ship it! Ship It! - Attila Magyar On May 1, 2017, 5:30 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58884/ > --- > > (Updated May 1, 2017, 5:30 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Attila Magyar, Balázs Bence > Sári, Eugene Chekanskiy, Laszlo Puskas, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-20874 > https://issues.apache.org/jira/browse/AMBARI-20874 > > > Repository: ambari > > > Description > --- > > Mask the data for sensitive fields and properties in Request resource > responses to protect that data. > > `org.apache.ambari.server.utils.SecretReference#maskPasswordInPropertyMap` is > used `org.apache.ambari.server.controller.internal.StageResourceProvider` to > protected sensitive data. The same technique should be used in > `org.apache.ambari.server.controller.internal.RequestResourceProvider`. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > 57e702477d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java > feedc74b7c > > > Diff: https://reviews.apache.org/r/58884/diff/1/ > > > Testing > --- > > Manually tested > > # Local test results: PENDING > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
Re: Review Request 58884: Mask passwords in Request resource responses
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58884/#review173478 --- Ship it! Ship It! - Sumit Mohanty On May 1, 2017, 5:30 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58884/ > --- > > (Updated May 1, 2017, 5:30 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Attila Magyar, Balázs Bence > Sári, Eugene Chekanskiy, Laszlo Puskas, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-20874 > https://issues.apache.org/jira/browse/AMBARI-20874 > > > Repository: ambari > > > Description > --- > > Mask the data for sensitive fields and properties in Request resource > responses to protect that data. > > `org.apache.ambari.server.utils.SecretReference#maskPasswordInPropertyMap` is > used `org.apache.ambari.server.controller.internal.StageResourceProvider` to > protected sensitive data. The same technique should be used in > `org.apache.ambari.server.controller.internal.RequestResourceProvider`. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > 57e702477d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java > feedc74b7c > > > Diff: https://reviews.apache.org/r/58884/diff/1/ > > > Testing > --- > > Manually tested > > # Local test results: PENDING > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
Review Request 58884: Mask passwords in Request resource responses
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58884/ --- Review request for Ambari, Alejandro Fernandez, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, Laszlo Puskas, Sumit Mohanty, and Sebastian Toader. Bugs: AMBARI-20874 https://issues.apache.org/jira/browse/AMBARI-20874 Repository: ambari Description --- Mask the data for sensitive fields and properties in Request resource responses to protect that data. `org.apache.ambari.server.utils.SecretReference#maskPasswordInPropertyMap` is used `org.apache.ambari.server.controller.internal.StageResourceProvider` to protected sensitive data. The same technique should be used in `org.apache.ambari.server.controller.internal.RequestResourceProvider`. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 57e702477d ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java feedc74b7c Diff: https://reviews.apache.org/r/58884/diff/1/ Testing --- Manually tested # Local test results: PENDING # Jenkins test results: PENDING Thanks, Robert Levas
