Re: Review Request 58919: AMBARI-20903 RepoVersion parsing error should be more specific

2017-05-02 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58919/#review173603
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 2, 2017, 3:37 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58919/
> ---
> 
> (Updated May 2, 2017, 3:37 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20903
> https://issues.apache.org/jira/browse/AMBARI-20903
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a minor JIRA on updating an error message in case the repoinfo.xml 
> misses any of the three required fields - repo_name, repo_id, and base url.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  d3705f3 
> 
> 
> Diff: https://reviews.apache.org/r/58919/diff/1/
> 
> 
> Testing
> ---
> 
> existing unit tests. patch a cluster with the change.
> 
> 
> Thanks,
> 
> Di Li
> 
>



Re: Review Request 58919: AMBARI-20903 RepoVersion parsing error should be more specific

2017-05-02 Thread Tim Thorpe

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58919/#review173598
---


Ship it!




Ship It!

- Tim Thorpe


On May 2, 2017, 3:37 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58919/
> ---
> 
> (Updated May 2, 2017, 3:37 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20903
> https://issues.apache.org/jira/browse/AMBARI-20903
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a minor JIRA on updating an error message in case the repoinfo.xml 
> misses any of the three required fields - repo_name, repo_id, and base url.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  d3705f3 
> 
> 
> Diff: https://reviews.apache.org/r/58919/diff/1/
> 
> 
> Testing
> ---
> 
> existing unit tests. patch a cluster with the change.
> 
> 
> Thanks,
> 
> Di Li
> 
>



Review Request 58919: AMBARI-20903 RepoVersion parsing error should be more specific

2017-05-02 Thread Di Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58919/
---

Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-20903
https://issues.apache.org/jira/browse/AMBARI-20903


Repository: ambari


Description
---

This is a minor JIRA on updating an error message in case the repoinfo.xml 
misses any of the three required fields - repo_name, repo_id, and base url.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
 d3705f3 


Diff: https://reviews.apache.org/r/58919/diff/1/


Testing
---

existing unit tests. patch a cluster with the change.


Thanks,

Di Li