Re: Review Request 58933: AMBARI-20913 : Grafana LLAP overview dashboard showing incorrect metrics
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58933/#review173659 --- Ship it! Ship It! - Alejandro Fernandez On May 2, 2017, 9:43 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58933/ > --- > > (Updated May 2, 2017, 9:43 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-20913 > https://issues.apache.org/jira/browse/AMBARI-20913 > > > Repository: ambari > > > Description > --- > > PROBLEM > On a 4 node LLAP cluster grafana "LLAP Overview" dashboard shows incorrect > data. The metric seems to have been multiplied by a factor of 10. > > BUG > This issue had been fixed in the V2 aggregation mechanism (Phoenix server > side aggregation) through AMBARI-15638. It was missed out on the V1 mechanism > of aggregation where the data is read into the Metrics Collector and manual > client side aggregation is done. > > > Diffs > - > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregator.java > 02677b9 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/ITClusterAggregator.java > 590f82a > > > Diff: https://reviews.apache.org/r/58933/diff/1/ > > > Testing > --- > > mvn clean test on ambari-metrics > Manually tested. > > > Thanks, > > Aravindan Vijayan > >
Re: Review Request 58933: AMBARI-20913 : Grafana LLAP overview dashboard showing incorrect metrics
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58933/#review173658 --- Ship it! Ship It! - Sid Wagle On May 2, 2017, 9:43 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58933/ > --- > > (Updated May 2, 2017, 9:43 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-20913 > https://issues.apache.org/jira/browse/AMBARI-20913 > > > Repository: ambari > > > Description > --- > > PROBLEM > On a 4 node LLAP cluster grafana "LLAP Overview" dashboard shows incorrect > data. The metric seems to have been multiplied by a factor of 10. > > BUG > This issue had been fixed in the V2 aggregation mechanism (Phoenix server > side aggregation) through AMBARI-15638. It was missed out on the V1 mechanism > of aggregation where the data is read into the Metrics Collector and manual > client side aggregation is done. > > > Diffs > - > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregator.java > 02677b9 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/ITClusterAggregator.java > 590f82a > > > Diff: https://reviews.apache.org/r/58933/diff/1/ > > > Testing > --- > > mvn clean test on ambari-metrics > Manually tested. > > > Thanks, > > Aravindan Vijayan > >
Review Request 58933: AMBARI-20913 : Grafana LLAP overview dashboard showing incorrect metrics
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58933/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-20913 https://issues.apache.org/jira/browse/AMBARI-20913 Repository: ambari Description --- PROBLEM On a 4 node LLAP cluster grafana "LLAP Overview" dashboard shows incorrect data. The metric seems to have been multiplied by a factor of 10. BUG This issue had been fixed in the V2 aggregation mechanism (Phoenix server side aggregation) through AMBARI-15638. It was missed out on the V1 mechanism of aggregation where the data is read into the Metrics Collector and manual client side aggregation is done. Diffs - ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregator.java 02677b9 ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/ITClusterAggregator.java 590f82a Diff: https://reviews.apache.org/r/58933/diff/1/ Testing --- mvn clean test on ambari-metrics Manually tested. Thanks, Aravindan Vijayan
