Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-14 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60707/#review180519
---


Ship it!




Ship It!

- Attila Doroszlai


On July 14, 2017, 1:36 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60707/
> ---
> 
> (Updated July 14, 2017, 1:36 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Balázs Bence 
> Sári, Eugene Chekanskiy, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20861
> https://issues.apache.org/jira/browse/AMBARI-20861
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update the Ambari REST API to allow for GET, POST, PUT, and DELETE operations 
> on the authentication sources related to an Ambari user account.
> 
> Add the following entry points:
> 
> - `/api/v1/users/:USERNAME/sources`
> -- List a user’s authentication sources
> -- Add a new authentication source for a user
> 
> - `/api/v1/users/:USERNAME/sources/:SOURCE_ID`
> -- Get details on a specific authentication source for a user
> -- Modify details for a specific authentication source for a user
> 
> Update the following entry points, ensuring backwards compatibility where 
> possible:
> 
> - `/api/v1/users`
> -- List all users
> -- Add a new user
> -- Backward compatibility: Set password should create or update the 
> appropriate user_authentication record.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/generated/index.html 21e043b7bc 
>   ambari-server/docs/api/generated/swagger.json 6347bfaa2f 
>   ambari-server/docs/api/v1/authentication-source-create.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-delete.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-get.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-list.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-resources.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-update.md PRE-CREATION 
>   ambari-server/docs/api/v1/index.md da05d75bc3 
>   ambari-server/docs/api/v1/user-create.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-delete.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-get.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-list.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-resources.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-update.md PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  96e288fee0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/UserResourceDefinition.java
>  b228c82aa9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
>  d24780b4ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthenticationSourceService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java
>  a69ed4e170 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  25d12c7dd6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  2454bf7694 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequestCreateSwagger.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequestUpdateSwagger.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequest.java
>  3011d01402 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequestCreateUserSwagger.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequestCreateUsersSwagger.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequestUpdateUserSwagger.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
>  bcb3aaf3e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  595b7f996f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
>  45b733b042 
>   
>

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-14 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60707/
---

(Updated July 14, 2017, 7:36 a.m.)


Review request for Ambari, Attila Doroszlai, Attila Magyar, Balázs Bence Sári, 
Eugene Chekanskiy, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.


Changes
---

Fix swagger issues.


Bugs: AMBARI-20861
https://issues.apache.org/jira/browse/AMBARI-20861


Repository: ambari


Description
---

Update the Ambari REST API to allow for GET, POST, PUT, and DELETE operations 
on the authentication sources related to an Ambari user account.

Add the following entry points:

- `/api/v1/users/:USERNAME/sources`
-- List a user’s authentication sources
-- Add a new authentication source for a user

- `/api/v1/users/:USERNAME/sources/:SOURCE_ID`
-- Get details on a specific authentication source for a user
-- Modify details for a specific authentication source for a user

Update the following entry points, ensuring backwards compatibility where 
possible:

- `/api/v1/users`
-- List all users
-- Add a new user
-- Backward compatibility: Set password should create or update the appropriate 
user_authentication record.


Diffs (updated)
-

  ambari-server/docs/api/generated/index.html 21e043b7bc 
  ambari-server/docs/api/generated/swagger.json 6347bfaa2f 
  ambari-server/docs/api/v1/authentication-source-create.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-delete.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-get.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-list.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-resources.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-update.md PRE-CREATION 
  ambari-server/docs/api/v1/index.md da05d75bc3 
  ambari-server/docs/api/v1/user-create.md PRE-CREATION 
  ambari-server/docs/api/v1/user-delete.md PRE-CREATION 
  ambari-server/docs/api/v1/user-get.md PRE-CREATION 
  ambari-server/docs/api/v1/user-list.md PRE-CREATION 
  ambari-server/docs/api/v1/user-resources.md PRE-CREATION 
  ambari-server/docs/api/v1/user-update.md PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 96e288fee0 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/UserResourceDefinition.java
 b228c82aa9 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
 d24780b4ac 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthenticationSourceService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java
 a69ed4e170 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 25d12c7dd6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
 2454bf7694 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequestCreateSwagger.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequestUpdateSwagger.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequest.java
 3011d01402 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequestCreateUserSwagger.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequestCreateUsersSwagger.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserRequestUpdateUserSwagger.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
 bcb3aaf3e1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 595b7f996f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
 45b733b042 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 362b4e631c 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
 5ecff52ab2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
 ffb8e6dd16 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 de12a1669f 
  ambari-server/src/main/resources/properties.json 11ca7f678a

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-13 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60707/#review180421
---


Ship it!




Ship It!

- Jonathan Hurley


On July 12, 2017, 5:56 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60707/
> ---
> 
> (Updated July 12, 2017, 5:56 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Balázs Bence 
> Sári, Eugene Chekanskiy, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20861
> https://issues.apache.org/jira/browse/AMBARI-20861
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update the Ambari REST API to allow for GET, POST, PUT, and DELETE operations 
> on the authentication sources related to an Ambari user account.
> 
> Add the following entry points:
> 
> - `/api/v1/users/:USERNAME/sources`
> -- List a user’s authentication sources
> -- Add a new authentication source for a user
> 
> - `/api/v1/users/:USERNAME/sources/:SOURCE_ID`
> -- Get details on a specific authentication source for a user
> -- Modify details for a specific authentication source for a user
> 
> Update the following entry points, ensuring backwards compatibility where 
> possible:
> 
> - `/api/v1/users`
> -- List all users
> -- Add a new user
> -- Backward compatibility: Set password should create or update the 
> appropriate user_authentication record.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/authentication-source-create.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-delete.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-get.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-list.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-resources.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-update.md PRE-CREATION 
>   ambari-server/docs/api/v1/index.md da05d75bc3 
>   ambari-server/docs/api/v1/user-create.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-delete.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-get.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-list.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-resources.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-update.md PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  96e288fee0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/UserResourceDefinition.java
>  b228c82aa9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthenticationSourceService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  25d12c7dd6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  2454bf7694 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
>  bcb3aaf3e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  595b7f996f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
>  45b733b042 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  362b4e631c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  5ecff52ab2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  ffb8e6dd16 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  de12a1669f 
>   ambari-server/src/main/resources/properties.json 11ca7f678a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/UserResourceDefinitionTest.java
>  024b118a9c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
>  3becc02aa8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java
>  db7548f077 
>   
>

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-13 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60707/#review180419
---




ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthenticationSourceService.java
Lines 70-76 (patched)


Please use constants defined in `BaseService` for parameters of these 
annotations, where applicable.  This makes it easier to update descriptions 
like "... starting page resource ..." if needed.  It also lets us avoid typos 
in parameters that Swagger parses like "query", "integer", etc.  Thanks.



ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
Lines 57 (patched)


Please consider using constants from `*Provider` for property names in 
request/response models: avoid repetition, avoid typos, easier to change.



ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
Lines 62 (patched)


Also, to more accurately reflect the request/response schema, please 
consider using plain names (eg. "source_id") and using wrapper interface for 
the enclosing `AuthenticationSourceInfo` map (see `RequestPostRequest` for 
example).


- Attila Doroszlai


On July 12, 2017, 11:56 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60707/
> ---
> 
> (Updated July 12, 2017, 11:56 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Balázs Bence 
> Sári, Eugene Chekanskiy, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20861
> https://issues.apache.org/jira/browse/AMBARI-20861
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update the Ambari REST API to allow for GET, POST, PUT, and DELETE operations 
> on the authentication sources related to an Ambari user account.
> 
> Add the following entry points:
> 
> - `/api/v1/users/:USERNAME/sources`
> -- List a user’s authentication sources
> -- Add a new authentication source for a user
> 
> - `/api/v1/users/:USERNAME/sources/:SOURCE_ID`
> -- Get details on a specific authentication source for a user
> -- Modify details for a specific authentication source for a user
> 
> Update the following entry points, ensuring backwards compatibility where 
> possible:
> 
> - `/api/v1/users`
> -- List all users
> -- Add a new user
> -- Backward compatibility: Set password should create or update the 
> appropriate user_authentication record.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/authentication-source-create.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-delete.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-get.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-list.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-resources.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-update.md PRE-CREATION 
>   ambari-server/docs/api/v1/index.md da05d75bc3 
>   ambari-server/docs/api/v1/user-create.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-delete.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-get.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-list.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-resources.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-update.md PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  96e288fee0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/UserResourceDefinition.java
>  b228c82aa9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthenticationSourceService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  25d12c7dd6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  2454bf7694 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
>  bcb3aaf3e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  595b7f996f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
>  PRE-CREATION 
>   
>

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-12 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60707/
---

(Updated July 12, 2017, 5:56 p.m.)


Review request for Ambari, Attila Doroszlai, Attila Magyar, Balázs Bence Sári, 
Eugene Chekanskiy, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20861
https://issues.apache.org/jira/browse/AMBARI-20861


Repository: ambari


Description
---

Update the Ambari REST API to allow for GET, POST, PUT, and DELETE operations 
on the authentication sources related to an Ambari user account.

Add the following entry points:

- `/api/v1/users/:USERNAME/sources`
-- List a user’s authentication sources
-- Add a new authentication source for a user

- `/api/v1/users/:USERNAME/sources/:SOURCE_ID`
-- Get details on a specific authentication source for a user
-- Modify details for a specific authentication source for a user

Update the following entry points, ensuring backwards compatibility where 
possible:

- `/api/v1/users`
-- List all users
-- Add a new user
-- Backward compatibility: Set password should create or update the appropriate 
user_authentication record.


Diffs (updated)
-

  ambari-server/docs/api/v1/authentication-source-create.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-delete.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-get.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-list.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-resources.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-update.md PRE-CREATION 
  ambari-server/docs/api/v1/index.md da05d75bc3 
  ambari-server/docs/api/v1/user-create.md PRE-CREATION 
  ambari-server/docs/api/v1/user-delete.md PRE-CREATION 
  ambari-server/docs/api/v1/user-get.md PRE-CREATION 
  ambari-server/docs/api/v1/user-list.md PRE-CREATION 
  ambari-server/docs/api/v1/user-resources.md PRE-CREATION 
  ambari-server/docs/api/v1/user-update.md PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 96e288fee0 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/UserResourceDefinition.java
 b228c82aa9 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthenticationSourceService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 25d12c7dd6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
 2454bf7694 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
 bcb3aaf3e1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 595b7f996f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
 45b733b042 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 362b4e631c 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
 5ecff52ab2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
 ffb8e6dd16 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 de12a1669f 
  ambari-server/src/main/resources/properties.json 11ca7f678a 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/UserResourceDefinitionTest.java
 024b118a9c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
 3becc02aa8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java
 db7548f077 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
 4530d40ce4 
  
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
 43d56cd473 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 e049b4e83b 


Diff: https://reviews.apache.org/r/60707/diff/4/

Changes: https://reviews.apache.org/r/60707/diff/3-4/


Testing
---

Manaully tested using REST API testing tool.

# Local test results
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO]

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-12 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60707/#review180352
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
Lines 93 (patched)


When passing in properties defined inside the provider (as opposed to the 
ancient JSON file), you should use the constructor which takes a type, like 
this:

super(Type.UserAuthenticationSource, PROPERTY_IDS, KEY_PROPERTY_IDS);


- Jonathan Hurley


On July 12, 2017, 4:32 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60707/
> ---
> 
> (Updated July 12, 2017, 4:32 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20861
> https://issues.apache.org/jira/browse/AMBARI-20861
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update the Ambari REST API to allow for GET, POST, PUT, and DELETE operations 
> on the authentication sources related to an Ambari user account.
> 
> Add the following entry points:
> 
> - `/api/v1/users/:USERNAME/sources`
> -- List a user’s authentication sources
> -- Add a new authentication source for a user
> 
> - `/api/v1/users/:USERNAME/sources/:SOURCE_ID`
> -- Get details on a specific authentication source for a user
> -- Modify details for a specific authentication source for a user
> 
> Update the following entry points, ensuring backwards compatibility where 
> possible:
> 
> - `/api/v1/users`
> -- List all users
> -- Add a new user
> -- Backward compatibility: Set password should create or update the 
> appropriate user_authentication record.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/authentication-source-create.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-delete.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-get.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-list.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-resources.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-update.md PRE-CREATION 
>   ambari-server/docs/api/v1/index.md da05d75bc3 
>   ambari-server/docs/api/v1/user-create.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-delete.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-get.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-list.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-resources.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-update.md PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  96e288fee0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/UserResourceDefinition.java
>  b228c82aa9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthenticationSourceService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  25d12c7dd6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  2454bf7694 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
>  bcb3aaf3e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  595b7f996f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
>  45b733b042 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  362b4e631c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
>  5ecff52ab2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
>  ffb8e6dd16 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  de12a1669f 
>   ambari-server/src/main/resources/properties.json 11ca7f678a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/UserResourceDefinitionTest.java
>  024b118a9c 
>   
>

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-12 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60707/
---

(Updated July 12, 2017, 4:32 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20861
https://issues.apache.org/jira/browse/AMBARI-20861


Repository: ambari


Description (updated)
---

Update the Ambari REST API to allow for GET, POST, PUT, and DELETE operations 
on the authentication sources related to an Ambari user account.

Add the following entry points:

- `/api/v1/users/:USERNAME/sources`
-- List a user’s authentication sources
-- Add a new authentication source for a user

- `/api/v1/users/:USERNAME/sources/:SOURCE_ID`
-- Get details on a specific authentication source for a user
-- Modify details for a specific authentication source for a user

Update the following entry points, ensuring backwards compatibility where 
possible:

- `/api/v1/users`
-- List all users
-- Add a new user
-- Backward compatibility: Set password should create or update the appropriate 
user_authentication record.


Diffs
-

  ambari-server/docs/api/v1/authentication-source-create.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-delete.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-get.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-list.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-resources.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-update.md PRE-CREATION 
  ambari-server/docs/api/v1/index.md da05d75bc3 
  ambari-server/docs/api/v1/user-create.md PRE-CREATION 
  ambari-server/docs/api/v1/user-delete.md PRE-CREATION 
  ambari-server/docs/api/v1/user-get.md PRE-CREATION 
  ambari-server/docs/api/v1/user-list.md PRE-CREATION 
  ambari-server/docs/api/v1/user-resources.md PRE-CREATION 
  ambari-server/docs/api/v1/user-update.md PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 96e288fee0 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/UserResourceDefinition.java
 b228c82aa9 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthenticationSourceService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 25d12c7dd6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
 2454bf7694 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
 bcb3aaf3e1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 595b7f996f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
 45b733b042 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 362b4e631c 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
 5ecff52ab2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
 ffb8e6dd16 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 de12a1669f 
  ambari-server/src/main/resources/properties.json 11ca7f678a 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/UserResourceDefinitionTest.java
 024b118a9c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
 3becc02aa8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java
 db7548f077 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
 4530d40ce4 
  
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
 43d56cd473 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 e049b4e83b 


Diff: https://reviews.apache.org/r/60707/diff/3/


Testing
---

Manaully tested using REST API testing tool.

# Local test results
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO]

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-10 Thread Robert Levas 


> On July 10, 2017, 2:57 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
> > Lines 367-369 (patched)
> > 
> >
> > Shouldn't be an error message returned here in case no pwd passed in 
> > for local users?

The password is optional.  If set, the local authentication source will be 
added (for backward compatibilty).  If not set, there is no issue becuase the 
user did not want to create a local authentication source for the new resource.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60707/#review180009
---


On July 7, 2017, 9:30 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60707/
> ---
> 
> (Updated July 7, 2017, 9:30 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20861
> https://issues.apache.org/jira/browse/AMBARI-20861
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update the Ambari REST API to allow for GET, POST, PUT, and DELETE operations 
> on the authentication sources related to an Ambari user account.
> 
> Add the following entry points:
> 
> - `/api/v1/users/:USER_ID`
> -- Get a user
> -- Modify a user
> 
> - `/api/v1/users/:USERNAME/sources`
> -- List a user’s authentication sources
> -- Add a new authentication source for a user
> 
> - `/api/v1/users/:USERNAME/sources/:SOURCE_ID`
> -- Get details on a specific authentication source for a user
> -- Modify details for a specific authentication source for a user
> 
> - `/api/v1/users/:USER_ID/sources`
> -- List a user’s authentication sources
> -- Add a new authentication source for a user
> 
> - `/api/v1/users/:USER_ID/sources/:SOURCE_ID`
> -- Get details on a specific authentication source for a user
> -- Modify details for a specific authentication source for a user
> 
> Update the following entry points, ensuring backwards compatibility where 
> possible:
> 
> - `/api/v1/users`
> -- List all users
> -- Add a new user
> -- Backward compatibility: Set password should create or update the 
> appropriate user_authentication record.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/authentication-source-create.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-delete.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-get.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-list.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-resources.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-update.md PRE-CREATION 
>   ambari-server/docs/api/v1/index.md da05d75bc3 
>   ambari-server/docs/api/v1/user-create.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-delete.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-get.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-list.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-resources.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-update.md PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  96e288fee0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/UserResourceDefinition.java
>  b228c82aa9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthenticationSourceService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  25d12c7dd6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  2454bf7694 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
>  bcb3aaf3e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  595b7f996f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
>  45b733b042 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  362b4e631c 
>   
>

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-10 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60707/#review180009
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
Lines 76-78 (patched)


You could use guava's ImmutableSet.of(...) here.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
Lines 80-88 (patched)


You could use guava's ImmutableSet.builder() here.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
Lines 90-93 (patched)


You could use guava's ImmutableMap.of(...) here.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
Lines 101-123 (patched)


You could use guava here.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
Lines 367-369 (patched)


Shouldn't be an error message returned here in case no pwd passed in for 
local users?



ambari-server/src/test/java/org/apache/ambari/server/api/resources/UserResourceDefinitionTest.java
Line 42 (original), 44 (patched)


It worth adding a test that ensures that none breaks the equals method of 
UserDefinition in the future by adding a new field to the class but forgetting 
to update the equals and hashcode methods accordingly.

There a test library that does that for you ```EqualsVerifier``` that can 
be used for that. (look at ```OperationStatusAuditEventTest.testEquals()``` as 
an example how currently is used.


- Sebastian Toader


On July 7, 2017, 3:30 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60707/
> ---
> 
> (Updated July 7, 2017, 3:30 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20861
> https://issues.apache.org/jira/browse/AMBARI-20861
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update the Ambari REST API to allow for GET, POST, PUT, and DELETE operations 
> on the authentication sources related to an Ambari user account.
> 
> Add the following entry points:
> 
> - `/api/v1/users/:USER_ID`
> -- Get a user
> -- Modify a user
> 
> - `/api/v1/users/:USERNAME/sources`
> -- List a user’s authentication sources
> -- Add a new authentication source for a user
> 
> - `/api/v1/users/:USERNAME/sources/:SOURCE_ID`
> -- Get details on a specific authentication source for a user
> -- Modify details for a specific authentication source for a user
> 
> - `/api/v1/users/:USER_ID/sources`
> -- List a user’s authentication sources
> -- Add a new authentication source for a user
> 
> - `/api/v1/users/:USER_ID/sources/:SOURCE_ID`
> -- Get details on a specific authentication source for a user
> -- Modify details for a specific authentication source for a user
> 
> Update the following entry points, ensuring backwards compatibility where 
> possible:
> 
> - `/api/v1/users`
> -- List all users
> -- Add a new user
> -- Backward compatibility: Set password should create or update the 
> appropriate user_authentication record.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/authentication-source-create.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-delete.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-get.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-list.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-resources.md PRE-CREATION 
>   ambari-server/docs/api/v1/authentication-source-update.md PRE-CREATION 
>   ambari-server/docs/api/v1/index.md da05d75bc3 
>   ambari-server/docs/api/v1/user-create.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-delete.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-get.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-list.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-resources.md PRE-CREATION 
>   ambari-server/docs/api/v1/user-update.md PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  96e288fee0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/UserResourceDefinition.java
>  b228c82aa9 
>   
>

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-07 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60707/
---

(Updated July 7, 2017, 9:30 a.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20861
https://issues.apache.org/jira/browse/AMBARI-20861


Repository: ambari


Description
---

Update the Ambari REST API to allow for GET, POST, PUT, and DELETE operations 
on the authentication sources related to an Ambari user account.

Add the following entry points:

- `/api/v1/users/:USER_ID`
-- Get a user
-- Modify a user

- `/api/v1/users/:USERNAME/sources`
-- List a user’s authentication sources
-- Add a new authentication source for a user

- `/api/v1/users/:USERNAME/sources/:SOURCE_ID`
-- Get details on a specific authentication source for a user
-- Modify details for a specific authentication source for a user

- `/api/v1/users/:USER_ID/sources`
-- List a user’s authentication sources
-- Add a new authentication source for a user

- `/api/v1/users/:USER_ID/sources/:SOURCE_ID`
-- Get details on a specific authentication source for a user
-- Modify details for a specific authentication source for a user

Update the following entry points, ensuring backwards compatibility where 
possible:

- `/api/v1/users`
-- List all users
-- Add a new user
-- Backward compatibility: Set password should create or update the appropriate 
user_authentication record.


Diffs (updated)
-

  ambari-server/docs/api/v1/authentication-source-create.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-delete.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-get.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-list.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-resources.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-update.md PRE-CREATION 
  ambari-server/docs/api/v1/index.md da05d75bc3 
  ambari-server/docs/api/v1/user-create.md PRE-CREATION 
  ambari-server/docs/api/v1/user-delete.md PRE-CREATION 
  ambari-server/docs/api/v1/user-get.md PRE-CREATION 
  ambari-server/docs/api/v1/user-list.md PRE-CREATION 
  ambari-server/docs/api/v1/user-resources.md PRE-CREATION 
  ambari-server/docs/api/v1/user-update.md PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 96e288fee0 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/UserResourceDefinition.java
 b228c82aa9 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthenticationSourceService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 25d12c7dd6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
 2454bf7694 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
 bcb3aaf3e1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 595b7f996f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
 45b733b042 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 362b4e631c 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
 5ecff52ab2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
 ffb8e6dd16 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 de12a1669f 
  ambari-server/src/main/resources/properties.json 11ca7f678a 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/UserResourceDefinitionTest.java
 024b118a9c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
 3becc02aa8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java
 db7548f077 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
 4530d40ce4 
  
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
 43d56cd473

Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-07 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60707/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20861
https://issues.apache.org/jira/browse/AMBARI-20861


Repository: ambari


Description
---

Update the Ambari REST API to allow for GET, POST, PUT, and DELETE operations 
on the authentication sources related to an Ambari user account.

Add the following entry points:

- `/api/v1/users/:USER_ID`
-- Get a user
-- Modify a user

- `/api/v1/users/:USERNAME/sources`
-- List a user’s authentication sources
-- Add a new authentication source for a user

- `/api/v1/users/:USERNAME/sources/:SOURCE_ID`
-- Get details on a specific authentication source for a user
-- Modify details for a specific authentication source for a user

- `/api/v1/users/:USER_ID/sources`
-- List a user’s authentication sources
-- Add a new authentication source for a user

- `/api/v1/users/:USER_ID/sources/:SOURCE_ID`
-- Get details on a specific authentication source for a user
-- Modify details for a specific authentication source for a user

Update the following entry points, ensuring backwards compatibility where 
possible:

- `/api/v1/users`
-- List all users
-- Add a new user
-- Backward compatibility: Set password should create or update the appropriate 
user_authentication record.


Diffs
-

  ambari-server/docs/api/v1/authentication-source-create.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-delete.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-get.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-list.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-resources.md PRE-CREATION 
  ambari-server/docs/api/v1/authentication-source-update.md PRE-CREATION 
  ambari-server/docs/api/v1/index.md da05d75bc3 
  ambari-server/docs/api/v1/user-create.md PRE-CREATION 
  ambari-server/docs/api/v1/user-delete.md PRE-CREATION 
  ambari-server/docs/api/v1/user-get.md PRE-CREATION 
  ambari-server/docs/api/v1/user-list.md PRE-CREATION 
  ambari-server/docs/api/v1/user-resources.md PRE-CREATION 
  ambari-server/docs/api/v1/user-update.md PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 96e288fee0 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/UserResourceDefinition.java
 b228c82aa9 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthenticationSourceService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 25d12c7dd6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
 2454bf7694 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
 bcb3aaf3e1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 595b7f996f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
 45b733b042 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 362b4e631c 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
 5ecff52ab2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
 ffb8e6dd16 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 de12a1669f 
  ambari-server/src/main/resources/properties.json 11ca7f678a 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/UserResourceDefinitionTest.java
 024b118a9c 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
 3becc02aa8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java
 db7548f077 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
 4530d40ce4 
  
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
 43d56cd473 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 e049b4e83b 


Diff: